aboutsummaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authoranushadasari <danush10@in.ibm.com>2019-11-07 12:48:23 +0530
committerIttay Stern <ittay.stern@att.com>2019-11-24 16:34:58 +0000
commita7498b8b59c7872ae3de2237b681500384cbdc9b (patch)
treea2d3f5f62a3a3fdabfda9177c16852f589868d98
parentae36a252b2772a94d3c8ae6b93e2a342156f75d5 (diff)
Merge this if statement with the nested one
Merging collapsible if statements increases the code's readability. Issue-ID: VID-699 Change-Id: Icb52f1e1fcaec6ebfec3711c32c4cfcca9582af6 Signed-off-by: anushadasari <danush10@in.ibm.com>
-rwxr-xr-xvid-app-common/src/main/webapp/app/vid/scripts/controller/InstantiationController.js4
1 files changed, 1 insertions, 3 deletions
diff --git a/vid-app-common/src/main/webapp/app/vid/scripts/controller/InstantiationController.js b/vid-app-common/src/main/webapp/app/vid/scripts/controller/InstantiationController.js
index 6d8dde844..4b6b0f47a 100755
--- a/vid-app-common/src/main/webapp/app/vid/scripts/controller/InstantiationController.js
+++ b/vid-app-common/src/main/webapp/app/vid/scripts/controller/InstantiationController.js
@@ -1016,8 +1016,7 @@
var isVfc = false;
_.map($scope.service.model.vnfs, function (value, key) {
- if (value.uuid == vnf.uuid) {
- if (!_.isEmpty(value.vfcInstanceGroups)) {
+ if (value.uuid == vnf.uuid && !_.isEmpty(value.vfcInstanceGroups)) {
isVfc = true;
var queryData = {
serviceModelId: $scope.service.model.service.uuid,
@@ -1033,7 +1032,6 @@
$scope.$broadcast(COMPONENT.IFRAME_DIALOG, queryData);
return;
}
- }
});
DataService.setSubscriberName($scope.service.instance.subscriberName);