summaryrefslogtreecommitdiffstats
diff options
context:
space:
mode:
authorfujinhua <fu.jinhua@zte.com.cn>2019-04-09 11:42:39 +0800
committerfujinhua <fu.jinhua@zte.com.cn>2019-04-09 11:43:54 +0800
commit70c7a96f9e94d0dcfd2156ded9466bd12ef81044 (patch)
treeef2d7151c144ee6071c401821bd47e95da658886
parent166779eff195bc9b3693ca85002ef1f8e2308c89 (diff)
Add view common for catalog
Change-Id: I00ff2fb2d9c95092dd270c267f19c1e80af0b4e4 Issue-ID: VFC-1306 Signed-off-by: fujinhua <fu.jinhua@zte.com.cn>
-rw-r--r--catalog/packages/views/common.py50
1 files changed, 50 insertions, 0 deletions
diff --git a/catalog/packages/views/common.py b/catalog/packages/views/common.py
index 94566ebc..f6b4a068 100644
--- a/catalog/packages/views/common.py
+++ b/catalog/packages/views/common.py
@@ -12,9 +12,15 @@
# See the License for the specific language governing permissions and
# limitations under the License.
+import traceback
import logging
+from rest_framework import status
+from rest_framework.response import Response
+
from catalog.pub.exceptions import CatalogException
+from catalog.pub.exceptions import NsdmBadRequestException
+from catalog.pub.exceptions import PackageNotFoundException
logger = logging.getLogger(__name__)
@@ -29,3 +35,47 @@ def validate_data(data, serializer):
def fmt_error_rsp(error_message, status):
return {"errorMessage": error_message, "error": status}
+
+
+def make_error_resp(status, detail):
+ return Response(
+ data={
+ 'status': status,
+ 'detail': detail
+ },
+ status=status
+ )
+
+
+def view_safe_call_with_log(logger):
+ def view_safe_call(func):
+ def wrapper(*args, **kwargs):
+ try:
+ return func(*args, **kwargs)
+ except PackageNotFoundException as e:
+ logger.error(e.message)
+ return make_error_resp(
+ detail=e.message,
+ status=status.HTTP_404_NOT_FOUND
+ )
+ except NsdmBadRequestException as e:
+ logger.error(e.message)
+ return make_error_resp(
+ detail=e.message,
+ status=status.HTTP_400_BAD_REQUEST
+ )
+ except CatalogException as e:
+ logger.error(e.message)
+ return make_error_resp(
+ detail=e.message,
+ status=status.HTTP_500_INTERNAL_SERVER_ERROR
+ )
+ except Exception as e:
+ logger.error(e.message)
+ logger.error(traceback.format_exc())
+ return make_error_resp(
+ detail='Unexpected exception',
+ status=status.HTTP_500_INTERNAL_SERVER_ERROR
+ )
+ return wrapper
+ return view_safe_call