Age | Commit message (Collapse) | Author | Files | Lines |
|
-Removed unnecessary code.
-Removed unused variables.
Issue-ID: SO-2102
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Ie85cb51da959dacc80b61aa9d5bb608b4198a5fb
|
|
|
|
Removing the application-local.yaml files because they're no longer
maintained or working.
Issue-ID: SO-2121
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I191c8775de931671a4657be8940e6aec64023359
|
|
Major Sonar fixes in different classes:
-Removed unused variables.
-Simplified diamond operators.
-Removed unnecessary imports.
-Removed unnecessary code.
Issue-ID: SO-2102
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Ib54fbe048700a4e31042481f0a9b13838552aee7
|
|
|
|
|
|
|
|
Major Sonar fixes in different classes:
-Removed unnecessary code.
-Removed unused variables.
-Removed unnecessary imports.
-Simplified diamond operators.
Issue-ID: SO-2102
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I098e3dcd93b804e58220bb41ea15325e820e3a59
|
|
Sonar fixes in OrchestrationRequests according to the Sonar analysis.
-Removed unnecessary code.
-Removed unused variables.
Issue-ID: SO-2101
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I564f35519c5063028e1cf540eb81ab81cf923fd5
|
|
Code fixes in ManualTasks according to the Sonar analysis.
-Removed unnecessary code.
-Removed unused imports.
-Removed unused variables.
Issue-ID: SO-2100
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I79848456cc88b7f2cb812f7054bb6cec12b584c0
|
|
Major code fixes in E2EServiceInstances according to the Sonar analysis.
-Removed unnecessary code.
-Removed unnecessary method parameters.
-Removed unused variables.
Issue-ID: SO-2099
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I0e217174455a6748c663b3d5cc92fdc22b67ce2d
|
|
Modified the e2e service instance flow to
support both new list types groups along with
backward compatibility to support old types
alloted resources, network etc.
Change-Id: Ie8fc8a4550a90b44736b6b9de058e2a2e187570c
Issue-ID: SO-1393
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
|
|
- added format query parameter (optional), implemented logic to
populate requestStatus field based on whether or not format is present
moved request status constants to its own class visible globally.
- changed @requestParam to @QueryParam in GET endpoint
(OrchestrationRequests class. updated unit tests to call method being
tested directly rather than from another private function
- moved setting requestStatus to a separate method, also updated unit
tests to separate out each scenarion into its own method
- added unit test for when format=detail, corrected existing unit tests
to test result to be FAILED
- updated Status.java to include extra request status values; moved
Status class to common org.onap.so.constants package
Change-Id: Ic593de5fdfdcbc3121f481c86d1e261406082260
Issue-ID: SO-2080
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Added rollbackExtSystemErrorSource column and updated GET
orchestrationRequests response
Added missing columns from requestDb to schema.sql
Change-Id: I2380f08b9bb1c86922e8faea70454df722c0873a
Issue-ID: SO-2054
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
General fixes and improvements according to the Sonar analysis.
-Fixed imports.
-Removed unnecessary code.
Issue-ID: SO-1992
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I4299f3efc4444625f70fc36e65b57c500b113596
|
|
Updated path to match AID for resume requests
Change-Id: I0035360f206882e602265500dcd54036b3e69ea2
Issue-ID: SO-2042
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
format AbstractRestHandler.java file
Change-Id: I6f0025ba2a542e2476ee694b40ed670a9e02f2f3
Issue-ID: SO-2044
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
|
|
|
|
|
|
added extSystemErrorSource queryparam flag to getOrchestrationRequest
endpoint.
added junit tests for the protected method that maps
external system error source to request object being returned.
added junit tests to test mapExtSystemErrorSourceToRequest method with
extSystemErrorSource flag
Change-Id: If5c9a41938d4cc922c26f7d64e3a839b6547556f
Issue-ID: SO-2035
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Added null check to fix NPE when setting instanceName
Added check for null instanceName for vfModule
Change-Id: Ie70651770466790fd1f9d666eeabdce26510b01b
Issue-ID: SO-2034
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Swap to using HTTP Enumerations rather than ints
Add Unit Tests to Service Instances endpoint
Add Vnf Tests remove Abstract class
Clean up usage of abstract classes
Fix volume and module bean wiring issues
Add logic to find create request if cloud not in AAI
Updated network to take in version pathparam
Additonal refactor of the endpoints
Add missing license headers to all files
Clean up public variable usage, move to protected
Change-Id: Icdbdf78aa6c8af7a30fdff8a5805103f8df9364d
Issue-ID: SO-2032
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
These are changes related to ASDC controller for evicting database
connection pool when ip address changes
Included other appllications such as requestDB, CatalogDB, API Handler,
BPMN, OpenstackAdapter etc
Change-Id: I9a96ea12fb0c10643a204a58d55360bebba326fe
Issue-ID: SO-2018
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Corrected arguments to logger methods
only log exception in catch blocks
Change-Id: I0657b00ce45ac543d5e900db6ce5c24ba34e345d
Issue-ID: SO-2007
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Improvements in ServiceInstances according to the Sonar analysis.
-Fixed imports.
-Removed unnecessary code.
-Refactored diamond operators.
Issue-ID: SO-2008
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Ieb03f5b3fb52432091170402237ba4e23ed70e5d
|
|
replaced String.repeat with static final strings
Change-Id: Ife14fde70e8f648881a03e9343ae8faf9cb87e2e
Issue-ID: SO-1999
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
copy request body rewrite requestorid
added missing curly brace case to regex
Updated how we are updating requestorId in requestBody
Removed unused imports from RequestHandlerUtils
Replaced requestorId in requestBody string
Began updating requestorId in requestBody
Change-Id: I54bd8097b196899b271956f03395bb98d295e1e0
Issue-ID: SO-1990
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
checked and evaluated naming policy only if infra bonding.
Updated workflowAction to include vrf configuration for vpn-binding in
resourceIds list.
added in linked resource to service proxy cust
committing the asdc controller classpath change
added some unit tests for vrf validation and updated bbinput setup test
update config resource cust foreign key mapping
Moved mockbean for AssignVrfConfiguration task class into BaseBpmnTest.
added in a check to see if list is empty before access
added unit tests for bbinput setup for vrf config
Update AssignFlows enum with correct AssignVrfConfiguration flow name
Change-Id: Ibf14e36505638b19c1366ecebfce560c02e69e44
Issue-ID: SO-1975
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Change-Id: I551ea3f29a76dc99532455ea4d7e84a316f9bf38
Issue-ID: SO-1980
Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
|
|
UPDATE these files
so/bpmn/mso-infrastructure-bpmn/src/main/resources/application.yaml
so/mso-api-handlers/mso-api-handler-infra/src/main/resources/application.yaml
should have
mso: infra:
auditInventory: false
Issue-ID: SO-1974
Signed-off-by: Bonkur, Venkat (vb8416) <vb8416@att.com>
Change-Id: I57bb396604e9eb2787122199cdf8a2d1ce54048a
|
|
Cleaned up Sonar code smells related to the duplicated
literals in loggers.
Issue-ID: SO-1932
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I58c48cec0012c42b7b892ae76c24c6a087c60c7e
|
|
getInstanceName throws exception if requestScope doesn't match modelType
Updated to combine separate return statements
Replaced if statements for modelType and added tests
Replace if statements for modelType in ResumeOrchestrationRequest and
added tests
Added coverage for setId in ModelType
Updated to use ModelType setters/getters
model type can now get and set generically
Added modelInfo to RequestBody for resume request
Added getModelType call and unit tests
Moved getModelType from ServiceInstances
Moved getModelType and added unit tests
Added tests for getIsBaseVfModule
Added more tests for isBaseVfModule
Began adding tests for getIsBaseVfModule
Updated currentActiveRequest creation and isBaseVfModule
Updated recipe lookup and setting of aLaCarte to be more general
Updated concurrency control to include other resources
Change-Id: I12ad011d0a021c3ee066e16b4c8a4526d040cbe3
Issue-ID: SO-1963
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
enums are now single item per line
Change-Id: I6330ea4a9093071457dd47b95b6ed3bb7f8312e7
Issue-ID: SO-1970
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Updated schema.sql to fix failing tests
Added constants for request parameters
Added originalRequestId to be saved on resume request
Added originalRequestId to orchestrationRequests response
Change-Id: If2b86d233ee3db9bbe0e1185d92874bca2b3a07a
Issue-ID: SO-1960
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Improvements in AAIClientHelper according to the Sonar analysis.
Removed unnecessary exception throwing.
Fixed imports.
Updated java docs.
Issue-ID: SO-1958
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I60835304466bb656f09ba16b487907fa529e5eab
|
|
Return empty WorkflowInputParameters when none are available
Issue-ID: SO-1919
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: I057e30bb55f6545c25060c28e1af097286f4e88b
|
|
fix toString method and add unit tests for new code
Fix Null pointer issue in UT, extra chars
Initial checkin of updates for vf module replace
Change-Id: I2d62f5c2077cd022ccf796d126494e526ad48c54
Issue-ID: SO-1893
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Added logic to check if the requestId sent in GET orchestrationRequest
query is a valid UUID. Updated existing unit tests and added a new test
for invalid UUID scenario.
Change-Id: I424bef8aa75dd7e47de8145603899820dfb99725
Issue-ID: SO-1865
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
Use workflow's name for invocation
Change-Id: Ie527788f029bdccc91f7f406df0a478e55375c01
Issue-ID: SO-1876
Signed-off-by: Kuleshov, Elena <evn@att.com>
|
|
Added native workflows to result list
Issue-ID: SO-1852
Signed-off-by: Bonkur, Venkat (vb8416) <vb8416@att.com>
Change-Id: Ifeb2adf4ea78b191bcf46a1e7367bc0939d53b83
|
|
Fix resourceIndex to model in json mapping.
Change-Id: Ia609d3eb381b14fc5654774e83f8417a4d876e91
Issue-ID: SO-1393
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
|
|
Updated license for 2019 and added null check test
Moved record creation to RequestHandlerUtils
Updated uri retrieval to obtain full uri
Updated verify based on actual objects
Renamed tests for better description
Removed use of Spring in unit tests
Moved constant to other logger files
Added new class to JerseyConfiguration
Separated resume request work to separate file
Updated value that progress is saved as in db
Added new original_partner_name key for partnername retrieval
Added column for progress to be saved to db
Added additional columns to be saved to requestDb
Added inProgress request check to resume
Change-Id: I9ef1e61829be49da348b29bc255beb073b48639d
Issue-ID: SO-1831
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Fix the sql migration version numbering to be proper
Fix marking test as private, mark public
Clean up public declarations to private
Fix schema.sql to have new column for unit test
Revert POM Change, add License, clean up comments
Fix bad spelling of method name issue
Update catalog db to support new rest endpoint
Update local query service and mappers
Localstaging of potential catalog db changes
Update logic to write overall distro status
Change-Id: I84d53b972ede3176c5af32d13444583a36606efa
Issue-ID: SO-1820
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
Store Cloud Request in Database, add to request service
Add query Param to Plural to include cloud data
Change-Id: If906d28d0dc9c0c804e550e2074af3d75ba46d32
Issue-ID: SO-1807
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Correct Catalog DB beans
Change-Id: Ie9bb4aef606da8c87e5960c95b564fb2fc299869
Issue-ID: SO-1828
Signed-off-by: Kuleshov, Elena <evn@att.com>
|