summaryrefslogtreecommitdiffstats
path: root/mso-api-handlers/mso-api-handler-infra
AgeCommit message (Collapse)AuthorFilesLines
2019-09-10General sonar fixesArindam Mondal2-4/+0
+)Format logger ++) Remove toString() +++) Extract nested IF Issue-ID: SO-2226 Change-Id: Iff28408584b04ffd03b6aca0f647d0af9090a9c2 Signed-off-by: arind.mondal <arind.mondal@samsung.com>
2019-08-29added fix for missing Error from SDNC prefixChan, Mercy2-1/+23
added fix for missing Error from SDNC prefix to SDNC callback flow reverted implementation from bpmn-tasks package and moved them to apih side, added junit test renamed error message constant, removed regex check, add error message porefix directly to actual message Issue-ID: SO-2267 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I440cf9eff12571f576fcc5f2d28d9f2c8130e4b6
2019-08-27Fix issue in mso-api-handler-infraParshad Patel4-45/+50
Either log or rethrow this exception Define a constant instead of duplicating this literal Immediately throw this expression instead of assigning it to the temporary variable Remove the declaration of thrown exception 'org.json.JSONException' which is a runtime exception Issue-ID: SO-1841 Change-Id: I193f21ec2c4214863c8b51faf25fc3561d6be818 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2019-08-26Added default value for when ErrorCode is null inBoslet, Cory4-130/+9
Added default value for when ErrorCode is null in mdc test to see if 404 log gets enhanced by change. Removed test id from class that was put to test via docker. Removed setting of partner name and tested with using try/catch Reverted change to request uri filter per comments Removed the request filter uri class that rerouted old uri orders Removed request filter from jersey config files Updated junit test that were pointing to the old uri to be failure test corrected formatting issues on ServiceInstancesTest Issue-ID: SO-2259 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Id8f9daef139a82ee9e934d4d37906ffb7a7aadff
2019-08-21Merge "Javadoc and logging improvement"Seshu Kumar M1-23/+64
2019-08-16Merge "Initial commit of validation framework to APIH"Steve Smokowski13-122/+293
2019-08-16Merge "apih format statusdetail to return granular"Steve Smokowski2-1/+14
2019-08-16Javadoc and logging improvementManamohan1-23/+64
Added Javadocs and logging for these classes. Change-Id: I365fc0677c0d5136e4579de3947d0478b26c22d3 Issue-ID: SO-2052 Signed-off-by: Manamohan <MS00534989@Techmahindra.com>
2019-08-15Initial commit of validation framework to APIHSmokowski, Steven13-122/+293
Move ListenerRunner to common location Adjust request params name, update junit tests Update validations to work properly Properly escape period for the string split Issue-ID: SO-2232 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Ia468cf7062cccf30e28afeb7a5cddc37ceb2e002
2019-08-15Added check for empty processInstanceListPlummer, Brittany2-13/+26
Added check for empty processInstanceList Issue-ID: SO-2225 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: If4569d94dbda794c9a347e6dc73102acf7664558
2019-08-15apih format statusdetail to return granularPlummer, Brittany2-1/+14
Should return unchanged requestState on statusDetail queryParam Formatted files with changes to fix build Added enum validation for setting requestStatus Updated test to send in "statusDetail" Issue-ID: SO-2230 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I8f5d79bc287581635a1543a00ddc69fb9eba2295
2019-08-12Merge "Remove repeated conditional test in ​buildServiceErrorResponse"Lukasz Muszkieta1-4/+2
2019-08-12Merge "health check now entirely config based"Steve Smokowski13-338/+459
2019-08-12Change string literal left side-avoid null pointer exsindhu36721-2/+2
Change string literal left side so.adapters.vnfmadapter WebSecurityConfigImpl class Issue-ID: SO-2187 Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com> Change-Id: I8ba57bd9c3c548a35b90d9324f1d214985c3c539
2019-08-09health check now entirely config basedBenjamin, Max13-338/+459
health check now entirely config based api handler now lists itself as an endpoint updated robot test to verify new format fixed formatting issues with modified files updated test case to reflect new statuses fixed duplicate bean issue with converter ignore unit test that never worked added missing class to context configuration removed extraneous spaces from robot file update robot files as well as fix compile issues config format must be correct on startup Issue-ID: SO-2216 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I86770922c7b7f36e4a4d59615f7336cda7cbe629
2019-08-09Remove repeated conditional test in ​buildServiceErrorResponseArtem Naluzhnyy1-4/+2
Coverity-scan: CID-203826 Issue-ID: SO-2211 Signed-off-by: Artem Naluzhnyy <A.Naluzhnyy@samsung.com> Change-Id: I18d788e361b502e392f7f59ff6bc772dfee394bd
2019-08-08fix sonar issuesarada prasad sahoo1-28/+25
fix sonar issues Issue-ID: SO-1811 Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com> Change-Id: I137e40866ccbfb634b430ea56028fac87cc6b2bc
2019-08-08fix sonar issuesarada prasad sahoo1-61/+35
fix sonar issues Issue-ID: SO-1811 Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com> Change-Id: Ia0bb25c9fc10364fddde10d38675540d0c539227
2019-08-08fix sonar issuesarada prasad sahoo1-2/+2
fix sonar issues Issue-ID: SO-1811 Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com> Change-Id: I79db093a27165fd5d54dfab1c1d25749bf6df533
2019-07-30Use generic req mapping for CM requestsElena Kuleshov3-1/+35
Do not pass specially preprocessed ServiceRequestParameter to msoToJson mapping for Instance Management requests. Issue-ID: SO-2168 Signed-off-by: Kuleshov, Elena <evn@att.com> Change-Id: Ic6bdd624bd03c7c03213248781dc5e554331feed
2019-07-26Upgrade springboot.version from 2.0.5 to 2.1.5.Sangalang, Felix2-6/+8
Upgrade springboot.version from 2.0.5 to 2.1.5. Fixed APIHandler junit test cases with expected DB error messages. Issue-ID: SO-2157 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I77ce873018b88268b9221226b95c9c106f93a8d0
2019-07-24Merge "Major Sonar fixes in InstanceManagement"Steve Smokowski1-6/+2
2019-07-24Merge "Removed not used loggers"Steve Smokowski5-20/+10
2019-07-24Merge "Major Sonar fixes in E2EServiceInstances"Steve Smokowski1-18/+15
2019-07-24Merge "enhance get orchestration request"Steve Smokowski14-68/+749
2019-07-24Removed not used loggersr.bogacki5-20/+10
-Removed unnecessary loggers according to Sonar. Issue-ID: SO-2102 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I05a0cc3187692fa17a6734d1c2a6be33d4b5ee34
2019-07-24Major Sonar fixes in InstanceManagementr.bogacki1-6/+2
-Removed unnecessary code. -Removed unused variables. Issue-ID: SO-2102 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: Ie85cb51da959dacc80b61aa9d5bb608b4198a5fb
2019-07-24Major Sonar fixes in E2EServiceInstancesr.bogacki1-18/+15
-Removed unnecessary code. -Removed unused variables. -Introduced constants for repeating Strings. Issue-ID: SO-2102 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I4ac692849508178390796d149b2c3f2fddcd093b
2019-07-23Merge "Enhanced List Level flow with backward support"Seshu Kumar M2-1/+12
2019-07-22enhance get orchestration requestPlummer, Brittany14-68/+749
Enhance get orchestration request to include workflow step Began working on adding call for activity name Added call to return activity information Updated to return last task executed Added last task executed info to returned string Updated mocks to fix failing unit tests Added responses for mocks to Camunda for process and activity history Added tests to cover taskName changes Began adding tests to cover changes to RequestHandlerUtils Added more unit tests for activity lookup Updated error messages for taskName Moved properties to application.yaml file Added unit tests to add more coverage to task retrieval Moved Camunda calls to CamundaRequestHandler class Removed unused imports from RequestHandlerUtils Fixed formatting of tests and removed handler where not used Removed CamundaRequestHandler from JerseyConfiguration Added retryTemplate for camunda calls Issue-ID: SO-2142 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I09a82e3458e8f611e4bbaf3ce9ab5de36b1b060a
2019-07-18Removing application-local.yaml filesRoy, Amresh1-179/+0
Removing the application-local.yaml files because they're no longer maintained or working. Issue-ID: SO-2121 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I191c8775de931671a4657be8940e6aec64023359
2019-07-12Major Sonar fixesr.bogacki1-9/+8
Major Sonar fixes in different classes: -Removed unused variables. -Simplified diamond operators. -Removed unnecessary imports. -Removed unnecessary code. Issue-ID: SO-2102 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: Ib54fbe048700a4e31042481f0a9b13838552aee7
2019-07-10Merge "Major Sonar fixes in E2EServiceInstances"Lukasz Muszkieta1-27/+10
2019-07-09Merge "Sonar fixes in ManualTasks"Lukasz Muszkieta1-10/+3
2019-07-09Merge "Sonar fixes in OrchestrationRequests"Lukasz Muszkieta1-8/+4
2019-07-09Major Sonar fixesr.bogacki3-16/+17
Major Sonar fixes in different classes: -Removed unnecessary code. -Removed unused variables. -Removed unnecessary imports. -Simplified diamond operators. Issue-ID: SO-2102 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I098e3dcd93b804e58220bb41ea15325e820e3a59
2019-07-09Sonar fixes in OrchestrationRequestsr.bogacki1-8/+4
Sonar fixes in OrchestrationRequests according to the Sonar analysis. -Removed unnecessary code. -Removed unused variables. Issue-ID: SO-2101 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I564f35519c5063028e1cf540eb81ab81cf923fd5
2019-07-09Sonar fixes in ManualTasksr.bogacki1-10/+3
Code fixes in ManualTasks according to the Sonar analysis. -Removed unnecessary code. -Removed unused imports. -Removed unused variables. Issue-ID: SO-2100 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I79848456cc88b7f2cb812f7054bb6cec12b584c0
2019-07-09Major Sonar fixes in E2EServiceInstancesr.bogacki1-27/+10
Major code fixes in E2EServiceInstances according to the Sonar analysis. -Removed unnecessary code. -Removed unnecessary method parameters. -Removed unused variables. Issue-ID: SO-2099 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I0e217174455a6748c663b3d5cc92fdc22b67ce2d
2019-07-02Enhanced List Level flow with backward supportsarada prasad sahoo2-1/+12
Modified the e2e service instance flow to support both new list types groups along with backward compatibility to support old types alloted resources, network etc. Change-Id: Ie8fc8a4550a90b44736b6b9de058e2a2e187570c Issue-ID: SO-1393 Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
2019-07-01support new query param formatChan, Mercy26-101/+176
- added format query parameter (optional), implemented logic to populate requestStatus field based on whether or not format is present moved request status constants to its own class visible globally. - changed @requestParam to @QueryParam in GET endpoint (OrchestrationRequests class. updated unit tests to call method being tested directly rather than from another private function - moved setting requestStatus to a separate method, also updated unit tests to separate out each scenarion into its own method - added unit test for when format=detail, corrected existing unit tests to test result to be FAILED - updated Status.java to include extra request status values; moved Status class to common org.onap.so.constants package Change-Id: Ic593de5fdfdcbc3121f481c86d1e261406082260 Issue-ID: SO-2080 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-27add rollback ext system error sourcePlummer, Brittany3-12/+10
Added rollbackExtSystemErrorSource column and updated GET orchestrationRequests response Added missing columns from requestDb to schema.sql Change-Id: I2380f08b9bb1c86922e8faea70454df722c0873a Issue-ID: SO-2054 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-26Merge "Updated path to match AID for resume requests"Steve Smokowski1-1/+1
2019-06-24Sonar fixes and improvementsr.bogacki1-2/+4
General fixes and improvements according to the Sonar analysis. -Fixed imports. -Removed unnecessary code. Issue-ID: SO-1992 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I4299f3efc4444625f70fc36e65b57c500b113596
2019-06-21Updated path to match AID for resume requestsPlummer, Brittany2-2/+2
Updated path to match AID for resume requests Change-Id: I0035360f206882e602265500dcd54036b3e69ea2 Issue-ID: SO-2042 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-21fix jenkins buildLukasz Muszkieta1-1/+1
format AbstractRestHandler.java file Change-Id: I6f0025ba2a542e2476ee694b40ed670a9e02f2f3 Issue-ID: SO-2044 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-06-20Merge "support no payload for alacarte deletes"Steve Smokowski46-51/+3539
2019-06-20Merge "NPE when setting instanceName"Steve Smokowski2-16/+63
2019-06-18update apih to accept new uri parameterChan, Mercy2-10/+131
added extSystemErrorSource queryparam flag to getOrchestrationRequest endpoint. added junit tests for the protected method that maps external system error source to request object being returned. added junit tests to test mapExtSystemErrorSourceToRequest method with extSystemErrorSource flag Change-Id: If5c9a41938d4cc922c26f7d64e3a839b6547556f Issue-ID: SO-2035 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-18NPE when setting instanceNamePlummer, Brittany2-16/+63
Added null check to fix NPE when setting instanceName Added check for null instanceName for vfModule Change-Id: Ie70651770466790fd1f9d666eeabdce26510b01b Issue-ID: SO-2034 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>