summaryrefslogtreecommitdiffstats
path: root/mso-api-handlers/mso-api-handler-infra/src
AgeCommit message (Collapse)AuthorFilesLines
2019-08-08fix sonar issuesarada prasad sahoo1-61/+35
fix sonar issues Issue-ID: SO-1811 Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com> Change-Id: Ia0bb25c9fc10364fddde10d38675540d0c539227
2019-08-08fix sonar issuesarada prasad sahoo1-2/+2
fix sonar issues Issue-ID: SO-1811 Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com> Change-Id: I79db093a27165fd5d54dfab1c1d25749bf6df533
2019-07-30Use generic req mapping for CM requestsElena Kuleshov3-1/+35
Do not pass specially preprocessed ServiceRequestParameter to msoToJson mapping for Instance Management requests. Issue-ID: SO-2168 Signed-off-by: Kuleshov, Elena <evn@att.com> Change-Id: Ic6bdd624bd03c7c03213248781dc5e554331feed
2019-07-26Upgrade springboot.version from 2.0.5 to 2.1.5.Sangalang, Felix2-6/+8
Upgrade springboot.version from 2.0.5 to 2.1.5. Fixed APIHandler junit test cases with expected DB error messages. Issue-ID: SO-2157 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I77ce873018b88268b9221226b95c9c106f93a8d0
2019-07-24Merge "Major Sonar fixes in InstanceManagement"Steve Smokowski1-6/+2
2019-07-24Merge "Removed not used loggers"Steve Smokowski5-20/+10
2019-07-24Merge "Major Sonar fixes in E2EServiceInstances"Steve Smokowski1-18/+15
2019-07-24Merge "enhance get orchestration request"Steve Smokowski13-68/+745
2019-07-24Removed not used loggersr.bogacki5-20/+10
-Removed unnecessary loggers according to Sonar. Issue-ID: SO-2102 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I05a0cc3187692fa17a6734d1c2a6be33d4b5ee34
2019-07-24Major Sonar fixes in InstanceManagementr.bogacki1-6/+2
-Removed unnecessary code. -Removed unused variables. Issue-ID: SO-2102 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: Ie85cb51da959dacc80b61aa9d5bb608b4198a5fb
2019-07-24Major Sonar fixes in E2EServiceInstancesr.bogacki1-18/+15
-Removed unnecessary code. -Removed unused variables. -Introduced constants for repeating Strings. Issue-ID: SO-2102 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I4ac692849508178390796d149b2c3f2fddcd093b
2019-07-23Merge "Enhanced List Level flow with backward support"Seshu Kumar M2-1/+12
2019-07-22enhance get orchestration requestPlummer, Brittany13-68/+745
Enhance get orchestration request to include workflow step Began working on adding call for activity name Added call to return activity information Updated to return last task executed Added last task executed info to returned string Updated mocks to fix failing unit tests Added responses for mocks to Camunda for process and activity history Added tests to cover taskName changes Began adding tests to cover changes to RequestHandlerUtils Added more unit tests for activity lookup Updated error messages for taskName Moved properties to application.yaml file Added unit tests to add more coverage to task retrieval Moved Camunda calls to CamundaRequestHandler class Removed unused imports from RequestHandlerUtils Fixed formatting of tests and removed handler where not used Removed CamundaRequestHandler from JerseyConfiguration Added retryTemplate for camunda calls Issue-ID: SO-2142 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I09a82e3458e8f611e4bbaf3ce9ab5de36b1b060a
2019-07-18Removing application-local.yaml filesRoy, Amresh1-179/+0
Removing the application-local.yaml files because they're no longer maintained or working. Issue-ID: SO-2121 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I191c8775de931671a4657be8940e6aec64023359
2019-07-12Major Sonar fixesr.bogacki1-9/+8
Major Sonar fixes in different classes: -Removed unused variables. -Simplified diamond operators. -Removed unnecessary imports. -Removed unnecessary code. Issue-ID: SO-2102 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: Ib54fbe048700a4e31042481f0a9b13838552aee7
2019-07-10Merge "Major Sonar fixes in E2EServiceInstances"Lukasz Muszkieta1-27/+10
2019-07-09Merge "Sonar fixes in ManualTasks"Lukasz Muszkieta1-10/+3
2019-07-09Merge "Sonar fixes in OrchestrationRequests"Lukasz Muszkieta1-8/+4
2019-07-09Major Sonar fixesr.bogacki3-16/+17
Major Sonar fixes in different classes: -Removed unnecessary code. -Removed unused variables. -Removed unnecessary imports. -Simplified diamond operators. Issue-ID: SO-2102 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I098e3dcd93b804e58220bb41ea15325e820e3a59
2019-07-09Sonar fixes in OrchestrationRequestsr.bogacki1-8/+4
Sonar fixes in OrchestrationRequests according to the Sonar analysis. -Removed unnecessary code. -Removed unused variables. Issue-ID: SO-2101 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I564f35519c5063028e1cf540eb81ab81cf923fd5
2019-07-09Sonar fixes in ManualTasksr.bogacki1-10/+3
Code fixes in ManualTasks according to the Sonar analysis. -Removed unnecessary code. -Removed unused imports. -Removed unused variables. Issue-ID: SO-2100 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I79848456cc88b7f2cb812f7054bb6cec12b584c0
2019-07-09Major Sonar fixes in E2EServiceInstancesr.bogacki1-27/+10
Major code fixes in E2EServiceInstances according to the Sonar analysis. -Removed unnecessary code. -Removed unnecessary method parameters. -Removed unused variables. Issue-ID: SO-2099 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I0e217174455a6748c663b3d5cc92fdc22b67ce2d
2019-07-02Enhanced List Level flow with backward supportsarada prasad sahoo2-1/+12
Modified the e2e service instance flow to support both new list types groups along with backward compatibility to support old types alloted resources, network etc. Change-Id: Ie8fc8a4550a90b44736b6b9de058e2a2e187570c Issue-ID: SO-1393 Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
2019-07-01support new query param formatChan, Mercy26-101/+176
- added format query parameter (optional), implemented logic to populate requestStatus field based on whether or not format is present moved request status constants to its own class visible globally. - changed @requestParam to @QueryParam in GET endpoint (OrchestrationRequests class. updated unit tests to call method being tested directly rather than from another private function - moved setting requestStatus to a separate method, also updated unit tests to separate out each scenarion into its own method - added unit test for when format=detail, corrected existing unit tests to test result to be FAILED - updated Status.java to include extra request status values; moved Status class to common org.onap.so.constants package Change-Id: Ic593de5fdfdcbc3121f481c86d1e261406082260 Issue-ID: SO-2080 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-27add rollback ext system error sourcePlummer, Brittany3-12/+10
Added rollbackExtSystemErrorSource column and updated GET orchestrationRequests response Added missing columns from requestDb to schema.sql Change-Id: I2380f08b9bb1c86922e8faea70454df722c0873a Issue-ID: SO-2054 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-26Merge "Updated path to match AID for resume requests"Steve Smokowski1-1/+1
2019-06-24Sonar fixes and improvementsr.bogacki1-2/+4
General fixes and improvements according to the Sonar analysis. -Fixed imports. -Removed unnecessary code. Issue-ID: SO-1992 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I4299f3efc4444625f70fc36e65b57c500b113596
2019-06-21Updated path to match AID for resume requestsPlummer, Brittany2-2/+2
Updated path to match AID for resume requests Change-Id: I0035360f206882e602265500dcd54036b3e69ea2 Issue-ID: SO-2042 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-21fix jenkins buildLukasz Muszkieta1-1/+1
format AbstractRestHandler.java file Change-Id: I6f0025ba2a542e2476ee694b40ed670a9e02f2f3 Issue-ID: SO-2044 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-06-20Merge "support no payload for alacarte deletes"Steve Smokowski46-51/+3539
2019-06-20Merge "NPE when setting instanceName"Steve Smokowski2-16/+63
2019-06-18update apih to accept new uri parameterChan, Mercy2-10/+131
added extSystemErrorSource queryparam flag to getOrchestrationRequest endpoint. added junit tests for the protected method that maps external system error source to request object being returned. added junit tests to test mapExtSystemErrorSourceToRequest method with extSystemErrorSource flag Change-Id: If5c9a41938d4cc922c26f7d64e3a839b6547556f Issue-ID: SO-2035 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-18NPE when setting instanceNamePlummer, Brittany2-16/+63
Added null check to fix NPE when setting instanceName Added check for null instanceName for vfModule Change-Id: Ie70651770466790fd1f9d666eeabdce26510b01b Issue-ID: SO-2034 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-18support no payload for alacarte deletesSmokowski, Steven46-51/+3539
Swap to using HTTP Enumerations rather than ints Add Unit Tests to Service Instances endpoint Add Vnf Tests remove Abstract class Clean up usage of abstract classes Fix volume and module bean wiring issues Add logic to find create request if cloud not in AAI Updated network to take in version pathparam Additonal refactor of the endpoints Add missing license headers to all files Clean up public variable usage, move to protected Change-Id: Icdbdf78aa6c8af7a30fdff8a5805103f8df9364d Issue-ID: SO-2032 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-17Changes related to eviction of connectionsBenjamin, Max (mb388a)4-18/+55
These are changes related to ASDC controller for evicting database connection pool when ip address changes Included other appllications such as requestDB, CatalogDB, API Handler, BPMN, OpenstackAdapter etc Change-Id: I9a96ea12fb0c10643a204a58d55360bebba326fe Issue-ID: SO-2018 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-11update logger statements in apihBhatt, Prema3-21/+8
Corrected arguments to logger methods only log exception in catch blocks Change-Id: I0657b00ce45ac543d5e900db6ce5c24ba34e345d Issue-ID: SO-2007 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-11Improvements in ServiceInstancesr.bogacki1-12/+7
Improvements in ServiceInstances according to the Sonar analysis. -Fixed imports. -Removed unnecessary code. -Refactored diamond operators. Issue-ID: SO-2008 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: Ieb03f5b3fb52432091170402237ba4e23ed70e5d
2019-06-10replaced String.repeat with static final stringsBenjamin, Max7-46/+46
replaced String.repeat with static final strings Change-Id: Ife14fde70e8f648881a03e9343ae8faf9cb87e2e Issue-ID: SO-1999 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-07Merge "resume request support"Steve Smokowski4-12/+48
2019-06-06resume request supportPlummer, Brittany4-12/+48
copy request body rewrite requestorid added missing curly brace case to regex Updated how we are updating requestorId in requestBody Removed unused imports from RequestHandlerUtils Replaced requestorId in requestBody string Began updating requestorId in requestBody Change-Id: I54bd8097b196899b271956f03395bb98d295e1e0 Issue-ID: SO-1990 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-06Accommodate WAN NetworkingGamboa, Gilbert11-1/+519
checked and evaluated naming policy only if infra bonding. Updated workflowAction to include vrf configuration for vpn-binding in resourceIds list. added in linked resource to service proxy cust committing the asdc controller classpath change added some unit tests for vrf validation and updated bbinput setup test update config resource cust foreign key mapping Moved mockbean for AssignVrfConfiguration task class into BaseBpmnTest. added in a check to see if list is empty before access added unit tests for bbinput setup for vrf config Update AssignFlows enum with correct AssignVrfConfiguration flow name Change-Id: Ibf14e36505638b19c1366ecebfce560c02e69e44 Issue-ID: SO-1975 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-06Merge remote-tracking branch 'origin/dublin' into 'origin/master'Steve Smokowski20-900/+1105
Change-Id: I551ea3f29a76dc99532455ea4d7e84a316f9bf38 Issue-ID: SO-1980 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2019-06-03Add SO Turn off OpenStack heat stack auditBonkur, Venkat (vb8416)1-2/+2
UPDATE these files so/bpmn/mso-infrastructure-bpmn/src/main/resources/application.yaml so/mso-api-handlers/mso-api-handler-infra/src/main/resources/application.yaml should have mso: infra: auditInventory: false Issue-ID: SO-1974 Signed-off-by: Bonkur, Venkat (vb8416) <vb8416@att.com> Change-Id: I57bb396604e9eb2787122199cdf8a2d1ce54048a
2019-06-03Cleaned up duplicated literalsrob.bog7-61/+73
Cleaned up Sonar code smells related to the duplicated literals in loggers. Issue-ID: SO-1932 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I58c48cec0012c42b7b892ae76c24c6a087c60c7e
2019-05-31apih resume request handling more genericPlummer, Brittany6-152/+648
getInstanceName throws exception if requestScope doesn't match modelType Updated to combine separate return statements Replaced if statements for modelType and added tests Replace if statements for modelType in ResumeOrchestrationRequest and added tests Added coverage for setId in ModelType Updated to use ModelType setters/getters model type can now get and set generically Added modelInfo to RequestBody for resume request Added getModelType call and unit tests Moved getModelType from ServiceInstances Moved getModelType and added unit tests Added tests for getIsBaseVfModule Added more tests for isBaseVfModule Began adding tests for getIsBaseVfModule Updated currentActiveRequest creation and isBaseVfModule Updated recipe lookup and setting of aLaCarte to be more general Updated concurrency control to include other resources Change-Id: I12ad011d0a021c3ee066e16b4c8a4526d040cbe3 Issue-ID: SO-1963 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-31Merge "Corrected enum formatting by plugin"Steve Smokowski2-4/+32
2019-05-31Corrected enum formatting by pluginBenjamin, Max (mb388a)2-4/+32
enums are now single item per line Change-Id: I6330ea4a9093071457dd47b95b6ed3bb7f8312e7 Issue-ID: SO-1970 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-31apih to populate original request idPlummer, Brittany6-6/+106
Updated schema.sql to fix failing tests Added constants for request parameters Added originalRequestId to be saved on resume request Added originalRequestId to orchestrationRequests response Change-Id: If2b86d233ee3db9bbe0e1185d92874bca2b3a07a Issue-ID: SO-1960 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-31Improvements in AAIClientHelperr.bogacki1-5/+3
Improvements in AAIClientHelper according to the Sonar analysis. Removed unnecessary exception throwing. Fixed imports. Updated java docs. Issue-ID: SO-1958 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I60835304466bb656f09ba16b487907fa529e5eab
2019-05-23Return empty WorkflowInputParametersElena Kuleshov2-3/+4
Return empty WorkflowInputParameters when none are available Issue-ID: SO-1919 Signed-off-by: Kuleshov, Elena <evn@att.com> Change-Id: I057e30bb55f6545c25060c28e1af097286f4e88b