summaryrefslogtreecommitdiffstats
path: root/mso-api-handlers/mso-api-handler-infra/src/test
AgeCommit message (Collapse)AuthorFilesLines
2019-09-30Add null check for the InfraActiveRequests lookupBonkur, Venkat2-1/+12
Add null check for the InfraActiveRequests lookup move it into a separate method for InfraActiveRequests lookup Issue-ID: SO-2374 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I84ff23b4da12719b589d43135a7604a2d4b24fef
2019-09-24Update Resume Logic and Add Workflow ListenersSmokowski, Steven2-7/+7
Updated with the error log messages Changed the code to do string compare for eventName update workflowaction to only persist if not resume Issue-ID: SO-2363 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I139f2427ae0f0253a15cc51003318686568cb514
2019-09-10Integrate Logging LibraryPlummer, Brittany5-54/+59
Updated SO to use ONAP provided filters and constants to meet logging standards. Removed redundant classes Updated constant references Issue-ID: SO-2301 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Ia4e3c2b1a4dcb3881aa34d39885c8b2782880d64
2019-09-09updated all sql files including in tests to useChan, Mercy3-6/+6
updated all sql files including in tests to use the correct column name. Updated hibernate mapping to use the correct column name as well. Issue-ID: SO-2297 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I4a2d3e82a7b182ea1d67d297c0a0d3a35c856255
2019-08-29added fix for missing Error from SDNC prefixChan, Mercy1-0/+16
added fix for missing Error from SDNC prefix to SDNC callback flow reverted implementation from bpmn-tasks package and moved them to apih side, added junit test renamed error message constant, removed regex check, add error message porefix directly to actual message Issue-ID: SO-2267 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I440cf9eff12571f576fcc5f2d28d9f2c8130e4b6
2019-08-26Added default value for when ErrorCode is null inBoslet, Cory2-65/+7
Added default value for when ErrorCode is null in mdc test to see if 404 log gets enhanced by change. Removed test id from class that was put to test via docker. Removed setting of partner name and tested with using try/catch Reverted change to request uri filter per comments Removed the request filter uri class that rerouted old uri orders Removed request filter from jersey config files Updated junit test that were pointing to the old uri to be failure test corrected formatting issues on ServiceInstancesTest Issue-ID: SO-2259 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Id8f9daef139a82ee9e934d4d37906ffb7a7aadff
2019-08-16Merge "Initial commit of validation framework to APIH"Steve Smokowski5-25/+56
2019-08-16Merge "apih format statusdetail to return granular"Steve Smokowski1-0/+8
2019-08-15Initial commit of validation framework to APIHSmokowski, Steven5-25/+56
Move ListenerRunner to common location Adjust request params name, update junit tests Update validations to work properly Properly escape period for the string split Issue-ID: SO-2232 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Ia468cf7062cccf30e28afeb7a5cddc37ceb2e002
2019-08-15Added check for empty processInstanceListPlummer, Brittany1-12/+25
Added check for empty processInstanceList Issue-ID: SO-2225 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: If4569d94dbda794c9a347e6dc73102acf7664558
2019-08-15apih format statusdetail to return granularPlummer, Brittany1-0/+8
Should return unchanged requestState on statusDetail queryParam Formatted files with changes to fix build Added enum validation for setting requestStatus Updated test to send in "statusDetail" Issue-ID: SO-2230 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I8f5d79bc287581635a1543a00ddc69fb9eba2295
2019-08-09health check now entirely config basedBenjamin, Max2-132/+80
health check now entirely config based api handler now lists itself as an endpoint updated robot test to verify new format fixed formatting issues with modified files updated test case to reflect new statuses fixed duplicate bean issue with converter ignore unit test that never worked added missing class to context configuration removed extraneous spaces from robot file update robot files as well as fix compile issues config format must be correct on startup Issue-ID: SO-2216 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I86770922c7b7f36e4a4d59615f7336cda7cbe629
2019-07-30Use generic req mapping for CM requestsElena Kuleshov2-0/+34
Do not pass specially preprocessed ServiceRequestParameter to msoToJson mapping for Instance Management requests. Issue-ID: SO-2168 Signed-off-by: Kuleshov, Elena <evn@att.com> Change-Id: Ic6bdd624bd03c7c03213248781dc5e554331feed
2019-07-26Upgrade springboot.version from 2.0.5 to 2.1.5.Sangalang, Felix1-6/+6
Upgrade springboot.version from 2.0.5 to 2.1.5. Fixed APIHandler junit test cases with expected DB error messages. Issue-ID: SO-2157 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I77ce873018b88268b9221226b95c9c106f93a8d0
2019-07-22enhance get orchestration requestPlummer, Brittany9-28/+537
Enhance get orchestration request to include workflow step Began working on adding call for activity name Added call to return activity information Updated to return last task executed Added last task executed info to returned string Updated mocks to fix failing unit tests Added responses for mocks to Camunda for process and activity history Added tests to cover taskName changes Began adding tests to cover changes to RequestHandlerUtils Added more unit tests for activity lookup Updated error messages for taskName Moved properties to application.yaml file Added unit tests to add more coverage to task retrieval Moved Camunda calls to CamundaRequestHandler class Removed unused imports from RequestHandlerUtils Fixed formatting of tests and removed handler where not used Removed CamundaRequestHandler from JerseyConfiguration Added retryTemplate for camunda calls Issue-ID: SO-2142 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I09a82e3458e8f611e4bbaf3ce9ab5de36b1b060a
2019-07-01support new query param formatChan, Mercy9-45/+77
- added format query parameter (optional), implemented logic to populate requestStatus field based on whether or not format is present moved request status constants to its own class visible globally. - changed @requestParam to @QueryParam in GET endpoint (OrchestrationRequests class. updated unit tests to call method being tested directly rather than from another private function - moved setting requestStatus to a separate method, also updated unit tests to separate out each scenarion into its own method - added unit test for when format=detail, corrected existing unit tests to test result to be FAILED - updated Status.java to include extra request status values; moved Status class to common org.onap.so.constants package Change-Id: Ic593de5fdfdcbc3121f481c86d1e261406082260 Issue-ID: SO-2080 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-27add rollback ext system error sourcePlummer, Brittany2-12/+9
Added rollbackExtSystemErrorSource column and updated GET orchestrationRequests response Added missing columns from requestDb to schema.sql Change-Id: I2380f08b9bb1c86922e8faea70454df722c0873a Issue-ID: SO-2054 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-20Merge "support no payload for alacarte deletes"Steve Smokowski18-22/+1390
2019-06-20Merge "NPE when setting instanceName"Steve Smokowski1-13/+47
2019-06-18update apih to accept new uri parameterChan, Mercy1-3/+112
added extSystemErrorSource queryparam flag to getOrchestrationRequest endpoint. added junit tests for the protected method that maps external system error source to request object being returned. added junit tests to test mapExtSystemErrorSourceToRequest method with extSystemErrorSource flag Change-Id: If5c9a41938d4cc922c26f7d64e3a839b6547556f Issue-ID: SO-2035 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-18NPE when setting instanceNamePlummer, Brittany1-13/+47
Added null check to fix NPE when setting instanceName Added check for null instanceName for vfModule Change-Id: Ie70651770466790fd1f9d666eeabdce26510b01b Issue-ID: SO-2034 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-18support no payload for alacarte deletesSmokowski, Steven18-22/+1390
Swap to using HTTP Enumerations rather than ints Add Unit Tests to Service Instances endpoint Add Vnf Tests remove Abstract class Clean up usage of abstract classes Fix volume and module bean wiring issues Add logic to find create request if cloud not in AAI Updated network to take in version pathparam Additonal refactor of the endpoints Add missing license headers to all files Clean up public variable usage, move to protected Change-Id: Icdbdf78aa6c8af7a30fdff8a5805103f8df9364d Issue-ID: SO-2032 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-07Merge "resume request support"Steve Smokowski3-11/+40
2019-06-06resume request supportPlummer, Brittany3-11/+40
copy request body rewrite requestorid added missing curly brace case to regex Updated how we are updating requestorId in requestBody Removed unused imports from RequestHandlerUtils Replaced requestorId in requestBody string Began updating requestorId in requestBody Change-Id: I54bd8097b196899b271956f03395bb98d295e1e0 Issue-ID: SO-1990 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-06Accommodate WAN NetworkingGamboa, Gilbert10-0/+505
checked and evaluated naming policy only if infra bonding. Updated workflowAction to include vrf configuration for vpn-binding in resourceIds list. added in linked resource to service proxy cust committing the asdc controller classpath change added some unit tests for vrf validation and updated bbinput setup test update config resource cust foreign key mapping Moved mockbean for AssignVrfConfiguration task class into BaseBpmnTest. added in a check to see if list is empty before access added unit tests for bbinput setup for vrf config Update AssignFlows enum with correct AssignVrfConfiguration flow name Change-Id: Ibf14e36505638b19c1366ecebfce560c02e69e44 Issue-ID: SO-1975 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-06Merge remote-tracking branch 'origin/dublin' into 'origin/master'Steve Smokowski17-895/+1089
Change-Id: I551ea3f29a76dc99532455ea4d7e84a316f9bf38 Issue-ID: SO-1980 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2019-05-31apih resume request handling more genericPlummer, Brittany3-51/+489
getInstanceName throws exception if requestScope doesn't match modelType Updated to combine separate return statements Replaced if statements for modelType and added tests Replace if statements for modelType in ResumeOrchestrationRequest and added tests Added coverage for setId in ModelType Updated to use ModelType setters/getters model type can now get and set generically Added modelInfo to RequestBody for resume request Added getModelType call and unit tests Moved getModelType from ServiceInstances Moved getModelType and added unit tests Added tests for getIsBaseVfModule Added more tests for isBaseVfModule Began adding tests for getIsBaseVfModule Updated currentActiveRequest creation and isBaseVfModule Updated recipe lookup and setting of aLaCarte to be more general Updated concurrency control to include other resources Change-Id: I12ad011d0a021c3ee066e16b4c8a4526d040cbe3 Issue-ID: SO-1963 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-31apih to populate original request idPlummer, Brittany3-3/+96
Updated schema.sql to fix failing tests Added constants for request parameters Added originalRequestId to be saved on resume request Added originalRequestId to orchestrationRequests response Change-Id: If2b86d233ee3db9bbe0e1185d92874bca2b3a07a Issue-ID: SO-1960 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-23Return empty WorkflowInputParametersElena Kuleshov1-1/+2
Return empty WorkflowInputParameters when none are available Issue-ID: SO-1919 Signed-off-by: Kuleshov, Elena <evn@att.com> Change-Id: I057e30bb55f6545c25060c28e1af097286f4e88b
2019-05-17Initial checkin of updates for vf module replaceSmokowski, Steven2-2/+233
fix toString method and add unit tests for new code Fix Null pointer issue in UT, extra chars Initial checkin of updates for vf module replace Change-Id: I2d62f5c2077cd022ccf796d126494e526ad48c54 Issue-ID: SO-1893 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-10APIH should ensure valid requestId UUIDBhatt, Prema2-7/+30
Added logic to check if the requestId sent in GET orchestrationRequest query is a valid UUID. Updated existing unit tests and added a new test for invalid UUID scenario. Change-Id: I424bef8aa75dd7e47de8145603899820dfb99725 Issue-ID: SO-1865 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-15Merge "Add SO native workflows to result list" into dublinSteve Smokowski3-0/+56
2019-05-15Use workflow's name for invocationElena Kuleshov1-1/+2
Use workflow's name for invocation Change-Id: Ie527788f029bdccc91f7f406df0a478e55375c01 Issue-ID: SO-1876 Signed-off-by: Kuleshov, Elena <evn@att.com>
2019-05-15Add SO native workflows to result listBonkur, Venkat (vb8416)3-0/+56
Added native workflows to result list Issue-ID: SO-1852 Signed-off-by: Bonkur, Venkat (vb8416) <vb8416@att.com> Change-Id: Ifeb2adf4ea78b191bcf46a1e7367bc0939d53b83
2019-05-05Resume APIH FunctionalityPlummer, Brittany5-11/+475
Updated license for 2019 and added null check test Moved record creation to RequestHandlerUtils Updated uri retrieval to obtain full uri Updated verify based on actual objects Renamed tests for better description Removed use of Spring in unit tests Moved constant to other logger files Added new class to JerseyConfiguration Separated resume request work to separate file Updated value that progress is saved as in db Added new original_partner_name key for partnername retrieval Added column for progress to be saved to db Added additional columns to be saved to requestDb Added inProgress request check to resume Change-Id: I9ef1e61829be49da348b29bc255beb073b48639d Issue-ID: SO-1831 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-04-30Add Model Version QuerySmokowski, Steven1-3/+4
Fix the sql migration version numbering to be proper Fix marking test as private, mark public Clean up public declarations to private Fix schema.sql to have new column for unit test Revert POM Change, add License, clean up comments Fix bad spelling of method name issue Update catalog db to support new rest endpoint Update local query service and mappers Localstaging of potential catalog db changes Update logic to write overall distro status Change-Id: I84d53b972ede3176c5af32d13444583a36606efa Issue-ID: SO-1820 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-04-28Store Cloud Request in DatabaseSmokowski, Steven3-74/+101
Store Cloud Request in Database, add to request service Add query Param to Plural to include cloud data Change-Id: If906d28d0dc9c0c804e550e2074af3d75ba46d32 Issue-ID: SO-1807 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-04-27Correct Catalog DB beansElena Kuleshov15-894/+1030
Correct Catalog DB beans Change-Id: Ie9bb4aef606da8c87e5960c95b564fb2fc299869 Issue-ID: SO-1828 Signed-off-by: Kuleshov, Elena <evn@att.com>
2019-04-26Enhancement for querysubhash kumar singh1-0/+1
Enhancemenv for query to include group and vnfccustomization. { "serviceResources": { "modelInfo": { "modelName": "NSService", "modelUuid": "0bad8c92-7d22-49f0-b092-b64e6ca564a7", "modelInvariantUuid": "69161960-515b-4bf3-91f1-313b813f5e1d", "modelVersion": "1.0" }, "serviceType": "", "serviceRole": "", "environmentContext": "General_Revenue-Bearing", "resourceOrder": "NF", "workloadContext": "Production", "serviceVnfs": [ { "modelInfo": { "modelName": "", "modelUuid": "123", "modelInvariantUuid": "", "modelVersion": "", "modelCustomizationUuid": "1234", "modelInstanceName": "test" }, "toscaNodeType": "", "nfFunction": "", "nfType": "", "nfRole": "", "nfNamingCode": "", "multiStageDesign": "", "resourceInput": "", "vfModules": [], "groups": [ { "modelInfo": { "modelName": "test", "modelUuid": "11", "modelInvariantUuid": "11", "modelVersion": "2" }, "vnfcs": [ { "modelInfo": { "modelName": "xfs", "modelUuid": "22", "modelInvariantUuid": "2222", "modelVersion": "22222", "modelCustomizationUuid": "2222" } } ] } ] } ], "serviceNetworks": [], "serviceAllottedResources": [] } } Issue-ID: SO-1393 Change-Id: Iee7f79337f73276f857d6d42b5b2416e4e8f4536 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2019-04-24add resourceInput in vnfczm3301-0/+1
Issue-ID: SO-1393 Change-Id: I643f49df545bef92f0f0e931f7b7ce1a5dbc21c0 Signed-off-by: zm330 <zhangminyj@chinamobile.com>
2019-04-23add vnfcInstanceGroup sequencezm3301-0/+1
Issue-ID: SO-1393 Change-Id: Ife3b71dcfa543a693564779da44800f1dd8486e9 Signed-off-by: zm330 <zhangminyj@chinamobile.com>
2019-04-15Merge "vnr vrf fk issue"Steve Smokowski1-22/+14
2019-04-12vnr vrf fk issueBenjamin, Max (mb388a)1-22/+14
Updated flyway migration script to rename object as per review comments. Used Tosca node type for determining VRF and VNF nodes updated code based on review comments for schema.sql Altered ConfigurationCustomizationResource for VRF-VNF to have bidirectional relationship ToscaResourceInstaller ConfigurationResourceCustomization was made bidrectional Change-Id: Ib45151ff7a40edca38d512ae76f8889b1cc4d0c4 Issue-ID: SO-1777 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-04-12Updated ServicesInstancesTest with mocksBenjamin, Max (mb388a)2-0/+7
- Updated ServicesInstancesTest with mocks for RequestDb.InfraActiveRequests query. Tests in ServicesInstancesTest were not failing, but seeing 'HTTP method does not match' messages on the console for most of the tests. Change-Id: Ic029cc50da1f414d3228f80b02721e132a15c264 Issue-ID: SO-1783 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-04-09Query CatalogDB for WorkflowSpecificationsElena Kuleshov4-36/+1119
Query CatalogDB for WorkflowSpecifications fron APIH Change-Id: I5eef5ba9b49c0a7420ef93a5425121bfe7225b1b Issue-ID: SO-1727 Signed-off-by: Kuleshov, Elena <evn@att.com>
2019-04-08Replaced all tabs with spaces in java and pom.xmlBenjamin, Max (mb388a)53-5323/+6091
Added in maven plugins to enforce coding style rules Added in eclipse java formatting xml Change-Id: I3727bbf4ce8dc66abfd8ad21b6cfd0890c5d3ff0 Issue-ID: SO-1765 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-04-08Workflow Recipe LookupElena Kuleshov3-11/+33
Workflow Recipe Lookup and related Catalog Beans Change-Id: Ib1c3493106658d139861d2620dfb9cb382115744 Issue-ID: SO-1728 Signed-off-by: Kuleshov, Elena <evn@att.com>
2019-04-04Return 200 instead of 202 on WorkflowSpecs GETElena Kuleshov1-1/+1
Return 200 instead of 202 on WorkflowSpecs GET Change-Id: I861801f86416b98beea98913b3788da8180dbdf9 Issue-ID: SO-1745 Signed-off-by: Kuleshov, Elena <evn@att.com>
2019-04-02fix catalogdb cvfnc customizationBenjamin, Max (mb388a)11-1040/+1330
Hibernate entities were all wrong and needed a complete rewrite. The scope kept growing and ended up touching a lot more of the code than originally planned. These changes make the db interactions much easier and more straightforward from java. The flyway script order had to change to make this migration possible. Change-Id: I6ce363a385661300eddb11923ac6a80538edaddc Issue-ID: SO-1710 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-04-01replace all fixed wiremock portsBenjamin, Max (mb388a)18-434/+457
trying to get the tests that can be threaded to pass started to remove fixed port references Change-Id: I7bfe067a8f36c908039700646571681321e9a6f5 Issue-ID: SO-1676 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>