summaryrefslogtreecommitdiffstats
path: root/mso-api-handlers/mso-api-handler-infra/src/main/java
AgeCommit message (Collapse)AuthorFilesLines
2019-07-09Merge "Sonar fixes in ManualTasks"Lukasz Muszkieta1-10/+3
2019-07-09Merge "Sonar fixes in OrchestrationRequests"Lukasz Muszkieta1-8/+4
2019-07-09Major Sonar fixesr.bogacki3-16/+17
Major Sonar fixes in different classes: -Removed unnecessary code. -Removed unused variables. -Removed unnecessary imports. -Simplified diamond operators. Issue-ID: SO-2102 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I098e3dcd93b804e58220bb41ea15325e820e3a59
2019-07-09Sonar fixes in OrchestrationRequestsr.bogacki1-8/+4
Sonar fixes in OrchestrationRequests according to the Sonar analysis. -Removed unnecessary code. -Removed unused variables. Issue-ID: SO-2101 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I564f35519c5063028e1cf540eb81ab81cf923fd5
2019-07-09Sonar fixes in ManualTasksr.bogacki1-10/+3
Code fixes in ManualTasks according to the Sonar analysis. -Removed unnecessary code. -Removed unused imports. -Removed unused variables. Issue-ID: SO-2100 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I79848456cc88b7f2cb812f7054bb6cec12b584c0
2019-07-01support new query param formatChan, Mercy17-56/+99
- added format query parameter (optional), implemented logic to populate requestStatus field based on whether or not format is present moved request status constants to its own class visible globally. - changed @requestParam to @QueryParam in GET endpoint (OrchestrationRequests class. updated unit tests to call method being tested directly rather than from another private function - moved setting requestStatus to a separate method, also updated unit tests to separate out each scenarion into its own method - added unit test for when format=detail, corrected existing unit tests to test result to be FAILED - updated Status.java to include extra request status values; moved Status class to common org.onap.so.constants package Change-Id: Ic593de5fdfdcbc3121f481c86d1e261406082260 Issue-ID: SO-2080 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-27add rollback ext system error sourcePlummer, Brittany1-0/+1
Added rollbackExtSystemErrorSource column and updated GET orchestrationRequests response Added missing columns from requestDb to schema.sql Change-Id: I2380f08b9bb1c86922e8faea70454df722c0873a Issue-ID: SO-2054 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-26Merge "Updated path to match AID for resume requests"Steve Smokowski1-1/+1
2019-06-24Sonar fixes and improvementsr.bogacki1-2/+4
General fixes and improvements according to the Sonar analysis. -Fixed imports. -Removed unnecessary code. Issue-ID: SO-1992 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I4299f3efc4444625f70fc36e65b57c500b113596
2019-06-21Updated path to match AID for resume requestsPlummer, Brittany2-2/+2
Updated path to match AID for resume requests Change-Id: I0035360f206882e602265500dcd54036b3e69ea2 Issue-ID: SO-2042 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-21fix jenkins buildLukasz Muszkieta1-1/+1
format AbstractRestHandler.java file Change-Id: I6f0025ba2a542e2476ee694b40ed670a9e02f2f3 Issue-ID: SO-2044 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-06-20Merge "support no payload for alacarte deletes"Steve Smokowski28-29/+2149
2019-06-20Merge "NPE when setting instanceName"Steve Smokowski1-3/+16
2019-06-18update apih to accept new uri parameterChan, Mercy1-7/+19
added extSystemErrorSource queryparam flag to getOrchestrationRequest endpoint. added junit tests for the protected method that maps external system error source to request object being returned. added junit tests to test mapExtSystemErrorSourceToRequest method with extSystemErrorSource flag Change-Id: If5c9a41938d4cc922c26f7d64e3a839b6547556f Issue-ID: SO-2035 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-18NPE when setting instanceNamePlummer, Brittany1-3/+16
Added null check to fix NPE when setting instanceName Added check for null instanceName for vfModule Change-Id: Ie70651770466790fd1f9d666eeabdce26510b01b Issue-ID: SO-2034 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-18support no payload for alacarte deletesSmokowski, Steven28-29/+2149
Swap to using HTTP Enumerations rather than ints Add Unit Tests to Service Instances endpoint Add Vnf Tests remove Abstract class Clean up usage of abstract classes Fix volume and module bean wiring issues Add logic to find create request if cloud not in AAI Updated network to take in version pathparam Additonal refactor of the endpoints Add missing license headers to all files Clean up public variable usage, move to protected Change-Id: Icdbdf78aa6c8af7a30fdff8a5805103f8df9364d Issue-ID: SO-2032 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-17Changes related to eviction of connectionsBenjamin, Max (mb388a)3-9/+41
These are changes related to ASDC controller for evicting database connection pool when ip address changes Included other appllications such as requestDB, CatalogDB, API Handler, BPMN, OpenstackAdapter etc Change-Id: I9a96ea12fb0c10643a204a58d55360bebba326fe Issue-ID: SO-2018 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-11update logger statements in apihBhatt, Prema3-21/+8
Corrected arguments to logger methods only log exception in catch blocks Change-Id: I0657b00ce45ac543d5e900db6ce5c24ba34e345d Issue-ID: SO-2007 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-11Improvements in ServiceInstancesr.bogacki1-12/+7
Improvements in ServiceInstances according to the Sonar analysis. -Fixed imports. -Removed unnecessary code. -Refactored diamond operators. Issue-ID: SO-2008 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: Ieb03f5b3fb52432091170402237ba4e23ed70e5d
2019-06-10replaced String.repeat with static final stringsBenjamin, Max7-46/+46
replaced String.repeat with static final strings Change-Id: Ife14fde70e8f648881a03e9343ae8faf9cb87e2e Issue-ID: SO-1999 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-07Merge "resume request support"Steve Smokowski1-1/+8
2019-06-06resume request supportPlummer, Brittany1-1/+8
copy request body rewrite requestorid added missing curly brace case to regex Updated how we are updating requestorId in requestBody Removed unused imports from RequestHandlerUtils Replaced requestorId in requestBody string Began updating requestorId in requestBody Change-Id: I54bd8097b196899b271956f03395bb98d295e1e0 Issue-ID: SO-1990 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-06Accommodate WAN NetworkingGamboa, Gilbert1-1/+14
checked and evaluated naming policy only if infra bonding. Updated workflowAction to include vrf configuration for vpn-binding in resourceIds list. added in linked resource to service proxy cust committing the asdc controller classpath change added some unit tests for vrf validation and updated bbinput setup test update config resource cust foreign key mapping Moved mockbean for AssignVrfConfiguration task class into BaseBpmnTest. added in a check to see if list is empty before access added unit tests for bbinput setup for vrf config Update AssignFlows enum with correct AssignVrfConfiguration flow name Change-Id: Ibf14e36505638b19c1366ecebfce560c02e69e44 Issue-ID: SO-1975 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-06Merge remote-tracking branch 'origin/dublin' into 'origin/master'Steve Smokowski2-3/+14
Change-Id: I551ea3f29a76dc99532455ea4d7e84a316f9bf38 Issue-ID: SO-1980 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2019-06-03Cleaned up duplicated literalsrob.bog7-61/+73
Cleaned up Sonar code smells related to the duplicated literals in loggers. Issue-ID: SO-1932 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I58c48cec0012c42b7b892ae76c24c6a087c60c7e
2019-05-31apih resume request handling more genericPlummer, Brittany3-101/+159
getInstanceName throws exception if requestScope doesn't match modelType Updated to combine separate return statements Replaced if statements for modelType and added tests Replace if statements for modelType in ResumeOrchestrationRequest and added tests Added coverage for setId in ModelType Updated to use ModelType setters/getters model type can now get and set generically Added modelInfo to RequestBody for resume request Added getModelType call and unit tests Moved getModelType from ServiceInstances Moved getModelType and added unit tests Added tests for getIsBaseVfModule Added more tests for isBaseVfModule Began adding tests for getIsBaseVfModule Updated currentActiveRequest creation and isBaseVfModule Updated recipe lookup and setting of aLaCarte to be more general Updated concurrency control to include other resources Change-Id: I12ad011d0a021c3ee066e16b4c8a4526d040cbe3 Issue-ID: SO-1963 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-31Merge "Corrected enum formatting by plugin"Steve Smokowski2-4/+32
2019-05-31Corrected enum formatting by pluginBenjamin, Max (mb388a)2-4/+32
enums are now single item per line Change-Id: I6330ea4a9093071457dd47b95b6ed3bb7f8312e7 Issue-ID: SO-1970 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-31apih to populate original request idPlummer, Brittany3-3/+10
Updated schema.sql to fix failing tests Added constants for request parameters Added originalRequestId to be saved on resume request Added originalRequestId to orchestrationRequests response Change-Id: If2b86d233ee3db9bbe0e1185d92874bca2b3a07a Issue-ID: SO-1960 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-31Improvements in AAIClientHelperr.bogacki1-5/+3
Improvements in AAIClientHelper according to the Sonar analysis. Removed unnecessary exception throwing. Fixed imports. Updated java docs. Issue-ID: SO-1958 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I60835304466bb656f09ba16b487907fa529e5eab
2019-05-23Return empty WorkflowInputParametersElena Kuleshov1-2/+2
Return empty WorkflowInputParameters when none are available Issue-ID: SO-1919 Signed-off-by: Kuleshov, Elena <evn@att.com> Change-Id: I057e30bb55f6545c25060c28e1af097286f4e88b
2019-05-17Initial checkin of updates for vf module replaceSmokowski, Steven2-28/+41
fix toString method and add unit tests for new code Fix Null pointer issue in UT, extra chars Initial checkin of updates for vf module replace Change-Id: I2d62f5c2077cd022ccf796d126494e526ad48c54 Issue-ID: SO-1893 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-10APIH should ensure valid requestId UUIDBhatt, Prema1-0/+10
Added logic to check if the requestId sent in GET orchestrationRequest query is a valid UUID. Updated existing unit tests and added a new test for invalid UUID scenario. Change-Id: I424bef8aa75dd7e47de8145603899820dfb99725 Issue-ID: SO-1865 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-15Merge "Add SO native workflows to result list" into dublinSteve Smokowski1-0/+7
2019-05-15Use workflow's name for invocationElena Kuleshov1-1/+1
Use workflow's name for invocation Change-Id: Ie527788f029bdccc91f7f406df0a478e55375c01 Issue-ID: SO-1876 Signed-off-by: Kuleshov, Elena <evn@att.com>
2019-05-15Add SO native workflows to result listBonkur, Venkat (vb8416)1-0/+7
Added native workflows to result list Issue-ID: SO-1852 Signed-off-by: Bonkur, Venkat (vb8416) <vb8416@att.com> Change-Id: Ifeb2adf4ea78b191bcf46a1e7367bc0939d53b83
2019-05-07Fix resourceIndex to modelsubhash kumar singh1-0/+11
Fix resourceIndex to model in json mapping. Change-Id: Ia609d3eb381b14fc5654774e83f8417a4d876e91 Issue-ID: SO-1393 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2019-05-05Resume APIH FunctionalityPlummer, Brittany6-66/+301
Updated license for 2019 and added null check test Moved record creation to RequestHandlerUtils Updated uri retrieval to obtain full uri Updated verify based on actual objects Renamed tests for better description Removed use of Spring in unit tests Moved constant to other logger files Added new class to JerseyConfiguration Separated resume request work to separate file Updated value that progress is saved as in db Added new original_partner_name key for partnername retrieval Added column for progress to be saved to db Added additional columns to be saved to requestDb Added inProgress request check to resume Change-Id: I9ef1e61829be49da348b29bc255beb073b48639d Issue-ID: SO-1831 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-04-29Merge "Store Cloud Request in Database"Steve Smokowski1-10/+26
2019-04-28Store Cloud Request in DatabaseSmokowski, Steven1-10/+26
Store Cloud Request in Database, add to request service Add query Param to Plural to include cloud data Change-Id: If906d28d0dc9c0c804e550e2074af3d75ba46d32 Issue-ID: SO-1807 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-04-27Correct Catalog DB beansElena Kuleshov1-0/+4
Correct Catalog DB beans Change-Id: Ie9bb4aef606da8c87e5960c95b564fb2fc299869 Issue-ID: SO-1828 Signed-off-by: Kuleshov, Elena <evn@att.com>
2019-04-27Sonar comments fixedSubhosree Pan1-2/+1
Removed commented lines/ Change static string litrals name according to the guidelines. Issue-ID: SO-1490 Change-Id: I77a0b2a5067d71ede2de8e090ed4d0b1fb61e219 Signed-off-by: Subhosree Pan <subhosree.pan1@huawei.com>
2019-04-27Sonar comments fixedSubhosree Pan3-32/+34
Removed commented lines/ Change static string litrals name according to the guidelines. Issue-ID: SO-1490 Change-Id: I4ffee97269f0f0bdcb23f5b297df8fddb0c133f1 Signed-off-by: Subhosree Pan <subhosree.pan1@huawei.com>
2019-04-27comments updatedSubhosree Pan2-2/+2
String constant added as per the guidance, commented out codes has been removed Issue-ID: SO-1490 Change-Id: Ia7a531580eaafd80900200b1cf5122c1a8b9f511 Signed-off-by: Subhosree Pan <subhosree.pan1@huawei.com>
2019-04-24removal of unused file imports.Subhosree Pan1-1/+1
removal of unused file imports. Issue-ID: SO-1490 Change-Id: I35c09f25f363c7da276beece4fff854f8f42a2f8 Signed-off-by: Subhosree Pan <subhosree.pan1@huawei.com>
2019-04-19Merge "Remove unused code and members."Seshu Kumar M1-9/+2
2019-04-19remove unused code and added loggingIsaac Manuel Raj1-2/+3
remove unused code and added logging Issue-ID: SO-1490 Change-Id: Ie9b0fd66d83e355617bf07c1c544daa1843a534e Signed-off-by: Isaac Manuel Raj <isaac.manuelraj@huawei.com>
2019-04-19Remove unused code and members.Isaac Manuel Raj1-9/+2
Remove unused code and members. Issue-ID: SO-1490 Change-Id: I5e2518401c51ac646f0b78b7236b9c88387f20ff Signed-off-by: Isaac Manuel Raj <isaac.manuelraj@huawei.com>
2019-04-09Query CatalogDB for WorkflowSpecificationsElena Kuleshov1-7/+141
Query CatalogDB for WorkflowSpecifications fron APIH Change-Id: I5eef5ba9b49c0a7420ef93a5425121bfe7225b1b Issue-ID: SO-1727 Signed-off-by: Kuleshov, Elena <evn@att.com>
2019-04-08Replaced all tabs with spaces in java and pom.xmlBenjamin, Max (mb388a)140-9699/+9636
Added in maven plugins to enforce coding style rules Added in eclipse java formatting xml Change-Id: I3727bbf4ce8dc66abfd8ad21b6cfd0890c5d3ff0 Issue-ID: SO-1765 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>