Age | Commit message (Collapse) | Author | Files | Lines |
|
Change-Id: I95381232eeefcd247a66a5cec370a8ce1c288e18
Issue-ID: SO-670
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Replace literal 'End of the transaction, the final response is: '
with already-defined constant END_OF_THE_TRANSACTION.
Issue-ID: SO-666
Change-Id: I96e097df2042eeace55c8692c4dfd95df2594d13
Signed-off-by: Ethan Hampton <ethanx.hampton@intel.com>
|
|
|
|
Removed two lines of commented-out code for readability.
Issue-ID: SO-666
Change-Id: If897ba1f7b4eaeab2bb41c2c7e7b8e6a8e34b245
Signed-off-by: Mariah Jacobs <mariah.jacobs@intel.com>
|
|
Immediately return expression instead of assigning it to variable "returnResp".
Issue-ID: SO-666
Change-Id: I7a9de4ebfb59776d9225f3bd29ef57d184b2679a
Signed-off-by: Mariah Jacobs <mariah.jacobs@intel.com>
|
|
service instance id is now correctly passed in case of delete instance operation
Change-Id: Ifb5c27194d6a588852051df0aa391b559b484ac0
Issue-ID: SO-640
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
|
|
This reverts commit c40b51651eff7997eb1bc823644a059b5406868c.
Change-Id: I99e03cf9be05110ca7b4609a35ce7106f3c30b3b
Issue-ID: SO-640
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
|
|
|
|
This commit adds some robustness to the interface between the
API-H and BPMN, specifically, in how the response is handled.
I don't have proof, but there appears to be some randomness to
the json provider behavior when used with the jax-rs. Sometimes,
the serializer is adding the root element, and sometimes it
is not. Maybe there's something wrong with the configuration.
Maybe we have competing json providers. I couldn't pin this
down.
I'm almost certain it is the presence of the root element in
the content that causes the API-H code to fail parsing of the
BPMN response. This doesn't kill the request, as you might
expect, but rather, the API-H passes the BPMN response through
to the client (VID, or policy, or whatever).
The original problem (SO-586) was "fixed" by "removing the
wrapper". This "wrapper" is a needed feature of the interface
between BPMN and the API-H. We shouldn't have removed it.
The fact that the "fix" appeared to work is due to the
behavior I described in the previous paragraph. The API-H
chokes on the message, and it passes it through unchanged.
Not really what we want.
So, I don't know why the jackson/json behavior is flaky and
different now, but I can (and did) modify the API-H so it can
parse a json message whether or not it has a root element.
Note that WorkflowResponse.java (in BPMN) and CamundaResponse.java
(in the API-H) are basically the same bean representing the
message format. Seems less than ideal to have two different
classes.
Also note that I changed the name of the "response" attribute
of the WorkflowResponse and CamundaResponse classes to "content".
Got tired of seeing this nonsense everywhere in the code:
response.getResponse()
Change-Id: Icaf70f8457de99e493cf882170fe778c620308c9
Issue-ID: SO-586
Issue-ID: SO-618
Signed-off-by: Rob Daugherty <rd472p@att.com>
|
|
Change-Id: Ia38fa1234f7b89c0574c74efe62d7b270c8ff987
Issue-ID: SO-596
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
|
|
Remove operation status set in api-handler
Change-Id: I579d25044130b0701231c0a2d42534e8c63e3ebd
Issue-ID: SO-587
Signed-off-by: c00149107 <chenchuanyu@huawei.com>
|
|
File:E2EServiceInstances.java
Line:L706
Sonar
Link:https://sonar.onap.org/project/issues?assigned=false&id=org.onap.so%3Aso&open=AWJskpquRGy6eclHE4zt&resolved=false&rules=squid%3AS1132&severities=MAJOR
Change-Id: Iba618d98de4153deefa3822240b3ec29226bef68
Issue-ID: SO-592
Signed-off-by: Sumapriya <SS00493505@techmahindra.com>
|
|
File: MsoVnfAdapterImpl.java
Sonar Link:
https://sonar.onap.org/project/issues?assigned=false&id=org.onap.so%3Aso&open=AWHCr-UwEU5FCDfKtmD4&resolved=false&rules=squid%3AS1481&severities=MAJOR
Location:
src/main/java/org/openecomp/mso/adapters/vnf/MsoVnfAdapterImpl.java
Line No:L1888
File: E2EServiceInstances.java
Sonar Link:
https://sonar.onap.org/project/issues?assigned=false&id=org.onap.so%3Aso&open=AWHCr-iMEU5FCDfKtmO-&resolved=false&rules=squid%3AS1481&severities=MAJOR
Location:
src/main/java/org/openecomp/mso/apihandlerinfra/E2EServiceInstances.java
Line No:L1326
File: MsoRequest.java
Sonar Link:
https://sonar.onap.org/project/issues?assigned=false&id=org.onap.so%3Aso&open=AWHCr-jXEU5FCDfKtmSQ&resolved=false&rules=squid%3AS1481&severities=MAJOR
Location:
src/main/java/org/openecomp/mso/apihandlerinfra/MsoRequest.java
Line No:L916
File: SdncUnderlayVpnOperationClient.java
Sonar Link:
https://sonar.onap.org/project/issues?assigned=false&id=org.onap.so%3Aso&open=AWIP10X8RGy6eclHDJ5J&resolved=false&rules=squid%3AS1481&severities=MAJOR
Location:
src/main/java/org/opencomp/mso/bpmn/infrastructure/workflow/serviceTask/SdncUnderlayVpnOperationClient.java
Line No:L70
Change-Id: Id2548cb7e9ef2a916d5adbd93fa5ded4fba6d7ab
Issue-ID: SO-582
Signed-off-by: Sumapriya <SS00493505@techmahindra.com>
|
|
File:RestfulUtil.java
Line:L85
Sonar Link:
https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL
File:E2EServiceInstances.java
Line:L263 L1059
Sonar Link:
https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL
File:OrchestrationRequests.java
Line:L343
Sonar Link:
https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL
File:ASDCConfiguration.java
Line:L286 L378
SonarLink:
https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL
File:ResourceInput.java
Line:L287
Sonar Link:
https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL
File:ResourceRecipeRequest.java
Line:L136
Sonar Link:
https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL
File:ResourceRequestBuilder.java
Line:L108 L214
Sonar Link:
https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL
File:CheckAaiForCorrelationIdDelegate.java
Line:L70
Sonar Link:
https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL
File:AbstractSdncOperationTask.java
Line:L359
Sonar Link:
https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL
File:DmaapClient.java
Line:L62
Sonar Link:
https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL
File:HasAnnotationPropertyWithValueMatcher.java
Line:L60
Sonar Link:
https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL
Change-Id: Ic168a118790c31850a9f32f98465be5d52b8c96f
Issue-ID: SO-581
Signed-off-by: AS00465059 <AS00465059@techmahindra.com>
|
|
Change-Id: Idaa55084f5ecb0dd3636c232cebc14fa5f064305
Issue-ID: SO-578
Signed-off-by: Yulian Han <elaine.hanyulian@huawei.com>
|
|
Change-Id: Idaa55084f5ecb0dd3636c232cebc14fa5f064300
Issue-ID: SO-578
Signed-off-by: Yulian Han <elaine.hanyulian@huawei.com>
|
|
Change-Id: Idaa55084f5ecb0dd3636c232cebc14fa5f064601
Issue-ID: SO-565
Signed-off-by: Yulian Han <elaine.hanyulian@huawei.com>
|
|
|
|
Issue-ID: SO-423
Change-Id: I752e096806ec513250a8fb1bf51a2ed57fb05f6e
Signed-off-by: guanwenyao <guanwenyao@chinamobile.com>
|
|
Change-Id: Idaa55084f5ecb0dd3636c232cebc14fa5f0641f8
Issue-ID: SO-419
Signed-off-by: Yulian Han <elaine.hanyulian@huawei.com>
|
|
Upgrade org.codehaus.jackson : jackson-mapper-asl : 1.9.13 to com.fasterxml.jackson.core : jackson-databind : 2.8.7
Change Jackson error message in test to new error message.
Change-Id: I719166bcf71d171c2e2ba721790eb87fcda8f305
Issue-ID: SO-537
Signed-off-by: Arthur Martella <amartell@research.att.com>
|
|
Change-Id: Idaa55084f5ecb0dd3636c232cebc14fa5f0641e6
Issue-ID: SO-419
Signed-off-by: Yulian Han <elaine.hanyulian@huawei.com>
|
|
|
|
Either log or rethrow this exception
E2EServiceInstances.java:513
Sonar Link:
https://sonar.onap.org/issues?myIssues=true&open=AWIA0508RGy6eclHC5SJ&resolved=false
Location:
mso-api-handler-infra/src/main/java/org/openecomp/mso/apihandlerinfra/E2EServiceInstances.java
Change-Id: Ie38f89f41ea58ab5911c5213e7c39da68ded9209
Issue-ID: SO-483
Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
|
|
|
|
Update e2e models.
Change-Id: Ifc64a394670a7edcd01d2e4ec78f96a113913bbc
Issue-ID: SO-368
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
|
|
This is code from AT&T's 1712 and 1802 releases.
Change-Id: Ie1e85851e94bc66c4d9514a0226c221939531a04
Issue-ID: SO-425
Signed-off-by: Rob Daugherty <rd472p@att.com>
|
|
Issue-ID: SO-419
Change-Id: Ibef5e8e617dcfb1d4f9b4087f20d6058a47bd741
Signed-off-by: Yulian Han <elaine.hanyulian@huawei.com>
|
|
Add recipe params for bpmn call, to improve recipe enhancement.
Change-Id: If9f2bff3f27ced62e814afcb918c863a527363e6
Issue-ID: SO-449
Signed-off-by: c00149107 <chenchuanyu@huawei.com>
|
|
Select recipe for create service
Change-Id: I4109c775aef14d2621777bef3a6891b8a6cb8a05
Issue-ID: SO-438
Signed-off-by: c00149107 <chenchuanyu@huawei.com>
|
|
Fix Null Point Exception
Change-Id: I4e542ffd1369140b21d6252a5f90db66651df181
Issue-ID:SO-328
Signed-off-by: c00149107 <chenchuanyu@huawei.com>
|
|
IssueId: SO-260
Change-Id: Ie57b57b98472f6d8b012137562713de02d6a516c
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
|
|
IssueId: SO-259
Change-Id: Ibb7a78bc13628ffd2c9d2569dd40542adb9f299d
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
|
|
IssueId:SO-270
Change-Id: Ib0dffb240ae905a6c190fbab1ebcac379e8f7319
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
|
|
IssueId: SO-263
Change-Id: I965a34906c9b22345452000bf26dcfe5d5773429
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
|
|
IssueId: SO-258
Change-Id: I7699b44d5e72fdcec96f86b0c493b969f9c91598
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
|
|
IssueId: SO-258
Change-Id: Ib038f1a40d3a1a8604b3ba1da6b7bc7de33a074e
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
|
|
IssueId : SO-253
Change-Id: Id7422ce88965c82c20eea5071db4992bee349279
Signed-off-by: Seshu-Kumar-M <seshu.kumar.m@huawei.com>
|
|
Fix Issues about voLTE Create
Change-Id: I811dc05c8f9a7caecddb279e025772d5d02c2548
Issue-ID:SO-254
Signed-off-by: c00149107 <chenchuanyu@huawei.com>
|
|
IssueId : SO-205
Change-Id: I5650400729ab89b5b3ae1e8adb0e892390281489
Signed-off-by: Seshu-Kumar-M <seshu.kumar.m@huawei.com>
|
|
IssueId: SO-205
Change-Id: Ib5f634c13c09c9f5df04d3973dd6c95684520d0b
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
|
|
|
|
IssueId: SO-118
Change-Id: Ia2e6e0d3bbef4c80721991762876c9ed98043790
Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
|
|
Fix major sonar issues in so module
https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#resolved=false|severities=BLOCKER%2CMAJOR|rules=squid%3AS1132%2Csquid%3AS1143
Move the "service" string literal on the left side of this string comparison.
Deleted redundant variables
Issue-Id: APPC-186
Change-Id: I25410825aadfaf1ff444c6fa39d2783344db70d0
Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
|
|
Adding java docs and resolved conversion issue of 2e2sir to sir
IssueId: SO-153
Change-Id: Ia5803246f13f729b184d0d0a9df67d39fa008825
Signed-off-by: Seshu-Kumar-M <seshu.kumar.m@huawei.com>
|
|
IssueId: SO-151
Change-Id: I267c81464a2ae42474516a79f9711b370b3ba5ca
Signed-off-by: Seshu-Kumar-M <seshu.kumar.m@huawei.com>
|
|
IssueId: SO-60
Change-Id: I94a705d2d590436e27f290f413fc1a5eab1a2e10
Signed-off-by: Seshu-Kumar-M <seshu.kumar.m@huawei.com>
|
|
IssueId: SO-56
Change-Id: I3c407cc2b2c0abeb6e315d6b0886edf35d099fd3
Signed-off-by: Seshu-Kumar-M <seshu.kumar.m@huawei.com>
|
|
IssueId:SO-135
Change-Id: I7cd247400c91a4a9d2fa9b10b917d1657f27c361
Signed-off-by: Seshu-Kumar-M <seshu.kumar.m@huawei.com>
|