aboutsummaryrefslogtreecommitdiffstats
path: root/mso-api-handlers/mso-api-handler-common
AgeCommit message (Collapse)AuthorFilesLines
2020-06-19Ignore unknown properties in the camunda responseBoslet, Cory1-0/+2
Ignore unknown properties in the camunda response so doesnt fail on timestamp. Updated unit test to account for changes to object mapper. Issue-ID: SO-2990 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I15c064f7e93307f921c07d4aaa42122a5f93c380
2020-06-18Prepare for java 11Benjamin, Max2-1/+1
final changes for java11 groovy compatibility removed unnecessary dependencies and cleaned up poms added missing jaxws-api dependency to pom.xml java8 profile is now active by default in parent pom update beans to have RemoteResource annotation always use the compiler plugin from parent pom Update external task timeout to longer value to hold lock update remote resource annotation to match catalog db client add remote resource annotation to bean for bowman completely remove bowman from requests db client Issue-ID: SO-2059 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: If6f0df36e8077ccd703abce9f64290daed63955b
2020-05-08CamundaClient not handle operationType used by Activate5GSliceServiceInstanceshetengjiao5-5/+25
Issue-ID: SO-2911 Change-Id: I23a7628359439adeeec9f22302f64f4441939897 Signed-off-by: hetengjiao <hetengjiao@chinamobile.com>
2020-04-27refactor camunda client in apihPlummer, Brittany13-907/+299
Switched CamundaClient to use restTemplate Combined clients into one CamundaClient Initial setup of exception handling in camundaclient Initial fix of compilation issues Switched CamundaClient constructor Updated how url is set in CamundaClient Updated auth to fix tag mismatch warning Added throwing ClientConnectionException to client Updated ServiceInstancesTest cases Updated error handling for CamundaClient Updated how response is returned Fixed failing unit tests in apih infra Refactored response handler for responseentity Fixed failing unit tests in apih Removed old unit tests for client Import cleanup for unneeded changes Updated to use new CamundaClient Updated CamundaClient and ResponseHandler tests Removed unused RequestHandler Issue-ID: SO-2834 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I82ff489c9c939a7e8ec0e48476daf7e45baa5f20
2020-04-13lowered code smellsRupinder1-8/+0
removed unused imports Issue-ID: SO-2804 Change-Id: I85b8b35be12bad9183261183c490ee90702db9af Signed-off-by: Rupinder<rupinsi1@in.ibm.com>
2020-03-05create custom spring aop annotation for loggingPlummer, Brittany3-3/+3
Added annotation for setting up scheduled tasks logs Added new annotation to scheduledTasks Moved annotation setup to logging-library Issue-ID: SO-2713 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I7080c4bb289e454f14167631e2601c954389c0ef
2020-02-29Add Slice Service Activate Requestzm3301-0/+14
Issue-ID: SO-2368 Signed-off-by: zm330 <zhangminyj@chinamobile.com> Change-Id: Id9d0b295b115e3639ebdbcf5287ea240ceb9eca7
2020-02-26bump the versions for all the SO to 1.6.0seshukm1-1/+1
Issue-ID: SO-2519 Signed-off-by: seshukm <seshu.kumar.m@huawei.com> Change-Id: Id0993b244b0978375ff8476e4bf8ef79e1bb9e68
2020-01-02SO API to support custom PNF workflowYulian Han1-1/+2
Change-Id: Idaa55084f5ecb0dd3636c232cebc14fa5f064418 Issue-ID: SO-2071 Signed-off-by: Yulian Han <elaine.hanyulian@huawei.com>
2019-12-11add application id support to soBonkur, Venkat2-3/+0
add application id support to so api Issue-ID: SO-2561 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Ifc8c4dd5e178b68347a7df01ab1942a59baca9b0
2019-11-22Merge "vnf and vf module replace requests to make"Steve Smokowski4-105/+12
2019-11-22improve error log scoresPlummer, Brittany1-7/+9
Updated error code name to fix spelling Defaulted errorcode and errordesc to unknown when not provided Remove unused imports from nc orchestrator application Added defaulting of serviceName to error log Issue-ID: SO-2538 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I5ae960f728739e2528173b66484562742429416c
2019-11-20vnf and vf module replace requests to makePlummer, Brittany4-105/+12
Added cloudConfiguration when not sent in replace request Added robot test for vfModule request with no cloud config Started adding unit tests for ServiceInstances Added unit tests for BpmnRequestBuilder changes Added ServiceInstances tests to test replace without CloudConfig Removed unused wiremock stubbings from test Added check for replaceInstanceRetainAssignments action Added action to common package to fix failing robot tests Removed new test, updated existing vfModule replace Added jackson annotations to RequestError object Fixed failing unit tests apih common Issue-ID: SO-2523 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I9470a0a9c7e356ef98ceb7269e066e79e0afb074
2019-10-31- Skip requestId lookup when uri isMerkel, Jeff2-7/+43
- Skip requestId lookup when uri is orchestrationRequests. - Reformatted code to fix the build error. - Updated mockContext in TC to mock up URI path. - Added a test that skips the requestId lookup. - Added verify to ensure the lookup method is not called. - Fixed the formatting to pass the verify build. Issue-ID: SO-2499 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I12a991032a8cd1b3664cc807fde568f89bf779fa
2019-09-24Update Resume Logic and Add Workflow ListenersSmokowski, Steven6-7/+138
Updated with the error log messages Changed the code to do string compare for eventName update workflowaction to only persist if not resume Issue-ID: SO-2363 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I139f2427ae0f0253a15cc51003318686568cb514
2019-08-15Initial commit of validation framework to APIHSmokowski, Steven3-2/+16
Move ListenerRunner to common location Adjust request params name, update junit tests Update validations to work properly Properly escape period for the string split Issue-ID: SO-2232 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Ia468cf7062cccf30e28afeb7a5cddc37ceb2e002
2019-08-13Merge "Change variable name-comply with regex"Seshu Kumar M1-2/+2
2019-08-13Merge "Modify variable name-comply with regex"Seshu Kumar M1-2/+2
2019-08-12Change variable name-comply with regexsindhu36721-2/+2
Change variable name-comply with regex asdc-controller & mso-api-handlers classes Issue-ID: SO-2187 Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com> Change-Id: I709cbcacc32e57a8b9cf89a963321bfde3b08301
2019-08-12Modify variable name-comply with regexsindhu36721-2/+2
Modify variable name-comply with regex mso api handlers DuplicateRequestException class Issue-ID: SO-2187 Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com> Change-Id: Ifbd69bffcfce08cc2e9c44817a02f9ddfe28aadc
2019-08-09All extendable enums should be serializableBenjamin, Max (mb388a)1-1/+3
marking items as transient causes them to be lost Issue-ID: SO-2217 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: If66f9034b67f94c8122875ef915043525fb9bdb7
2019-07-29apih allowing requests with the same requestidPlummer, Brittany3-26/+102
Updated filters to throw error on duplicate requestId Added message indicating exception will be thrown Added unit tests for requestIdFilters Added access modifier in filter test Updated CloudApiRequests for successful deletion when InfraActiveRequest is deleted Removed changes from CloudApiRequests bean Updated repository to include deleteByRequestId Removed unused import from cloudApiRequests Removed deleteByRequestId from interface Updated to change type of extended jparepository Removed repository added for CloudApiRequests Updated uri check to remove '/' from checked string Updated returned on failing junit test Updated access modifiers for logger and createRequestError Issue-ID: SO-2166 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Id0cee672567b15e0a3eb1acfbdfb967945494500
2019-07-22enhance get orchestration requestPlummer, Brittany1-4/+4
Enhance get orchestration request to include workflow step Began working on adding call for activity name Added call to return activity information Updated to return last task executed Added last task executed info to returned string Updated mocks to fix failing unit tests Added responses for mocks to Camunda for process and activity history Added tests to cover taskName changes Began adding tests to cover changes to RequestHandlerUtils Added more unit tests for activity lookup Updated error messages for taskName Moved properties to application.yaml file Added unit tests to add more coverage to task retrieval Moved Camunda calls to CamundaRequestHandler class Removed unused imports from RequestHandlerUtils Fixed formatting of tests and removed handler where not used Removed CamundaRequestHandler from JerseyConfiguration Added retryTemplate for camunda calls Issue-ID: SO-2142 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I09a82e3458e8f611e4bbaf3ce9ab5de36b1b060a
2019-07-01support new query param formatChan, Mercy2-30/+1
- added format query parameter (optional), implemented logic to populate requestStatus field based on whether or not format is present moved request status constants to its own class visible globally. - changed @requestParam to @QueryParam in GET endpoint (OrchestrationRequests class. updated unit tests to call method being tested directly rather than from another private function - moved setting requestStatus to a separate method, also updated unit tests to separate out each scenarion into its own method - added unit test for when format=detail, corrected existing unit tests to test result to be FAILED - updated Status.java to include extra request status values; moved Status class to common org.onap.so.constants package Change-Id: Ic593de5fdfdcbc3121f481c86d1e261406082260 Issue-ID: SO-2080 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-18support no payload for alacarte deletesSmokowski, Steven4-7/+118
Swap to using HTTP Enumerations rather than ints Add Unit Tests to Service Instances endpoint Add Vnf Tests remove Abstract class Clean up usage of abstract classes Fix volume and module bean wiring issues Add logic to find create request if cloud not in AAI Updated network to take in version pathparam Additonal refactor of the endpoints Add missing license headers to all files Clean up public variable usage, move to protected Change-Id: Icdbdf78aa6c8af7a30fdff8a5805103f8df9364d Issue-ID: SO-2032 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-14update multi stage code to accurately skip bbsBenjamin, Max1-0/+20
moved around classes to packages that make more sense updated license headers in java files converted MultiStage logic to FlowManipulator moved tests to new package location and fixed issues allow for custom listeners before flowsToExecute moved validation classes to listener.validation Change-Id: Ic5416812ef9c5611fe19bf9b6aa316373b110ec6 Issue-ID: SO-2021 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-11update logger statements in apihBhatt, Prema5-21/+8
Corrected arguments to logger methods only log exception in catch blocks Change-Id: I0657b00ce45ac543d5e900db6ce5c24ba34e345d Issue-ID: SO-2007 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-10replaced String.repeat with static final stringsBenjamin, Max3-9/+9
replaced String.repeat with static final strings Change-Id: Ife14fde70e8f648881a03e9343ae8faf9cb87e2e Issue-ID: SO-1999 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-03Cleaned up duplicated literalsrob.bog3-7/+10
Cleaned up Sonar code smells related to the duplicated literals in loggers. Issue-ID: SO-1932 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I58c48cec0012c42b7b892ae76c24c6a087c60c7e
2019-05-31Corrected enum formatting by pluginBenjamin, Max (mb388a)1-1/+23
enums are now single item per line Change-Id: I6330ea4a9093071457dd47b95b6ed3bb7f8312e7 Issue-ID: SO-1970 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-31Merge "Improvements in RequestClient"Lukasz Muszkieta2-13/+62
2019-05-30Improvements in RequestClientFactoryr.bogacki1-5/+6
Improvements in RequestClientFactory according to the Sonar analysis. Fixed imports. Removed unnecessary exceptions handling. Replaced depreciated DefaultHttpClient with a new one. Issue-ID: SO-1947 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: Id497bfb620775aac67ad4c5f6d57e0fccce4fd34
2019-05-30Improvements in RequestClientr.bogacki2-13/+62
Improvements in RequestClient according to the Sonar analysis. Removed unnecessary exceptions handling. Added junit tests. Fixed imports. Issue-ID: SO-1945 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: Iee22e7dbeb39ca28c437f9a8a804b81945cb9bc5
2019-05-29Improvements in CamundaClientrob.bog1-49/+21
Removed code duplicates. Fixed declarations of thrown exceptions. Fixed imports. Issue-ID: SO-1936 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: Ic178341b0049307da033408719ff263a00059ba7
2019-04-25Removal of unused local variables.NITIN KAWA3-46/+21
Removed useless assignment to local variables and reordered the modifiers as per java language specification. Issue-ID: SO-1490 Change-Id: I43f25854d60cd25fb472618e21f2c1c91bc1c457 Signed-off-by: NITIN KAWA <nitin.kawa@huawei.com>
2019-04-24Removal of unused local variables.NITIN KAWA1-9/+12
Removal of unused local guidelines as per guidelines. Issue-ID: SO-1490 Change-Id: I54df34d24a88b5cf7a4e3f0a222ff334b85ebe83 Signed-off-by: NITIN KAWA <nitin.kawa@huawei.com>
2019-04-21Merge "Reallocate Constructor call"Seshu Kumar M1-2/+2
2019-04-21Merge "Move Constructor call"Seshu Kumar M1-2/+2
2019-04-21Reallocate Constructor callSindhuri.A1-2/+2
Reallocate Constructor call api handler common Constants class Issue-ID: SO-1490 Change-Id: I07ec6ca98019860105361f622a792abdf726f30b Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
2019-04-21Move Constructor callSindhuri.A1-2/+2
Move Constructor call CamundaResponse class Issue-ID: SO-1490 Change-Id: I60d31c31dff8a27319a0e85624c4d7b1eeeca032 Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
2019-04-21Shift Constructor callSindhuri.A1-2/+2
Shift Constructor call CamundaResponse class Issue-ID: SO-1490 Change-Id: Ie4105120b0ddc50281149c65b0186b89d4570359 Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
2019-04-11corrected inlucde filter for formatterBenjamin, Max (mb388a)1-122/+122
all pom.xml files now have two spaces validation is on for pom.xml files Change-Id: I424ea2e4d6a549f468792e5f90a43f3a97e6c954 Issue-ID: SO-1781 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-04-08Replaced all tabs with spaces in java and pom.xmlBenjamin, Max (mb388a)52-2052/+2010
Added in maven plugins to enforce coding style rules Added in eclipse java formatting xml Change-Id: I3727bbf4ce8dc66abfd8ad21b6cfd0890c5d3ff0 Issue-ID: SO-1765 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-04-08Do not overwrite requestIdBenjamin, Max (mb388a)3-0/+134
Added filter to reject requests that reuse request ids for requests db Change-Id: Iced020a9e1bc98c93911966f62ac0049e43e314b Issue-ID: SO-1762 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-03-25JUnit tests for CamundaClientr.bogacki1-0/+18
Increased junit tests coverage according to Sonar analyses. Change-Id: I52b13399c03bae4efbb0a5a7daf8eb9fde40d244 Issue-ID: SO-1692 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
2019-03-18Removed MsoLogger classr.bogacki6-19/+18
Bye bye MsoLogger class. Extracted constants to separated classes. Fixed imports. Change-Id: I7c8e0527e7dbd097d3ea93b9dab279354652da47 Issue-ID: LOG-631 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
2019-03-12add instance group support to SOBenjamin, Max (mb388a)1-0/+1
add create support add delete support added naming service support Change-Id: Iaf4f2bdae8ea55aca71d6e9b818a76e90db0b012 Issue-ID: SO-1616 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-03-01Removed MsoLogger from 'mso-api-handler-common'r.bogacki8-37/+66
Replaced MsoLogger with plain slf4j. Refactored login output. Fixed imports. Change-Id: I4254087187c9b7006d0dac8b3ab13fe41113c42f Issue-ID: LOG-631 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
2019-02-28CorrelationId cleanupJoanna Jeremicz6-25/+25
Remove old correlationId field and references from ServiceInstancesRequest and rename correlationId to pnfCorrelationId Change-Id: I5d8861aebe14c68574b6c54bc8d4eadf2967478b Issue-ID: SO-1274 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2019-02-05Removed duplicate classes from api handlerBenjamin, Max (mb388a)3-2/+29
removed duplicate classes Change-Id: I5158e1b8ce197cb8c204e484b87a5411161f3d93 Issue-ID: SO-1464 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>