aboutsummaryrefslogtreecommitdiffstats
path: root/mso-api-handlers/mso-api-handler-common/src
AgeCommit message (Collapse)AuthorFilesLines
2018-09-18Merge "added test case to CamundaClientTest.java"Seshu Kumar M1-34/+52
2018-09-17Accept header not honored when building exceptionBenjamin, Max (mb388a)2-19/+130
added accept headers to http entity request mappers were looking at "Content-Type" and not "Accept" modified test to no longer share global headers added additional tests and corrected comparison errors Fixing issue with comparing media types, the equals method in MediaType.class uses parameters as well to compare, added a method to just compare the type and subtype and get done with it Fixing test failures, getMEdiaType would come as null in most cases, this causes the defautl serialization mode to be picked which is xml. tests now pass with exception providers in place exception providers now handle JSON and XML Dumy push to re-trigger the build which failed at sonar evaluation Trying to fix the build by removing different spy's Returning XML instead of JSON in cases of error for endpoints. Removed exceptions and its generic handler which is a good thought, however given that the exceptionhandlers are generic it gets tough to return to handle exceptions which require different namesaces in response amongst other problems. Change-Id: I684fe3b0047693093a99aa999faf261d7713f404 Issue-ID: SO-1058 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-09-17Accept VNF Recreate RequestsBenjamin, Max (mb388a)1-1/+2
Updated nfRole in sample catdb json response Added gr-api-default recipe for recreate Updated description in catdb response json Updated catdb response file to have the correct action Added action to common package Removed requestor ids and source from test requests Began adding recreate endpoint and tests Began adding validation for recreate and junit tests Change-Id: I60c588be104b82b2d0dfb8587069e04f7b4710be Issue-ID: SO-1057 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-09-17added test case to CamundaClientTest.javaSandeep J1-34/+52
to increase code coverage Issue-ID: SO-1053 Change-Id: I34f287041f5f09cf0c37a0c9babe9719a6d5ce97 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-09-10fixed sonar issue in CamundaClient.javaSandeep J1-1/+3
fixed sonar issue as detailed in SO-993 Issue-ID: SO-993 Change-Id: I614cf8add2e056b18f1e4926b658b4ea716afd86 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-08-24Added actions to common APIH packageBrittany Plummer (bp896r)1-1/+3
Added scaleOut to common APIH Action enums Change-Id: I94f3d6b68d8890dd41aa4bd9ff51e5ecd2253383 Issue-ID: SO-904 Signed-off-by: Brittany Plummer (bp896r) <bp896r@att.com>
2018-08-10Merge "Fix Error Scenario"Rob Daugherty2-2/+2
2018-08-10Fix Error ScenarioSmokowski, Steve (ss835w)2-2/+2
If Camunda returns a non-auth error, or invalid JSON. APIH was not logging the error or properly updating the request database record Issue-ID: SO-818 Change-Id: I8b164002132ca6c25f95e1fa2b194e6cb4c3be03 Change-Id: If6e06de0fb8a01a00ef06ade915dd7c13623047b Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-08-10Improve LoggingSmokowski, Steve (ss835w)1-3/+4
Add Stack trace to be logged, currently only a generic error message is logged Issue-ID: SO-846 Change-Id: I8479247227cf08de25bece5077003ee83c08472d Change-Id: I8479247227cf08de25bece5077003ee83c08472d Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-08-09Remove PropertySmokowski, Steve (ss835w)1-2/+0
Remove BPEL properties that are no longer used Issue-ID: SO-817 Change-Id: Ie654562dabaddfcff68de3dfddeb85eed478b0a5 Change-Id: I6a418c73608d08f4cf12833f893e671ffa77beb0 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-07-31Containerization feature of SOBenjamin, Max (mb388a)59-1076/+2422
Change-Id: I95381232eeefcd247a66a5cec370a8ce1c288e18 Issue-ID: SO-670 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-06-01add junit for CamundaTaskClientLukasz Muszkieta3-7/+137
Change-Id: I3afd465b6b2536cd3a285865de9a8aa29c046bd8 Issue-ID: SO-665 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-05-28CorrelationId implementation correctionLukasz Muszkieta8-132/+307
service instance id is now correctly passed in case of delete instance operation Change-Id: Ifb5c27194d6a588852051df0aa391b559b484ac0 Issue-ID: SO-640 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-05-24Revert correlationId implLukasz Muszkieta8-307/+133
This reverts commit c40b51651eff7997eb1bc823644a059b5406868c. Change-Id: I99e03cf9be05110ca7b4609a35ce7106f3c30b3b Issue-ID: SO-640 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-05-22Merge "Add correlationId to ServiceInstancesRequest"Seshu Kumar M8-133/+307
2018-05-15WorkflowResponse json issuesRob Daugherty4-105/+137
This commit adds some robustness to the interface between the API-H and BPMN, specifically, in how the response is handled. I don't have proof, but there appears to be some randomness to the json provider behavior when used with the jax-rs. Sometimes, the serializer is adding the root element, and sometimes it is not. Maybe there's something wrong with the configuration. Maybe we have competing json providers. I couldn't pin this down. I'm almost certain it is the presence of the root element in the content that causes the API-H code to fail parsing of the BPMN response. This doesn't kill the request, as you might expect, but rather, the API-H passes the BPMN response through to the client (VID, or policy, or whatever). The original problem (SO-586) was "fixed" by "removing the wrapper". This "wrapper" is a needed feature of the interface between BPMN and the API-H. We shouldn't have removed it. The fact that the "fix" appeared to work is due to the behavior I described in the previous paragraph. The API-H chokes on the message, and it passes it through unchanged. Not really what we want. So, I don't know why the jackson/json behavior is flaky and different now, but I can (and did) modify the API-H so it can parse a json message whether or not it has a root element. Note that WorkflowResponse.java (in BPMN) and CamundaResponse.java (in the API-H) are basically the same bean representing the message format. Seems less than ideal to have two different classes. Also note that I changed the name of the "response" attribute of the WorkflowResponse and CamundaResponse classes to "content". Got tired of seeing this nonsense everywhere in the code: response.getResponse() Change-Id: Icaf70f8457de99e493cf882170fe778c620308c9 Issue-ID: SO-586 Issue-ID: SO-618 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-05-08Add correlationId to ServiceInstancesRequestLukasz Muszkieta8-133/+307
Change-Id: Ia38fa1234f7b89c0574c74efe62d7b270c8ff987 Issue-ID: SO-596 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-03-27UT Coverage for API HandlerAbhishek Shekhar1-2/+25
Change-Id: I7bde5bf105ecda5404875edd8de953e3d1f9d1ff Issue-ID: SO-369 Signed-off-by: Abhishek Shekhar <abhishek.shekhar1@amdocs.com>
2018-03-22Add Pojo Validations CamundaBeansSmokowski, Steve (ss835w)5-4/+76
Change-Id: I17fdca41929f4ba237721d65dcf5e92a2becdfd7 Issue-ID: SO-524 Change-Id: I17fdca41929f4ba237721d65dcf5e92a2becdfd7 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-03-20Add UT for BpmnRequestTestsubhash kumar singh1-0/+178
Add UT for BpmnRequestTest class. Change-Id: Ic5d31beb84d427e79c0eab7f374f064ce6d5ff07 Issue-ID: SO-369 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-03-14AT&T 1712 and 1802 release codeRob Daugherty19-82/+104
This is code from AT&T's 1712 and 1802 releases. Change-Id: Ie1e85851e94bc66c4d9514a0226c221939531a04 Issue-ID: SO-425 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-03-09Revert Reduce log noise/warningsRob Daugherty5-147/+166
This reverts commit 327b17ab250b4c17cf3f91f5e4cd9bffd89f3d1e. It is seriously impeding our ability complete the promised merge of AT&T 1802 code. While I'm all for coding standards, if we are serious about using spaces instead of tabs, then I think we need to (1) agree with the community when this will happen, (2) do consistently in all files, and (3) enforce it. Change-Id: Ib9b996f6b6c7d81ac9ac95d58b0c7d8cc39675ff Issue-ID: SO-368 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-03-08Reduce log noise/warnings format to conventionsMarcus G K Williams5-166/+147
Reduce build log warnings by formatting tests to ONAP code conventions (removing tabs etc.) Issue-ID: SO-368 Change-Id: I48c6d359b83617aebeb79db4e30c1d72d31f7eec Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2018-03-07Remove unnecessary String constructor callMunir Ahmad2-5/+10
Change-Id: Ibb0dcc412ae6243ee370b8e272455269303130eb Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-02-28Add Properties Order for recipeParamsc001491071-1/+1
Add Properties Order for recipeParams Change-Id: Iae1d1609e9e543dc4b7ac6b9017ab9184deef6b9 Issue-ID: SO-449 Signed-off-by: c00149107 <chenchuanyu@huawei.com>
2018-02-27Add recipe params for bpmn callc001491076-10/+23
Add recipe params for bpmn call, to improve recipe enhancement. Change-Id: If9f2bff3f27ced62e814afcb918c863a527363e6 Issue-ID: SO-449 Signed-off-by: c00149107 <chenchuanyu@huawei.com>
2018-02-08Fix some Sonar Blocker issues in apihandler/commonShashank Kumar Shankar9-59/+38
Some sonar code fixes are done in this patch. https://sonar.onap.org/issues/search#issues=AV3BntKO5bp_wwmIVCLv https://sonar.onap.org/issues/search#issues=AV5mhwQk32hFUzlqebFJ https://sonar.onap.org/issues/search#issues=AV3BntKc5bp_wwmIVCMJ https://sonar.onap.org/issues/search#issues=AV3BntKi5bp_wwmIVCMK https://sonar.onap.org/issues/search#issues=AV3BntKu5bp_wwmIVCMQ https://sonar.onap.org/issues/search#issues=AV3BntK35bp_wwmIVCMX https://sonar.onap.org/issues/search#issues=AV5mhwRN32hFUzlqebFQ https://sonar.onap.org/issues/search#issues=AV3BntLG5bp_wwmIVCMc https://sonar.onap.org/issues/search#issues=AV3BntLR5bp_wwmIVCMh Change-Id: I3ba77adec1951fb7153ed640eb1ea0a4a3ed3e6b Issue-ID: SO-165 Signed-off-by: Shashank Kumar Shankar <shashank.kumar.shankar@intel.com>
2017-10-05Moved "" string literal on the left side.rama-huawei1-1/+1
Replaced with diamond symbol Removed useless assignment to variables Issue-Id: SO-187 Change-Id: If6fac39f2f8832fe6f7a00ed8f0a221e8d8fb897 Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
2017-09-30Commenting for empty constructorAnkit-Huawei3-12/+9
SO-158 Change-Id: I1e67fff2c96efc6e79dca8facfd6f0b230c70cd4 Signed-off-by: Ankit-Huawei <ankit.kumar.sinha1@huawei.com>
2017-09-28Merge "Fix some major sonar issues"Seshu Kumar M1-1/+1
2017-09-28Merge "Removed useless assignment to local variables"Seshu Kumar M1-2/+2
2017-09-28Removed useless assignment to local variablesrama-huawei1-2/+2
Issue-Id:SO-118 Change-Id: I29ec088aa52073f4e9df5503ede9f306c72e41d0 Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
2017-09-27Fix some major sonar issuessurya-huawei1-1/+1
*Use collection.isEmpty() instead of collection.size *Remove unnecessary commented line This is done for increasing code readability *Pass the string object directly Instead of wrapping the returned object and creating a new object, passing the object itself will save memory Issue-Id: SO-118 Change-Id: I24c15e9270ec3422d35d3910a8aff9fcf8d632d9 Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-26Removed useless assignment to variablesrama-huawei1-1/+1
Issue-Id:SO-118 Change-Id: I38f63be63f1ee3464ea16107d4b5c152dd4b1410 Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
2017-09-25Rename "status" which hides the class fieldrama-huawei2-12/+12
Issue-Id:SO-118 Change-Id: I7a367373f15f7cfa2d2cfb965b63397cabdcbf1f Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
2017-09-11Change the header to SOSeshu-Kumar-M27-27/+27
IssueId: SO-120 Change-Id: Ic7be2d1eba06cb1b3bb15b7ccec5856d1528e23b Signed-off-by: Seshu-Kumar-M <seshu.kumar.m@huawei.com>
2017-09-081710 Rebase - Second AttemptArthur Martella7-8/+159
This commit rebases changes from openecomp-mso/internal-staging-1710 up to and including this codecloud commit: 54483fc6606ddb1591a2e9da61bff8712325f924 Wed Sep 6 18:12:56 2017 -0400 Rebasing was done on a branch on top of this commit in so/master in ONAP: 93fbdfbe46104f8859d4754040f979cb7997c157 Thu Sep 7 16:42:59 2017 +0000 Change-Id: I4ad9abf40da32bf5bdca43e868b8fa2dbcd9dc59 Issue-id: SO-107 Signed-off-by: Arthur Martella <amartell@research.att.com>
2017-05-02[MSO-8] Second step of the rebase for MSODeterme, Sebastien (sd378r)1-36/+36
Second rebase containing additional features for MSO + total reworking of the BPMN structure + Notification flow can now be added at the end of some BPMN flows Change-Id: I7e937c7a0ba1593ca85e164a093f79c7e38b6ce0 Signed-off-by: Determe, Sebastien (sd378r) <sd378r@intl.att.com>
2017-04-11[MSO-8] Update the maven dependencyxg353y7-44/+31
Update the maven depenency for sdc-distribution-client to cooperate with the sdc changes. Change-Id: I2da936e5c40cb68c7181bb78307192dd5655b5dc Signed-off-by: xg353y <xg353y@intl.att.com>
2017-01-31Initial OpenECOMP MSO commitChrisC27-0/+2837
Change-Id: Ia6a7574859480717402cc2f22534d9973a78fa6d Signed-off-by: ChrisC <cc697w@intl.att.com>