aboutsummaryrefslogtreecommitdiffstats
path: root/common
AgeCommit message (Collapse)AuthorFilesLines
2019-11-22improve error log scoresPlummer, Brittany4-5/+5
Updated error code name to fix spelling Defaulted errorcode and errordesc to unknown when not provided Remove unused imports from nc orchestrator application Added defaulting of serviceName to error log Issue-ID: SO-2538 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I5ae960f728739e2528173b66484562742429416c
2019-11-19add junit coverageLukasz Muszkieta1-43/+75
Change-Id: I060660abd9b07e6262d08efde3eafcbf29fa762b Issue-ID: SO-1576 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-11-08removed global configuration of jar pluginBenjamin, Max1-0/+17
removed global configuration of jar plugin to prevent extra artifacts Issue-ID: SO-2518 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I5b25150089f39792452cf67cac1c916ef2069bed
2019-11-07remove unused columns infra active requestsChan, Mercy1-0/+1
Removed unused columns in db across codebase Issue-ID: SO-2516 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Ieedb61ed371bc3626ef94df0bf88b7a9cf139c82
2019-10-16Merge "update scheduled tasks to have mdc setup"Steve Smokowski4-3/+188
2019-10-14Merge "General sonar fixes"Lukasz Muszkieta1-2/+1
2019-10-14update scheduled tasks to have mdc setupPlummer, Brittany4-3/+188
Added MDCSetup for Scheduled Tasks Added tests for ScheduledTasksMDCSetup Added required fields for audit log and markers Issue-ID: SO-2444 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I05e8032ed934abd76d898559c51230761d36b78c
2019-10-09Merge "Converted tests to use LATEST"Steve Smokowski2-2/+2
2019-10-09Improved error handlingMichaelMorris4-9/+61
Change-Id: Iac436f6a950bf61ac6321ef1d427a7bb14774e30 Issue-ID: SO-2395 Signed-off-by: MichaelMorris <michael.morris@est.tech>
2019-10-07Converted tests to use LATESTGamboa, Gilbert2-2/+2
Always use LATEST for A&AI based tests rather than a particular version Issue-ID: SO-2398 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I7840b46f8d50b74a6e6b98270c4f3febc4d0b993
2019-10-03General sonar fixesArindam Mondal1-2/+1
Issue-ID: SO-2381 Change-Id: I58c41ec7295838465a8af28721842625ee828a17 Signed-off-by: arindamm <arind.mondal@samsung.com>
2019-09-25Merge "Added missing headers"Steve Smokowski2-2/+41
2019-09-24check for null before setting headersMnushkin, Dmitry2-1/+99
check for null before setting headers Issue-ID: SO-2356 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I51bd332b13f687df09bc80489cf93baebc84ceb8
2019-09-24Added missing headersPlummer, Brittany2-2/+41
Added missing headers to files Issue-ID: SO-2365 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Ib3f7808d997e324da4ae57f40d4f7ba946721538
2019-09-20Merge "Exception string in checkRelationshipRelatedTo"Steve Smokowski1-1/+1
2019-09-19Exception string in checkRelationshipRelatedToBhatt, Prema1-1/+1
Exception string in checkRelationshipRelatedTo not being returned properly. Added a new exception - UnassignNetworkException. Added a new unit test to test the exception case as per review comment. Updated UnassignNetworkBBTest.java file to fix the formatting errors. Updated unit test , removed setVariable, it wasn't needed to do as it was performed in the actual method call. Updated pom.xmp file to fix the formatting errors. Updated pom.xml file to fix the formatting errors. Issue-ID: SO-2346 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I617dfbcb07d6080598a3ef8138aad5c7008dcee2
2019-09-19update logging to match onap logging libraryPlummer, Brittany7-30/+32
Updated to use changes added to logging library in ONAP Updated RestClient to set mdc rather than extend filter Updated filter removal to include new spring filter Updated to exclude filter causing failure in catdb Excluded filter causing failures in requestdb Updated requestdbatt to exclude filter Updated check for spring filters to fix failing tests Issue-ID: SO-2353 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Idb081a0f5527690f9dc41c7914a2d721f9022aea
2019-09-11Merge "error message formatter now handles percent"Steve Smokowski2-1/+19
2019-09-10error message formatter now handles percentBenjamin, Max2-1/+19
error message formatter now handles percent encoding Issue-ID: SO-2303 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: If4784ab54023b1df43eb7ee266a2797c9a12731b
2019-09-10Integrate Logging LibraryPlummer, Brittany34-1078/+342
Updated SO to use ONAP provided filters and constants to meet logging standards. Removed redundant classes Updated constant references Issue-ID: SO-2301 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Ia4e3c2b1a4dcb3881aa34d39885c8b2782880d64
2019-09-08Created external task utils in a common locationBoslet, Cory5-1/+223
Created external task utils in a common location then refactored external task to use these common utils Updated junit errors and failures in openstack Removed env param and updated unit test with class Remove env file from parm in unit test class Match argu to match class abstract to con. removed implementation within anonymous class Issue-ID: SO-2291 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I47c2850d750cbfe7ef67e2396fcb46db43e3cb97
2019-09-04General sonar fix add loggerArindam Mondal1-0/+4
Issue-ID: SO-2226 Change-Id: I5a826a9ea75b3065987a274ab7962c4a5fc1d614 Signed-off-by: arind.mondal <arind.mondal@samsung.com>
2019-08-26Merge "path prefix now stripped off per system"Steve Smokowski2-1/+12
2019-08-26Merge "fixed dsl builder to correctly add output"Steve Smokowski2-1/+45
2019-08-20path prefix now stripped off per systemBenjamin, Max2-1/+12
path prefix now stripped off per system Issue-ID: SO-2243 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Ie74e7c68f927a49b612c433b4a664887058a1726
2019-08-19Close input streams via try-with-resourcesk.kazak1-4/+5
DefaultDmaapPropertiesImpl: close FileInputStream after loading ServicePluginFactory: close HttpClient if processing fails close application.properties InputStream after loading remove redundant catch block if behavior is the same add logging of exception in finally block BpmnInstaller: close csarFile if processing fails Change-Id: Ic6f942c401277c5150c5cc1297aba27ccd40694c Coverity-scan: CID-203903, CID-211476, CID-211615, CID-219308 Issue-ID: SO-2211 Signed-off-by: k.kazak <k.kazak@samsung.com>
2019-08-16fixed dsl builder to correctly add outputBenjamin, Max2-1/+45
fixed dsl builder to correctly add output look for lambda key rather than parent class null Issue-ID: SO-2233 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I251b9b8b4c391354b9759ee16a2462df43c188f9
2019-08-15Initial commit of validation framework to APIHSmokowski, Steven4-1/+102
Move ListenerRunner to common location Adjust request params name, update junit tests Update validations to work properly Properly escape period for the string split Issue-ID: SO-2232 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Ia468cf7062cccf30e28afeb7a5cddc37ceb2e002
2019-08-12Merge "query builder now handles more than just strings"Steve Smokowski3-6/+20
2019-08-09All extendable enums should be serializableBenjamin, Max (mb388a)1-1/+3
marking items as transient causes them to be lost Issue-ID: SO-2217 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: If66f9034b67f94c8122875ef915043525fb9bdb7
2019-08-09query builder now handles more than just stringsBenjamin, Max3-6/+20
query builder now handles more than just strings Issue-ID: SO-2215 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Ib138d96cf8578a0e3055120f9c3e036c690e7eae
2019-08-06updated delete payloads for bulk deletesBenjamin, Max8-20/+60
updated delete payloads for bulk deletes moved test-request.json to the correct location Issue-ID: SO-2203 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I8d9d4d0bbe45f32d4e07a1ba0128e627d3b27795
2019-08-01Handle no pservers case on lock checkElena Kuleshov2-4/+13
Check for null return value from pservers query Issue-ID: SO-2184 Signed-off-by: Kuleshov, Elena <evn@att.com> Change-Id: I34c71601e694241a6d3cfefa8227200e715e2ed3
2019-07-23Merge "Enhanced List Level flow with backward support"Seshu Kumar M1-0/+12
2019-07-05update bpmn to save extsystemerrorsourcePlummer, Brittany2-2/+31
Added ext error source to workflow exception Updated all lines that create this exception with source Added unit tests and updated existing ones Change-Id: Id9b3b1e6e24368224214a6370ea2d450ae667bfb Issue-ID: SO-2092 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-07-02Enhanced List Level flow with backward supportsarada prasad sahoo1-0/+12
Modified the e2e service instance flow to support both new list types groups along with backward compatibility to support old types alloted resources, network etc. Change-Id: Ie8fc8a4550a90b44736b6b9de058e2a2e187570c Issue-ID: SO-1393 Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
2019-07-01support new query param formatChan, Mercy3-1/+98
- added format query parameter (optional), implemented logic to populate requestStatus field based on whether or not format is present moved request status constants to its own class visible globally. - changed @requestParam to @QueryParam in GET endpoint (OrchestrationRequests class. updated unit tests to call method being tested directly rather than from another private function - moved setting requestStatus to a separate method, also updated unit tests to separate out each scenarion into its own method - added unit test for when format=detail, corrected existing unit tests to test result to be FAILED - updated Status.java to include extra request status values; moved Status class to common org.onap.so.constants package Change-Id: Ic593de5fdfdcbc3121f481c86d1e261406082260 Issue-ID: SO-2080 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-27Merge "Update failsafe dependency to 2.0.1"Steve Smokowski5-27/+44
2019-06-27Update failsafe dependency to 2.0.1Benjamin, Max5-27/+44
Updated calls to failsafe 2.0.1 API Change-Id: I2c86ca02d56a07262e330ee5f8f088d1a1f5b4a7 Issue-ID: SO-2057 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-27add rollback ext system error sourcePlummer, Brittany1-1/+12
Added rollbackExtSystemErrorSource column and updated GET orchestrationRequests response Added missing columns from requestDb to schema.sql Change-Id: I2380f08b9bb1c86922e8faea70454df722c0873a Issue-ID: SO-2054 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-20Merge "update apih to accept new uri parameter"Steve Smokowski1-1/+12
2019-06-19changed hikari dependency to java based oneBenjamin, Max (mb388a)1-5/+15
clojure dependency used by accident, replaced with HikariCP Change-Id: I25b9f75d8be061fb3ac3d7737e9a58883a801425 Issue-ID: SO-2038 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-18update apih to accept new uri parameterChan, Mercy1-1/+12
added extSystemErrorSource queryparam flag to getOrchestrationRequest endpoint. added junit tests for the protected method that maps external system error source to request object being returned. added junit tests to test mapExtSystemErrorSourceToRequest method with extSystemErrorSource flag Change-Id: If5c9a41938d4cc922c26f7d64e3a839b6547556f Issue-ID: SO-2035 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-17Changes related to eviction of connectionsBenjamin, Max (mb388a)4-0/+121
These are changes related to ASDC controller for evicting database connection pool when ip address changes Included other appllications such as requestDB, CatalogDB, API Handler, BPMN, OpenstackAdapter etc Change-Id: I9a96ea12fb0c10643a204a58d55360bebba326fe Issue-ID: SO-2018 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-15Merge "Validate names before writing to A&AI"Max Benjamin1-0/+2
2019-06-15Merge "update multi stage code to accurately skip bbs"Max Benjamin7-0/+140
2019-06-15Merge "dmaap client using wrong auth property"Max Benjamin1-5/+5
2019-06-14Validate names before writing to A&AISangalang, Felix1-0/+2
Validate name for InstanceGroup, Configuration and Network. Change-Id: I494749e17a40c6c0cdd51dd28d9c9bca371410ac Issue-ID: SO-2022 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-14update multi stage code to accurately skip bbsBenjamin, Max7-0/+140
moved around classes to packages that make more sense updated license headers in java files converted MultiStage logic to FlowManipulator moved tests to new package location and fixed issues allow for custom listeners before flowsToExecute moved validation classes to listener.validation Change-Id: Ic5416812ef9c5611fe19bf9b6aa316373b110ec6 Issue-ID: SO-2021 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-14dmaap client using wrong auth propertyBoslet, Cory1-5/+5
Changed dmaap client to set auth property correctly to prevent double decryting and wrong value Change-Id: I83dc8c67e94a8bec187c056e7dfa1f966cc5ee3c Issue-ID: SO-2019 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>