summaryrefslogtreecommitdiffstats
path: root/common
AgeCommit message (Collapse)AuthorFilesLines
2018-11-28Fix HttpClient change which broke multicloudEric Multanen1-2/+0
The lines added to HttpClient in https://gerrit.onap.org/r/#/c/72771/ broke the usage of HttpClient by the multicloud adapter. The 'content-type' line seems redundant - content type is specified in the HttpClient constructor. The 'Authorization' line (which broke multicloud usage) seems inappropriate here. The Authorization string shouldn't be hard coded into a generic client. There are other methods available for adding the authentication header. Change-Id: I19ac1a382778fe50bc7e98e1e9b9a4d84897b2a6 Issue-ID: SO-1257 Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
2018-11-15Merge "Update Library Version" into casablancaRob Daugherty1-1/+0
2018-11-15Update Library VersionSmokowski, Steve (ss835w)1-1/+0
Update javax.servlet Issue-ID: SO-1171 Change-Id: I063cefdb3ad405045b3d6f1ea301da83a1cc2361 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-11-15Fix auth for catalog dbsubhash kumar singh1-1/+2
Fix auth for catalog db. Change-Id: Ic787993f608b7ddf74167f7859a519ca02b794ed Issue-ID: SO-689 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-11-14Get Csar file bug fixYulian Han1-0/+4
modify getting openecomp.db.endpoint config codes Delete bug fix for R3 config changes Change-Id: Idaa55084f5ecb0dd3636c232cebc14fa5f064408 Issue-ID: SO-1194 Signed-off-by: Yulian Han <elaine.hanyulian@huawei.com>
2018-11-08Updated pom.xml appc library version to 1.4.0Prema Bhatt1-2/+2
Issue-ID: SO-1199 Change-Id: I5c1f8d6e434ce12e370435bcae4f22485c5d249e Signed-off-by: Prema Bhatt <pb6115@att.com>
2018-11-05Bug fixes November 5thBenjamin, Max (mb388a)1-3/+23
building block validator test now passes added buildingblockvalidator process instance test Retrieve actual error from WorkflowExceptionErrorMessage when the error message is empty, not only when null. Propagate orchestrationStatusValidationResult values from BB to BB. corrected use of constructor for AaiUtil use AaiUtil method to create path for get call modified how allotted resource urls are constructed - Removed the findExistingVnfcInstanceGroup method. It is not required to check this because the vnfResourceCustomization is always a new object at this location. Enable multiStage VF Module Create processing only when aLaCarte flag is on. Change-Id: If8cf397a84abc290e67e287d5b2264dd226398bc Issue-ID: SO-1188 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-10-26Bug fixes October 26thBenjamin, Max (mb388a)9-9/+71
Set non-custom health diagnostic check code to a default value. created custom java serialization for SimpleUri changed property value for cloud-owner in unit test converted aai call to use the AAI Client Correct a JUnit data file to include userParams values that are expected to be set. Set userParams on requestContext to parameters that need to be passed to downstream systems. Change-Id: I3974691875ef967f90a15f076ae27bc0cd76ee8e Issue-ID: SO-1169 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-10-23removed att-aic from codebaseBenjamin, Max (mb388a)3-12/+12
remove att-aic cloud owner from ONAP files Change-Id: Ifba8ef6f53194ddca12d11973817f6d85e2fa7e3 Issue-ID: SO-1161 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-10-23default cloud owner now configurableBenjamin, Max (mb388a)8-8/+244
default cloud owner can now be set via a property Change-Id: I9b900cb2a5c7176a78e889ad2ce31a4ed9d38585 Issue-ID: SO-1158 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-10-19bug fixes october 19thBenjamin, Max (mb388a)1-1/+1
Fixed issue with resource version being added twice. added silent success to orch validation when unassign is not found Removed SNAPSHOT from dependency Fixed failing BBInputSetup tests Updated apih tests to use networkInstanceGroup Updated ModelType enum and fixed compilation issues Change the place where the data for multistage gets set Update treatment of PENDING_ACTIVATION VF_MODULE CREATE entries to SILENT_SUCCESS to support first stage of multistage. Implement second stage of multistage design VF Module Creation Implementation of the first stage of multistage design for VF Module creation. Change-Id: I6d76282d1f37c081355cee72797d8e13da4e3cb0 Issue-ID: SO-1149 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com> Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-10-19logging-slf4j:1.2.2-SNAPSHOT does not existRob Daugherty1-7/+1
Change the dependency to the 1.2.2 release version. Remove the exclusion for EELF, because 1.2.2 doesn't use it. Change-Id: I0ccca79df59282d5d9d71eec4b3faa845d31814f Issue-ID: SO-1152 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-10-19Merge "remove unused code"Seshu Kumar M7-139/+18
2018-10-17remove unused codeLukasz Muszkieta7-139/+18
UUID parameter in AAIRestClientI interface is redundant - part 1 Issue-ID: SO-729 Change-Id: I7db331098911e6e183d921175f3109f62b7aedbd Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-10-17Bug fixes October 16Benjamin, Max (mb388a)2-5/+23
Treat the VfModule returned from PrepareUpdateAAIVfModule call as an AAI object collection create, connect instanceGroup to cloudRegion Fix a typo in the name of the method for getting a variable testing mapping of instance group role test NetworkInstanceGroup role to be SUB-INTERFACE use enum value with hyphen for subtype Some updates based on feedback to java codes updated client to use optional instead of passing null added case where client sends null due to mapping issue added generic response object and pinc returns response build relationship now correctly removes wrapper Ensure that no null object gets referenced while checking if VNF is empty. Change-Id: I6177877518475c1f2e8e4e9dbd2ad1e2f3e10d18 Issue-ID: SO-1144 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-10-17Merge "correlationId is now read from userParams"Rob Daugherty1-1/+1
2018-10-17Merge "Bug fixes for casablanca"Rob Daugherty3-6/+32
2018-10-16Bug fixes for casablancaBenjamin, Max (mb388a)3-6/+32
Updated builder to use String.format Added exception specifically for issues interacting with requestdbadapter Updated exception message and added junit test case Added case to handle when homing is not called during assign vnf. include network ID for completion handler Added exception handling for saving to requestdb added null check to mdc and interceptors to sdnc cxf confirm subnet map is not null in adapter response shallow copy subnet before AAI udpate update AAIObjectType to use uriTemplate extract subnet data from adapter response update correct AAIObjectType for subnet query update subnet(s) in AAI on network create completion updated how request db is set to failure in workflowA updated in and out mapping to be generalBuildingBlock change source out mapping to generalBuildingBlock Use explicit conversion to JSON to read cloudConfiguration settings. Use explicit conversion to JSON to read cloudConfiguration settings. Correct the name of DeleteVfModuleBB subprocess. Write the returned value from Homing to gBBInput updated unit test coverage for update network sync subnet status with network update Added WorkflowException to out mapping which will trigger an exception to be thrown when populated. Correct the payload for HealthCheck APP-C Action to remove escaping and change parameter name. Added WorkflowException to out mapping which will trigger an exception to be thrown when populated. Commit a change that was not staged in previous commit updated arguments to getConstructor method forgot to extract throwable from Optional object added throwable constructor to createException fixed broken unit test and added a new test and method set the network technology in the network request remove namespace from added networkId payload element - Updated SDWan test case to check the database to make sure the VNFCustomization object exist. - Updated code to only loop in iNotif.getResources() for VF resources, all others are unnecessary and were causing issues with the Service object. - Removed modifiedHeatTemplate variable since this isn't needed in the ONAP code base. Make sure vnfResponseCode variable is set to 200 when VNF is correctly retrieved from A&AI. VRR VRRCreateVfModule - send availability_zone to SDNC Infra Assign request Safeguard the retrieval of Boolean setting for isRollbackEnabled. Set isRollbackEnabled to opposite of suppressRollback early on in the execution. Reverse suppressRollback value to pass as backout parameter to VNF Adapter Add the exceptions to the calls to aai client queries Correct retrieval of the object from Optional for A&AI queries. Change-Id: I7d22e621b0316c14ce61bd51a9d5753473622697 Issue-ID: SO-1134 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-10-15correlationId is now read from userParamsbiniek1-1/+1
Change-Id: I92c6caad1370fde7daf067addbf39e45469e08aa Issue-ID: SO-1116 Signed-off-by: biniek <lukasz.biniek@nokia.com>
2018-10-12Updated aai dependency to 1.3.1Benjamin, Max (mb388a)1-1/+1
Change-Id: I1e9f9e972b65607304f7076e0a63879159b8ae94 Issue-ID: SO-1133 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-10-12Dynamic Cloud Owner SupportBenjamin, Max (mb388a)6-19/+84
added in cloud configuration object to request params Fix Bean scanning so it picks up the resttemplate removed unnecessary RestTemplate Bean configurations corrected typo in CloudConfiguration class updated gr api test cases with dynamic cloud owner updated groovy files to allow for dynamic cloud owner values updated GR API layer to include cloud owner added enum for default cloud owner add cloud owner variable to camunda in mapping removed references to att-aic from BBInputSetup updated aai schema dependency to 1.3.1 from 1.3.0 Fixed incorrect type AAIUri and updated logging in the method. use existing service instance id instead of generating Pass cloudOwner to process to propagate to subprocesses. NOTE: our aai-schema dependency is 1.3.1-SNAPSHOT to be compatible with the cloud owner changes here. The releaesed 1.3.0 version is NOT compatible. Change-Id: I43b46774b77981d1c8bfe7c7a79b9434889e62ae Issue-ID: SO-1128 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com> Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-10-11aai-schema:1.3.0-SNAPSHOT is goneRob Daugherty1-1/+1
We must now use the newly released 1.3.0 version Change-Id: I5b7f0f8847031b776ab49b453f237f009e71804b Issue-ID: SO-1129 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-09-27Fix calls to multicloud adapterEric Multanen1-1/+2
Fix up the json body of the POST call to multicloud. Improve checkout of responses from multicloud calls. Change-Id: I1fb47460b54e9e5b478815d3b531d5bdbe1fe3dc Issue-ID: SO-1082 Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
2018-09-20Update LoggingSmokowski, Steve (ss835w)9-45/+217
Update logging to meet Casablanca Spec Change-Id: I029d6c63765992d6f091d96e2b4c34c60d30c484 Issue-ID: SO-947 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-09-19Workflow Designer Activities ImplementationElena Kuleshov1-10/+11
Logging changes and error message fixes for runAppcCommand() added unit test and removed catch blocks Workflow Designer Activities Implementation Change-Id: I22d3d95541708ddc9e2617a92085b0d4c16caad9 Issue-ID: SO-829 Signed-off-by: Elena Kuleshov <EK1439@att.com>
2018-09-17more stability fixesBenjamin, Max (mb388a)1-1/+2
Remove conditional to not check VNF topology add empty string verification for serviceName field Add junits for CNRCR and NtwkAdptr changes. Add search in new CollNtwkResCust tbl to get NtwkResource. - Updated test data files to include 'pre-load' flag in both VfModuleOperation and NetworkOperation json test data files. - MSO to not to send <preload>boolean</from-preload> to SDNC in network-topology-opertion and vf-module-topology-operation. Updated GeneralTopologyObjectMapper to set 'from-preload' to null so that elements with Nulls are not sent to SDNC. Updated buildNetworkInformation() and buildVfModuleInformation() methods. update flow stats to not cause bpmn flow to crash Fix headers so SDNC does not return XML Add implementation of deleteVolumeGroupResponse parsing; fix JUnits that worked by accident. Change-Id: Ia96d552d731e112505fcf739029a6fd4d0134546 Issue-ID: SO-1061 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-09-17add single transaction api to aaiclientBenjamin, Max (mb388a)21-104/+1110
fixed marshalling when issuing a patch request added support for single transaction api in A&AI Change-Id: Icf755f547523cc7dbf931e198177847a5a1c6ea1 Issue-ID: SO-1060 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-09-13Stability fixesBenjamin, Max (mb388a)1-0/+20
sdnc now logs the full response message as a json removed erroneous encoding of variables with full XML Return created network from getVirtualLinkL3Network added exception logger to workflowaction aai check Check for null value for vnfcPorts before referencing it Added test case for invalid camunda response Changed to use updateStatus method Added saving for currentActiveReq and test for 401 resp Change JUnit to use expectedException and clean up unused items. Add vfModuleId to the exception message for missing model info. Report an error if VF Module model info is expected but is null. - Just renamed the Cvnfc and Vnfc set names - Updated code to check for duplicate VNFC's across multiple modules in the same VNF. - Removed commented out if statement line for ALLOTTED_RESOURCE - Reinitialize the Cvnfc and Vnfc Sets each time we iterate the VFModule loop. This will avoid the concurrent modification exception. Eliminated Ben from the sample request Changed to use else if for null check Added null check before catdb call and test case Fix implementation of a call to VNF Adapter for DeleteVolumeGroupBB. Update the method to no call save and do a put Revert usage of PUT method, use save instead Change-Id: I9f69fb68d0639c23b8e1de6931938119bd3ac54b Issue-ID: SO-1032 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-09-12Fix threading problems in requestdbclientBenjamin, Max (mb388a)1-0/+15
Disable Flakey tests, that do not run well Resolve bean conflict, move to common project Fix port in properties file for replacement Fix threading problems in requestdbclient Change-Id: I12d145863152d302da4fa0854db1c85286266e02 Issue-ID: SO-1034 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-09-11NexusIQ issue: jackson-databindRob Daugherty1-15/+0
Upgrade to fasterxml.jackson 2.8.10. This is the latest version that seems to work with our code on springboot 1.5.13.RELEASE. Change-Id: I734f84c18e53218f111fb08c959a67ee0a2e6014 Issue-ID: SO-856 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-09-10add ability to start from parent uriBenjamin, Max (mb388a)7-5/+134
AAIResourceUris can now be created from parent uris fixed unit test after change to task impl removed last use of nodes query in code Change-Id: I797cb12674e3421972e35957bd4d431c3cf3285b Issue-ID: SO-1000 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-09-08added object constructorBenjamin, Max (mb388a)2-2/+23
added Object constructor to AAIResultWrapper Change-Id: Ic1bae387a13b7b7864c2687a63532347d8f102e7 Issue-ID: SO-998 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-09-08stability fixesBenjamin, Max (mb388a)1-3/+3
fixed bean error fixed execution variable name do not explicitly set hibernate objects Removed remaing references to tunnel-xconnect fixed virtual link case Change-Id: Ia5a59794e84beadcbf259efb899878cc4465ca57 Issue-ID: SO-997 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-09-08added generic fabric support to SOBenjamin, Max (mb388a)27-63/+1094
Fix Autoincrement of ID field in table Fix accidental removal of method Update usage of requestdb client removed unused imports in common tasks and test Fix broken branch, have unit tests pass references the Epic branch Fix broken branch from compiling committing classpath for vfc adapter cause its not going away added in the fail case for when there are no profiles removed second set of adapters in application test yml removed double adapters in request db application test added jpa repo dependency to the so bpmn folder pom add creation timestamp column to the table added in null checks for Config returned from policy switched to string in requestprocess with jenerate switched to string in requestprocess with jenerate updated aai version in common pom to 605 from 591 renamed the db scripts for flyway sync to register added endpoint to application test yml for failing test ... Change-Id: I800f837ea75d7cdff740dc3a387e4d7654cfd085 Issue-ID: SO-972 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-09-05Client LoggingSmokowski, Steve (ss835w)17-961/+222
Update Client Logging to use interceptor Move CXF to own project due to dependency hell Issue-ID: SO-947 Change-Id: I2597ff6d32231b8625b04ef63ab5e8f589e2545c Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-09-04updated aai version enumBenjamin, Max (mb388a)1-1/+2
version enum updated to 1810 A&AI version Change-Id: I42fe7cd4364df7ac6d74e936615ea748e028413d Issue-ID: SO-971 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-09-04fixing Sonar reported log issueGOPINATH MATHIVANAN1-1/+5
Fixed Sonar reported vulnerability in LoggerStartupListener Issue-ID: SO-962 Change-Id: Icc82d8de94c8ea3c4cd27133e833e2d499e8670d Signed-off-by: GOPINATH MATHIVANAN <gopinath.mathivanan@in.ibm.com>
2018-09-01Logging ImprovementSmokowski, Steve (ss835w)3-0/+142
Add Spring interceptor to log all the SpringDataRest calls Issue-ID: SO-947 Change-Id: Ia1a574cedd90e79bb2fd30a094831dc5cd269ff0 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-08-31Update LoggingSmokowski, Steve (ss835w)10-112/+363
Add CXF interceptor for SOAP based logging Clean up extra logging statements Add UT to ensure MDC properly populated Change package name on Jax-RS Filter to be more accurate Issue-ID: SO-947 Change-Id: I3a2afc58de3bf370675658ce3d19cf899b90def7 Change-Id: I3a2afc58de3bf370675658ce3d19cf899b90def7 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-08-28Use managed guava versionGary Wu1-4/+4
Use centrally managed guava version specified in oparent. Includes upgrade to oparent 1.2.0. This change was submitted by script and may include additional whitespace or formatting changes. Change-Id: I4da3f582e347da62f9d6fe8d6f20c147d493b8a0 Issue-ID: INT-619 Signed-off-by: Gary Wu <gary.i.wu@huawei.com>
2018-08-28added unit test for decoded keysBenjamin, Max (mb388a)1-0/+8
unit test to demonstrate that uri values are decoded Change-Id: Idd90e02f9c794b7ebf6755a4dbd834fb29be40ad Issue-ID: SO-922 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-08-24Merge "Do not log stack trace when http not found occurs"Marcus Williams2-1/+5
2018-08-24Merge "Created Ref Data tbl for controllerSelection"Marcus Williams1-0/+1
2018-08-24Do not log stack trace when http not found occursBenjamin, Max (mb388a)2-1/+5
do not log stack trace when http not found occurs Change-Id: Ia0638eba7f8d9544dae21290c836c7be1e05ac2e Issue-ID: SO-902 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-08-24aairesultwrapper is now actually serializableBenjamin, Max (mb388a)2-12/+31
added in a proper serialization and deserialization test addressed any comments from pull added in a serialization test for AAIResultWrapper and updated one of the null returns change jsonBody in AAIResultWrapper back to String Change-Id: Iffa5661f129cc26d69dfaa966cd265c67903cf21 Issue-ID: SO-899 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-08-23Created Ref Data tbl for controllerSelectionPrema Bhatt1-0/+1
RD: I rebased this and fixed the unit tests. Issue-ID: SO-763 Change-Id: Ie5f6a708cffbc70a9481afd35db3047fe44cb088 Signed-off-by: Prema Bhatt <pb6115@att.com> Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-08-23Merge "removed classes no longer in use"Rob Daugherty2-194/+0
2018-08-23Merge "created generic HttpLookupUri class"Rob Daugherty5-84/+193
2018-08-23removed classes no longer in useBenjamin, Max (mb388a)2-194/+0
Change create configuration to use yang service instance and removed AAIServiceInstance pojo. Change-Id: I2420503f1a00c2dc64b6021aad8e42aa2080eb98 Issue-ID: SO-895 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-08-22removed problematic swagger dependencyBenjamin, Max (mb388a)1-5/+0
removed swagger dependency which was causing issues Change-Id: I1e840f7ea9a45547c2562ce628c38f7c7e065e65 Issue-ID: SO-880 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>