summaryrefslogtreecommitdiffstats
path: root/common
AgeCommit message (Collapse)AuthorFilesLines
2018-09-04fixing Sonar reported log issueGOPINATH MATHIVANAN1-1/+5
Fixed Sonar reported vulnerability in LoggerStartupListener Issue-ID: SO-962 Change-Id: Icc82d8de94c8ea3c4cd27133e833e2d499e8670d Signed-off-by: GOPINATH MATHIVANAN <gopinath.mathivanan@in.ibm.com>
2018-09-01Logging ImprovementSmokowski, Steve (ss835w)3-0/+142
Add Spring interceptor to log all the SpringDataRest calls Issue-ID: SO-947 Change-Id: Ia1a574cedd90e79bb2fd30a094831dc5cd269ff0 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-08-31Update LoggingSmokowski, Steve (ss835w)10-112/+363
Add CXF interceptor for SOAP based logging Clean up extra logging statements Add UT to ensure MDC properly populated Change package name on Jax-RS Filter to be more accurate Issue-ID: SO-947 Change-Id: I3a2afc58de3bf370675658ce3d19cf899b90def7 Change-Id: I3a2afc58de3bf370675658ce3d19cf899b90def7 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-08-28Use managed guava versionGary Wu1-4/+4
Use centrally managed guava version specified in oparent. Includes upgrade to oparent 1.2.0. This change was submitted by script and may include additional whitespace or formatting changes. Change-Id: I4da3f582e347da62f9d6fe8d6f20c147d493b8a0 Issue-ID: INT-619 Signed-off-by: Gary Wu <gary.i.wu@huawei.com>
2018-08-28added unit test for decoded keysBenjamin, Max (mb388a)1-0/+8
unit test to demonstrate that uri values are decoded Change-Id: Idd90e02f9c794b7ebf6755a4dbd834fb29be40ad Issue-ID: SO-922 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-08-24Merge "Do not log stack trace when http not found occurs"Marcus Williams2-1/+5
2018-08-24Merge "Created Ref Data tbl for controllerSelection"Marcus Williams1-0/+1
2018-08-24Do not log stack trace when http not found occursBenjamin, Max (mb388a)2-1/+5
do not log stack trace when http not found occurs Change-Id: Ia0638eba7f8d9544dae21290c836c7be1e05ac2e Issue-ID: SO-902 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-08-24aairesultwrapper is now actually serializableBenjamin, Max (mb388a)2-12/+31
added in a proper serialization and deserialization test addressed any comments from pull added in a serialization test for AAIResultWrapper and updated one of the null returns change jsonBody in AAIResultWrapper back to String Change-Id: Iffa5661f129cc26d69dfaa966cd265c67903cf21 Issue-ID: SO-899 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-08-23Created Ref Data tbl for controllerSelectionPrema Bhatt1-0/+1
RD: I rebased this and fixed the unit tests. Issue-ID: SO-763 Change-Id: Ie5f6a708cffbc70a9481afd35db3047fe44cb088 Signed-off-by: Prema Bhatt <pb6115@att.com> Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-08-23Merge "removed classes no longer in use"Rob Daugherty2-194/+0
2018-08-23Merge "created generic HttpLookupUri class"Rob Daugherty5-84/+193
2018-08-23removed classes no longer in useBenjamin, Max (mb388a)2-194/+0
Change create configuration to use yang service instance and removed AAIServiceInstance pojo. Change-Id: I2420503f1a00c2dc64b6021aad8e42aa2080eb98 Issue-ID: SO-895 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-08-22removed problematic swagger dependencyBenjamin, Max (mb388a)1-5/+0
removed swagger dependency which was causing issues Change-Id: I1e840f7ea9a45547c2562ce628c38f7c7e065e65 Issue-ID: SO-880 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-08-21created generic HttpLookupUri classBenjamin, Max (mb388a)5-84/+193
created generic HttpLookupUri abstract class Change-Id: Ie45d620af77fb58c0a7b469aba4a10f274b0de59 Issue-ID: SO-877 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-08-14Added vfModule scale out endpoint and validationBrittany Plummer (bp896r)1-7/+15
Issue-ID: SO-764 Change-Id: I6fc983ed6bc9d9c410406db1f2355c27e201b4f4 Signed-off-by: Brittany Plummer (bp896r) <bp896r@att.com>
2018-08-13Merge "Update CatalogDB Logging"Marcus Williams3-132/+165
2018-08-13Update CatalogDB LoggingSmokowski, Steve (ss835w)3-132/+165
Update CatalogDB Logging to remove MSO Logger, remove useless log lines, clean up minor sonar issues while working in the file Issue-ID: SO-847 Change-Id: Icab5d8cf2885d2193bb55f495b3230dde0f5af54 Change-Id: I2d2b2fa919074c439b6c9039aa7ed5e45a792781 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-08-13Sonar issue MajorArindam Mondal1-11/+3
Issue-ID: SO-852 Change-Id: Ia0d58c52884abdd1f752dc6671d315b8516812e6 Signed-off-by: Arindam Mondal <arind.mondal@samsung.com>
2018-08-11Merge "added edge label support to A&AI client"Seshu Kumar M3-0/+55
2018-08-10Handle special aai case betterBenjamin, Max (mb388a)7-49/+219
corrected error handling in aai client for service instances updated the exception logic for si's that are not found adhere to mapNotFoundToEmpty in special case Issue-ID: SO-851 Change-Id: I3843733553143dae046c1ae944a3bfd71ac5170c Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-08-10added edge label support to A&AI clientBenjamin, Max (mb388a)3-0/+55
you can now specify an edge label when connecting two objects Issue-ID: SO-849 Change-Id: I851d523c271823911cdc344ac8c28beec993cb09 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-08-10Downgrade CXFSmokowski, Steve (ss835w)1-1/+1
The Upgrade of CXF broke the A&AI client, downgrading it for now to unblock integration testing. We will investigate in more detail around the upgrade of the version. Issue-ID: SO-823 Change-Id: I15d761737b8c62db6de74ce5e5ee9262016120e0 Change-Id: I15d761737b8c62db6de74ce5e5ee9262016120e0 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-08-07Clean up pomSmokowski, Steve (ss835w)1-13/+2
Remove logging jars that are not used Issue-ID: SO-809 Change-Id: I5af45b00811fde53243273d90dbf88c8215de7ed Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-08-06Add page support to A&AI ClientBenjamin, Max (mb388a)6-4/+53
Issue-ID: SO-805 Change-Id: Id95c29db4594db494c647937636c09b0837335be Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-08-02Resolve Sonar Blocking issuesSmokowski, Steve (ss835w)2-21/+0
Issue-ID: SO-788 Change-Id: I4496ef16c56c980a81031ad01fcbb1524d135ea8 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-07-31Containerization feature of SOBenjamin, Max (mb388a)309-6135/+7348
Change-Id: I95381232eeefcd247a66a5cec370a8ce1c288e18 Issue-ID: SO-670 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-07-24Fix use try-with-resources sonar issuesParshad Patel2-5/+3
Replace try with try-with-resources statement Issue-ID: SO-703 Change-Id: I971b61af2070a6856c751ed36050dd018216fe03 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2018-06-29Fix build issue due to missing appc client libsMichal Kabaj1-2/+2
Changed versions from 1.3.0-SNAPSHOT to 1.3.0 for appc maven artifacts: client-lib client-kit Change-Id: Ie4d98b400c7557655c74c3225b089c2ccc54b0cb Issue-ID: SO-682 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-05-15WorkflowResponse json issuesRob Daugherty3-0/+200
This commit adds some robustness to the interface between the API-H and BPMN, specifically, in how the response is handled. I don't have proof, but there appears to be some randomness to the json provider behavior when used with the jax-rs. Sometimes, the serializer is adding the root element, and sometimes it is not. Maybe there's something wrong with the configuration. Maybe we have competing json providers. I couldn't pin this down. I'm almost certain it is the presence of the root element in the content that causes the API-H code to fail parsing of the BPMN response. This doesn't kill the request, as you might expect, but rather, the API-H passes the BPMN response through to the client (VID, or policy, or whatever). The original problem (SO-586) was "fixed" by "removing the wrapper". This "wrapper" is a needed feature of the interface between BPMN and the API-H. We shouldn't have removed it. The fact that the "fix" appeared to work is due to the behavior I described in the previous paragraph. The API-H chokes on the message, and it passes it through unchanged. Not really what we want. So, I don't know why the jackson/json behavior is flaky and different now, but I can (and did) modify the API-H so it can parse a json message whether or not it has a root element. Note that WorkflowResponse.java (in BPMN) and CamundaResponse.java (in the API-H) are basically the same bean representing the message format. Seems less than ideal to have two different classes. Also note that I changed the name of the "response" attribute of the WorkflowResponse and CamundaResponse classes to "content". Got tired of seeing this nonsense everywhere in the code: response.getResponse() Change-Id: Icaf70f8457de99e493cf882170fe778c620308c9 Issue-ID: SO-586 Issue-ID: SO-618 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-05-04Fix for FileNotFoundException in MsoLoggerTestMichal Kabaj1-1/+1
Remove over 100 whitespaces from logger filename which causes the unit tests to fail in some development environments. Change-Id: I068f4d4562b635b19889c3537282949665348c21 Issue-ID: SO-604 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-05-04Add enforcer.skip to pom.xmlArthur Martella1-2/+2
To prevent appc snapshot problem Also change appc version to SNAPSHOT Change-Id: Ifce05b7f44ccc70a2d654526d67da873dd325dcd Issue-ID: SO-605 Signed-off-by: Arthur Martella <am153x@att.com>
2018-04-27Add correlationId to ServiceInstancesRequestLukasz Muszkieta1-8/+21
Change-Id: Idc5ee56660da31f08fd8ed3a67b7cd28f9844f43 Issue-ID: SO-596 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-04-23Sonar-Critical Bug FixingAS004650592-1/+4
File:RestfulUtil.java Line:L85 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:E2EServiceInstances.java Line:L263 L1059 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:OrchestrationRequests.java Line:L343 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:ASDCConfiguration.java Line:L286 L378 SonarLink: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:ResourceInput.java Line:L287 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:ResourceRecipeRequest.java Line:L136 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:ResourceRequestBuilder.java Line:L108 L214 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:CheckAaiForCorrelationIdDelegate.java Line:L70 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:AbstractSdncOperationTask.java Line:L359 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:DmaapClient.java Line:L62 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:HasAnnotationPropertyWithValueMatcher.java Line:L60 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL Change-Id: Ic168a118790c31850a9f32f98465be5d52b8c96f Issue-ID: SO-581 Signed-off-by: AS00465059 <AS00465059@techmahindra.com>
2018-04-20Merge "Exception in AAIRestClientImpl.java"Seshu Kumar M1-2/+2
2018-04-19Exception in AAIRestClientImpl.javasanchitap1-2/+2
AAIRestClientImpl.java Sonar link: https://sonar.onap.org/code?id=org.onap.so%3Aso&selected=org.onap.so%3Acommon%3Asrc%2Fmain%2Fjava%2Forg%2Fopenecomp%2Fmso%2Fclient%2Faai%2FAAIRestClientImpl.java Change-Id: I9bdcd2e389cad15119f322a3ac7f7bcc1bd2cc67 Issue-ID: SO-575 Signed-off-by: sanchitap <sanchita@techmahindra.com>
2018-04-18AAIRestClient support for Basic AuthRob Daugherty6-5/+60
Adding support for Basic Auth in the AAI Rest Clients because ONAP uses this (whereas ECOMP uses 2-way SSL). In general, each AAI client will allow the user to configure properties called "aai.auth" and "mso.msoKey". If these are set, then the client will add the Authorization header to every request. Change-Id: I7c81ec05d2ec4a7dca131f2e9e19d341ac89b09f Issue-ID: SO-576 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-04-16PnfReadyEventConsumer implementationLukasz Muszkieta1-0/+10
Change-Id: I7252400a3f60ca22ddfa71edb28eaf1d16ccd9b4 Issue-ID: SO-466 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-04-10Merge "PnfReadyEventConsumer implementation"Seshu Kumar M2-178/+0
2018-04-06PnfReadyEventConsumer implementationLukasz Muszkieta2-178/+0
Change-Id: Ia4d9fedb023ef6893e887ff6b5802623649aeeba Issue-ID: SO-466 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-04-06Add junit test for UUIDChecker java Felix Sangalang1-0/+44
junit coverage for UUIDChecker Issue-ID: SO-558 Change-Id: I6203b970e9960ea8fba3a1c052cb24b0340b4284 Change-Id: I6203b970e9960ea8fba3a1c052cb24b0340b4284 Signed-off-by: Felix Sangalang <fs7692@us.att.com>
2018-04-03Added controllerType to requestParametersBrittany Plummer (bp896r)1-6/+14
Change-Id: Ib99642783e9d88558ff0875a246a9a1a628d3817 Issue-ID: SO-553 Signed-off-by: Brittany Plummer (bp896r) <bp896r@att.com>
2018-03-28Merge "Added junit for policy client impl"Rob Daugherty3-76/+121
2018-03-28Merge "Added subworkflow for Pnf pnp"Rob Daugherty3-125/+171
2018-03-28Merge "pnf ready event consumer"Rob Daugherty5-51/+202
2018-03-28improved coverage for catalog db beansBenjamin, Max (mb388a)1-0/+23
Change-Id: Ibf1fd21dc81f0a3e16447b05dfce1761efa69237 Issue-ID: SO-541 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-03-28Added junit for policy client implKalkere Ramesh, Sharan (sk720x)3-76/+121
Change-Id: Ibe5319e9b795355372cbd5ef374a545fb3a9b1d3 Issue-ID: SO-542 Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
2018-03-28Added subworkflow for Pnf pnpbiniek3-125/+171
Change-Id: Ifeba2e74a03ce8c5a13b80f673809c3ef60bfe3f Issue-ID: SO-506 Signed-off-by: biniek <lukasz.biniek@nokia.com>
2018-03-27pnf ready event consumerLukasz Muszkieta5-51/+202
Change-Id: I63802ea60d318626ae32e734167d2bce602d72e4 Issue-ID: SO-466 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-03-27Dependency version updates for BeijingRob Daugherty1-1/+1
Update so/libs version to 1.2.1 Update aai-common version to 1.2.1 Update sdc-distribution-client version to 1.3.0 Update sdc-tosca version to 1.3.3 Change-Id: I6c8f1c5476efc4dc866bf765c265736ab70c12c7 Issue-ID: SO-536 Signed-off-by: Rob Daugherty <rd472p@att.com>