aboutsummaryrefslogtreecommitdiffstats
path: root/common/src
AgeCommit message (Collapse)AuthorFilesLines
2019-02-18set version when using constructorBenjamin, Max (mb388a)1-0/+1
set version when using constructor Change-Id: Iaa7c74c8189eb4c607f25fe3f1660c08e80b2586 Issue-ID: SO-1529 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-18Merge "fix critical sonar bugs"Steve Smokowski2-4/+12
2019-02-14query clients now set their expected objectBenjamin, Max (mb388a)3-4/+6
unit test is using the wrong number of keys for aai uri query clients now set their expected object for method Change-Id: I622c76cee0e9d47be35a78156267bf1c22cbf404 Issue-ID: SO-1514 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-14fix critical sonar bugsk.kazak2-4/+12
Restore interrupted state when InterruptedException is thrown in SDNCRestClient Added test for this case Replaced formatting anchor with text empty object in GraphInventoryResultWrapper Escaped anchor is also considered as bug by sonar Case is already covered in AAIResultWrapperTest Marked comparison of the same object as false positive in EqualsAndHashCodeTester Added clearer comment to this comparison Change-Id: I24496c2323c33599db99a3d3b59fc4f6a008cf1f Issue-ID: SO-1492 Signed-off-by: k.kazak <k.kazak@samsung.com>
2019-02-13add new functionality to aai clientBenjamin, Max (mb388a)32-901/+771
Remove only the first occurrence of parentUri from uriTemplate. add createIfNotExists to transaction clients moved classes to generic GraphInventory location removed unused interfaces from graphinventory client refactored all graph inventory clients Change-Id: I2b946674ff92c44d33fff2f327e96655ed5c0195 Issue-ID: SO-1501 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-13Merge "use encrypted auth for dmaap"Steve Smokowski10-62/+77
2019-02-11Merge "Add junit tests for AdapterRestClient"Steve Smokowski1-0/+109
2019-02-11restructured a&ai clientBenjamin, Max (mb388a)19-312/+703
made generics a bit safer and updated groovy tests Change-Id: I6d7a2567cd9bf795e0cfa4914a7674a4ed5f50c4 Issue-ID: SO-1493 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-11Merge "added license headers to various java files"Steve Smokowski10-0/+200
2019-02-11Merge "Increase long poll DMaaP timeout value to 60"Steve Smokowski1-0/+1
2019-02-08Increase long poll DMaaP timeout value to 60Benjamin, Max (mb388a)1-0/+1
Corrected a JUnit to include updated timeout value. Increase long poll DMaaP timeout value to 60 seconds Change-Id: I22a6f17bc694b17b14f25c7dccd6b57d89d0c2b7 Issue-ID: SO-1488 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-08added license headers to various java filesBenjamin, Max (mb388a)10-0/+200
added license headers to various java files Change-Id: Icd93ba2943f9ab9a4298a7bf91a1b2e92f700e7a Issue-ID: SO-1487 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-08add DSL endpoint support to A&AI ClientBenjamin, Max (mb388a)9-0/+416
add DSL endpoint support to A&AI Client Change-Id: I4e5772354d1d79a343bfac78b4a10ca0c00e3edf Issue-ID: SO-1485 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-08Add junit tests for AdapterRestClientLukasz Muszkieta1-0/+109
Change-Id: Ieb92404710b716c40762365965852dc9a00947c2 Issue-ID: SO-1480 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-02-01compare resources from openstack to aaiBenjamin, Max (mb388a)2-0/+4
Address Review comments on pull request Update Unit test to have proper variable for testing update logic inside bpmn to reflect proper variable Update unit test to check property for audit Add flag to turn on and off audit behavior Add license headers, remove un-used files Update Building Block Tests and Activity Names Fix additional unit tests in so-bpmn-tasks layer Fix broken Junit Test, and correct Bug in if statement Add annotation to ignore class under test profile Additional bug fixes and unit tests for classes Add Additional JUNITS, add more sample data Add Openstack Audit functionality to Adapter Change-Id: I0492063271e991eefc608b56336a5cdf1d5a7778 Issue-ID: SO-1456 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-31use OE from AAI with sdcBenjamin, Max (mb388a)3-215/+0
Updated the SDC API call with the ECOMP OE from AAI relationship instead of VNF OE value. Change-Id: I576ed83364f11213f36781c033f7c2d56f98f1c6 Issue-ID: SO-1451 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-27add custom object support to a ai clientBenjamin, Max (mb388a)7-97/+170
enhanced custom support of objects in client simplified the way objects are added to the type map attempt to search all packages with ClasspathHelper do not allow reflections to log so much former enums are now serializable again added the ability to create custom object types for A&AI client Change-Id: I47aae99bc42ccb0ab3d60d4d5d1fe0558cd1a273 Issue-ID: SO-1429 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-25Merge "Removed deprecated Matcher imports"Steve Smokowski3-4/+4
2019-01-24Removed deprecated Matcher importsBenjamin, Max (mb388a)3-4/+4
replaced org.mockito.Matchers with ArgumentMatchers Change-Id: I2feb4d4fb314cd14aca0719c4cc29b1a0510cbf7 Issue-ID: SO-1413 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-24use encrypted auth for dmaapBenjamin, Max (mb388a)10-62/+77
remove deobfuscate as crypto is already used. update based on the feedback to use crypto utils to decrypt Re-Factor DMAAP Credentials to use encrypted auth credential Change-Id: I2ac5be84594d84f0f24ae554d99cef274dbb6c16 Issue-ID: SO-1425 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-24bugfixes jan 24thBenjamin, Max (mb388a)2-0/+3
Fix null pointer exception when no requestParameters are specified Add configurable timer in ActivateVfModuleBB to delay call to SDNC activate - Use raw slf4j logger - use {} formatting Add configurable timer in ActivateVfModuleBB to delay call to SDNC activate - Use raw slf4j logger Add configurable timer in ActivateVfModuleBB to delay call to SDNC activate - removed unused references in test class Add configurable timer in ActivateVfModuleBB to delay call to SDNC activate Update PortGroup objects separately from the parent VCE object - restore setVariable calls back into vce object - they might be needed later. Update PortGroup objects separately from the parent VCE object - updated test class extra call to get PortGroups Update PortGroup objects separately from the parent VCE object - use PortGroup.getInterfaceRole() getter method instead of accessing field directly. Update PortGroup objects separately from the parent VCE object Added back required headers for tenant isolation. removed workflow exception from outmapping in execute Fix possible null ptr exception, fix to add braces. Default networkTechnology in Update as done in Create Fix failing junits, mapper force upper case nwtech update exception builder to properly throw exception error message supporting assign service instance a la carte as well adding in proper exception handling in network rest v1 add the unassign action to R macro data file Change-Id: Ide420514f81b8083b4c76c762c064de199624cf7 Issue-ID: SO-1424 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-22validate number of uri keysBenjamin, Max (mb388a)4-2/+87
test was setting unnecessary keys on uri changed plural to singular AAI class added in validation for number of keys provided Change-Id: I86f61301aa5f2ea676678908bae1e88b86d7e570 Issue-ID: SO-1409 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-22fixed incorrect object referenceBenjamin, Max (mb388a)1-2/+2
changed plural to singular AAI class Change-Id: I6205d95b881d011e377669858fc85dc2ff0a17f6 Issue-ID: SO-1412 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-21Merge "Bug fixes from AT&T January 20th"Steve Smokowski9-38/+251
2019-01-21Bug fixes from AT&T January 20thBenjamin, Max (mb388a)9-38/+251
sorted vfmodules by base last for negative action reqs store Response in execution as String on network delete added functionality to skip rollback based on flag # Conflicts: # bpmn/so-bpmn-tasks/src/main/java/org/onap/so/bpmn/infrastructure/workflo w/tasks/WorkflowAction.java require XML in the header for delete network request Update APP-C LCM Client library version to 1.7.0. replaced wiremock style test with mockito test Handle AAIClient Exps in CreateCustomerV1 getServiceInstance() changed default status code to be configurable Replace vnfType by nfRole in the healthcheck request to SDNO. updated error messages in sdnc handler and flow status updated flow status message on completion of flow Send GenericVnf object for AAI VNF update for vnf-api updates Add a JUnit test file for SDNOValidatorImpl.java Set nodeType on the inner SDNO request as per update from SDNO. updated rollbackToAssigned logic to remove unassign flows updated sdnc handler error message for client error added exception handling for httpclienterror in sdnc out map workflow exception so error is reported throws sdnc error message on bad response from sdnc add catalog entries for TRANSPORT service delete flows change script number that was duplicate add find method to NorthBoundRequestRepository include serviceType in hash code use asterisk for all non-TRANSPORT flow db entries alacart true, rm not needed transport srvc model steps correct insert query syntax for orchestration_flow support serviceType (TRANSPORT) process flow fix SDNCAdapterException causing no callback to bpmn use JsonAlias for alternate case when deserializing GRM client will accept both "serviceEndPointList" and "ServiceEndPointList" root node in the JSON response. AAIRestClient now uses getSystemName in headers finishtime should not be returned in requeststatus Change-Id: I81a185252b057020f7f36f125c85c3357756da88 Issue-ID: SO-1403 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-20ensure data for si matches on macro requestsBenjamin, Max (mb388a)2-7/+7
Fixed failing ValidationExceptionTest Moved MacroRequest.json to test specific folder Moved resource files to test specific folder Cleaned up comments from UserParamsValidationTest Refactored modelInfoValidation method Removed unused constants from ValidationException Removed unused ValidationException ADded overrideExistingMessage boolean Added test for missing modelType in userParams service object Fixed failing JUnit tests in MsoRequestTest Started fixing failing JUnit tests Began adding validation and tests for userParams modelInfo Began adding validation for instanceName Change-Id: I442f6b660af4e716d75746f8d8155aac1e183e80 Issue-ID: SO-1405 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-17remove unused uuid parameterLukasz Muszkieta2-5/+5
Change-Id: I0c4d5d6fcbf5d7c48c82b4485980adf2fde809cd Issue-ID: SO-729 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-01-15remove unused uuid parameterLukasz Muszkieta6-20/+16
Change-Id: I07793ddafdb8c23ff62ce282c413585c495751ab Issue-ID: SO-729 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-01-12Merge "updated logging to JaxRsFilterLogging"Steve Smokowski3-9/+3
2019-01-12Merge "Quality of Life logging improvements"Steve Smokowski1-0/+9
2019-01-11removed retired A&AI versions from codebaseBenjamin, Max (mb388a)3-13/+8
removed retired A&AI versions from codebase Change-Id: I3e0a185ad1020c91be2fa3df7a509fde2a83c4cd Issue-ID: SO-1385 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-11Quality of Life logging improvementsBenjamin, Max (mb388a)1-0/+9
Remove invalid newline character in process name Quality of Life logging improvements Change-Id: I2193c08e365e847f6be144106a0b20aa7828497e Issue-ID: SO-1381 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-11updated logging to JaxRsFilterLoggingBenjamin, Max (mb388a)3-9/+3
Changed the MDC sourcing from LoggingInterceptor to JaxRsFilterLogging. Change-Id: Idd807f1bf6d3a5a680f547d09503a53a362cd5d1 Issue-ID: SO-1362 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-04Bugfixes for December 2018Benjamin, Max (mb388a)1-1/+1
Changed the way that the cidr is constructed in network utils. added in the if statement to check if selflink already exists removed execution line that was not needed in pull added service instance id to workflowResourceIds for virtualLinkKey network flows wrote test for updating request to complete in db workflow action directly updates db instead of using mso complete process Increase max timeout for SDNO Health Checks dmaap. Added execution variable and corrected type and way data is retrieved to fix defect fixed retry status message in request db for #/5 updated workflowActionBBTasks for flow status message updated flow status to failed on a workflowaction fail Removed slashes and fixed rollbackStatusMessage Updated requestStatus logic for adding status messages Added junit test to validate casue of a defect and cleaned up code and logging added end timestamp to request db on complete request fixed l3Network update of orchestation status in DoUpdateNetworkInstance groovy as well fixed update of l3network orchestration status Add explicit resetting of heatStackId in A&AI to DeleteVfModule and DeleteVolumeGroup BBs. Preserve heatStackId setting in the copiedVfModule when updating the VF Module in A&AI. added functionality to skip rollback based on flag Update snapshot version for logging, add headers fixed optional of error in retrieveErrorMessage method Set heatStackId to null if we want to remove it in A&AI. added in a warn logger statement to keep track of field map network technology from l3network instead of model info for network adapter object mapper Force heatStackId value to empty on an attempt to set it to null on update updated common pom to use aai schema version 1.4.1 removed handle sync error from SDNCHandler bpmn flow Change-Id: I1bd7aa55b06d4e439000b216165c9daafeacc9a4 Issue-ID: SO-1361 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-04Merge "Added timeStamp to requestStatus returned"Steve Smokowski1-1/+8
2019-01-04HttpClientFactory to create HttpClient instancesMichal Kabaj4-17/+27
-Replace constructor calls with existing factory -Add create methods to factory for each required Media Type Change-Id: Ibd03c10230c87a0413c0ec529e0ea9ac800444f9 Issue-ID: SO-1344 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2019-01-03Added timeStamp to requestStatus returnedKalkere Ramesh, Sharan (sk720x)1-1/+8
Added timeStamp to requestStatus returned Change-Id: Ife220b95287e672f456f1511f64ddccb613dde93 Issue-ID: SO-1328 Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
2018-12-10Merge "Add unit tests for ExternalAPIUtil"Rob Daugherty1-0/+30
2018-12-06Merge "fix flakey unit test"Rob Daugherty1-1/+1
2018-12-06Merge "grm clients use encrypted auth loading"Rob Daugherty6-263/+14
2018-12-06update orchestrationrequest responseKalkere Ramesh, Sharan (sk720x)1-1/+16
Change-Id: If2bebd5fe511a1beee4ada0bb473e3b37f8ce474 Issue-ID: SO-1290 Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
2018-12-06fix flakey unit testKalkere Ramesh, Sharan (sk720x)1-1/+1
Change-Id: Ie82a2ae1890a867d027b534c2a674fcd750b2a66 Issue-ID: SO-1289 Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
2018-12-06grm clients use encrypted auth loadingKalkere Ramesh, Sharan (sk720x)6-263/+14
Change-Id: I328e7c0913acf3d84d4a51ba9b9237ec337b0ee1 Issue-ID: SO-1288 Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
2018-12-05Merge "Resolve Security Exploits"Rob Daugherty1-1/+2
2018-12-05Merge "Updated Network Logic"Rob Daugherty1-0/+2
2018-12-05Resolve Security ExploitsSmokowski, Steve (ss835w)1-1/+2
normalize all file paths before using them Change-Id: I67aaa00d7218b95dde96f3679efe92c3c0cd33f9 Issue-ID: SO-1275 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-12-04Updated Network LogicSmokowski, Steve (ss835w)1-0/+2
Added logic to get aggregate route, updated unit test, fixed bugs, refactored select code. Change-Id: I3269da1967ba903dd11459f76030c3fc2aad797a Issue-ID: SO-1270 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-12-04Fix auth for catalog dbsubhash kumar singh1-1/+0
Fix auth for catalog db. Change-Id: Ic787993f608b7ddf74167f7859a519ca02b794ed Issue-ID: SO-689 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-11-28Merge "Remove all usage of AlarmLogger"Rob Daugherty4-331/+5
2018-11-27Remove all usage of AlarmLoggerBenjamin, Max (mb388a)4-331/+5
Fix broken UT from removing alarm logger fixed compilation and merge issues Remove all usage of AlarmLogger Change-Id: Ic87abd51423274570bfca0ed976d9642a91a843d Issue-ID: SO-1229 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>