summaryrefslogtreecommitdiffstats
path: root/common/src
AgeCommit message (Collapse)AuthorFilesLines
2018-08-02Resolve Sonar Blocking issuesSmokowski, Steve (ss835w)2-21/+0
Issue-ID: SO-788 Change-Id: I4496ef16c56c980a81031ad01fcbb1524d135ea8 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-07-31Containerization feature of SOBenjamin, Max (mb388a)307-5927/+7209
Change-Id: I95381232eeefcd247a66a5cec370a8ce1c288e18 Issue-ID: SO-670 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-07-24Fix use try-with-resources sonar issuesParshad Patel2-5/+3
Replace try with try-with-resources statement Issue-ID: SO-703 Change-Id: I971b61af2070a6856c751ed36050dd018216fe03 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2018-05-15WorkflowResponse json issuesRob Daugherty3-0/+200
This commit adds some robustness to the interface between the API-H and BPMN, specifically, in how the response is handled. I don't have proof, but there appears to be some randomness to the json provider behavior when used with the jax-rs. Sometimes, the serializer is adding the root element, and sometimes it is not. Maybe there's something wrong with the configuration. Maybe we have competing json providers. I couldn't pin this down. I'm almost certain it is the presence of the root element in the content that causes the API-H code to fail parsing of the BPMN response. This doesn't kill the request, as you might expect, but rather, the API-H passes the BPMN response through to the client (VID, or policy, or whatever). The original problem (SO-586) was "fixed" by "removing the wrapper". This "wrapper" is a needed feature of the interface between BPMN and the API-H. We shouldn't have removed it. The fact that the "fix" appeared to work is due to the behavior I described in the previous paragraph. The API-H chokes on the message, and it passes it through unchanged. Not really what we want. So, I don't know why the jackson/json behavior is flaky and different now, but I can (and did) modify the API-H so it can parse a json message whether or not it has a root element. Note that WorkflowResponse.java (in BPMN) and CamundaResponse.java (in the API-H) are basically the same bean representing the message format. Seems less than ideal to have two different classes. Also note that I changed the name of the "response" attribute of the WorkflowResponse and CamundaResponse classes to "content". Got tired of seeing this nonsense everywhere in the code: response.getResponse() Change-Id: Icaf70f8457de99e493cf882170fe778c620308c9 Issue-ID: SO-586 Issue-ID: SO-618 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-05-04Fix for FileNotFoundException in MsoLoggerTestMichal Kabaj1-1/+1
Remove over 100 whitespaces from logger filename which causes the unit tests to fail in some development environments. Change-Id: I068f4d4562b635b19889c3537282949665348c21 Issue-ID: SO-604 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-04-27Add correlationId to ServiceInstancesRequestLukasz Muszkieta1-8/+21
Change-Id: Idc5ee56660da31f08fd8ed3a67b7cd28f9844f43 Issue-ID: SO-596 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-04-23Sonar-Critical Bug FixingAS004650592-1/+4
File:RestfulUtil.java Line:L85 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:E2EServiceInstances.java Line:L263 L1059 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:OrchestrationRequests.java Line:L343 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:ASDCConfiguration.java Line:L286 L378 SonarLink: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:ResourceInput.java Line:L287 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:ResourceRecipeRequest.java Line:L136 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:ResourceRequestBuilder.java Line:L108 L214 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:CheckAaiForCorrelationIdDelegate.java Line:L70 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:AbstractSdncOperationTask.java Line:L359 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:DmaapClient.java Line:L62 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:HasAnnotationPropertyWithValueMatcher.java Line:L60 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL Change-Id: Ic168a118790c31850a9f32f98465be5d52b8c96f Issue-ID: SO-581 Signed-off-by: AS00465059 <AS00465059@techmahindra.com>
2018-04-20Merge "Exception in AAIRestClientImpl.java"Seshu Kumar M1-2/+2
2018-04-19Exception in AAIRestClientImpl.javasanchitap1-2/+2
AAIRestClientImpl.java Sonar link: https://sonar.onap.org/code?id=org.onap.so%3Aso&selected=org.onap.so%3Acommon%3Asrc%2Fmain%2Fjava%2Forg%2Fopenecomp%2Fmso%2Fclient%2Faai%2FAAIRestClientImpl.java Change-Id: I9bdcd2e389cad15119f322a3ac7f7bcc1bd2cc67 Issue-ID: SO-575 Signed-off-by: sanchitap <sanchita@techmahindra.com>
2018-04-18AAIRestClient support for Basic AuthRob Daugherty6-5/+60
Adding support for Basic Auth in the AAI Rest Clients because ONAP uses this (whereas ECOMP uses 2-way SSL). In general, each AAI client will allow the user to configure properties called "aai.auth" and "mso.msoKey". If these are set, then the client will add the Authorization header to every request. Change-Id: I7c81ec05d2ec4a7dca131f2e9e19d341ac89b09f Issue-ID: SO-576 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-04-16PnfReadyEventConsumer implementationLukasz Muszkieta1-0/+10
Change-Id: I7252400a3f60ca22ddfa71edb28eaf1d16ccd9b4 Issue-ID: SO-466 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-04-10Merge "PnfReadyEventConsumer implementation"Seshu Kumar M2-178/+0
2018-04-06PnfReadyEventConsumer implementationLukasz Muszkieta2-178/+0
Change-Id: Ia4d9fedb023ef6893e887ff6b5802623649aeeba Issue-ID: SO-466 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-04-06Add junit test for UUIDChecker java Felix Sangalang1-0/+44
junit coverage for UUIDChecker Issue-ID: SO-558 Change-Id: I6203b970e9960ea8fba3a1c052cb24b0340b4284 Change-Id: I6203b970e9960ea8fba3a1c052cb24b0340b4284 Signed-off-by: Felix Sangalang <fs7692@us.att.com>
2018-04-03Added controllerType to requestParametersBrittany Plummer (bp896r)1-6/+14
Change-Id: Ib99642783e9d88558ff0875a246a9a1a628d3817 Issue-ID: SO-553 Signed-off-by: Brittany Plummer (bp896r) <bp896r@att.com>
2018-03-28Merge "Added junit for policy client impl"Rob Daugherty2-76/+105
2018-03-28Merge "Added subworkflow for Pnf pnp"Rob Daugherty3-125/+171
2018-03-28Merge "pnf ready event consumer"Rob Daugherty4-25/+196
2018-03-28improved coverage for catalog db beansBenjamin, Max (mb388a)1-0/+23
Change-Id: Ibf1fd21dc81f0a3e16447b05dfce1761efa69237 Issue-ID: SO-541 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-03-28Added junit for policy client implKalkere Ramesh, Sharan (sk720x)2-76/+105
Change-Id: Ibe5319e9b795355372cbd5ef374a545fb3a9b1d3 Issue-ID: SO-542 Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
2018-03-28Added subworkflow for Pnf pnpbiniek3-125/+171
Change-Id: Ifeba2e74a03ce8c5a13b80f673809c3ef60bfe3f Issue-ID: SO-506 Signed-off-by: biniek <lukasz.biniek@nokia.com>
2018-03-27pnf ready event consumerLukasz Muszkieta4-25/+196
Change-Id: I63802ea60d318626ae32e734167d2bce602d72e4 Issue-ID: SO-466 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-03-23UT Coverage for SOSindhu A1-0/+64
UT Coverage for so/common/src/main/java/org/openecomp/mso/entity Issue-ID: SO-369 Change-Id: Ibf5859fb068abfadd7e9aa98e7ef2a82a2b654c7 Signed-off-by: Sindhu A <arcot.sindhuri@huawei.com>
2018-03-22added openpojo test for policy entities beansBenjamin, Max (mb388a)2-6/+65
Change-Id: I41031381e5cb5d2f9540e6c941479283f6a59280 Issue-ID: SO-512 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-03-22updated grm beans test to remove flakey junitBenjamin, Max (mb388a)1-9/+12
Change-Id: Ie6162a62fb3e61d547a7dfd82f01f194127ac989 Issue-ID: SO-514 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-03-22added openpojo tests for sdno beansBenjamin, Max (mb388a)6-0/+77
Change-Id: I185fb4262347120ae94c6d41e0a8de4d47d1ea0f Issue-ID: SO-517 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-03-22Added openpojo tests for ruby beansBenjamin, Max (mb388a)1-0/+59
Change-Id: Id30228ee7b02d9200ca3c02b73e9b0cb9541df46 Issue-ID: SO-515 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-03-22added openpojo tests for service instance beansBenjamin, Max (mb388a)21-622/+788
Change-Id: I97db02310eace781b41b1463239a519a7a167a12 Issue-ID: SO-513 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-03-21added custom validators for use with openpojoBenjamin, Max (mb388a)7-0/+513
Change-Id: I7c9fdeb6bccddb1b7ec6bf845351731c3043aafa Issue-ID: SO-510 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-03-21UT CoverageSindhu A2-0/+92
UT Coverage for SO Change-Id: Ib9517c25b22c37c85b2af84259911b01ddb4bbe5 Issue-ID: SO-369 Signed-off-by: Sindhu A <arcot.sindhuri@huawei.com>
2018-03-21Adding JuintSP005016384-0/+189
Adding Junit for: 1.AAIOperationalEnvironmentTest 2.AAIOwningEntityTest 3.AAIProjectTest 4.AAIServiceInstanceTest Sonar link: https://sonar.onap.org/code?id=org.onap.so%3Aso&selected=org.onap.so%3Acommon%3Asrc%2Fmain%2Fjava%2Forg%2Fopenecomp%2Fmso%2Fclient%2Faai%2Fobjects Change-Id: I68265d9df5094941bc6f85dd812b7c85480adf21 Issue-ID: SO-503 Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
2018-03-21Sonar BlockerSP005016381-13/+11
Use try-with-resources or close in a finally clause MsoLogger.java:993,994,1005 Sonar Link: https://sonar.onap.org/issues?assignees=swapnalipode&resolved=false Location: common/src/main/java/org/openecomp/mso/logger/MsoLogger.java Change-Id: I9a1e5b39f2c25ace3febc65fca1104358acaa7b7 Issue-ID: SO-508 Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
2018-03-20Add test case for DmaapPublishersubhash kumar singh1-0/+60
Add test case for DmaapPublisher. Change-Id: Ia69b174eb429a1b9e69a250eb1110334a97785aa Issue-ID: SO-369 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-03-19CII badging issue resolutionManamohan Satapathy2-5/+16
PASSWORD detected in this expression review this potentially hardcoded credential RestClientSSL.java:L41 Location:https://sonar.onap.org/issues?myIssues=true&open=AWIklWurRGy6eclHDh62&resolved=false&rules=squid%3AS2068&severities=CRITICAL Change-Id: I6c80f04c0965711e836f0ff1ee5dcdfd2725fb62 Issue-ID: SO-478 Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>
2018-03-14AT&T 1712 and 1802 release codeRob Daugherty222-232/+16180
This is code from AT&T's 1712 and 1802 releases. Change-Id: Ie1e85851e94bc66c4d9514a0226c221939531a04 Issue-ID: SO-425 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-03-13Merge "Remove trailing spaces from property files"Seshu Kumar M5-134/+134
2018-03-09Remove unnecessary simicolon from all java classesMunir Ahmad2-6/+6
Change-Id: I5a320c606ea3e0c47efa6d84e8b0cc1ab40f3b70 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-03-09private is redundant for enum constructorsMunir Ahmad1-2/+2
Change-Id: I3fbd868e83651111a6bce6c268ed4d7cf84c3fd5 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-03-09Remove trailing spaces from property filesMunir Ahmad5-134/+134
Change-Id: I2b7fdfb8121eaddcb618af2117f534c27766feee Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-03-09Revert Reduce log noise/warningsRob Daugherty7-1169/+1093
This reverts commit 327b17ab250b4c17cf3f91f5e4cd9bffd89f3d1e. It is seriously impeding our ability complete the promised merge of AT&T 1802 code. While I'm all for coding standards, if we are serious about using spaces instead of tabs, then I think we need to (1) agree with the community when this will happen, (2) do consistently in all files, and (3) enforce it. Change-Id: Ib9b996f6b6c7d81ac9ac95d58b0c7d8cc39675ff Issue-ID: SO-368 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-03-08Reduce log noise/warnings format to conventionsMarcus G K Williams7-1093/+1169
Reduce build log warnings by formatting tests to ONAP code conventions (removing tabs etc.) Issue-ID: SO-368 Change-Id: I48c6d359b83617aebeb79db4e30c1d72d31f7eec Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2018-03-08Swap StringBuilder with string where makes senseMunir Ahmad1-9/+3
Change-Id: I3faaa90d97e936b0d86282db5958e1048460ee81 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-03-07Remove unnecessary String constructor callMunir Ahmad1-2/+2
Change-Id: Ibb0dcc412ae6243ee370b8e272455269303130eb Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-03-06Replace explicit type with dimond typeMunir Ahmad4-6/+6
Change-Id: I1dedb9ef1ca7b734e3cfc0a3a594d733dbd298d4 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-02-27Make use of append instead of string concatenationMunir Ahmad2-3/+4
Change-Id: I94ad658026f165ba8b5a74352095188a27ee50e5 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-02-24Swap StringBuffer with StringBuilder everywhereMunir Ahmad2-2/+2
Change-Id: Ia1f8d3ebc4026179bf08cdb0bd71c4480b8481df Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-02-24Swap for loop in favor of foreachMunir Ahmad1-4/+4
Change-Id: I04b3691abd958a1455f55b8b295a7f08998b8692 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-02-21Boolean constructor callMunir Ahmad1-1/+1
Change-Id: Ic5a16598b1f1ac4f53ab651064b872316abafde0 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-02-15Optimize number of MsoLogger instancesUsaraswat1-10/+36
Each call to getMsoLogger creates a new instance of MsoLogger which is a potential memory leak Change-Id: Ib0dda3abbf45d8633b4c8a2d49aa9d5c87e12931 Issue-ID: LOG-174 Signed-off-by: Usaraswat <saraswat.urwashi@amdocs.com>
2018-01-17Update VF Module Check for Tosca VNFc001491072-0/+6
Update VF Module Check for Tosca VNF, so that voLTE can distribute to SO Change-Id: I39d87f198532e480540e039f207f1bd201a5d4d7 Issue-ID: SO-380 Signed-off-by: c00149107 <chenchuanyu@huawei.com>