summaryrefslogtreecommitdiffstats
path: root/common/src/main/java
AgeCommit message (Collapse)AuthorFilesLines
2018-07-24Fix use try-with-resources sonar issuesParshad Patel2-5/+3
Replace try with try-with-resources statement Issue-ID: SO-703 Change-Id: I971b61af2070a6856c751ed36050dd018216fe03 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2018-05-15WorkflowResponse json issuesRob Daugherty2-0/+106
This commit adds some robustness to the interface between the API-H and BPMN, specifically, in how the response is handled. I don't have proof, but there appears to be some randomness to the json provider behavior when used with the jax-rs. Sometimes, the serializer is adding the root element, and sometimes it is not. Maybe there's something wrong with the configuration. Maybe we have competing json providers. I couldn't pin this down. I'm almost certain it is the presence of the root element in the content that causes the API-H code to fail parsing of the BPMN response. This doesn't kill the request, as you might expect, but rather, the API-H passes the BPMN response through to the client (VID, or policy, or whatever). The original problem (SO-586) was "fixed" by "removing the wrapper". This "wrapper" is a needed feature of the interface between BPMN and the API-H. We shouldn't have removed it. The fact that the "fix" appeared to work is due to the behavior I described in the previous paragraph. The API-H chokes on the message, and it passes it through unchanged. Not really what we want. So, I don't know why the jackson/json behavior is flaky and different now, but I can (and did) modify the API-H so it can parse a json message whether or not it has a root element. Note that WorkflowResponse.java (in BPMN) and CamundaResponse.java (in the API-H) are basically the same bean representing the message format. Seems less than ideal to have two different classes. Also note that I changed the name of the "response" attribute of the WorkflowResponse and CamundaResponse classes to "content". Got tired of seeing this nonsense everywhere in the code: response.getResponse() Change-Id: Icaf70f8457de99e493cf882170fe778c620308c9 Issue-ID: SO-586 Issue-ID: SO-618 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-04-27Add correlationId to ServiceInstancesRequestLukasz Muszkieta1-8/+21
Change-Id: Idc5ee56660da31f08fd8ed3a67b7cd28f9844f43 Issue-ID: SO-596 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-04-23Sonar-Critical Bug FixingAS004650592-1/+4
File:RestfulUtil.java Line:L85 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:E2EServiceInstances.java Line:L263 L1059 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:OrchestrationRequests.java Line:L343 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:ASDCConfiguration.java Line:L286 L378 SonarLink: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:ResourceInput.java Line:L287 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:ResourceRecipeRequest.java Line:L136 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:ResourceRequestBuilder.java Line:L108 L214 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:CheckAaiForCorrelationIdDelegate.java Line:L70 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:AbstractSdncOperationTask.java Line:L359 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:DmaapClient.java Line:L62 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:HasAnnotationPropertyWithValueMatcher.java Line:L60 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL Change-Id: Ic168a118790c31850a9f32f98465be5d52b8c96f Issue-ID: SO-581 Signed-off-by: AS00465059 <AS00465059@techmahindra.com>
2018-04-20Merge "Exception in AAIRestClientImpl.java"Seshu Kumar M1-2/+2
2018-04-19Exception in AAIRestClientImpl.javasanchitap1-2/+2
AAIRestClientImpl.java Sonar link: https://sonar.onap.org/code?id=org.onap.so%3Aso&selected=org.onap.so%3Acommon%3Asrc%2Fmain%2Fjava%2Forg%2Fopenecomp%2Fmso%2Fclient%2Faai%2FAAIRestClientImpl.java Change-Id: I9bdcd2e389cad15119f322a3ac7f7bcc1bd2cc67 Issue-ID: SO-575 Signed-off-by: sanchitap <sanchita@techmahindra.com>
2018-04-18AAIRestClient support for Basic AuthRob Daugherty4-4/+42
Adding support for Basic Auth in the AAI Rest Clients because ONAP uses this (whereas ECOMP uses 2-way SSL). In general, each AAI client will allow the user to configure properties called "aai.auth" and "mso.msoKey". If these are set, then the client will add the Authorization header to every request. Change-Id: I7c81ec05d2ec4a7dca131f2e9e19d341ac89b09f Issue-ID: SO-576 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-04-16PnfReadyEventConsumer implementationLukasz Muszkieta1-0/+10
Change-Id: I7252400a3f60ca22ddfa71edb28eaf1d16ccd9b4 Issue-ID: SO-466 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-04-06PnfReadyEventConsumer implementationLukasz Muszkieta1-93/+0
Change-Id: Ia4d9fedb023ef6893e887ff6b5802623649aeeba Issue-ID: SO-466 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-04-03Added controllerType to requestParametersBrittany Plummer (bp896r)1-6/+14
Change-Id: Ib99642783e9d88558ff0875a246a9a1a628d3817 Issue-ID: SO-553 Signed-off-by: Brittany Plummer (bp896r) <bp896r@att.com>
2018-03-28Merge "Added junit for policy client impl"Rob Daugherty1-1/+1
2018-03-28Merge "Added subworkflow for Pnf pnp"Rob Daugherty3-125/+171
2018-03-28Merge "pnf ready event consumer"Rob Daugherty3-25/+111
2018-03-28improved coverage for catalog db beansBenjamin, Max (mb388a)1-0/+23
Change-Id: Ibf1fd21dc81f0a3e16447b05dfce1761efa69237 Issue-ID: SO-541 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-03-28Added junit for policy client implKalkere Ramesh, Sharan (sk720x)1-1/+1
Change-Id: Ibe5319e9b795355372cbd5ef374a545fb3a9b1d3 Issue-ID: SO-542 Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
2018-03-28Added subworkflow for Pnf pnpbiniek3-125/+171
Change-Id: Ifeba2e74a03ce8c5a13b80f673809c3ef60bfe3f Issue-ID: SO-506 Signed-off-by: biniek <lukasz.biniek@nokia.com>
2018-03-27pnf ready event consumerLukasz Muszkieta3-25/+111
Change-Id: I63802ea60d318626ae32e734167d2bce602d72e4 Issue-ID: SO-466 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-03-22added openpojo test for policy entities beansBenjamin, Max (mb388a)1-6/+6
Change-Id: I41031381e5cb5d2f9540e6c941479283f6a59280 Issue-ID: SO-512 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-03-22added openpojo tests for sdno beansBenjamin, Max (mb388a)5-0/+18
Change-Id: I185fb4262347120ae94c6d41e0a8de4d47d1ea0f Issue-ID: SO-517 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-03-22added openpojo tests for service instance beansBenjamin, Max (mb388a)20-622/+724
Change-Id: I97db02310eace781b41b1463239a519a7a167a12 Issue-ID: SO-513 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-03-21added custom validators for use with openpojoBenjamin, Max (mb388a)7-0/+513
Change-Id: I7c9fdeb6bccddb1b7ec6bf845351731c3043aafa Issue-ID: SO-510 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-03-21Sonar BlockerSP005016381-13/+11
Use try-with-resources or close in a finally clause MsoLogger.java:993,994,1005 Sonar Link: https://sonar.onap.org/issues?assignees=swapnalipode&resolved=false Location: common/src/main/java/org/openecomp/mso/logger/MsoLogger.java Change-Id: I9a1e5b39f2c25ace3febc65fca1104358acaa7b7 Issue-ID: SO-508 Signed-off-by: SP00501638 <SP00501638@techmahindra.com>
2018-03-19CII badging issue resolutionManamohan Satapathy1-4/+14
PASSWORD detected in this expression review this potentially hardcoded credential RestClientSSL.java:L41 Location:https://sonar.onap.org/issues?myIssues=true&open=AWIklWurRGy6eclHDh62&resolved=false&rules=squid%3AS2068&severities=CRITICAL Change-Id: I6c80f04c0965711e836f0ff1ee5dcdfd2725fb62 Issue-ID: SO-478 Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>
2018-03-14AT&T 1712 and 1802 release codeRob Daugherty168-1/+12863
This is code from AT&T's 1712 and 1802 releases. Change-Id: Ie1e85851e94bc66c4d9514a0226c221939531a04 Issue-ID: SO-425 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-03-09Remove unnecessary simicolon from all java classesMunir Ahmad2-6/+6
Change-Id: I5a320c606ea3e0c47efa6d84e8b0cc1ab40f3b70 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-03-09private is redundant for enum constructorsMunir Ahmad1-2/+2
Change-Id: I3fbd868e83651111a6bce6c268ed4d7cf84c3fd5 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-03-08Swap StringBuilder with string where makes senseMunir Ahmad1-9/+3
Change-Id: I3faaa90d97e936b0d86282db5958e1048460ee81 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-03-06Replace explicit type with dimond typeMunir Ahmad3-5/+5
Change-Id: I1dedb9ef1ca7b734e3cfc0a3a594d733dbd298d4 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-02-27Make use of append instead of string concatenationMunir Ahmad2-3/+4
Change-Id: I94ad658026f165ba8b5a74352095188a27ee50e5 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-02-24Swap StringBuffer with StringBuilder everywhereMunir Ahmad2-2/+2
Change-Id: Ia1f8d3ebc4026179bf08cdb0bd71c4480b8481df Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-02-24Swap for loop in favor of foreachMunir Ahmad1-4/+4
Change-Id: I04b3691abd958a1455f55b8b295a7f08998b8692 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-02-15Optimize number of MsoLogger instancesUsaraswat1-10/+36
Each call to getMsoLogger creates a new instance of MsoLogger which is a potential memory leak Change-Id: Ib0dda3abbf45d8633b4c8a2d49aa9d5c87e12931 Issue-ID: LOG-174 Signed-off-by: Usaraswat <saraswat.urwashi@amdocs.com>
2018-01-17Update VF Module Check for Tosca VNFc001491071-0/+1
Update VF Module Check for Tosca VNF, so that voLTE can distribute to SO Change-Id: I39d87f198532e480540e039f207f1bd201a5d4d7 Issue-ID: SO-380 Signed-off-by: c00149107 <chenchuanyu@huawei.com>
2017-12-13Reduce complexity of HealthCheckUtilskurczews1-11/+14
* Split bulk conditionals * Split health checks to separate methods * Fix minor issues Issue-ID: SO-353 Change-Id: Ib6298bc488a94aa4fbb253e3894532708547533d Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
2017-10-18Revert "Fix defect SO-36"Seshu-Kumar-M1-61/+60
IssueId:SO-232 Change-Id: I4118bf42a7325ae6fe6f304638e247bd8a042864 Signed-off-by: Seshu-Kumar-M <seshu.kumar.m@huawei.com>
2017-09-30remove odl dependence temporary黄卓垚1011221521-2101/+0
Change-Id: I2d4348974badf6b4ecb255adb3ffa3b5c399d7e2 Issue-ID: SO-88 Signed-off-by: Zhuoyao Huang <10112215@zte.com.cn> description: Remove odl dependence temporary for docker deployment, utill the issue is be solved. Before that time, yang decoder is unavailable.
2017-09-28Merge "Removed the unused variables"Seshu Kumar M1-1/+1
2017-09-27Merge "Fixed Blocker issues. IssueId: SO-165"Rob Daugherty2-12/+27
2017-09-27Fixed Blocker issues.seshukm2-12/+27
IssueId: SO-165 Change-Id: I7c2520af9394ceb600a5a25fa9acfd095d872a1d Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
2017-09-27Removed the unused variablesrama-huawei1-1/+1
Issue-Id:SO-118 Change-Id: I979370f8d3ffa0382856353aa189610d24dcd20c Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
2017-09-27Update POM to inherit from oparentRob Daugherty21-0/+420
Issue: SO-71 Change-Id: I91d503b52909cfcb62ca4b5cd93f6cfc70d6eb24 Signed-off-by: Rob Daugherty <rd472p@att.com>
2017-09-23Yang decoderZhuoyao Huang21-0/+1666
Change-Id: I4e264c33915969f883ebc3721e7020fb1256682c Issue-ID: SO-88 Signed-off-by: Zhuoyao Huang <10112215@zte.com.cn> description: It could help SO to use the restconf interface which is generated by yang-tools in SDN-C directly.
2017-09-12Fix for SONAR critical issuesseshukm2-0/+5
Issue-Id : SO-117 Change-Id: Icdc64605b475e20af7e871135af327f7d0e38792 Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
2017-09-11Change the header to SOSeshu-Kumar-M20-20/+20
IssueId : SO-120 Change-Id: I1a94ec1846caaa8968054eb0124fa7cf7885a432 Signed-off-by: Seshu-Kumar-M <seshu.kumar.m@huawei.com>
2017-09-081710 Rebase - Second AttemptArthur Martella7-104/+181
This commit rebases changes from openecomp-mso/internal-staging-1710 up to and including this codecloud commit: 54483fc6606ddb1591a2e9da61bff8712325f924 Wed Sep 6 18:12:56 2017 -0400 Rebasing was done on a branch on top of this commit in so/master in ONAP: 93fbdfbe46104f8859d4754040f979cb7997c157 Thu Sep 7 16:42:59 2017 +0000 Change-Id: I4ad9abf40da32bf5bdca43e868b8fa2dbcd9dc59 Issue-id: SO-107 Signed-off-by: Arthur Martella <amartell@research.att.com>
2017-09-04Merge "Fix to get calling application identifier"Seshu Kumar M2-0/+8
2017-08-30Fix to get calling application identifieranupmarathe2-0/+8
As per EELF logging guidelines, component can put a calling application identifier or user name in MDC against key PartnerName. SO is setting user name against key PartnerName in LogFilter. By having an identity of calling application can assist in debugging. To achieve this SO will check request header key X-FromAppId and set its value against MDC - FromAppId. Change-Id: Ib67c5e76fdf5567282200e17210ddb49cf9a57fb Issue-ID: SO-99 Signed-off-by: anupmarathe <anup.marathe@amdocs.com>
2017-08-30Add VF-C Message Typec001491071-0/+1
Add VF-C Message Type Enum for log Change-Id: Ia22d5c4a1652b977020c40085a17e19100232115 Issue-ID:SO-41 Signed-off-by: c00149107 <chenchuanyu@huawei.com>
2017-08-09Fix defect SO-36pranavdi1-102/+103
Modify MSOLogger to route info messages to debugmso.log instead of errormso.log Change-Id: Id985e83c336e85083764f0d52e7f7e9bb5a20595 Issue-ID: SO-36 Signed-off-by: pranavdi <Pranav.Dixit@amdocs.com>
2017-05-09[MSO-8] Additional fixes for the second rebaseDeterme, Sebastien (sd378r)1-230/+231
DB fixes + BPMN flows and groovy fixes + Fix issue with CloudConfig file not reloaded properly when it's wrong (JSON error or model hierarchy mistake) at MSO startup Change-Id: I2853030b78499e2a761706b643ea210955e72de3 Signed-off-by: Determe, Sebastien (sd378r) <sd378r@intl.att.com> [MSO-8] Restore files removed in patch set 2 Those groovy files must be there Change-Id: I9a47ac3d9c8fc06774a1b8f518491b1b0b00af04 Signed-off-by: Determe, Sebastien (sd378r) <sd378r@intl.att.com>