summaryrefslogtreecommitdiffstats
path: root/bpmn
AgeCommit message (Collapse)AuthorFilesLines
2019-09-18Prevent reading twice from ResponseEntity stream, since this caused IOErrors.grabinsk4-23/+24
Also moving empty response checks to parseJsonToGelAllPnfCorrelationId Issue-ID: SO-2349 Signed-off-by: grabinsk <maciej.grabinski@nokia.com> Change-Id: I316856d56106a1ae715812628695406f4147765d Signed-off-by: grabinsk <maciej.grabinski@nokia.com>
2019-09-17Merge "Build payload APPC parameter from UserParams"Steve Smokowski2-0/+38
2019-09-16Use the configurationId associated to vnfc ifBonkur, Venkat2-1/+31
Use the configurationId associated to vnfc if present. removing the autowiring of the Configuration bean class Issue-ID: SO-2343 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I29f8f9e50ed04014f74b7f6dfaa2cdedb2f334d0
2019-09-12Build payload APPC parameter from UserParamsElena Kuleshov2-0/+38
If a payload parameter is not specified on VID request for APPC interaction, we will need to build it from UserParams from requestCOntext. Issue-ID: SO-2311 Signed-off-by: Kuleshov, Elena <evn@att.com> Change-Id: Ie6affe2bad031d80c43c0358a49cb252fb04f5e2
2019-09-11Merge "Added null check to avoid crash at getErrorCode() call; fixed typos ↵Lukasz Muszkieta1-9/+8
in error messages; removed unnecessary try...catch block"
2019-09-11Added null check to avoid crash atOleksandr Moliavko1-9/+8
getErrorCode() call; fixed typos in error messages; removed unnecessary try...catch block Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko<o.moliavko@samsung.com> Change-Id: I95765a1a5a10497e366b5d94b89d45b6bde2b212
2019-09-11Merge "Integrate Logging Library"Steve Smokowski37-156/+158
2019-09-11Merge "Set payload to empty when it is not specified"Seshu Kumar M1-2/+5
2019-09-11Merge "fix of the instanceParams adding to the CDS request"Seshu Kumar M2-65/+184
2019-09-11Merge "bug fix - avoid npe in pnf flow"Seshu Kumar M5-48/+48
2019-09-11bug fix - avoid npe in pnf flowLukasz Muszkieta5-48/+48
Change-Id: I8e848c2bdcec0822ae08280223297b4825e9b7c2 Issue-ID: SO-2289 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-09-11Fix sonar issuesParshad Patel4-13/+32
Either log or rethrow this exception Make "attributeValue" transient or serializable "attributeName" is already a string, there's no need to call "toString()" Issue-ID: SO-2226 Change-Id: If6ae623202f2c243d73839d0aaefba5ba5c50dd4 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2019-09-10Set payload to empty when it is not specifiedElena Kuleshov1-2/+5
Handle a case of non-existent payload and improve error reporting on APPC request construction Issue-ID: SO-2300 Signed-off-by: Kuleshov, Elena <evn@att.com> Change-Id: I93a1ac8ebfcaa0e39b26130e601d3b657cbed503
2019-09-10Merge "Add SO Update to default the controller type query as "APPC" instead ↵Seshu Kumar M1-1/+7
of null."
2019-09-10Integrate Logging LibraryPlummer, Brittany37-156/+158
Updated SO to use ONAP provided filters and constants to meet logging standards. Removed redundant classes Updated constant references Issue-ID: SO-2301 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Ia4e3c2b1a4dcb3881aa34d39885c8b2782880d64
2019-09-10Merge "Added ACTIVATED Orchestration Status same as"Steve Smokowski2-33/+91
2019-09-09fix of the instanceParams adding to the CDS requestLukasz Muszkieta2-65/+184
Change-Id: I3bff9b5cac47d5fa29fbe503e2c3752a2b207aab Issue-ID: SO-2208 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-09-08Added ACTIVATED Orchestration Status same asSangalang, Felix2-33/+91
Added ACTIVATED Orchestration Status same as ACTIVE. Issue-ID: SO-2284 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Ia62b7ad228d80f3690c3748587a41ee2dc486087
2019-09-05Set AAIClient on AAIValidatorImplElena Kuleshov2-0/+5
AAIValidatorImpl requires setting an initialized AAIClient before validation calls Issue-ID: SO-2286 Signed-off-by: Kuleshov, Elena <evn@att.com> Change-Id: I254e8e01812e47af2855e1c1afaa5904ed792d22
2019-09-05Merge "Log exception"Lukasz Muszkieta5-11/+21
2019-09-05Log exceptionParshad Patel5-11/+21
Either log or rethrow this exception Use isEmpty() to check whether the collection is empty or not Issue-ID: SO-1841 Change-Id: Ia964a871497df8a7211260ad1ad8f1efa8ae4d42 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2019-09-04Merge "Fix rollback for ConfigAssignBB"Max Benjamin1-6/+6
2019-09-04Merge "fix create call to A&AI"Steve Smokowski2-6/+4
2019-09-04General Sonar fixesArindam Mondal7-13/+1
+) Make field transient or serializable ++) Organize imports Issue-ID: SO-2273 Change-Id: I04eeb02c4052e3a790db865b59f873694fc1514d Signed-off-by: arind.mondal <arind.mondal@samsung.com>
2019-08-30fix create call to A&AIGamboa, Gilbert2-6/+4
createIfNotExists should be used rather than create Issue-ID: SO-2269 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I03af6a83460acbb1d7bde01f108d2a5a03d05adf
2019-08-30Merge "sonar fix for ExtractPojosForBB class"Lukasz Muszkieta1-25/+13
2019-08-30Merge "Added back MDC.put to generated missing requestID"Steve Smokowski1-0/+12
2019-08-29Update requestStatus to FAILED on activity error.Elena Kuleshov2-2/+39
Update status and related fields in Requests DB on activity error, add a junit to verify error reporting. Issue-ID: SO-2263 Signed-off-by: Kuleshov, Elena <evn@att.com> Change-Id: I1a2e97afb95e4510b4860486c2b7836b014f990e
2019-08-29Fix rollback for ConfigAssignBBMunir Ahmad1-6/+6
Issue-ID: SO-2266 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca> Change-Id: Iff2faa9f9b919818c4a5f98a62ec2a66ee7589e4
2019-08-29Added back MDC.put to generated missing requestIDSangalang, Felix1-0/+12
Added back MDC.put to generated missing requestID in logfiles. Issue-ID: SO-2265 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I67e0b01dfeb609e7a5d7e29f976ec3ec6549e96b
2019-08-28sonar fix for ExtractPojosForBB classLukasz Muszkieta1-25/+13
Change-Id: I2d568604fa5d2e688b367644de620c8e91508aae Issue-ID: SO-2187 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-08-28Merge "Removed unused methods injectSNIROCallbacks() according to comments ↵Lukasz Muszkieta1-166/+0
by maintainer"
2019-08-26Merge "Add the check Fabric Config in"Steve Smokowski2-2/+6
2019-08-26Merge "added in exception handling if auditResult is null"Steve Smokowski1-2/+8
2019-08-26Merge "added additional mock to MsoGroovyTest"Steve Smokowski1-66/+69
2019-08-26Javadoc and logging improvementManamohan8-12/+221
Added Javadocs and logging for these classes. Change-Id: I26dd974357cfb9ccaed3f9afd0510dc07e9bc33e Issue-ID: SO-2052 Signed-off-by: Manamohan <MS00534989@Techmahindra.com>
2019-08-23Add the check Fabric Config inBonkur, Venkat2-2/+6
Add the check Fabric Config in configuration-subtype after format file run and commit Issue-ID: SO-2256 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: If47f81a985e6321cd84ccfc8d35c51f3ee79e1c2
2019-08-22Fix issue in so-bpmn-tasksParshad Patel2-49/+61
Either log or rethrow this exception Define a constant instead of duplicating this literal Move the string literal on the left side of this string comparison Issue-ID: SO-1841 Change-Id: I828e744be9e71b84d85850d56373e921c174d26b Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2019-08-22General sonar fixesArindam Mondal3-6/+5
+) Use format specifier to log exception ++) remove unused import Issue-ID: SO-2226 Change-Id: I0938d624b918eddf30e96da4f12d7a06cc0ddfe1 Signed-off-by: arindamm <arind.mondal@samsung.com>
2019-08-21Merge "Javadoc and logging improvement"Seshu Kumar M4-8/+33
2019-08-21Removed unused methods injectSNIROCallbacks()Oleksandr Moliavko1-166/+0
according to comments by maintainer Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: I22af32a50cc08954861232a8e38d23166a88c442
2019-08-20added in exception handling if auditResult is nullKalkere Ramesh, Sharan1-2/+8
added in exception handling if auditResult is null maven process format the file that is not formatted fix formsatting again because it failed last time Issue-ID: SO-2242 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I6a83c7fe120e02e808470dbc9e7e431e0b62f4f4
2019-08-20added additional mock to MsoGroovyTestBoslet, Cory1-66/+69
added additional mock to MsoGroovyTest Issue-ID: SO-2241 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I441d79f4951184b0ca79f2c568978fe3d2043025
2019-08-19Close input streams via try-with-resourcesk.kazak1-9/+5
DefaultDmaapPropertiesImpl: close FileInputStream after loading ServicePluginFactory: close HttpClient if processing fails close application.properties InputStream after loading remove redundant catch block if behavior is the same add logging of exception in finally block BpmnInstaller: close csarFile if processing fails Change-Id: Ic6f942c401277c5150c5cc1297aba27ccd40694c Coverity-scan: CID-203903, CID-211476, CID-211615, CID-219308 Issue-ID: SO-2211 Signed-off-by: k.kazak <k.kazak@samsung.com>
2019-08-16Merge "Add retrieval of vmIds and vServerIds for APPC"Steve Smokowski9-4/+719
2019-08-16Merge "Add SO Same deployment id on deployed custom workflows"Steve Smokowski1-1/+1
2019-08-16Merge "Initial commit of validation framework to APIH"Steve Smokowski14-124/+71
2019-08-16Sonar fix in MSOCommonBPMNParshad Patel2-18/+18
Either log or rethrow this exception Remove this useless assignment to local variable "serviceInstance" Remove the declaration of thrown exception which is a runtime exception Move the string literal on the left side of this string comparison Issue-ID: SO-1841 Change-Id: I24cdd3682eddd2e5ceb7e961477a61457ef91ab2 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2019-08-16Javadoc and logging improvementManamohan4-8/+33
Added Javadocs and logging for these classes. Change-Id: I365fc0677c0d5136e4579de3947d0478b26c22d3 Issue-ID: SO-2052 Signed-off-by: Manamohan <MS00534989@Techmahindra.com>
2019-08-15Initial commit of validation framework to APIHSmokowski, Steven14-124/+71
Move ListenerRunner to common location Adjust request params name, update junit tests Update validations to work properly Properly escape period for the string split Issue-ID: SO-2232 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Ia468cf7062cccf30e28afeb7a5cddc37ceb2e002