Age | Commit message (Collapse) | Author | Files | Lines |
|
Fixed critical bugs according to the Sonar analysis.
-Fixed possible NPE.
-Fixed wrong comparison.
-Removed unused variables.
Issue-ID: SO-2025
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I5e2e5413c8421eb7ed1db21de6d888a50e1db689
|
|
|
|
General fixes and improvements according to the Sonar analysis.
-Fixed imports.
-Improvements in diamond operators.
-Removed unnecessary code.
Issue-ID: SO-1992
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I9345b6ab0f4027b17e1bebf0b6657394c13dc298
|
|
Validate ServiceInstance name using createNodesUri.
Change-Id: I5194dd933dc98064888250bc9a38e6ee9716fc01
Issue-ID: SO-2024
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
|
|
|
|
Validate name for InstanceGroup, Configuration and Network.
Change-Id: I494749e17a40c6c0cdd51dd28d9c9bca371410ac
Issue-ID: SO-2022
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Need to change query by name using nodes query to make sure names are
globally unique.
Added new Exception type for duplicate A&AI object names.
Added tests for AAIVfModulResources.
Change-Id: I71558d0881d7060819f5f807fe58779be6edfa6f
Issue-ID: SO-2020
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Update logic to properly format rollback error messages
Change-Id: I66ad4fd78758661be297810f393e6da759daa17b
Issue-ID: SO-2014
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
moved around classes to packages that make more sense
updated license headers in java files
converted MultiStage logic to FlowManipulator
moved tests to new package location and fixed issues
allow for custom listeners before flowsToExecute
moved validation classes to listener.validation
Change-Id: Ic5416812ef9c5611fe19bf9b6aa316373b110ec6
Issue-ID: SO-2021
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
support async operation for vf module operations with sdnc
Update Junit comparison data to be valid for new code
Modify coded to support usage of ASYNC response sdnc
Change-Id: I95b955cb257dcead152d68cd4cc4fb0fbcdfd708
Issue-ID: SO-2015
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
|
|
replaced String.repeat with static final strings
Change-Id: Ife14fde70e8f648881a03e9343ae8faf9cb87e2e
Issue-ID: SO-1999
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
General fixes and improvements according to the Sonar analysis.
-Fixed imports.
-Removed unnecessary variables.
-Added String constants.
Issue-ID: SO-1992
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I8b77def931e703c8a73929ec09324823a91721e3
|
|
General fixes and improvements according to the Sonar analysis
-Added private constructor for a utility class.
-Refactored lambda expression.
Issue-ID: SO-1992
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Ife8cfdf9c341dc89a1699fd616ec68cba734a5d5
|
|
Change-Id: Ib8eaae7ee4a404bde568803afaf6c4e183cbbd53
Issue-ID: SO-2004
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
Using a cloudOwner different than "CloudOwner"
when instantiating a vfmodule using GR_API
causes nbrequest lookup in workflowAction to
fail. This change adds a final check for
northboundRequest that does not use
cloudOwner field before failing.
This should enable instantiation
on multiple cloudRegions without
seperate northbound_request_ref_lookup
actions for each cloudOwner.
Issue-ID: SO-1995
Change-Id: I9d1fe39fb056d03e8473a524c21f41319c13c20f
Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
|
|
Remove unused imports in VrfValidation class
Check for null AAI network and vpn-bindings. Do not catch exceptions in
WorkflowAction.traverseVrfCondifuration. Propagate exceptions and let
calling method selectExecutionList() handle exceptions.
Change-Id: I26adfdb351cee6dc111f496901558340b8152a2a
Issue-ID: SO-1988
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
correct sourcing for service-model-name in NamingMS
remove zone ID from NamingMS input for service name
follow up removal of autowired on NamingRequestObject
Change-Id: Icba2e32c07ee0c7d7739ce21bd547e3030c1e271
Issue-ID: SO-1976
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
checked and evaluated naming policy only if infra bonding.
Updated workflowAction to include vrf configuration for vpn-binding in
resourceIds list.
added in linked resource to service proxy cust
committing the asdc controller classpath change
added some unit tests for vrf validation and updated bbinput setup test
update config resource cust foreign key mapping
Moved mockbean for AssignVrfConfiguration task class into BaseBpmnTest.
added in a check to see if list is empty before access
added unit tests for bbinput setup for vrf config
Update AssignFlows enum with correct AssignVrfConfiguration flow name
Change-Id: Ibf14e36505638b19c1366ecebfce560c02e69e44
Issue-ID: SO-1975
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
Change-Id: I551ea3f29a76dc99532455ea4d7e84a316f9bf38
Issue-ID: SO-1980
Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
|
|
|
|
|
|
|
|
|
|
Improvements in ServiceDecomposition according to the Sonar analysis.
-Fixed imports.
-Replaced System.out with logger.
-Simplified if statements.
-Removed unused code.
Issue-ID: SO-1997
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: If7c399635fffef5bc75b10c7d93be4b27e097bd7
|
|
Issue-ID: SO-1938
Signed-off-by: MariosIakovidis <marios.iakovidis@huawei.com>
Change-Id: I68d684f837f2dea9decb2e577742ab905f825d04
|
|
Issue-ID: SO-1993
Signed-off-by: MariosIakovidis <marios.iakovidis@huawei.com>
Change-Id: I6abec916438221669817b49997431b6164ee1a76
|
|
|
|
General fixes and improvements according to the Sonar analysis.
-Fixed imports.
-Removed unnecessary variables.
-Protect utility static classes with private constructor.
-Removed unnecessary exceptions.
Issue-ID: SO-1992
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Ib0011d730f86e0e1a25d4cf1080a61b2fbb335ae
|
|
Improvements in SniroHomingV2 according to the Sonar analyses.
-Removed unnecessary variables.
-Removed duplicated code.
-Added String constants.
-Improvements for an array size checking.
-Refactored diamond operators for a simplicity.
Issue-ID: SO-1991
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Ia4f23210635e1ffad97eeb1d881a269fe391ff73
|
|
Updated the WorkflowAction.isConfiguration() to exclude ConfigurationScaleOutBB
problem- VF module check failure during scale out
Issue-ID: SO-1982
Signed-off-by: Bonkur, Venkat (vb8416) <vb8416@att.com>
Change-Id: I5caa6f1c5ff21131ea1c42a63b441a39f77a6e62
|
|
SDC activitySpec API returns 201 for success and 422 when already exists
Issue-ID: SO-1996
Signed-off-by: Kuleshov, Elena <evn@att.com>
Change-Id: I75837b75cbd24f4ccfb97a07e91219b3b61453f6
|
|
Fix ConfigAssign/Deploy null return of BlueprintName/Version
Issue-ID: SO-1985
Signed-off-by: sunilb <sb00577584@techmahindra.com>
Change-Id: I15b6d38a21320eae6ca58a1e3d515813b9c243fd
|
|
|
|
UPDATE these files
so/bpmn/mso-infrastructure-bpmn/src/main/resources/application.yaml
so/mso-api-handlers/mso-api-handler-infra/src/main/resources/application.yaml
should have
mso: infra:
auditInventory: false
Issue-ID: SO-1974
Signed-off-by: Bonkur, Venkat (vb8416) <vb8416@att.com>
Change-Id: I57bb396604e9eb2787122199cdf8a2d1ce54048a
|
|
Change-Id: If5a175ee26e279cf71e38c996a75fa627e5e2c00
Issue-ID: SO-1981
Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
|
|
Change-Id: If5a175ee26e279cf71e38c996a75fa627e5e2c00
Issue-ID: SO-1981
Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
|
|
Cleaned up Sonar code smells related to the duplicated
literals in loggers.
Issue-ID: SO-1932
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I58c48cec0012c42b7b892ae76c24c6a087c60c7e
|
|
|
|
Issue-ID: SO-1938
Signed-off-by: MariosIakovidis <marios.iakovidis@huawei.com>
Change-Id: I78cc401a746ef4dbca41a869729b9791210038f4
|
|
Change-Id: Ia5a37f80392693f603d6597760ca9725882de169
Issue-ID: SO-1971
Signed-off-by: waqas.ikram <waqas.ikram@est.tech>
|
|
|
|
update the onap delete vf module BB bpmn as well
validate formatting of audit tasks code changes
added a property to determine if delete audit is needed
Change-Id: Id29eed6295ed6623636a4812708e53c5ae440b83
Issue-ID: SO-1964
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
|