summaryrefslogtreecommitdiffstats
path: root/bpmn/so-bpmn-tasks
AgeCommit message (Collapse)AuthorFilesLines
2019-02-26Default fromPreload to false if noBenjamin, Max (mb388a)3-4/+4
Correct JUnit test data for default from-preload value Default fromPreload to false if no requestParameters are available. Change-Id: I20846871958226740e4a5dee90c8e31ff3bdfddf Issue-ID: SO-1572 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-24Add NETWORK_CORRELATOR on network updates asyncBenjamin, Max (mb388a)6-6/+108
added verification for mocked BpmnError add unmarshal test missing in commit add junit for NetworkAdapter Callback success/failure Add NETWORK_CORRELATOR on network updates async etc Change-Id: Ib10709ddb61011aec247e9c020b7ee7c42949118 Issue-ID: SO-1568 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-20assignvfmodulebb must send use-preloadBenjamin, Max (mb388a)5-4/+161
Corrections to JUnit data to account for usePreload usage. Resurrect usage of usePreload value and pass fromPreload to SDNC. Change-Id: I6fb52f6abf09ec501e90335a01e37db1c10ae2b3 Issue-ID: SO-1539 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-20Fixed possible NPE in WorkflowActionr.bogacki2-7/+19
NullPointerException could be thrown in case when resource == null. Change-Id: I1f78e4733187f3086ac1915d2bfb098fb8c4aabd Issue-ID: SO-1530 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
2019-02-19Create Pre Building Block validatorBenjamin, Max (mb388a)2-0/+145
Use Flowvalidator shouldRunFor method to check if flow needs to be validated. Create Pre Building Block validator to check if cloud-region orchestration-disabled is true Change-Id: I2f1dca16c97505292d9b99f7e206713e4963261f Issue-ID: SO-1534 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-19fix sonar potential nullpointerk.kazak2-17/+135
AppcRunTasks: fix potential null pointer if vnf = null AppcRunTasksTest: add tests for this case and the method itself Change-Id: I63b37670541ef5ff31b03b0336d990677b753fc5 Issue-ID: SO-1516 Signed-off-by: k.kazak <k.kazak@samsung.com>
2019-02-15Merge "updated camunda springboot version"Steve Smokowski1-2/+9
2019-02-15Merge "Process query of Network Policies from A&AI"Steve Smokowski7-16/+81
2019-02-14updated camunda springboot versionBenjamin, Max (mb388a)1-2/+9
Added required unimplemented methods to classes Change-Id: I1ab6333582f2f09c6c363786c8168fdf54936bf8 Issue-ID: SO-1512 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-14Process query of Network Policies from A&AIBenjamin, Max (mb388a)7-16/+81
Process query of Network Policies from A&AI as a NetworkPolicies object. Change-Id: I01b4c00e3732a5518ddc21d08740c0684de86d5e Issue-ID: SO-1511 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-14always increment gCurrentSequenceBenjamin, Max (mb388a)2-1/+5
always increment gCurrentSequence to properly interact with retry and rollback logic Change-Id: I7e99973682f93f891c8d35a4f3699ba17a05bc15 Issue-ID: SO-1509 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-14Merge "fix major sonar bug"Steve Smokowski2-10/+46
2019-02-14Merge "fixed CandidateType json serialization"Steve Smokowski5-61/+8
2019-02-13fixed CandidateType json serializationBenjamin, Max (mb388a)5-61/+8
fixed CandidateType json serialization Change-Id: Icafa5884db5424167c7fac08ad6aae5781bdafa5 Issue-ID: SO-1503 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-13workflow action should read config for max retriesBenjamin, Max (mb388a)2-2/+38
workflow action should also read config for max retries Change-Id: Ib0617b59ca95df7c82fb2ab54895c9c83586f02f Issue-ID: SO-1504 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-12fix major sonar bugk.kazak2-10/+46
Removed useless 'instanceof' operator as it always resolves as true Replaced it with checking for null Removed unused imports Added information about modifications on the top Added junit tests for the method Change-Id: I7a902ad2852e0ed0d507a6309857a1bab74921de Issue-ID: SO-1491 Signed-off-by: k.kazak <k.kazak@samsung.com>
2019-02-11Fix unmarshalling errorsBenjamin, Max (mb388a)2-0/+30
add data assertion to network update unit test Fix unmarshalling errors on updateNetworkResp and err Change-Id: Iddc13514198b3c89718b1b953a06cec6db190269 Issue-ID: SO-1494 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-08added license headers to various java filesBenjamin, Max (mb388a)5-0/+100
added license headers to various java files Change-Id: Icd93ba2943f9ab9a4298a7bf91a1b2e92f700e7a Issue-ID: SO-1487 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-08Merge "provide correct custIds"Steve Smokowski4-8/+167
2019-02-07mso is not updating the vip in aai for the vnfBenjamin, Max (mb388a)15-15/+477
Update JUnits for multiple invocation argument verifications Implement delete mechanism for network policies and vnf adapter params in AAI. Fix a JUnit for getNetworkPolicy(). Implement creation of network policies and setting of openstack-provided params for vf module in AAI CreateNetworkPolicies in AAI functionality update Add the plumbing for create network policy in AAI. Enable VnfAdapterBB to return fqdn and management ip info Change-Id: Id34fe088846a52dbafaf3e7c754bebada05f1bf1 Issue-ID: SO-1478 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-06improve vf module logicBenjamin, Max (mb388a)2-7/+24
remove vf module from list when calculating index Change-Id: I4b88a679eb79bfac6f25a26b10671cca4cf3c48d Issue-ID: SO-1476 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-05provide correct custIdsBenjamin, Max (mb388a)4-8/+167
correct variable name and use bean comparison included object assertion in junit on catalog client update test name to reflect return value fix cvnfc query by 2 customization uuid relationships provide customization ids to module query input Change-Id: I99df11c417230e398f86554d889a40e9d157544c Issue-ID: SO-1466 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-05logic to handle null values for vf module indexBenjamin, Max (mb388a)2-15/+60
added logic to handle null values for vf module index Change-Id: I53f4ed8b307a92187c22f19dbc7bb101d037fbd8 Issue-ID: SO-1465 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-05Merge "auto generated vf module index param"Steve Smokowski3-8/+134
2019-02-04Updated fields on sniro requestBenjamin, Max (mb388a)6-32/+32
Updated setter methods in avpn bonding classes. Updated fields on sniro request to be idenitier instead of candidate Change-Id: I67a98f742b28a93912c4b6fb05618449b629c883 Issue-ID: SO-1463 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-01compare resources from openstack to aaiBenjamin, Max (mb388a)3-0/+162
Address Review comments on pull request Update Unit test to have proper variable for testing update logic inside bpmn to reflect proper variable Update unit test to check property for audit Add flag to turn on and off audit behavior Add license headers, remove un-used files Update Building Block Tests and Activity Names Fix additional unit tests in so-bpmn-tasks layer Fix broken Junit Test, and correct Bug in if statement Add annotation to ignore class under test profile Additional bug fixes and unit tests for classes Add Additional JUNITS, add more sample data Add Openstack Audit functionality to Adapter Change-Id: I0492063271e991eefc608b56336a5cdf1d5a7778 Issue-ID: SO-1456 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-01auto generated vf module index paramBenjamin, Max (mb388a)3-8/+134
added test for when this is the first vfmodule added unit test no longer tests already created vnf refactored test to be more clear about uuid grouping Added javadoc for getLowestUnusedVfModIndex method. Increment index by vf module model invariant uuid Fix unnecessary whitespace delta for GenericVnf file Fix GenericVnf and modify junit for setting vfmodules Change-Id: Iacd31c5bf73c971c0b3c06e790d4c5193c3c9860 Issue-ID: SO-1458 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-31added list of flows to execution for cockpitBenjamin, Max (mb388a)1-2/+3
added list of flows to execution for cockpit readability Change-Id: Ia289ab59627b315320b097adaf2cf43cd5dc7543 Issue-ID: SO-1452 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-28Merge "Merge 'origin/casablanca' into master"Marcus Williams9-11/+127
2019-01-28Merge 'origin/casablanca' into masterBenjamin, Max (mb388a)9-11/+127
Issue-ID: SO-1435 Change-Id: If065ef5c91e769452fd6701fa6c28a23b4bdf2b2 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2019-01-25support alloc pool from dhcpStart/endBenjamin, Max (mb388a)3-5/+17
Fix to include alloc pool from dhcpStart End on reqs Change-Id: I6df666d80d48e1a87198b64ef7397b9c4739090a Issue-ID: SO-1427 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-25Merge "Removed deprecated Matcher imports"Steve Smokowski15-20/+89
2019-01-24Removed deprecated Matcher importsBenjamin, Max (mb388a)15-20/+89
replaced org.mockito.Matchers with ArgumentMatchers Change-Id: I2feb4d4fb314cd14aca0719c4cc29b1a0510cbf7 Issue-ID: SO-1413 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-24bugfixes jan 24thBenjamin, Max (mb388a)6-40/+104
Fix null pointer exception when no requestParameters are specified Add configurable timer in ActivateVfModuleBB to delay call to SDNC activate - Use raw slf4j logger - use {} formatting Add configurable timer in ActivateVfModuleBB to delay call to SDNC activate - Use raw slf4j logger Add configurable timer in ActivateVfModuleBB to delay call to SDNC activate - removed unused references in test class Add configurable timer in ActivateVfModuleBB to delay call to SDNC activate Update PortGroup objects separately from the parent VCE object - restore setVariable calls back into vce object - they might be needed later. Update PortGroup objects separately from the parent VCE object - updated test class extra call to get PortGroups Update PortGroup objects separately from the parent VCE object - use PortGroup.getInterfaceRole() getter method instead of accessing field directly. Update PortGroup objects separately from the parent VCE object Added back required headers for tenant isolation. removed workflow exception from outmapping in execute Fix possible null ptr exception, fix to add braces. Default networkTechnology in Update as done in Create Fix failing junits, mapper force upper case nwtech update exception builder to properly throw exception error message supporting assign service instance a la carte as well adding in proper exception handling in network rest v1 add the unassign action to R macro data file Change-Id: Ide420514f81b8083b4c76c762c064de199624cf7 Issue-ID: SO-1424 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-22validate number of uri keysBenjamin, Max (mb388a)1-3/+3
test was setting unnecessary keys on uri changed plural to singular AAI class added in validation for number of keys provided Change-Id: I86f61301aa5f2ea676678908bae1e88b86d7e570 Issue-ID: SO-1409 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-21Merge "Bug fixes from AT&T January 20th"Steve Smokowski8-53/+86
2019-01-21Bug fixes from AT&T January 20thBenjamin, Max (mb388a)8-53/+86
sorted vfmodules by base last for negative action reqs store Response in execution as String on network delete added functionality to skip rollback based on flag # Conflicts: # bpmn/so-bpmn-tasks/src/main/java/org/onap/so/bpmn/infrastructure/workflo w/tasks/WorkflowAction.java require XML in the header for delete network request Update APP-C LCM Client library version to 1.7.0. replaced wiremock style test with mockito test Handle AAIClient Exps in CreateCustomerV1 getServiceInstance() changed default status code to be configurable Replace vnfType by nfRole in the healthcheck request to SDNO. updated error messages in sdnc handler and flow status updated flow status message on completion of flow Send GenericVnf object for AAI VNF update for vnf-api updates Add a JUnit test file for SDNOValidatorImpl.java Set nodeType on the inner SDNO request as per update from SDNO. updated rollbackToAssigned logic to remove unassign flows updated sdnc handler error message for client error added exception handling for httpclienterror in sdnc out map workflow exception so error is reported throws sdnc error message on bad response from sdnc add catalog entries for TRANSPORT service delete flows change script number that was duplicate add find method to NorthBoundRequestRepository include serviceType in hash code use asterisk for all non-TRANSPORT flow db entries alacart true, rm not needed transport srvc model steps correct insert query syntax for orchestration_flow support serviceType (TRANSPORT) process flow fix SDNCAdapterException causing no callback to bpmn use JsonAlias for alternate case when deserializing GRM client will accept both "serviceEndPointList" and "ServiceEndPointList" root node in the JSON response. AAIRestClient now uses getSystemName in headers finishtime should not be returned in requeststatus Change-Id: I81a185252b057020f7f36f125c85c3357756da88 Issue-ID: SO-1403 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-20convert from sync to asyncBenjamin, Max (mb388a)11-58/+317
fixed network adapter object mapper test issues fixed all test issues and compilation issues remove setting of notification url for rollback covert sync calls for create and delete network to async removed async after from invoke sdnc adapter task remove unwanted changes that were committed earlier fix unmarshalling of response back from openstack adap added in code to throw an error when AIC issue Change-Id: Ic9fa39584ed2bcb70804fbd74586f1cc119c7d8b Issue-ID: SO-1404 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-14Add missing license headersBenjamin, Max (mb388a)17-5/+345
add headers to files which were missing them Issue-ID: SO-1390 Change-Id: I6c754f72c5d1ef6485d6343aae4b994120901d08 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-12Merge "Created sniro request pojos for homingV2 flow"Steve Smokowski14-82/+738
2019-01-12Merge "get subnet sequence number from A&AI"Steve Smokowski4-0/+47
2019-01-12Merge "Quality of Life logging improvements"Steve Smokowski1-0/+6
2019-01-12Merge "Miscellaneous fixes"Steve Smokowski2-1/+37
2019-01-11naming ms client fixesBenjamin, Max (mb388a)10-17/+182
Fixed failing unit test for request object builder Added throws declaration for IOException Changed endpoint to point to wiremock Added exception handling for httpstatuscode Reverted changes to validator Added exception handling for response from naming mS Changed how element object properties are set Changed yaml to point to naming mS dev env Began adding unit tests for naming client Change-Id: Ic753e0dbaed52065ff5c0dfc9a59a726fdbdc642 Issue-ID: SO-1387 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-11Miscellaneous fixesBenjamin, Max (mb388a)2-1/+37
updated common pom to use aai schema version 1.4.1 removed handle sync error from SDNCHandler bpmn flow added mso-request-id to in mapping of delete vnf flows moved temporary test file to temporary folder Removed obsolete genericVnfNode parameter from updateGenericVnfNode sorted vfmodules by base last for negative action reqs Change-Id: I7a5018d67292cfaac8d923ac3bd9b27ed037be57 Issue-ID: SO-1382 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-11Quality of Life logging improvementsBenjamin, Max (mb388a)1-0/+6
Remove invalid newline character in process name Quality of Life logging improvements Change-Id: I2193c08e365e847f6be144106a0b20aa7828497e Issue-ID: SO-1381 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-11get subnet sequence number from A&AIBenjamin, Max (mb388a)4-0/+47
Add AAIQuery for subnet block to CreateNetwork bpmn MSO shall get subnet sequence number. Change-Id: I5cf73d1b5344f41ac98a51274948822322e3591b Issue-ID: SO-1378 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-11Created sniro request pojos for homingV2 flowBenjamin, Max (mb388a)14-82/+738
Updated random ports to replaced in expected file response Created sniro request pojos for homingV2 flow. Change-Id: Ib2fedbc28dc048048a21eaa88601bcb0c21360f7 Issue-ID: SO-1376 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-04Bugfixes for December 2018Benjamin, Max (mb388a)11-49/+204
Changed the way that the cidr is constructed in network utils. added in the if statement to check if selflink already exists removed execution line that was not needed in pull added service instance id to workflowResourceIds for virtualLinkKey network flows wrote test for updating request to complete in db workflow action directly updates db instead of using mso complete process Increase max timeout for SDNO Health Checks dmaap. Added execution variable and corrected type and way data is retrieved to fix defect fixed retry status message in request db for #/5 updated workflowActionBBTasks for flow status message updated flow status to failed on a workflowaction fail Removed slashes and fixed rollbackStatusMessage Updated requestStatus logic for adding status messages Added junit test to validate casue of a defect and cleaned up code and logging added end timestamp to request db on complete request fixed l3Network update of orchestation status in DoUpdateNetworkInstance groovy as well fixed update of l3network orchestration status Add explicit resetting of heatStackId in A&AI to DeleteVfModule and DeleteVolumeGroup BBs. Preserve heatStackId setting in the copiedVfModule when updating the VF Module in A&AI. added functionality to skip rollback based on flag Update snapshot version for logging, add headers fixed optional of error in retrieveErrorMessage method Set heatStackId to null if we want to remove it in A&AI. added in a warn logger statement to keep track of field map network technology from l3network instead of model info for network adapter object mapper Force heatStackId value to empty on an attempt to set it to null on update updated common pom to use aai schema version 1.4.1 removed handle sync error from SDNCHandler bpmn flow Change-Id: I1bd7aa55b06d4e439000b216165c9daafeacc9a4 Issue-ID: SO-1361 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-12-19Use UUID to fill pnf-id in PNF PnPJoanna Jeremicz1-2/+0
Issue-ID: SO-1272 Change-Id: If516b7ec38dad3fbc7409aff42275a98ef2af76a Signed-off-by: Joanna Jeremicz <joanna.jeremicz@nokia.com>