aboutsummaryrefslogtreecommitdiffstats
path: root/bpmn/so-bpmn-tasks/src/main
AgeCommit message (Collapse)AuthorFilesLines
2018-11-20Enhanced Exception handling.Prema Bhatt1-4/+19
Issue-ID: SO-1182 Change-Id: Iae4a0072b637ddd0e64c4ec54421509e1c03ccc5 Signed-off-by: Prema Bhatt <pb6115@att.com>
2018-11-17Bug Fixes November 16thBenjamin, Max (mb388a)2-6/+24
fix failing junit when heatID not available provide name if ID is not present on delete op removed logic to skip unassign sdnc in rollback flows Move default settings to CrVfModRequest pojo. Check for null backout and failIfExists params - 1810. Updated exception message and test Added tests for networkCustomization not found Added tests for delete and update network Separated networkResourceCustomization and networkResource lookups Removed version check as not necessary for setting boolean Change-Id: Ia4b409244dc5ebdbb163d4a178713115719366ca Issue-ID: SO-1231 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-11-10Bug fixes November 10thBenjamin, Max (mb388a)1-1/+7
use network name on delete when heat id not present compare mod count index as Integers Change-Id: I76e567378fed83fb857d4d16b88f7a199d0df475 Issue-ID: SO-1204 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-11-07Merge "Make homingBB optinal and fix homing process" into casablancaMarcus Williams2-15/+76
2018-11-07Make homingBB optinal and fix homing processAlexis de Talhouët2-15/+76
Properly defined whether or not to call homing at AssignVnfBB where by default homing doesn't get called, but if a homing solution is provided, then we resolve the solutions. The goal is to change the BPMN definition to use serviceTask rather than a scriptTask, allowing to use the Srping component to inject logic. Also we create a new HomingV2 component that is agnostic of the homing implementation, which goal is to route the homing request to the proper bbackend implementation; e.g. oof vs homing. Finally, we remove the un-needed variables set in the execution context. Change-Id: Ic9fb2a599c6375617c92a6d3462b62921ee47a6f Issue-ID: SO-1168 Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
2018-11-06Fixing scaleOut workflow looping issuePrema Bhatt2-6/+37
Updated both GenericVnfHealthCheck and ConfigurationScaleOut BB with appropriate Exception catch block and added Exception unit test. Issue-ID: SO-1182 Change-Id: Ia29741a4a7d8e1bb759ace4fd888864141d224d6 Signed-off-by: Prema Bhatt <pb6115@att.com>
2018-11-06Merge "Removed slashes and added catch block" into casablancaRob Daugherty1-4/+6
2018-11-06Removed slashes and added catch blockBrittany Plummer (bp896r)1-4/+6
Issue-ID: SO-1183 Change-Id: Ib8581393d782f078fc844cf96cbf7a0228133581 Signed-off-by: Brittany Plummer (bp896r) <bp896r@att.com>
2018-11-05Bug fixes November 5thBenjamin, Max (mb388a)2-5/+10
building block validator test now passes added buildingblockvalidator process instance test Retrieve actual error from WorkflowExceptionErrorMessage when the error message is empty, not only when null. Propagate orchestrationStatusValidationResult values from BB to BB. corrected use of constructor for AaiUtil use AaiUtil method to create path for get call modified how allotted resource urls are constructed - Removed the findExistingVnfcInstanceGroup method. It is not required to check this because the vnfResourceCustomization is always a new object at this location. Enable multiStage VF Module Create processing only when aLaCarte flag is on. Change-Id: If8cf397a84abc290e67e287d5b2264dd226398bc Issue-ID: SO-1188 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-11-01Merge "Update Logic" into casablancaRob Daugherty1-29/+33
2018-11-01Update LogicSmokowski, Steve (ss835w)1-29/+33
Update Regex Logic to take into account new scale out URI and generate the UUID, Fix whitespace Issue-ID: SO-117 Change-Id: I1a3c3b31e18701fce3d622d501dd68efc7ab6969 Change-Id: I1a3c3b31e18701fce3d622d501dd68efc7ab6969 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-10-22Set homingService in WorkflowActionMarcus G K Williams1-0/+1
Issue-ID: SO-1153 Change-Id: I40ef5deb8699f7f0c602cb57e273c1a3dc814004 Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2018-10-19bug fixes october 19thBenjamin, Max (mb388a)2-2/+58
Fixed issue with resource version being added twice. added silent success to orch validation when unassign is not found Removed SNAPSHOT from dependency Fixed failing BBInputSetup tests Updated apih tests to use networkInstanceGroup Updated ModelType enum and fixed compilation issues Change the place where the data for multistage gets set Update treatment of PENDING_ACTIVATION VF_MODULE CREATE entries to SILENT_SUCCESS to support first stage of multistage. Implement second stage of multistage design VF Module Creation Implementation of the first stage of multistage design for VF Module creation. Change-Id: I6d76282d1f37c081355cee72797d8e13da4e3cb0 Issue-ID: SO-1149 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com> Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-10-17Bug fixes October 16Benjamin, Max (mb388a)2-0/+25
Treat the VfModule returned from PrepareUpdateAAIVfModule call as an AAI object collection create, connect instanceGroup to cloudRegion Fix a typo in the name of the method for getting a variable testing mapping of instance group role test NetworkInstanceGroup role to be SUB-INTERFACE use enum value with hyphen for subtype Some updates based on feedback to java codes updated client to use optional instead of passing null added case where client sends null due to mapping issue added generic response object and pinc returns response build relationship now correctly removes wrapper Ensure that no null object gets referenced while checking if VNF is empty. Change-Id: I6177877518475c1f2e8e4e9dbd2ad1e2f3e10d18 Issue-ID: SO-1144 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-10-17Merge "Bug fixes for casablanca"Rob Daugherty9-56/+82
2018-10-16Bug fixes for casablancaBenjamin, Max (mb388a)9-56/+82
Updated builder to use String.format Added exception specifically for issues interacting with requestdbadapter Updated exception message and added junit test case Added case to handle when homing is not called during assign vnf. include network ID for completion handler Added exception handling for saving to requestdb added null check to mdc and interceptors to sdnc cxf confirm subnet map is not null in adapter response shallow copy subnet before AAI udpate update AAIObjectType to use uriTemplate extract subnet data from adapter response update correct AAIObjectType for subnet query update subnet(s) in AAI on network create completion updated how request db is set to failure in workflowA updated in and out mapping to be generalBuildingBlock change source out mapping to generalBuildingBlock Use explicit conversion to JSON to read cloudConfiguration settings. Use explicit conversion to JSON to read cloudConfiguration settings. Correct the name of DeleteVfModuleBB subprocess. Write the returned value from Homing to gBBInput updated unit test coverage for update network sync subnet status with network update Added WorkflowException to out mapping which will trigger an exception to be thrown when populated. Correct the payload for HealthCheck APP-C Action to remove escaping and change parameter name. Added WorkflowException to out mapping which will trigger an exception to be thrown when populated. Commit a change that was not staged in previous commit updated arguments to getConstructor method forgot to extract throwable from Optional object added throwable constructor to createException fixed broken unit test and added a new test and method set the network technology in the network request remove namespace from added networkId payload element - Updated SDWan test case to check the database to make sure the VNFCustomization object exist. - Updated code to only loop in iNotif.getResources() for VF resources, all others are unnecessary and were causing issues with the Service object. - Removed modifiedHeatTemplate variable since this isn't needed in the ONAP code base. Make sure vnfResponseCode variable is set to 200 when VNF is correctly retrieved from A&AI. VRR VRRCreateVfModule - send availability_zone to SDNC Infra Assign request Safeguard the retrieval of Boolean setting for isRollbackEnabled. Set isRollbackEnabled to opposite of suppressRollback early on in the execution. Reverse suppressRollback value to pass as backout parameter to VNF Adapter Add the exceptions to the calls to aai client queries Correct retrieval of the object from Optional for A&AI queries. Change-Id: I7d22e621b0316c14ce61bd51a9d5753473622697 Issue-ID: SO-1134 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-10-15cloud owner support for SDNC interfaceBenjamin, Max (mb388a)3-0/+3
added cloudOwner to SDNC gr api payloads Change-Id: If8351ab9078bd0c0f503acdf21622d615eb5a5ab Issue-ID: SO-1137 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-10-12Dynamic Cloud Owner SupportBenjamin, Max (mb388a)9-19/+78
added in cloud configuration object to request params Fix Bean scanning so it picks up the resttemplate removed unnecessary RestTemplate Bean configurations corrected typo in CloudConfiguration class updated gr api test cases with dynamic cloud owner updated groovy files to allow for dynamic cloud owner values updated GR API layer to include cloud owner added enum for default cloud owner add cloud owner variable to camunda in mapping removed references to att-aic from BBInputSetup updated aai schema dependency to 1.3.1 from 1.3.0 Fixed incorrect type AAIUri and updated logging in the method. use existing service instance id instead of generating Pass cloudOwner to process to propagate to subprocesses. NOTE: our aai-schema dependency is 1.3.1-SNAPSHOT to be compatible with the cloud owner changes here. The releaesed 1.3.0 version is NOT compatible. Change-Id: I43b46774b77981d1c8bfe7c7a79b9434889e62ae Issue-ID: SO-1128 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com> Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-10-09Fix rollbackBenjamin, Max (mb388a)2-36/+60
removed useless error handling test case from workflow changed method name and added junit coverage to errors added max retry and success status after completed bb added assertion that global count var was reset to 0 updated rollback to reset current sequence count var revert the other change and fix the rollback logic instead fixed current sequence and updated rollback code Change-Id: Ifd3282de1dbda8b36d4d89e5b7135ad464a9b963 Issue-ID: SO-1107 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-09-21Merge "various bugfixes for casablanca"Rob Daugherty3-40/+43
2018-09-21Merge "Add Java OofClient"Byung-Woo Jun14-0/+1835
2018-09-20Merge "Add homing flag to alacart flows"Rob Daugherty1-0/+13
2018-09-20Add homing flag to alacart flowsMarcus G K Williams1-0/+13
Issue-ID: SO-745 Change-Id: I5e9e5031be403d17e0dc141a0879b0a28062168e Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2018-09-20various bugfixes for casablancaBenjamin, Max (mb388a)3-40/+43
fixed unit tests after addition of A&AI edge label added option for edgelabel between vnf inst group added belongs to in connecting a vnf to instance group - Adding test for getRainyDayHandlerStatusByFlowNameAndServiceTypeAndVnfTypeAndErrorCodeAn dWorkStep method in the catalogdb client correct default RainyDay table search input updated custom resolver to include float and added comment to explain timestamp configuration added a custom resolver and updated snake yaml version Replacing bowman client with restTemplate.exchange | Add Accept and Content-Type to headers Removing the unused imports as well Implementing some review comments for hte tests being ignored Replacing bowman client with restTemplate.exchange |Fixing Junits Replacing bowman client with restTemplate.exchange | Making Data inserts to go specifically in requestDB Replacing bowman client with restTemplate.exchange | Adding Junits Replacing bowman client with restTemplate.exchange | Adding Junits Replacing bowman client with restTemplate.exchange | Adding Junits Replacing bowman client with restTemplate.exchange - Updated tosca parser version to 1.4.3 and upgraded vnfc test case with new csar to pass with latest parser code. added test case for when workflow has not called all flows fixed issue with rollback and retry in workflowaction Reverted homing changes and changes assign vnf to use the homing produced GeneralBuildingBlock. fixed unit test to build the correct format hashmap reverted extraction back to LinkedHashMap marshal sdnc output to an object removed unused variables and imports extract response code/message from embedded map add junits to parse SDNC assign response removed missed org.openecomp.mso imports from bpmn Change-Id: Ib2b6591a744ecb5b08c522494cdf1ad7dae18a08 Issue-ID: SO-1069 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-09-20Merge "Activity for Flow Completion Status"Rob Daugherty1-0/+80
2018-09-20Activity for Flow Completion StatusElena Kuleshov1-0/+80
Add a JUnit for existing workflow exception Changes to base test to include flowCompletionTasks Workflow Designer - implementation of Completion Activity Change-Id: Id80a92f97603c10a40ef401522a05a52d976247e Issue-ID: SO-843 Signed-off-by: Elena Kuleshov <EK1439@att.com>
2018-09-20Update LoggingSmokowski, Steve (ss835w)2-53/+35
Update logging to meet Casablanca Spec Change-Id: I029d6c63765992d6f091d96e2b4c34c60d30c484 Issue-ID: SO-947 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-09-19Merge "Workflow Activities Execution Environment"Rob Daugherty1-0/+144
2018-09-19Add Java OofClientMarcus G K Williams14-0/+1835
Issue-ID: SO-745 Change-Id: I8c49c573b18d4b7a9e93f7627dc3d1a1e6e71432 Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2018-09-19Workflow Activities Execution EnvironmentElena Kuleshov1-0/+144
Add a license header to ExecuteActivity.java Fix a JUnit by modifying the values for the expected variables. BBInput changes to support CM flows Implement JavaDelegate for activities execution Change-Id: I9cfc51241d414b85441d1a8443a950b97d14b65f Issue-ID: SO-827 Signed-off-by: Elena Kuleshov <EK1439@att.com>
2018-09-19Workflow Designer Activities ImplementationElena Kuleshov1-0/+171
Logging changes and error message fixes for runAppcCommand() added unit test and removed catch blocks Workflow Designer Activities Implementation Change-Id: I22d3d95541708ddc9e2617a92085b0d4c16caad9 Issue-ID: SO-829 Signed-off-by: Elena Kuleshov <EK1439@att.com>
2018-09-17Merge "more stability fixes"Marcus Williams6-21/+46
2018-09-17more stability fixesBenjamin, Max (mb388a)6-21/+46
Remove conditional to not check VNF topology add empty string verification for serviceName field Add junits for CNRCR and NtwkAdptr changes. Add search in new CollNtwkResCust tbl to get NtwkResource. - Updated test data files to include 'pre-load' flag in both VfModuleOperation and NetworkOperation json test data files. - MSO to not to send <preload>boolean</from-preload> to SDNC in network-topology-opertion and vf-module-topology-operation. Updated GeneralTopologyObjectMapper to set 'from-preload' to null so that elements with Nulls are not sent to SDNC. Updated buildNetworkInformation() and buildVfModuleInformation() methods. update flow stats to not cause bpmn flow to crash Fix headers so SDNC does not return XML Add implementation of deleteVolumeGroupResponse parsing; fix JUnits that worked by accident. Change-Id: Ia96d552d731e112505fcf739029a6fd4d0134546 Issue-ID: SO-1061 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-09-17Fix SDNC ParseSmokowski, Steve (ss835w)2-4/+12
Fix to use proper wrapper bean to fix marshalling Change-Id: Iec167059557cbf73236f3efad9a9780571a0468e Issue-ID: SO-1056 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-09-13Stability fixesBenjamin, Max (mb388a)7-41/+70
sdnc now logs the full response message as a json removed erroneous encoding of variables with full XML Return created network from getVirtualLinkL3Network added exception logger to workflowaction aai check Check for null value for vnfcPorts before referencing it Added test case for invalid camunda response Changed to use updateStatus method Added saving for currentActiveReq and test for 401 resp Change JUnit to use expectedException and clean up unused items. Add vfModuleId to the exception message for missing model info. Report an error if VF Module model info is expected but is null. - Just renamed the Cvnfc and Vnfc set names - Updated code to check for duplicate VNFC's across multiple modules in the same VNF. - Removed commented out if statement line for ALLOTTED_RESOURCE - Reinitialize the Cvnfc and Vnfc Sets each time we iterate the VFModule loop. This will avoid the concurrent modification exception. Eliminated Ben from the sample request Changed to use else if for null check Added null check before catdb call and test case Fix implementation of a call to VNF Adapter for DeleteVolumeGroupBB. Update the method to no call save and do a put Revert usage of PUT method, use save instead Change-Id: I9f69fb68d0639c23b8e1de6931938119bd3ac54b Issue-ID: SO-1032 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-09-12Merge "Update GenericHealthCheck to send vnfHostIpAddress"Rob Daugherty1-0/+2
2018-09-12Update GenericHealthCheck to send vnfHostIpAddressPrema Bhatt1-0/+2
Change-Id: Ia0adb8784e81001ca0b54bfa62b12f28060114cf Issue-ID: SO-1024 Signed-off-by: Prema Bhatt <pb6115@att.com>
2018-09-10updated create task BBBenjamin, Max (mb388a)3-24/+73
updated aai create task test to verify creation of obj updated assignfabricconfig bpmn test with extra task added junit test in aai config resources vfmod and vnfc workflowaction passes more config id info to execute updated assign config to connect objects in aai config Change-Id: I19468f2bb83f4509e87d380a7c98a9f19358e1ef Issue-ID: SO-1001 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-09-08added generic fabric support to SOBenjamin, Max (mb388a)10-110/+158
Fix Autoincrement of ID field in table Fix accidental removal of method Update usage of requestdb client removed unused imports in common tasks and test Fix broken branch, have unit tests pass references the Epic branch Fix broken branch from compiling committing classpath for vfc adapter cause its not going away added in the fail case for when there are no profiles removed second set of adapters in application test yml removed double adapters in request db application test added jpa repo dependency to the so bpmn folder pom add creation timestamp column to the table added in null checks for Config returned from policy switched to string in requestprocess with jenerate switched to string in requestprocess with jenerate updated aai version in common pom to 605 from 591 renamed the db scripts for flyway sync to register added endpoint to application test yml for failing test ... Change-Id: I800f837ea75d7cdff740dc3a387e4d7654cfd085 Issue-ID: SO-972 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-09-04Added ConfigurationScaleOutBB, tasks, and testsBrittany Plummer (bp896r)1-0/+144
Issue-ID: SO-765 Change-Id: I7e0e902f00417b8c2439962f9ebfed6cc117a86e Signed-off-by: Brittany Plummer (bp896r) <bp896r@att.com>
2018-08-29 Sonar reported Vulnerability in AAIObjectMapperGOPINATH MATHIVANAN1-3/+4
Fixed Sonar reported Vulnerability in AAIObjectMapper file Issue-ID: SO-929 Change-Id: I8b47a7c80bf35007e2f48efb447cdb5fa60beadc Signed-off-by: GOPINATH MATHIVANAN <gopinath.mathivanan@in.ibm.com>
2018-08-28Added GenericVnfHealthCheckBB, tasks, and testsBrittany Plummer (bp896r)1-0/+103
Issue-ID: SO-777 Change-Id: I8a46f1802feb18ab4df098472fef5373ac42208b Signed-off-by: Brittany Plummer (bp896r) <bp896r@att.com>
2018-08-24retired flows no longer in useBenjamin, Max (mb388a)1-34/+1
corrected spelling for migration sql file delete 1802-style flow, MSO to create l3network in AAI Revert "retire 1802-style flow, MSO to create l3network in AAI" retire 1802-style flow, MSO to create l3network in AAI Change-Id: I0a63d086891565c2346424a3d1b49ce974f5db24 Issue-ID: SO-901 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-08-23Prod fixes August 21stBenjamin, Max (mb388a)5-8/+19
changes required for unit tests to pass again Changes sniro homing BB license demand to be a named array per sniro defect. boolean checks must now account for null fixed compilation issues in code updated tests and removed primatives from bbobjects upgraded to A&AI dependency with Boolean Change-Id: I5f3e69c0ad24d2c3e4591568467bad861abd0261 Issue-ID: SO-896 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-08-23Merge "write update status of BBs progress"Rob Daugherty1-0/+39
2018-08-23Merge "Do not serialize AAIResultWrapper"Rob Daugherty1-30/+14
2018-08-23Merge "Prod fixes August 18th"Rob Daugherty4-3/+12
2018-08-23Do not serialize AAIResultWrapperBenjamin, Max (mb388a)1-30/+14
fixed a broken building block bpmn test removed serialization of result wrapper Change-Id: I24a9b325e5543cb11b0dee4ae3a1e6957469e87a Issue-ID: SO-894 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-08-23write update status of BBs progressBenjamin, Max (mb388a)1-0/+39
added in the missing bpmn file change add implementation to update status of BBs progress Change-Id: If913b4e4da2a548e7b5660be947721cb17c60d3f Issue-ID: SO-890 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-08-23fixed filter of configuration flow callsBenjamin, Max (mb388a)1-0/+7
fix filtering of configuration flow calls Change-Id: I80f25d1b78b7268f92cb78b70f350ede100fe35e Issue-ID: SO-888 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>