aboutsummaryrefslogtreecommitdiffstats
path: root/bpmn/so-bpmn-tasks/src/main
AgeCommit message (Collapse)AuthorFilesLines
2019-12-05serviceinstanceid being overwritten by vnfid inPlummer, Brittany1-4/+12
Added check for vnfReplace before setting serviceInstanceId Added test to make sure serviceInstanceId is not overwritten Removed unused action import from WorkflowAction Formatted WorkflowActionTest to fix build failure Issue-ID: SO-2553 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I04cc668d4afbecd67b169f4e9d357ffc68cab02a
2019-11-15updated uri regular expression to support resumeSmokowski, Steven1-5/+7
updated uri regular expression to support resume Issue-ID: SO-2522 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I0a44a374d46c7b3892acabe31c0621d37103b37a
2019-11-08fix wrong handling of checking null valuesLukasz Muszkieta1-15/+19
Checking null values is handled by catching null pointer exception, this is not acceptable. Change-Id: I0c43bc8853b67579a50bc9e69c599b93b978f741 Issue-ID: SO-2187 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-11-04Merge "Adding preload capability using userParams"Steve Smokowski8-44/+246
2019-10-28Merge "General sonar improvements"Lukasz Muszkieta1-5/+0
2019-10-28General sonar improvementsArindam Mondal1-5/+0
+) Format logger witth log formatter ++) remove unused imports Issue-ID: SO-2381 Change-Id: If8b8f2377ae3b7c8d8a270792eaf99a04cfa7ef0 Signed-off-by: Arindam Mondal <arind.mondal@samsung.com> Signed-off-by: arind.mondal <arind.mondal@samsung.com>
2019-10-23Adding preload capability using userParamswaqas.ikram8-44/+246
Change-Id: Id107f2c9c2da643ecb57daaef26dfa2bfd89f8aa Issue-ID: SO-1635 Signed-off-by: waqas.ikram <waqas.ikram@est.tech>
2019-10-22Merge "add junit coverage and sonar fix"Steve Smokowski2-5/+13
2019-10-21Fortify scan reports vulnerability onGamboa, Gilbert1-0/+3
Fortify scan reports vulnerability on SDCRequestTasks.java. Recommends to set following features on XML factory factory.setFeature("http://xml.org/sax/features/external-general-entitie s", false); factory.setFeature("http://xml.org/sax/features/external-parameter-entit ies", false); factory.setFeature("http://apache.org/xml/features/disallow-doctype-decl ", true); Issue-ID: SO-2465 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I33d9b16e8836af102523d7d6bc3fc7c2a09d5b64
2019-10-18add junit coverage and sonar fixLukasz Muszkieta2-5/+13
Change-Id: I80632046b259cd75b0ab57e2c7bf673c3d021bcd Issue-ID: SO-1576 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-10-09Merge "mso should not send content type http header to"Steve Smokowski2-5/+7
2019-10-09Merge "Add model info on CHANGEASSIGN req to SDNC"Steve Smokowski1-0/+4
2019-10-09Improved error handlingMichaelMorris1-3/+6
Change-Id: Iac436f6a950bf61ac6321ef1d427a7bb14774e30 Issue-ID: SO-2395 Signed-off-by: MichaelMorris <michael.morris@est.tech>
2019-10-07Add model info on CHANGEASSIGN req to SDNCKuleshov, Elena1-0/+4
Add model info on CHANGEASSIGN req to SDNC Issue-ID: SO-2397 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Ieaf61e065273581512d797055dd7aef6f2a942d7
2019-10-04bug fix with wrong json handling in ConfigAssignVnfLukasz Muszkieta1-4/+5
Change-Id: Ib1a51a69bf421e33e439da6f1cb0abafd760cca2 Issue-ID: SO-2382 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-10-01Improve fall out case handlingSmokowski, Steven4-4/+6
Update Openstack adapter to handle fall out cases with greater stability Issue-ID: SO-2376 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I20116cbd3b63bb29c9bf4ed99e92bd5f2b691da5
2019-10-01mso should not send content type http header toPlummer, Brittany2-5/+7
Updated getHeaders to not add Content-Type header on GET requests Updated getHttpHeaders boolean to includeContentType Issue-ID: SO-2366 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I476bf02791d699cda2ca4118c8f578c96461097e
2019-09-26Set WorkflowException on BPMN WF errorElena Kuleshov1-1/+3
WorkflowException needs to be set when execution of a custom workflows fails due to an error from BPMN Issue-ID: SO-2369 Signed-off-by: Kuleshov, Elena <evn@att.com> Change-Id: Ie5ab66105681588000693fdbb3ca89310aee8a7c
2019-09-25Merge "sdn post 1908 rollback and resume mso should"Steve Smokowski2-1/+14
2019-09-24Update Resume Logic and Add Workflow ListenersSmokowski, Steven2-14/+11
Updated with the error log messages Changed the code to do string compare for eventName update workflowaction to only persist if not resume Issue-ID: SO-2363 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I139f2427ae0f0253a15cc51003318686568cb514
2019-09-24sdn post 1908 rollback and resume mso shouldGamboa, Gilbert2-1/+14
Do not remove UnassignFabricConfigurationBB when rolling back to created Do not remove UnassignFabricConfigurationBB when rolling back to created. Added unit test. Enhace error message for unassign and deactivate fabric flows if they fail during rollback Looks like a bad whitespace in pom file Updated rollback failure message for fabric. Added unit test and robot tests. Issue-ID: SO-2364 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I72d570826ade865e9c12ca7571b01cccbe920865
2019-09-23Merge "Fix default homing"Marcus Williams1-23/+23
2019-09-20Merge "Exception string in checkRelationshipRelatedTo"Steve Smokowski2-2/+20
2019-09-19Exception string in checkRelationshipRelatedToBhatt, Prema2-2/+20
Exception string in checkRelationshipRelatedTo not being returned properly. Added a new exception - UnassignNetworkException. Added a new unit test to test the exception case as per review comment. Updated UnassignNetworkBBTest.java file to fix the formatting errors. Updated unit test , removed setVariable, it wasn't needed to do as it was performed in the actual method call. Updated pom.xmp file to fix the formatting errors. Updated pom.xml file to fix the formatting errors. Issue-ID: SO-2346 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I617dfbcb07d6080598a3ef8138aad5c7008dcee2
2019-09-18Fix default homingkurczews1-23/+23
Issue-ID: SO-2307 Change-Id: Iee2562c6f38a440006d3a6108ce6f6fd6dbedcf6 Signed-off-by: kurczews <krzysztof.kurczewski@nokia.com>
2019-09-17Merge "Build payload APPC parameter from UserParams"Steve Smokowski1-0/+21
2019-09-16Use the configurationId associated to vnfc ifBonkur, Venkat1-1/+13
Use the configurationId associated to vnfc if present. removing the autowiring of the Configuration bean class Issue-ID: SO-2343 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I29f8f9e50ed04014f74b7f6dfaa2cdedb2f334d0
2019-09-12Build payload APPC parameter from UserParamsElena Kuleshov1-0/+21
If a payload parameter is not specified on VID request for APPC interaction, we will need to build it from UserParams from requestCOntext. Issue-ID: SO-2311 Signed-off-by: Kuleshov, Elena <evn@att.com> Change-Id: Ie6affe2bad031d80c43c0358a49cb252fb04f5e2
2019-09-11Merge "Integrate Logging Library"Steve Smokowski4-30/+31
2019-09-11Merge "Set payload to empty when it is not specified"Seshu Kumar M1-2/+5
2019-09-11Merge "fix of the instanceParams adding to the CDS request"Seshu Kumar M1-29/+65
2019-09-11Fix sonar issuesParshad Patel4-13/+32
Either log or rethrow this exception Make "attributeValue" transient or serializable "attributeName" is already a string, there's no need to call "toString()" Issue-ID: SO-2226 Change-Id: If6ae623202f2c243d73839d0aaefba5ba5c50dd4 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2019-09-10Set payload to empty when it is not specifiedElena Kuleshov1-2/+5
Handle a case of non-existent payload and improve error reporting on APPC request construction Issue-ID: SO-2300 Signed-off-by: Kuleshov, Elena <evn@att.com> Change-Id: I93a1ac8ebfcaa0e39b26130e601d3b657cbed503
2019-09-10Merge "Add SO Update to default the controller type query as "APPC" instead ↵Seshu Kumar M1-1/+7
of null."
2019-09-10Integrate Logging LibraryPlummer, Brittany4-30/+31
Updated SO to use ONAP provided filters and constants to meet logging standards. Removed redundant classes Updated constant references Issue-ID: SO-2301 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Ia4e3c2b1a4dcb3881aa34d39885c8b2782880d64
2019-09-10Merge "Added ACTIVATED Orchestration Status same as"Steve Smokowski1-29/+0
2019-09-09fix of the instanceParams adding to the CDS requestLukasz Muszkieta1-29/+65
Change-Id: I3bff9b5cac47d5fa29fbe503e2c3752a2b207aab Issue-ID: SO-2208 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-09-08Added ACTIVATED Orchestration Status same asSangalang, Felix1-29/+0
Added ACTIVATED Orchestration Status same as ACTIVE. Issue-ID: SO-2284 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Ia62b7ad228d80f3690c3748587a41ee2dc486087
2019-09-05Set AAIClient on AAIValidatorImplElena Kuleshov1-0/+3
AAIValidatorImpl requires setting an initialized AAIClient before validation calls Issue-ID: SO-2286 Signed-off-by: Kuleshov, Elena <evn@att.com> Change-Id: I254e8e01812e47af2855e1c1afaa5904ed792d22
2019-09-04Merge "Fix rollback for ConfigAssignBB"Max Benjamin1-6/+6
2019-09-04Merge "fix create call to A&AI"Steve Smokowski1-1/+1
2019-09-04General Sonar fixesArindam Mondal7-13/+1
+) Make field transient or serializable ++) Organize imports Issue-ID: SO-2273 Change-Id: I04eeb02c4052e3a790db865b59f873694fc1514d Signed-off-by: arind.mondal <arind.mondal@samsung.com>
2019-08-30fix create call to A&AIGamboa, Gilbert1-1/+1
createIfNotExists should be used rather than create Issue-ID: SO-2269 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I03af6a83460acbb1d7bde01f108d2a5a03d05adf
2019-08-29Update requestStatus to FAILED on activity error.Elena Kuleshov1-1/+6
Update status and related fields in Requests DB on activity error, add a junit to verify error reporting. Issue-ID: SO-2263 Signed-off-by: Kuleshov, Elena <evn@att.com> Change-Id: I1a2e97afb95e4510b4860486c2b7836b014f990e
2019-08-29Fix rollback for ConfigAssignBBMunir Ahmad1-6/+6
Issue-ID: SO-2266 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca> Change-Id: Iff2faa9f9b919818c4a5f98a62ec2a66ee7589e4
2019-08-26Javadoc and logging improvementManamohan7-10/+219
Added Javadocs and logging for these classes. Change-Id: I26dd974357cfb9ccaed3f9afd0510dc07e9bc33e Issue-ID: SO-2052 Signed-off-by: Manamohan <MS00534989@Techmahindra.com>
2019-08-22Fix issue in so-bpmn-tasksParshad Patel2-49/+61
Either log or rethrow this exception Define a constant instead of duplicating this literal Move the string literal on the left side of this string comparison Issue-ID: SO-1841 Change-Id: I828e744be9e71b84d85850d56373e921c174d26b Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2019-08-21Merge "Javadoc and logging improvement"Seshu Kumar M4-8/+33
2019-08-16Merge "Add retrieval of vmIds and vServerIds for APPC"Steve Smokowski2-3/+81
2019-08-16Javadoc and logging improvementManamohan4-8/+33
Added Javadocs and logging for these classes. Change-Id: I365fc0677c0d5136e4579de3947d0478b26c22d3 Issue-ID: SO-2052 Signed-off-by: Manamohan <MS00534989@Techmahindra.com>