Age | Commit message (Collapse) | Author | Files | Lines |
|
Improvements in SniroHomingV2 according to the Sonar analyses.
-Removed unnecessary variables.
-Removed duplicated code.
-Added String constants.
-Improvements for an array size checking.
-Refactored diamond operators for a simplicity.
Issue-ID: SO-1991
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Ia4f23210635e1ffad97eeb1d881a269fe391ff73
|
|
Change-Id: If5a175ee26e279cf71e38c996a75fa627e5e2c00
Issue-ID: SO-1981
Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
|
|
Cleaned up Sonar code smells related to the duplicated
literals in loggers.
Issue-ID: SO-1932
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I58c48cec0012c42b7b892ae76c24c6a087c60c7e
|
|
update the onap delete vf module BB bpmn as well
validate formatting of audit tasks code changes
added a property to determine if delete audit is needed
Change-Id: Id29eed6295ed6623636a4812708e53c5ae440b83
Issue-ID: SO-1964
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
enums are now single item per line
Change-Id: I6330ea4a9093071457dd47b95b6ed3bb7f8312e7
Issue-ID: SO-1970
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
unit test for the method that creates subnets
Remove project name from junit test data
Handle multiple host routes correctly for networks
Change-Id: I537b9bbb68c11901c06ed2366591cedeb3b29acd
Issue-ID: SO-1961
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
fix unit test now that method does not update status
Remove update of request status, should not be done
Change-Id: I17958ef76ccfa059893da0c2bcea1baa124d6922
Issue-ID: SO-1915
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
Renamed variable from contin to flowShouldContinue.
Updated bpmn junits and exceptionbuilder junits.
Updated bpmns to use non interrupting escalation event.
Altered bpmn and audit behavior on delete vf module
Change-Id: I4ade4c934a9193099cfd29d740c68e60633c03e5
Issue-ID: SO-1896
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Removed/Cleaned-up unnecessary lines/codes.
Updated junit tests for END_TIME to any(Timestamp.class).
END_TIME is not populated by bpmn when rainy day retry or rollback is
executed.
Change-Id: I614d66ca767629bf43aac8eee981423e5393015e
Issue-ID: SO-1887
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
Remove unused logger,replace type specification sdnc beans and mapper classes
Issue-ID: SO-1490
Change-Id: I9a671f0ade5b86dbfd4cce1fbc6c07c0fdcf38a8
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
|
|
|
|
|
|
|
|
|
|
with constants as per guidelines. Issue-ID: SO-1490"
|
|
according to the guidelines. Issue-ID: SO-1490"
|
|
|
|
Set initial OrchestrationStatus of Configuration object to Inventoried
After Assign call, we need to set the configuration orchestration status
to Assigned
Change-Id: I4abaeb18d1d220b2bdd03269b3b5a2aba478bf64
Issue-ID: SO-1796
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Change static string litrals name according to the guidelines.
Issue-ID: SO-1490
Change-Id: Iadabb204c5615f3bc559076999429bc0b9f615f6
Signed-off-by: h00397475 <hena.choudhury@huawei.com>
|
|
Replace repeated string literals with constants as per guidelines.
Issue-ID: SO-1490
Change-Id: Iffd4f5349f5e5c11daeb2ec76a75125c38a3e867
Signed-off-by: h00397475 <hena.choudhury@huawei.com>
|
|
Enhanced sniro BB to account for sole service proxies to support 1908.
Change-Id: I4bf57c7c43de755be03d2284cde321d182255ceb
Issue-ID: SO-1790
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Constant is defined and used further instead of using the same literal.
Issue-ID: SO-1490
Change-Id: Icabbd5074d8fb72643b8b73eba78d11507eefe1a
Signed-off-by: h00397475 <hena.choudhury@huawei.com>
|
|
avoid repeated use of literals Issue-ID: SO-1490 bash: c: command not found"
|
|
Constants are declared and used in place of literals
Issue-ID: SO-1490
Change-Id: I674b250fa3e141deea5c4b6c43d6fa94733f0b67
Signed-off-by: h00397475 <hena.choudhury@huawei.com>
|
|
|
|
|
|
Defined constants to avoid repeated use of literals
Issue-ID: SO-1490
bash: c: command not found
Change-Id: I6e3808fc462c9c87f5cfbe81f39aad3187b49930
Signed-off-by: h00397475 <hena.choudhury@huawei.com>
|
|
Defined a constant instead of repeatedly using literals.
Issue-ID: SO-1490
Change-Id: I4fc4eddeebf42436d6198ba92d7c8bfa8f3394b0
Signed-off-by: h00397475 <hena.choudhury@huawei.com>
|
|
Remove unused private field and replace repeated string with constants.
Change-Id: I2e68cfb5e7d83e626cb2e274b7ea2989352f2867
Issue-ID: SO-1490
Signed-off-by: h00397475 <hena.choudhury@huawei.com>
|
|
Remove unused local variables from class files.
Issue-ID: SO-1490
Change-Id: I8d0a39183883d97ab54ea04ce62f520247958a48
Signed-off-by: h00397475 <hena.choudhury@huawei.com>
|
|
|
|
|
|
|
|
|
|
|
|
Replace type specification,Remove unused import sniro beans
Issue-ID: SO-1490
Change-Id: Ic7d96ccc79db3cee839cc230dd69121ab6796e88
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
|
|
Remove unused logger,replace type specification sniro beans classes
Issue-ID: SO-1490
Change-Id: I02602de39507e80227336a4964a7a9a9c8cbfb85
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
|
|
Move String literal to left-hand side of equals SniroValidator class
Issue-ID: SO-1490
Change-Id: Ib9d1ba94908f92cc46cf5a8177e3808327398600
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
|
|
Substitute string literal with constant SO client sdnc classes
Issue-ID: SO-1490
Change-Id: Iada1dedfb27ec75946ba5bad23547a2fd8c4ae39
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
|
|
Change-Id: I0d8ab71393935ca791d37bb23340f96b921f5505
Issue-ID: SO-1791
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Remove unused logger client orchestration classes
Issue-ID: SO-1490
Change-Id: Ic36e7a33e35f28cc202614c3eee2dd1945f1aefe
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
|
|
|
|
|
|
|
|
Remove unused imports, logger client orchestration classes
Issue-ID: SO-1490
Change-Id: Id594765483cd46f2c73562c621ca637eba133476
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
|
|
Remove logger, unused import client orchestration classes
Issue-ID: SO-1490
Change-Id: I76edd3a0aaafdbe54a632cfea419c8593275cc3d
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
|
|
Change variable name to match regex,remove logger AAIVfModuleResources
Issue-ID: SO-1490
Change-Id: I4f79977324bf9572c58faf99d3c9209da42f2f20
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
|
|
Change variable name to match regex AAIServiceInstanceResources
Issue-ID: SO-1490
Change-Id: Ifd0179788d4d3d024e352629f0921e5771065570
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
|