summaryrefslogtreecommitdiffstats
path: root/bpmn/so-bpmn-tasks/src/main
AgeCommit message (Collapse)AuthorFilesLines
2019-06-27Merge "improved logging when no exception data is found"Steve Smokowski1-1/+5
2019-06-27improved logging when no exception data is foundBenjamin, Max1-1/+5
improved logging when no exception data is found Change-Id: I4f6298652ad474119cd1ebc58a927d532ea3e6be Issue-ID: SO-2068 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-27Fix macro delete instance bug.Gamboa, Gilbert1-1/+3
Fix macro delete instance bug. vf-modules not being sorted correctly because isbaseboolean field is not being set. Change-Id: Id196e152977d922bee6c9bb797ad240bb70fbf47 Issue-ID: SO-2053 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-25Merge remote-tracking branch 'origin/dublin' into 'origin/master'Benjamin, Max (mb388a)1-2/+3
Change-Id: I2b91332563d9c7b0f469c9e45a35cc1376465c5e Issue-ID: SO-2058 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-21fix jenkins buildLukasz Muszkieta1-2/+2
format AbstractRestHandler.java file Change-Id: I6f0025ba2a542e2476ee694b40ed670a9e02f2f3 Issue-ID: SO-2044 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-06-20Merge "Sonar fix too many method param"Steve Smokowski2-21/+179
2019-06-18nullpointer in vnfadaptervfmoduleobjectmapperBhatt, Prema3-3/+27
Added code block to throw exception when we get a 'Name' wthout a 'Value' tag in the SDNC vf-module-topology. Right now we are seeing oam0_net_id is missing a value tag. Added Unit test to test this code change. Change-Id: I765d5a4eb9d351b7613d4c3561a2a5dbe37e4781 Issue-ID: SO-2031 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-18Fixed critical Sonar bugsr.bogacki1-7/+8
Fixed critical bugs according to the Sonar analysis. -Fixed possible NPE. -Fixed wrong comparison. -Removed unused variables. Issue-ID: SO-2025 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I5e2e5413c8421eb7ed1db21de6d888a50e1db689
2019-06-16Validate ServiceInstance name using createNodesUriSangalang, Felix2-4/+14
Validate ServiceInstance name using createNodesUri. Change-Id: I5194dd933dc98064888250bc9a38e6ee9716fc01 Issue-ID: SO-2024 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-15Merge "Validate names before writing to A&AI"Max Benjamin4-0/+43
2019-06-15Merge "update multi stage code to accurately skip bbs"Max Benjamin17-70/+369
2019-06-14Merge "support async operation for vf module operations"Steve Smokowski9-59/+91
2019-06-14Validate names before writing to A&AISangalang, Felix4-0/+43
Validate name for InstanceGroup, Configuration and Network. Change-Id: I494749e17a40c6c0cdd51dd28d9c9bca371410ac Issue-ID: SO-2022 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-14mso to validate the name uniqueness in A&AIGamboa, Gilbert4-0/+47
Need to change query by name using nodes query to make sure names are globally unique. Added new Exception type for duplicate A&AI object names. Added tests for AAIVfModulResources. Change-Id: I71558d0881d7060819f5f807fe58779be6edfa6f Issue-ID: SO-2020 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-14update multi stage code to accurately skip bbsBenjamin, Max17-70/+369
moved around classes to packages that make more sense updated license headers in java files converted MultiStage logic to FlowManipulator moved tests to new package location and fixed issues allow for custom listeners before flowsToExecute moved validation classes to listener.validation Change-Id: Ic5416812ef9c5611fe19bf9b6aa316373b110ec6 Issue-ID: SO-2021 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-14support async operation for vf module operationsSmokowski, Steven9-59/+91
support async operation for vf module operations with sdnc Update Junit comparison data to be valid for new code Modify coded to support usage of ASYNC response sdnc Change-Id: I95b955cb257dcead152d68cd4cc4fb0fbcdfd708 Issue-ID: SO-2015 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-10Fix handling of NULL WorkflowAction northboundRequestMarcus G K Williams1-2/+3
Issue-ID: SO-1995 Change-Id: I16fd6067d4fe31ce66b399e292a7e0706fe05c0c Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2019-06-10replaced String.repeat with static final stringsBenjamin, Max10-34/+34
replaced String.repeat with static final strings Change-Id: Ife14fde70e8f648881a03e9343ae8faf9cb87e2e Issue-ID: SO-1999 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-08Merge remote-tracking branch 'origin/dublin' into 'origin/master'Benjamin, Max (mb388a)1-0/+4
Change-Id: Ib8eaae7ee4a404bde568803afaf6c4e183cbbd53 Issue-ID: SO-2004 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-07Merge "vrfvalidation exceptions not getting logged"Steve Smokowski2-27/+34
2019-06-07Add non-cloudowner nbrequest lookup in workflowActionMarcus G K Williams1-0/+4
Using a cloudOwner different than "CloudOwner" when instantiating a vfmodule using GR_API causes nbrequest lookup in workflowAction to fail. This change adds a final check for northboundRequest that does not use cloudOwner field before failing. This should enable instantiation on multiple cloudRegions without seperate northbound_request_ref_lookup actions for each cloudOwner. Issue-ID: SO-1995 Change-Id: I9d1fe39fb056d03e8473a524c21f41319c13c20f Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2019-06-06vrfvalidation exceptions not getting loggedGamboa, Gilbert2-27/+34
Remove unused imports in VrfValidation class Check for null AAI network and vpn-bindings. Do not catch exceptions in WorkflowAction.traverseVrfCondifuration. Propagate exceptions and let calling method selectExecutionList() handle exceptions. Change-Id: I26adfdb351cee6dc111f496901558340b8152a2a Issue-ID: SO-1988 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-06Enhance naming service supportMnushkin, Dmitry1-42/+0
correct sourcing for service-model-name in NamingMS remove zone ID from NamingMS input for service name follow up removal of autowired on NamingRequestObject Change-Id: Icba2e32c07ee0c7d7739ce21bd547e3030c1e271 Issue-ID: SO-1976 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-06Accommodate WAN NetworkingGamboa, Gilbert15-82/+701
checked and evaluated naming policy only if infra bonding. Updated workflowAction to include vrf configuration for vpn-binding in resourceIds list. added in linked resource to service proxy cust committing the asdc controller classpath change added some unit tests for vrf validation and updated bbinput setup test update config resource cust foreign key mapping Moved mockbean for AssignVrfConfiguration task class into BaseBpmnTest. added in a check to see if list is empty before access added unit tests for bbinput setup for vrf config Update AssignFlows enum with correct AssignVrfConfiguration flow name Change-Id: Ibf14e36505638b19c1366ecebfce560c02e69e44 Issue-ID: SO-1975 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-06Merge "Merge remote-tracking branch 'origin/dublin' into 'origin/master'"Max Benjamin14-37/+237
2019-06-06Merge remote-tracking branch 'origin/dublin' into 'origin/master'Steve Smokowski14-37/+237
Change-Id: I551ea3f29a76dc99532455ea4d7e84a316f9bf38 Issue-ID: SO-1980 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2019-06-05Merge "Fix ConfigAssign/Deploy null return of BlueprintName/Version" into dublinSteve Smokowski3-7/+9
2019-06-05Improvements in SniroHomingV2r.bogacki1-44/+33
Improvements in SniroHomingV2 according to the Sonar analyses. -Removed unnecessary variables. -Removed duplicated code. -Added String constants. -Improvements for an array size checking. -Refactored diamond operators for a simplicity. Issue-ID: SO-1991 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: Ia4f23210635e1ffad97eeb1d881a269fe391ff73
2019-06-04Add SO exclude ConfigurationScaleOutBBBonkur, Venkat (vb8416)1-1/+1
Updated the WorkflowAction.isConfiguration() to exclude ConfigurationScaleOutBB problem- VF module check failure during scale out Issue-ID: SO-1982 Signed-off-by: Bonkur, Venkat (vb8416) <vb8416@att.com> Change-Id: I5caa6f1c5ff21131ea1c42a63b441a39f77a6e62
2019-06-04Handle 201 and 422 status codesElena Kuleshov0-0/+0
SDC activitySpec API returns 201 for success and 422 when already exists Issue-ID: SO-1996 Signed-off-by: Kuleshov, Elena <evn@att.com> Change-Id: I75837b75cbd24f4ccfb97a07e91219b3b61453f6
2019-06-05Fix ConfigAssign/Deploy null return of BlueprintName/Versionsunilb3-7/+9
Fix ConfigAssign/Deploy null return of BlueprintName/Version Issue-ID: SO-1985 Signed-off-by: sunilb <sb00577584@techmahindra.com> Change-Id: I15b6d38a21320eae6ca58a1e3d515813b9c243fd
2019-06-03Fix ConfigAssignVnfBB and ConfigDeployVnfBBAlexis de Talhouët1-3/+7
Change-Id: If5a175ee26e279cf71e38c996a75fa627e5e2c00 Issue-ID: SO-1981 Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
2019-06-03Fix ConfigAssignVnfBB and ConfigDeployVnfBBAlexis de Talhouët1-3/+7
Change-Id: If5a175ee26e279cf71e38c996a75fa627e5e2c00 Issue-ID: SO-1981 Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
2019-06-03Cleaned up duplicated literalsrob.bog10-28/+40
Cleaned up Sonar code smells related to the duplicated literals in loggers. Issue-ID: SO-1932 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I58c48cec0012c42b7b892ae76c24c6a087c60c7e
2019-06-02Fixing EtSI BB ClassCastExceptionwaqas.ikram4-13/+179
Change-Id: Ia5a37f80392693f603d6597760ca9725882de169 Issue-ID: SO-1971 Signed-off-by: waqas.ikram <waqas.ikram@est.tech>
2019-05-31property to determine if delete audit is neededKalkere Ramesh, Sharan1-0/+10
update the onap delete vf module BB bpmn as well validate formatting of audit tasks code changes added a property to determine if delete audit is needed Change-Id: Id29eed6295ed6623636a4812708e53c5ae440b83 Issue-ID: SO-1964 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-31Corrected enum formatting by pluginBenjamin, Max (mb388a)4-32/+36
enums are now single item per line Change-Id: I6330ea4a9093071457dd47b95b6ed3bb7f8312e7 Issue-ID: SO-1970 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-31Handle multiple host routes correctly for networksMcblain, Thomas1-3/+3
unit test for the method that creates subnets Remove project name from junit test data Handle multiple host routes correctly for networks Change-Id: I537b9bbb68c11901c06ed2366591cedeb3b29acd Issue-ID: SO-1961 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-31Remove oof_directives from user_directives BB pathEric Multanen1-5/+13
Remove oof_directives from user_directives in the BB code path (as was done for the groovy code path). Change-Id: I018c3c85cc4a68ab128a2be869567b44fda08e48 Issue-ID: SO-1939 Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
2019-05-30Fixing infinte loop of flowwaqas.ikram3-10/+25
Change-Id: I80dc144750406d5afcec9b4da717a55a3840e503 Issue-ID: SO-1946 Signed-off-by: waqas.ikram <waqas.ikram@est.tech>
2019-05-23Remove update of request statusSmokowski, Steven1-1/+0
fix unit test now that method does not update status Remove update of request status, should not be done Change-Id: I17958ef76ccfa059893da0c2bcea1baa124d6922 Issue-ID: SO-1915 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-21Send syncAck on first ActivityElena Kuleshov1-0/+9
Send syncAck on first Activity Issue-ID: SO-1905 Signed-off-by: Kuleshov, Elena <evn@att.com> Change-Id: I0965b8247aa88a19be4417e2b5d58bce2d5dab27
2019-05-20Merge "Altered bpmn and audit behavior on delete vf mod"Steve Smokowski1-5/+10
2019-05-17Altered bpmn and audit behavior on delete vf modBoslet, Cory1-5/+10
Renamed variable from contin to flowShouldContinue. Updated bpmn junits and exceptionbuilder junits. Updated bpmns to use non interrupting escalation event. Altered bpmn and audit behavior on delete vf module Change-Id: I4ade4c934a9193099cfd29d740c68e60633c03e5 Issue-ID: SO-1896 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-17END_TIME is not populated by bpmn as expectedSangalang, Felix1-0/+6
Removed/Cleaned-up unnecessary lines/codes. Updated junit tests for END_TIME to any(Timestamp.class). END_TIME is not populated by bpmn when rainy day retry or rollback is executed. Change-Id: I614d66ca767629bf43aac8eee981423e5393015e Issue-ID: SO-1887 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-15Sonar fix too many method paramArindam Mondal2-21/+179
sonar:https://sonar.onap.org/issues?resolved=false&rules=squid%3AS00107 Issue-ID: SO-1878 Change-Id: I458fd436a85c7b3fb2c6a9df4a2a94591c6f6982 Signed-off-by: arindamm <arind.mondal@samsung.com>
2019-05-13Merge "Remove unused logger,replace type specification"Seshu Kumar M2-11/+10
2019-05-13Fix GR_API no homing pathMarcus G K Williams1-1/+1
Set correct variable name "homing" in AAICreateTasks.createVNF to ensure GR_API no homing path does not fail. Issue-ID: SO-1870 Change-Id: Ie19d9b5d475d2e3c5bec1f744975906813ab8723 Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2019-05-07Remove unused logger,replace type specificationSindhuri.A2-11/+10
Remove unused logger,replace type specification sdnc beans and mapper classes Issue-ID: SO-1490 Change-Id: I9a671f0ade5b86dbfd4cce1fbc6c07c0fdcf38a8 Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
2019-04-25Merge "Sniro BB now supports sole service proxies"Steve Smokowski2-3/+44