aboutsummaryrefslogtreecommitdiffstats
path: root/bpmn/so-bpmn-infrastructure-common
AgeCommit message (Collapse)AuthorFilesLines
2019-03-26Eliminated printStackTrace() callsWitold Ficio Kopel9-33/+23
Eliminated calls to printStackTrace() on Throwable as they go to stdout and are not handled by logger. Occurences has been replaced by calls to logger or modifications to nearby logger calls (Throwable passed as last parameter). Occurences in unit test classes left without modification. Change-Id: I6a771d60a3ea69ceecc29bb21358e565aa5ce101 Issue-ID: LOG-631 Signed-off-by: Witold Ficio Kopel <w.kopel@samsung.com>
2019-03-20Merge "Add cloudOwner to VNF adapter call"Steve Smokowski12-0/+43
2019-03-19Add cloudOwner to VNF adapter callEric Multanen12-0/+43
The BPMN layer has the CloudRegion which includes the CloudOwner attribute, but this is not passed to the VNF adapter layer. Calls to the Multicloud infrastructure workload need the CloudOwner as well. This patch adds CloudOwner to the VNF adapter API. While the intended usage is primarily for the multicloud adapter, it touches a log of other files - though those do not make use of it at this point. Change-Id: I88028096fbd84fc3fe5d53786c70b3c8806bb711 Issue-ID: SO-1447 Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
2019-03-19Removed logXXX() methods from MsoUtilsWitold Ficio Kopel5-7/+0
Following methods has been removed from MsoUtils (.groovy) class: logContext(requestId, serviceInstanceId) logMetrics(elapsedTime, logtxt) logAudit(logtxt) as no longer required. Remaining uses of them in other groovy clases has been deleted/replaced by apropriate use of logback. Change-Id: I473f01b65c67e90667311cff3b2a671e719f7258 Issue-ID: LOG-631 Signed-off-by: Witold Ficio Kopel <w.kopel@samsung.com>
2019-03-19Merge "Removed MsoLogger class"Steve Smokowski49-312/+250
2019-03-19Back to the correlationId value nameLukasz Muszkieta3-7/+7
Change-Id: I0dee6adb4e7c28b557aaed50a75c938e82a9bced Issue-ID: SO-1274 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-03-18Removed MsoLogger classr.bogacki49-312/+250
Bye bye MsoLogger class. Extracted constants to separated classes. Fixed imports. Change-Id: I7c8e0527e7dbd097d3ea93b9dab279354652da47 Issue-ID: LOG-631 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
2019-03-14Cleaned up content of MsoLoggerr.bogacki43-346/+365
Cleaned java and groovy code from 'getServiceName' method in MsoLogger. Change-Id: I23c3fc8005db5f89e94b87271bb60b7bcce72064 Issue-ID: LOG-631 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
2019-03-13Merge "Removed MsoLogger from UUIDChecker"Steve Smokowski1-1/+1
2019-03-13Run groovy bpmn/vcpe testsk.kazak14-6288/+5680
Fixed groovy tests in bpmn/vcpe/scripts to be runnable Added them to build Reformatted the code and removed unnecessary imports Change-Id: Id85c88bee666fc7f513042e0a4e83f337ab2765c Issue-ID: SO-1649 Signed-off-by: k.kazak <k.kazak@samsung.com>
2019-03-13Removed MsoLogger from UUIDCheckerr.bogacki1-1/+1
Cleaned UUIDChecker from MsoLogger. Fixed imports. Change-Id: Ieecea2fcd08025f950025f3bf8a679dee1626a25 Issue-ID: LOG-631 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
2019-03-12Remove MsoLogger form BPMN infrastructure scriptsk.kazak76-3375/+3873
Replaced MsoLogger with plain slf4j. Refactored loging output. Fixed imports. Replaced utils.log() with respective logger calls. Change-Id: I1154682f58206d6e97ae605f4eb9ba8ef8a10e1f Issue-ID: LOG-631 Signed-off-by: Witold Ficio Kopel <w.kopel@samsung.com> Signed-off-by: k.kazak <k.kazak@samsung.com>
2019-03-08Remove MsoLogger from BPMN VCPE scriptsFicio8-456/+508
Replaced MsoLogger with plain slf4j. Refactored login output. Fixed imports. Replaced utils.log() with respective logger calls. Issue-ID: LOG-631 Signed-off-by: Witold Kopel <w.kopel@samsung.com> Change-Id: I7c0f0e4a6b46e9e99f58e7c287b19bb93abc8677
2019-03-01Implement a separate task to query CatalogDB forBenjamin, Max (mb388a)1-19/+1
Restore script value for the script task Implement a separate task to query CatalogDB for CloudSite info for CM flows. Change-Id: Id9dc4da9a7d50b50b691f30a8e0a5ce68eec1739 Issue-ID: SO-1586 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-28CorrelationId cleanupJoanna Jeremicz23-129/+129
Remove old correlationId field and references from ServiceInstancesRequest and rename correlationId to pnfCorrelationId Change-Id: I5d8861aebe14c68574b6c54bc8d4eadf2967478b Issue-ID: SO-1274 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2019-02-27Removed MsoLogger 'so-bpmn-infrastructure-common'r.bogacki6-38/+48
Removed MsoLogger from adapters ('so-bpmn-infrastructure-common') Replaced MsoLogger with plain slf4j. Refactored login output. Fixed imports. Change-Id: I52fc6250ccd3ff528e906ac82809fb98c77984a4 Issue-ID: LOG-631 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
2019-02-22Merge "Change interface name to be more suitable"Lukasz Muszkieta10-37/+35
2019-02-21Merge "remove unneeded code"Steve Smokowski2-36/+21
2019-02-21remove unneeded codeLukasz Muszkieta2-36/+21
Change-Id: Ib1a62a8cf3a0335bf163ca2634c86e95d2a258b8 Issue-ID: SO-729 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-02-21Change interface name to be more suitableLukasz Muszkieta10-37/+35
Change-Id: Ifb4f6bc7f3e18974e9a11a17d474ad989c043673 Issue-ID: SO-1274 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-02-21Fixed major Sonar issues in ServicePluginFactoryr.bogacki1-22/+15
Removed not used variable. Removed unnecessary castings. Cleaned diamond operators. Removed commented out block of code. Change-Id: I0adca822f6dcb9efaa1ea96c9ff9092a7a2baa84 Issue-ID: SO-1552 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
2019-02-18Validate inputs for pnf associationJoanna Jeremicz3-33/+73
Issue-ID: SO-1274 Change-Id: I3fdb66ef4bd259bef46c6f092d7d142b6cb5d9dc Signed-off-by: Joanna Jeremicz <joanna.jeremicz@nokia.com>
2019-02-14updated camunda springboot versionBenjamin, Max (mb388a)3-37/+76
Added required unimplemented methods to classes Change-Id: I1ab6333582f2f09c6c363786c8168fdf54936bf8 Issue-ID: SO-1512 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-13Associate PNF instance with ServiceLukasz Muszkieta6-1/+150
Change-Id: I19e25e0daae042b30138bbfc074b0e651b8b1c01 Issue-ID: SO-1274 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-01-28Merge 'origin/casablanca' into masterBenjamin, Max (mb388a)22-97/+691
Issue-ID: SO-1435 Change-Id: If065ef5c91e769452fd6701fa6c28a23b4bdf2b2 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2019-01-24Removed deprecated Matcher importsBenjamin, Max (mb388a)10-10/+10
replaced org.mockito.Matchers with ArgumentMatchers Change-Id: I2feb4d4fb314cd14aca0719c4cc29b1a0510cbf7 Issue-ID: SO-1413 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-24Fix typosubhash kumar singh1-2/+2
Fix typo for typo in method name. Change-Id: I8dde10a5e161ad376469ff1bdc4d649d7fa89c02 Issue-ID: SO-1422 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2019-01-21Bug fixes from AT&T January 20thBenjamin, Max (mb388a)1-1/+2
sorted vfmodules by base last for negative action reqs store Response in execution as String on network delete added functionality to skip rollback based on flag # Conflicts: # bpmn/so-bpmn-tasks/src/main/java/org/onap/so/bpmn/infrastructure/workflo w/tasks/WorkflowAction.java require XML in the header for delete network request Update APP-C LCM Client library version to 1.7.0. replaced wiremock style test with mockito test Handle AAIClient Exps in CreateCustomerV1 getServiceInstance() changed default status code to be configurable Replace vnfType by nfRole in the healthcheck request to SDNO. updated error messages in sdnc handler and flow status updated flow status message on completion of flow Send GenericVnf object for AAI VNF update for vnf-api updates Add a JUnit test file for SDNOValidatorImpl.java Set nodeType on the inner SDNO request as per update from SDNO. updated rollbackToAssigned logic to remove unassign flows updated sdnc handler error message for client error added exception handling for httpclienterror in sdnc out map workflow exception so error is reported throws sdnc error message on bad response from sdnc add catalog entries for TRANSPORT service delete flows change script number that was duplicate add find method to NorthBoundRequestRepository include serviceType in hash code use asterisk for all non-TRANSPORT flow db entries alacart true, rm not needed transport srvc model steps correct insert query syntax for orchestration_flow support serviceType (TRANSPORT) process flow fix SDNCAdapterException causing no callback to bpmn use JsonAlias for alternate case when deserializing GRM client will accept both "serviceEndPointList" and "ServiceEndPointList" root node in the JSON response. AAIRestClient now uses getSystemName in headers finishtime should not be returned in requeststatus Change-Id: I81a185252b057020f7f36f125c85c3357756da88 Issue-ID: SO-1403 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-17remove unused uuid parameterLukasz Muszkieta1-3/+2
Change-Id: I0c4d5d6fcbf5d7c48c82b4485980adf2fde809cd Issue-ID: SO-729 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-01-15remove unused uuid parameterLukasz Muszkieta5-20/+10
Change-Id: I07793ddafdb8c23ff62ce282c413585c495751ab Issue-ID: SO-729 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-01-14Add missing license headersBenjamin, Max (mb388a)1-0/+20
add headers to files which were missing them Issue-ID: SO-1390 Change-Id: I6c754f72c5d1ef6485d6343aae4b994120901d08 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-11explicitly type defs and strings for templatesBenjamin, Max (mb388a)8-16/+16
explicitly type defs and strings for templates Change-Id: If4af5b0cdf086cd0d30277d1e835e2aa7c8e7f9c Issue-ID: SO-1386 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-11fix jenkins master buildLukasz Muszkieta1-2/+0
Change-Id: If263db591b98af62d9d49d75c602bd5c7966f1e4 Issue-ID: SO-1375 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-01-06Merge "Remove Swagger UI"Seshu Kumar M1-0/+2
2019-01-04Bugfixes for December 2018Benjamin, Max (mb388a)3-49/+42
Changed the way that the cidr is constructed in network utils. added in the if statement to check if selflink already exists removed execution line that was not needed in pull added service instance id to workflowResourceIds for virtualLinkKey network flows wrote test for updating request to complete in db workflow action directly updates db instead of using mso complete process Increase max timeout for SDNO Health Checks dmaap. Added execution variable and corrected type and way data is retrieved to fix defect fixed retry status message in request db for #/5 updated workflowActionBBTasks for flow status message updated flow status to failed on a workflowaction fail Removed slashes and fixed rollbackStatusMessage Updated requestStatus logic for adding status messages Added junit test to validate casue of a defect and cleaned up code and logging added end timestamp to request db on complete request fixed l3Network update of orchestation status in DoUpdateNetworkInstance groovy as well fixed update of l3network orchestration status Add explicit resetting of heatStackId in A&AI to DeleteVfModule and DeleteVolumeGroup BBs. Preserve heatStackId setting in the copiedVfModule when updating the VF Module in A&AI. added functionality to skip rollback based on flag Update snapshot version for logging, add headers fixed optional of error in retrieveErrorMessage method Set heatStackId to null if we want to remove it in A&AI. added in a warn logger statement to keep track of field map network technology from l3network instead of model info for network adapter object mapper Force heatStackId value to empty on an attempt to set it to null on update updated common pom to use aai schema version 1.4.1 removed handle sync error from SDNCHandler bpmn flow Change-Id: I1bd7aa55b06d4e439000b216165c9daafeacc9a4 Issue-ID: SO-1361 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-04HttpClientFactory to create HttpClient instancesMichal Kabaj9-48/+36
-Replace constructor calls with existing factory -Add create methods to factory for each required Media Type Change-Id: Ibd03c10230c87a0413c0ec529e0ea9ac800444f9 Issue-ID: SO-1344 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-12-28Merge "Enable use of resource order and input" into casablancaSeshu Kumar M1-1/+1
2018-12-28Merge "Update logging to msoLogger" into casablancaSeshu Kumar M3-189/+92
2018-12-27Merge "Bug fix for getInstnaceId" into casablancaYan Yang2-8/+122
2018-12-27Update logging to msoLoggersubhash kumar singh3-189/+92
Update logging to msoLogger. Change-Id: I24f09f372d4d5c7572ba37fcb5aee1e39b4992fe Issue-ID: SO-1330 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-12-26Update logging to msoLoggersubhash kumar singh3-189/+92
Update logging to msoLogger. Change-Id: I24f09f372d4d5c7572ba37fcb5aee1e39b4992fe Issue-ID: SO-1330 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-12-24Enable use of resource order and inputsubhash kumar singh1-1/+1
Enable use of resource order and input. Change-Id: I4d5b29997068447fc1bc657a6e5ae067d3b43496 Issue-ID: SO-1248 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-12-19Use UUID to fill pnf-id in PNF PnPJoanna Jeremicz8-67/+213
Issue-ID: SO-1272 Change-Id: If516b7ec38dad3fbc7409aff42275a98ef2af76a Signed-off-by: Joanna Jeremicz <joanna.jeremicz@nokia.com>
2018-12-18PNF PnP don't set "in-maint"biniek2-2/+1
Change-Id: I2c68a87d2483ebbd44fbf90f1afced9f02d23ab4 Issue-ID: SO-1345 Signed-off-by: biniek <lukasz.biniek@nokia.com>
2018-12-18Use UUID to fill pnf-id in PNF PnPJoanna Jeremicz7-43/+195
Issue-ID: SO-1272 Change-Id: If516b7ec38dad3fbc7409aff42275a98ef2af76b Signed-off-by: Joanna Jeremicz <joanna.jeremicz@nokia.com>
2018-12-17Merge "Bug fix for getInstnaceId"Steve Smokowski2-7/+125
2018-12-15Bug fix for getInstnaceId黄卓垚101122152-8/+122
CreateSDNCNetworkResource.afterCreateSDNCCall can't get instance id from getInstnaceId in afterCreateSDNCCall for modelName default case is missing Issue-ID: SO-1331 Change-Id: Ic9dab916cc17f0175c42f915d5acf4f817a4321c Signed-off-by: Zhuoyao Huang <10112215@zte.com.cn>
2018-12-15Bug fix for getInstnaceIdZhuoyao Huang2-7/+125
CreateSDNCNetworkResource.afterCreateSDNCCall can't get instance id from getInstnaceId for modelName default case is missing Issue-ID: SO-1331 Change-Id: Ia5eb03131a3137e5eede83a97d5b464e66bd2055 Signed-off-by: Zhuoyao Huang <10112215@zte.com.cn>
2018-12-13Add junit tests for CatalogDBUtilsLukasz Muszkieta11-93/+26
Change-Id: I1ea3e92b6dcb3fbca837513e11451be47d8c488b Issue-ID: SO-784 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-12-12Merge "use config value instead hard code of url"Seshu Kumar M1-3/+2