summaryrefslogtreecommitdiffstats
path: root/bpmn/so-bpmn-infrastructure-common/src/main
AgeCommit message (Collapse)AuthorFilesLines
2019-09-18Prevent reading twice from ResponseEntity stream, since this caused IOErrors.grabinsk2-19/+11
Also moving empty response checks to parseJsonToGelAllPnfCorrelationId Issue-ID: SO-2349 Signed-off-by: grabinsk <maciej.grabinski@nokia.com> Change-Id: I316856d56106a1ae715812628695406f4147765d Signed-off-by: grabinsk <maciej.grabinski@nokia.com>
2019-09-11Merge "Integrate Logging Library"Steve Smokowski10-21/+21
2019-09-11bug fix - avoid npe in pnf flowLukasz Muszkieta3-40/+43
Change-Id: I8e848c2bdcec0822ae08280223297b4825e9b7c2 Issue-ID: SO-2289 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-09-10Integrate Logging LibraryPlummer, Brittany10-21/+21
Updated SO to use ONAP provided filters and constants to meet logging standards. Removed redundant classes Updated constant references Issue-ID: SO-2301 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Ia4e3c2b1a4dcb3881aa34d39885c8b2782880d64
2019-09-05Log exceptionParshad Patel5-11/+21
Either log or rethrow this exception Use isEmpty() to check whether the collection is empty or not Issue-ID: SO-1841 Change-Id: Ia964a871497df8a7211260ad1ad8f1efa8ae4d42 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2019-08-19Close input streams via try-with-resourcesk.kazak1-9/+5
DefaultDmaapPropertiesImpl: close FileInputStream after loading ServicePluginFactory: close HttpClient if processing fails close application.properties InputStream after loading remove redundant catch block if behavior is the same add logging of exception in finally block BpmnInstaller: close csarFile if processing fails Change-Id: Ic6f942c401277c5150c5cc1297aba27ccd40694c Coverity-scan: CID-203903, CID-211476, CID-211615, CID-219308 Issue-ID: SO-2211 Signed-off-by: k.kazak <k.kazak@samsung.com>
2019-08-14public keyword removed for DoCreateServiceInstanceRollback.groovyanjali.walsatwar1-5/+5
groovy file correction Issue-ID: SO-2212 Signed-off-by: anjali.walsatwar <anjali.walsatwar@huawei.com> Change-Id: If2b6f5d1416042dd8ce88ae9d467ae24b00a1c55
2019-08-14Merge "DoCreateVFCNetworkServiceInstance.groovy corrected"Lukasz Muszkieta1-6/+6
2019-08-13Merge "Enhance variable name-comply with regex"Lukasz Muszkieta1-1/+1
2019-08-13Merge "Replace with equalsIgnoreCase"Seshu Kumar M1-4/+4
2019-08-13Enhance variable name-comply with regexsindhu36721-1/+1
Enhance variable name-comply with regex bpmn ConfigCheckerDelegate class Issue-ID: SO-2187 Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com> Change-Id: I11c06607cdb160f59c77e7e5af004364d53bddf5
2019-08-12Merge "Remove useless double assignment in ↵Lukasz Muszkieta1-1/+1
PnfEventReadyDmaapClient.​unregister"
2019-08-12Replace with equalsIgnoreCasesindhu36721-4/+4
Replace with equalsIgnoreCase bpmn ServicePluginFactory class Issue-ID: SO-2187 Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com> Change-Id: I2860546bb921a1b685f824beb0cd790e826435ad
2019-08-12DoCreateVFCNetworkServiceInstance.groovy correctedanjali.walsatwar1-6/+6
groovy file correction Issue-ID: SO-2212 Signed-off-by: anjali.walsatwar <anjali.walsatwar@huawei.com> Change-Id: I537a9a5ef72823f9aec9504e0475eee970c04a1a
2019-08-12DeleteVFCNSResource.groovy correctedanjali.walsatwar1-2/+2
groovy file correction Issue-ID: SO-2212 Signed-off-by: anjali.walsatwar <anjali.walsatwar@huawei.com> Change-Id: I2fead52822d107ad712624ba9a37c959eae8c077
2019-08-12DeActivateSDNCNetworkResource.groovy correctedanjali.walsatwar1-5/+5
groovy file correction Issue-ID: SO-2212 Signed-off-by: anjali.walsatwar <anjali.walsatwar@huawei.com> Change-Id: I2e9fd421f528ee147188f626817a5f3e68fa55fa
2019-08-12DoCreateServiceInstance.groovy correctedanjali.walsatwar1-11/+11
groovy file correction Issue-ID: SO-2212 Signed-off-by: anjali.walsatwar <anjali.walsatwar@huawei.com> Change-Id: Ib67d724009c172aa86347853075b3cf7ee6be502
2019-08-12DoCreateResources.groovy correctedanjali.walsatwar1-8/+8
groovy file correction Issue-ID: SO-2212 Signed-off-by: anjali.walsatwar <anjali.walsatwar@huawei.com> Change-Id: I1d4dc5370125a587b11cbf05b69fdaf8fcaa37aa
2019-08-12corrected CompareModelofE2EServiceInstance.groovyanjali.walsatwar1-5/+5
groovy file correction Issue-ID: SO-2212 Signed-off-by: anjali.walsatwar <anjali.walsatwar@huawei.com> Change-Id: I42b005210df986b1a4f006982f9d89be54bffa7f
2019-08-11Merge changes Ia52d9db2,Iab16430bSeshu Kumar M1-6/+6
* changes: Remove unused public access modifier Add vfmodule support to e2e service instance
2019-08-11Merge changes I045619a9,Iadffb2af,Ie97c560dSeshu Kumar M15-137/+137
* changes: Remove unwanted semicolon from groovy files Remove unwanted semicolon Removed unrequired semicolon from groovy
2019-08-09Remove useless double assignment in PnfEventReadyDmaapClient.​unregisterArtem Naluzhnyy1-1/+1
Coverity-scan: CID-211458 Issue-ID: SO-2211 Signed-off-by: Artem Naluzhnyy <A.Naluzhnyy@samsung.com> Change-Id: I670bb1f5684b90f0d4d01542c77c882e3d4966e4
2019-08-09Merge "removed unwanted public for ActivateSDNCNetworkResource.groovy"subhash kumar singh1-5/+5
2019-08-09Remove unwanted semicolon from groovy filessubhash kumar singh6-69/+69
Remove unwanted semicolon from groovy files. Issue-ID: SO-2212 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com> Change-Id: I045619a93597459d7ae5f656a880d36b4a46f001
2019-08-09Remove unwanted semicolonsubhash kumar singh9-68/+68
Remove unwanted semicolon. Issue-ID: SO-2212 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com> Change-Id: Iadffb2affff8597a8eb8258041b37cb8bf701f20
2019-08-09removed unwanted public for ActivateSDNCNetworkResource.groovyanjali.walsatwar1-5/+5
groovy file correction Issue-ID: SO-2212 Signed-off-by: anjali.walsatwar <anjali.walsatwar@huawei.com> Change-Id: I5f3adeb10b4f551f515144696695834a32493e97
2019-08-09Remove unused public access modifiersubhash kumar singh1-6/+6
Remove unused public access modifier. Issue-ID: SO-2212 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com> Change-Id: Ia52d9db2dc9b6500954f516cf456240f4b9e1bf0
2019-08-08remove not used BaseTask classLukasz Muszkieta2-5/+5
BaseTask class serves only as JavaDelegate implementation provider, should be removed Change-Id: I46f56cb850d12e4ef395db9429297d05f3a51b37 Issue-ID: SO-2187 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-08-08Fix NoClassDefFoundError for ServicePluginFactorysarada prasad sahoo1-6/+11
Fix NoClassDefFoundError for ServicePluginFactory appears when we run SO via docker-compose command Change-Id: I8ba5963edf28f81d948f71a9d698541f682de908 Issue-ID: SO-2206 Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
2019-08-07Fix Critical Bug - print array content correctlyLukasz Muszkieta1-1/+1
Change-Id: I525c2f3d2731a38183de108d4674d9dcef43bcb7 Issue-ID: SO-2187 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-07-29Vulnerability fixes in ServicePluginFactoryr.bogacki1-7/+8
Vulnerability fixes in ServicePluginFactory according to the Sonar. -Made constants final. -Changed access scopes from public to private. Issue-ID: SDC-2106 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: Iabaca0bd138b5dee22c95a4a0cc6cb5ebe442fd2
2019-07-26Enhanced List Level flow with backward supportsarada prasad sahoo4-114/+243
Modified the e2e service instance flow to support both new list types groups along with backward compatibility to support old types alloted resources, network etc. Change-Id: I1cb128e259c54b80009840914b2c1cee8cf8a4df Issue-ID: SO-1393 Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
2019-07-24Fix delete of generic neutron networkEric Multanen1-1/+1
Delete of Generic Neutron network was not working. Logic checking for association with vf-module appears to have been reversed. Change-Id: If541c1133322f75c70f86cd77d8bccd88b94f356 Issue-ID: SO-2082 Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
2019-07-23Merge "Enhanced List Level flow with backward support"Seshu Kumar M10-327/+530
2019-07-22Vulnerability fixes in ServicePluginFactoryr.bogacki1-1/+1
Sonar vulnerability fixes in ServicePluginFactory: -Added logger. Issue-ID: SO-2139 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: Id1752ea35db970b20d02e730dac9900c411958ca
2019-07-18Merge "Major Sonar fixes"Steve Smokowski1-1/+1
2019-07-12Major Sonar fixesr.bogacki1-1/+1
Major Sonar fixes in different classes: -Removed unused variables. -Simplified diamond operators. -Removed unnecessary imports. -Removed unnecessary code. Issue-ID: SO-2102 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: Ib54fbe048700a4e31042481f0a9b13838552aee7
2019-07-12Vulnerability fixes in ServicePluginFactoryr.bogacki2-7/+20
Sonar vulnerability fixes in ServicePluginFactory. -Moved hardcoded IP addresses to the property file. -Added junit test. Issue-ID: SO-2106 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: Id33e17f7845c106212bbf4d4a8ca78641cea1396
2019-07-02Enhanced List Level flow with backward supportsarada prasad sahoo10-327/+530
Modified the e2e service instance flow to support both new list types groups along with backward compatibility to support old types alloted resources, network etc. Change-Id: Ie8fc8a4550a90b44736b6b9de058e2a2e187570c Issue-ID: SO-1393 Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
2019-06-10Merge "replaced String.repeat with static final strings"Steve Smokowski41-182/+182
2019-06-10replaced String.repeat with static final stringsBenjamin, Max41-182/+182
replaced String.repeat with static final strings Change-Id: Ife14fde70e8f648881a03e9343ae8faf9cb87e2e Issue-ID: SO-1999 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-10Improvements in JsonUtilForPnfCorrelationIdr.bogacki1-4/+8
General fixes and improvements according to the Sonar analysis -Added private constructor for a utility class. -Refactored lambda expression. Issue-ID: SO-1992 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: Ife8cfdf9c341dc89a1699fd616ec68cba734a5d5
2019-06-08Merge remote-tracking branch 'origin/dublin' into 'origin/master'Benjamin, Max (mb388a)2-1/+39
Change-Id: Ib8eaae7ee4a404bde568803afaf6c4e183cbbd53 Issue-ID: SO-2004 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-06Merge remote-tracking branch 'origin/dublin' into 'origin/master'Steve Smokowski7-26/+77
Change-Id: I551ea3f29a76dc99532455ea4d7e84a316f9bf38 Issue-ID: SO-1980 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2019-06-05Changed service orc status to Assignedmarios.iakovidis1-1/+1
Issue-ID: SO-1938 Signed-off-by: MariosIakovidis <marios.iakovidis@huawei.com> Change-Id: I68d684f837f2dea9decb2e577742ab905f825d04
2019-06-05Added post process to AAI in HandlePNFmarios.iakovidis1-0/+38
Issue-ID: SO-1993 Signed-off-by: MariosIakovidis <marios.iakovidis@huawei.com> Change-Id: I6abec916438221669817b49997431b6164ee1a76
2019-06-03Cleaned up duplicated literalsrob.bog41-141/+183
Cleaned up Sonar code smells related to the duplicated literals in loggers. Issue-ID: SO-1932 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I58c48cec0012c42b7b892ae76c24c6a087c60c7e
2019-06-03Added orchestration status to servicemarios.iakovidis3-3/+50
Issue-ID: SO-1938 Signed-off-by: MariosIakovidis <marios.iakovidis@huawei.com> Change-Id: I78cc401a746ef4dbca41a869729b9791210038f4
2019-06-02Merge "New GroupLevel DeleteE2EServiceInstance flow"Seshu Kumar M4-188/+342
2019-05-31Corrected enum formatting by pluginBenjamin, Max (mb388a)1-28/+27
enums are now single item per line Change-Id: I6330ea4a9093071457dd47b95b6ed3bb7f8312e7 Issue-ID: SO-1970 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>