aboutsummaryrefslogtreecommitdiffstats
path: root/bpmn/so-bpmn-infrastructure-common/src/main/java
AgeCommit message (Collapse)AuthorFilesLines
2020-04-29rename package for external useBenjamin, Max7-30/+30
rename package for external use Issue-ID: SO-2852 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Id883f0c847c24a260dbf8c63ce5e1330c045d6de
2020-04-13decreased code smellsRupinder3-3/+0
Removed unused imports Issue-ID: SO-2804 Change-Id: I8ea686dd499578283fdda56ef0fe6c08c557383a Signed-off-by: Rupinder<rupinsi1@in.ibm.com>
2020-04-06Fix critical & major issuesParshad Patel3-80/+108
The Cyclomatic Complexity of this method is greater than 10 authorized. Either log or rethrow this exception Issue-ID: SO-1841 Change-Id: Idc12ca8d3256958f46f09fd0a34db54136438ad7 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2020-03-16Merge "Fix Critical & Major issues in adapters"Steve Smokowski1-1/+1
2020-03-16split single and plural graph inventory urisBenjamin, Max1-7/+5
split single and plural graph inventory uris updated all object references in MSO using graph inventory plurals corrected unit test stubbings added additional unit tests correct interfaces to return plural after related-to modified the way http aware uris are built reformated interfaces to no longer duplicate methods corrected issues with identity of unbuilt uris removed AAIUri references from groovy files fixed clone behavior on Uri objects Issue-ID: SO-2743 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I37aa2a13dcbf010b6c82ad73af3be5db5d9bd673
2020-03-13Fix Critical & Major issues in adaptersParshad Patel1-1/+1
The Cyclomatic Complexity of this method "createStackParam" is 16 which is greater than 10 authorized Either log or rethrow this exception Issue-ID: SO-1841 Change-Id: Ie5539a853a112ed751bbf891699f181479537e47 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2020-03-10Merge "create custom spring aop annotation for logging"Steve Smokowski2-2/+2
2020-03-05create custom spring aop annotation for loggingPlummer, Brittany2-2/+2
Added annotation for setting up scheduled tasks logs Added new annotation to scheduledTasks Moved annotation setup to logging-library Issue-ID: SO-2713 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I7080c4bb289e454f14167631e2601c954389c0ef
2020-03-05Support PNF software upgrade workflow using SDNC LCM APIEnbo Wang2-3/+8
Issue-ID: SO-2589 Signed-off-by: Enbo Wang <wangenbo@huawei.com> Change-Id: I4b6940c21b70eeeaf96e8781762cb7029572e7ae
2020-02-27SW UP building block and workflowEricMoore4-0/+237
This commit creates two bpmn 1. PNFSoftwareUpgrade.bpmn 2. PNFSWUPDownload.bpmn Respective Testcases are also written for both bpmns. Issue-ID: SO-2514 Issue-ID: SO-2515 Change-Id: Icb1706f1974341182f13b9125e09418b61571c52 Signed-off-by: EricMoore <eric.e.moore@est.tech>
2020-02-14Fix too many params issueParshad Patel2-17/+76
Methods should not have too many parameters Either log or rethrow this exception Issue-ID: SO-1841 Change-Id: Iabe32f4492560703228eb5d115b5e91ebeb17255 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2020-01-30WaitForPnfReadyBB message fixLukasz Muszkieta1-1/+1
fix problem with sending message to camunda process Issue-ID: SO-2606 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com> Change-Id: Iace8d283702968e0f3917feb498927eeacfed421
2020-01-29Merge "Create WaitForPnfReadyBB"Seshu Kumar M1-0/+99
2020-01-29AssignPnfBB connects PNF and service instance in AAIJoanna Jeremicz3-108/+0
Change-Id: I92ab4b45acb120d647ea3de7a455e2e873c12a72 Issue-ID: SO-2605 Signed-off-by: Joanna Jeremicz <joanna.jeremicz@nokia.com>
2020-01-28Create WaitForPnfReadyBBLukasz Muszkieta1-0/+99
Issue-ID: SO-2606 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com> Change-Id: I55281130c8ce0fde68d7a0554dd9023e44b9f2b0 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2020-01-24decision point APIeeginux5-10/+219
ControllerRunnable interface: implemented by controller ControllerContext: Controller Context for controller execution ControllerPreparable interface:used to setup execution context ControllerExecutionBB:controller execution for building block ControllerExecutionDE:controller execution for camunda Skeleton implementation for APPC controller Skeleton implementation for SDNC controller Use ControllerExecutionDE for existing PNF configuration. Add integration tests for controllerExecutionBB/DE Add GenericControllerExecution activity for BuildingBlockExecution based Add GenericControllerExecutionDE activity for DelegateExecution based. CDS controller to be implemented by SO-CDS generic buildingBlock Actor seletion based on ingested metadata Issue-ID: SO-2070 Change-Id: I4020c2ce21468939690e2cef78bbadbfff4bd3e4 Signed-off-by: eeginux<henry.xie@est.tech>
2020-01-10Align AssignPnfBB with Service Macro CreateRemigiusz Janeczek4-40/+108
-move and align logic of BB delegates with tests -remove unnecessary classes -add tests cases for Pnfs in ExtractPojosForBBTests Issue-ID: SO-2568 Signed-off-by: Remigiusz Janeczek <remigiusz.janeczek@nokia.com> Change-Id: Ic48e2c1c6ab852c33837091da3e7916b71c26466
2019-12-20Externalize AssignPnf Building Block and refactor existing code accordinglyRemigiusz Janeczek1-0/+40
Issue-ID: SO-2568 Change-Id: I1eec15862d6f0b5e8ae4c952b290be8d5fc786dd Signed-off-by: Remigiusz Janeczek <remigiusz.janeczek@nokia.com>
2019-11-26restoring the pnf dmaap client functionality to the proper working versionLukasz Muszkieta3-103/+19
Issue-ID: SO-2339 Change-Id: I2a12517fd7b37d3260058be6c5c27865e207b861 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-11-22improve error log scoresPlummer, Brittany1-1/+1
Updated error code name to fix spelling Defaulted errorcode and errordesc to unknown when not provided Remove unused imports from nc orchestrator application Added defaulting of serviceName to error log Issue-ID: SO-2538 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I5ae960f728739e2528173b66484562742429416c
2019-09-18Prevent reading twice from ResponseEntity stream, since this caused IOErrors.grabinsk2-19/+11
Also moving empty response checks to parseJsonToGelAllPnfCorrelationId Issue-ID: SO-2349 Signed-off-by: grabinsk <maciej.grabinski@nokia.com> Change-Id: I316856d56106a1ae715812628695406f4147765d Signed-off-by: grabinsk <maciej.grabinski@nokia.com>
2019-09-11bug fix - avoid npe in pnf flowLukasz Muszkieta3-40/+43
Change-Id: I8e848c2bdcec0822ae08280223297b4825e9b7c2 Issue-ID: SO-2289 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-09-05Log exceptionParshad Patel5-11/+21
Either log or rethrow this exception Use isEmpty() to check whether the collection is empty or not Issue-ID: SO-1841 Change-Id: Ia964a871497df8a7211260ad1ad8f1efa8ae4d42 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2019-08-19Close input streams via try-with-resourcesk.kazak1-9/+5
DefaultDmaapPropertiesImpl: close FileInputStream after loading ServicePluginFactory: close HttpClient if processing fails close application.properties InputStream after loading remove redundant catch block if behavior is the same add logging of exception in finally block BpmnInstaller: close csarFile if processing fails Change-Id: Ic6f942c401277c5150c5cc1297aba27ccd40694c Coverity-scan: CID-203903, CID-211476, CID-211615, CID-219308 Issue-ID: SO-2211 Signed-off-by: k.kazak <k.kazak@samsung.com>
2019-08-13Merge "Enhance variable name-comply with regex"Lukasz Muszkieta1-1/+1
2019-08-13Merge "Replace with equalsIgnoreCase"Seshu Kumar M1-4/+4
2019-08-13Enhance variable name-comply with regexsindhu36721-1/+1
Enhance variable name-comply with regex bpmn ConfigCheckerDelegate class Issue-ID: SO-2187 Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com> Change-Id: I11c06607cdb160f59c77e7e5af004364d53bddf5
2019-08-12Replace with equalsIgnoreCasesindhu36721-4/+4
Replace with equalsIgnoreCase bpmn ServicePluginFactory class Issue-ID: SO-2187 Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com> Change-Id: I2860546bb921a1b685f824beb0cd790e826435ad
2019-08-09Remove useless double assignment in PnfEventReadyDmaapClient.​unregisterArtem Naluzhnyy1-1/+1
Coverity-scan: CID-211458 Issue-ID: SO-2211 Signed-off-by: Artem Naluzhnyy <A.Naluzhnyy@samsung.com> Change-Id: I670bb1f5684b90f0d4d01542c77c882e3d4966e4
2019-08-08remove not used BaseTask classLukasz Muszkieta2-5/+5
BaseTask class serves only as JavaDelegate implementation provider, should be removed Change-Id: I46f56cb850d12e4ef395db9429297d05f3a51b37 Issue-ID: SO-2187 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-08-08Fix NoClassDefFoundError for ServicePluginFactorysarada prasad sahoo1-6/+11
Fix NoClassDefFoundError for ServicePluginFactory appears when we run SO via docker-compose command Change-Id: I8ba5963edf28f81d948f71a9d698541f682de908 Issue-ID: SO-2206 Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
2019-08-07Fix Critical Bug - print array content correctlyLukasz Muszkieta1-1/+1
Change-Id: I525c2f3d2731a38183de108d4674d9dcef43bcb7 Issue-ID: SO-2187 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-07-29Vulnerability fixes in ServicePluginFactoryr.bogacki1-7/+8
Vulnerability fixes in ServicePluginFactory according to the Sonar. -Made constants final. -Changed access scopes from public to private. Issue-ID: SDC-2106 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: Iabaca0bd138b5dee22c95a4a0cc6cb5ebe442fd2
2019-07-26Enhanced List Level flow with backward supportsarada prasad sahoo1-64/+170
Modified the e2e service instance flow to support both new list types groups along with backward compatibility to support old types alloted resources, network etc. Change-Id: I1cb128e259c54b80009840914b2c1cee8cf8a4df Issue-ID: SO-1393 Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
2019-07-22Vulnerability fixes in ServicePluginFactoryr.bogacki1-1/+1
Sonar vulnerability fixes in ServicePluginFactory: -Added logger. Issue-ID: SO-2139 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: Id1752ea35db970b20d02e730dac9900c411958ca
2019-07-18Merge "Major Sonar fixes"Steve Smokowski1-1/+1
2019-07-12Major Sonar fixesr.bogacki1-1/+1
Major Sonar fixes in different classes: -Removed unused variables. -Simplified diamond operators. -Removed unnecessary imports. -Removed unnecessary code. Issue-ID: SO-2102 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: Ib54fbe048700a4e31042481f0a9b13838552aee7
2019-07-12Vulnerability fixes in ServicePluginFactoryr.bogacki1-7/+17
Sonar vulnerability fixes in ServicePluginFactory. -Moved hardcoded IP addresses to the property file. -Added junit test. Issue-ID: SO-2106 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: Id33e17f7845c106212bbf4d4a8ca78641cea1396
2019-06-10Merge "replaced String.repeat with static final strings"Steve Smokowski3-6/+6
2019-06-10replaced String.repeat with static final stringsBenjamin, Max3-6/+6
replaced String.repeat with static final strings Change-Id: Ife14fde70e8f648881a03e9343ae8faf9cb87e2e Issue-ID: SO-1999 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-10Improvements in JsonUtilForPnfCorrelationIdr.bogacki1-4/+8
General fixes and improvements according to the Sonar analysis -Added private constructor for a utility class. -Refactored lambda expression. Issue-ID: SO-1992 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: Ife8cfdf9c341dc89a1699fd616ec68cba734a5d5
2019-06-03Cleaned up duplicated literalsrob.bog3-3/+6
Cleaned up Sonar code smells related to the duplicated literals in loggers. Issue-ID: SO-1932 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I58c48cec0012c42b7b892ae76c24c6a087c60c7e
2019-05-31Corrected enum formatting by pluginBenjamin, Max (mb388a)1-28/+27
enums are now single item per line Change-Id: I6330ea4a9093071457dd47b95b6ed3bb7f8312e7 Issue-ID: SO-1970 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-07fix newest sonar bugsk.kazak1-1/+2
OperationProgressor: restore interrupted state PnfEventReadyDmaapClient: remove useless check for null that never happens Test for this case already exists in PnfEventReadyDmaapClientTest.pnfCorrelationIdIsNotFoundInHttpResponse Change-Id: Ic7e4d0cb701721ee4d9a8bc46d65dc1d847d7704 Issue-ID: SO-1811 Signed-off-by: k.kazak <k.kazak@samsung.com>
2019-04-30Sonar fix NullPointerExceptionArindam Mondal1-1/+3
Issue-ID: SO-1829 Change-Id: I2b09733698391607989c2289b8c9f8ba5cdfabe4 Signed-off-by: arind.mondal <arind.mondal@samsung.com>
2019-04-26 Removed hardcoded values for PNF creation (cvlan, svlan, remoteId)marios.iakovidis3-9/+96
Change-Id: Ie4a63dd06279713c9f13062a09b44eb0e7f2e6bc Issue-ID: SO-1815 Signed-off-by: MariosIakovidis <marios.iakovidis@huawei.com>
2019-04-11Revert the change to avoid break PNF PnPeeginux3-65/+10
Revert PnfEventReadyDmaapClient PnfEventReadyDmaapClientTest Update the IT CreateVcpeResCustServiceSimplifiedTest Bug SO-1779 raise to fix the issue with Configure Issue-ID: SO-1506 Change-Id: I8f0e474405db7f0c23266208cee89df12ac6c0a2 Signed-off-by: eeginux <henry.xie@est.tech>
2019-04-11Merge "Fixed latest Sonar blocker issues"Seshu Kumar M1-15/+16
2019-04-10Fixed latest Sonar blocker issuesr.bogacki1-15/+16
Fixed blockers according to Sonar analysis. Change-Id: I2c2d053b66019b74ee20b0a56fb7b93bf931bb61 Issue-ID: SO-1734 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Signed-off-by: Katsia Kazak <k.kazak@samsung.com>
2019-04-09PNF WF post instantiation configurationeeginux3-9/+67
Fix the PNF registration issue Use the applicationEvent to notify about PNF ID Issue-ID: SO-1506 Change-Id: I4c5ebfdd4ed319408ef99e1360c37124688fd7f1 Signed-off-by: eeginux <henry.xie@est.tech>