Age | Commit message (Collapse) | Author | Files | Lines |
|
DefaultDmaapPropertiesImpl: close FileInputStream after loading
ServicePluginFactory: close HttpClient if processing fails
close application.properties InputStream after loading
remove redundant catch block if behavior is the same
add logging of exception in finally block
BpmnInstaller: close csarFile if processing fails
Change-Id: Ic6f942c401277c5150c5cc1297aba27ccd40694c
Coverity-scan: CID-203903, CID-211476, CID-211615, CID-219308
Issue-ID: SO-2211
Signed-off-by: k.kazak <k.kazak@samsung.com>
|
|
|
|
|
|
Enhance variable name-comply with regex bpmn ConfigCheckerDelegate class
Issue-ID: SO-2187
Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: I11c06607cdb160f59c77e7e5af004364d53bddf5
|
|
Replace with equalsIgnoreCase bpmn ServicePluginFactory class
Issue-ID: SO-2187
Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: I2860546bb921a1b685f824beb0cd790e826435ad
|
|
Coverity-scan: CID-211458
Issue-ID: SO-2211
Signed-off-by: Artem Naluzhnyy <A.Naluzhnyy@samsung.com>
Change-Id: I670bb1f5684b90f0d4d01542c77c882e3d4966e4
|
|
BaseTask class serves only as JavaDelegate implementation provider, should be removed
Change-Id: I46f56cb850d12e4ef395db9429297d05f3a51b37
Issue-ID: SO-2187
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
|
|
Fix NoClassDefFoundError for ServicePluginFactory
appears when we run SO via docker-compose command
Change-Id: I8ba5963edf28f81d948f71a9d698541f682de908
Issue-ID: SO-2206
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
|
|
Change-Id: I525c2f3d2731a38183de108d4674d9dcef43bcb7
Issue-ID: SO-2187
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
|
|
Vulnerability fixes in ServicePluginFactory according to the Sonar.
-Made constants final.
-Changed access scopes from public to private.
Issue-ID: SDC-2106
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Iabaca0bd138b5dee22c95a4a0cc6cb5ebe442fd2
|
|
Modified the e2e service instance flow to
support both new list types groups along with
backward compatibility to support old types
alloted resources, network etc.
Change-Id: I1cb128e259c54b80009840914b2c1cee8cf8a4df
Issue-ID: SO-1393
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
|
|
Sonar vulnerability fixes in ServicePluginFactory:
-Added logger.
Issue-ID: SO-2139
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Id1752ea35db970b20d02e730dac9900c411958ca
|
|
|
|
Major Sonar fixes in different classes:
-Removed unused variables.
-Simplified diamond operators.
-Removed unnecessary imports.
-Removed unnecessary code.
Issue-ID: SO-2102
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Ib54fbe048700a4e31042481f0a9b13838552aee7
|
|
Sonar vulnerability fixes in ServicePluginFactory.
-Moved hardcoded IP addresses to the property file.
-Added junit test.
Issue-ID: SO-2106
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Id33e17f7845c106212bbf4d4a8ca78641cea1396
|
|
|
|
replaced String.repeat with static final strings
Change-Id: Ife14fde70e8f648881a03e9343ae8faf9cb87e2e
Issue-ID: SO-1999
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
General fixes and improvements according to the Sonar analysis
-Added private constructor for a utility class.
-Refactored lambda expression.
Issue-ID: SO-1992
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: Ife8cfdf9c341dc89a1699fd616ec68cba734a5d5
|
|
Cleaned up Sonar code smells related to the duplicated
literals in loggers.
Issue-ID: SO-1932
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I58c48cec0012c42b7b892ae76c24c6a087c60c7e
|
|
enums are now single item per line
Change-Id: I6330ea4a9093071457dd47b95b6ed3bb7f8312e7
Issue-ID: SO-1970
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
OperationProgressor: restore interrupted state
PnfEventReadyDmaapClient: remove useless check for null that never happens
Test for this case already exists in
PnfEventReadyDmaapClientTest.pnfCorrelationIdIsNotFoundInHttpResponse
Change-Id: Ic7e4d0cb701721ee4d9a8bc46d65dc1d847d7704
Issue-ID: SO-1811
Signed-off-by: k.kazak <k.kazak@samsung.com>
|
|
Issue-ID: SO-1829
Change-Id: I2b09733698391607989c2289b8c9f8ba5cdfabe4
Signed-off-by: arind.mondal <arind.mondal@samsung.com>
|
|
Change-Id: Ie4a63dd06279713c9f13062a09b44eb0e7f2e6bc
Issue-ID: SO-1815
Signed-off-by: MariosIakovidis <marios.iakovidis@huawei.com>
|
|
Revert
PnfEventReadyDmaapClient
PnfEventReadyDmaapClientTest
Update the IT CreateVcpeResCustServiceSimplifiedTest
Bug SO-1779 raise to fix the issue with Configure
Issue-ID: SO-1506
Change-Id: I8f0e474405db7f0c23266208cee89df12ac6c0a2
Signed-off-by: eeginux <henry.xie@est.tech>
|
|
|
|
Fixed blockers according to Sonar analysis.
Change-Id: I2c2d053b66019b74ee20b0a56fb7b93bf931bb61
Issue-ID: SO-1734
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Signed-off-by: Katsia Kazak <k.kazak@samsung.com>
|
|
Fix the PNF registration issue
Use the applicationEvent to notify about PNF ID
Issue-ID: SO-1506
Change-Id: I4c5ebfdd4ed319408ef99e1360c37124688fd7f1
Signed-off-by: eeginux <henry.xie@est.tech>
|
|
Added in maven plugins to enforce coding style rules
Added in eclipse java formatting xml
Change-Id: I3727bbf4ce8dc66abfd8ad21b6cfd0890c5d3ff0
Issue-ID: SO-1765
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Fixed potential NullPointerException in lines:
123, 286, 480 and 607 - uuiObject is nullable here
Change-Id: I01b30d090add7faccf3958f2fa37c7905d4bd5a3
Issue-ID: SO-1490
Signed-off-by: k.kazak <k.kazak@samsung.com>
|
|
Change to use ipaddress-v4/6-oam for the config deploy
Add more assertions to the integration test
Issue-ID: SO-1506
Change-Id: I5ba45b055569f90f91308b6e9d4bd85a1d4e99fe
Signed-off-by: eeginux <henry.xie@est.tech>
|
|
|
|
Add PNF ipv4/v6 address for config Deploy
Add Integration test for CreateVcpeResCustService_simplified.bpmn
Modify the PnfEventReadyDmaapClient to avoid one more running thread
Refactor the so-bpmn-infrastructure-flows test resources
Modify the CreateVcpeResCustService_simplified.bpmn
Add ConfigurePnfResource.bpmn
Add Delegates
Issue-ID: SO-1506
Change-Id: Iffb69d1441ef0b485ee8cd3fb5da5f1a35279a95
Signed-off-by: eeginux <henry.xie@est.tech>
|
|
Issue-ID: SO-1577
Change-Id: I0bb4790ce179330cf7f942021725f2b72d1a0829
Signed-off-by: Arindam Mondal <arind.mondal@samsung.com>
|
|
|
|
Change-Id: I0dee6adb4e7c28b557aaed50a75c938e82a9bced
Issue-ID: SO-1274
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
|
|
Bye bye MsoLogger class.
Extracted constants to separated classes.
Fixed imports.
Change-Id: I7c8e0527e7dbd097d3ea93b9dab279354652da47
Issue-ID: LOG-631
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
|
|
Remove old correlationId field and references from ServiceInstancesRequest and rename correlationId to pnfCorrelationId
Change-Id: I5d8861aebe14c68574b6c54bc8d4eadf2967478b
Issue-ID: SO-1274
Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
|
|
Removed MsoLogger from adapters ('so-bpmn-infrastructure-common')
Replaced MsoLogger with plain slf4j.
Refactored login output.
Fixed imports.
Change-Id: I52fc6250ccd3ff528e906ac82809fb98c77984a4
Issue-ID: LOG-631
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
|
|
|
|
|
|
Change-Id: Ib1a62a8cf3a0335bf163ca2634c86e95d2a258b8
Issue-ID: SO-729
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
|
|
Change-Id: Ifb4f6bc7f3e18974e9a11a17d474ad989c043673
Issue-ID: SO-1274
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
|
|
Removed not used variable.
Removed unnecessary castings.
Cleaned diamond operators.
Removed commented out block of code.
Change-Id: I0adca822f6dcb9efaa1ea96c9ff9092a7a2baa84
Issue-ID: SO-1552
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
|
|
Issue-ID: SO-1274
Change-Id: I3fdb66ef4bd259bef46c6f092d7d142b6cb5d9dc
Signed-off-by: Joanna Jeremicz <joanna.jeremicz@nokia.com>
|
|
Change-Id: I19e25e0daae042b30138bbfc074b0e651b8b1c01
Issue-ID: SO-1274
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
|
|
Issue-ID: SO-1435
Change-Id: If065ef5c91e769452fd6701fa6c28a23b4bdf2b2
Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
|
|
Change-Id: I0c4d5d6fcbf5d7c48c82b4485980adf2fde809cd
Issue-ID: SO-729
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
|
|
Change-Id: If263db591b98af62d9d49d75c602bd5c7966f1e4
Issue-ID: SO-1375
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
|
|
|
|
Issue-ID: SO-1272
Change-Id: If516b7ec38dad3fbc7409aff42275a98ef2af76a
Signed-off-by: Joanna Jeremicz <joanna.jeremicz@nokia.com>
|