aboutsummaryrefslogtreecommitdiffstats
path: root/bpmn/MSOInfrastructureBPMN/src/test
AgeCommit message (Collapse)AuthorFilesLines
2018-05-15WorkflowResponse json issuesRob Daugherty17-46/+46
This commit adds some robustness to the interface between the API-H and BPMN, specifically, in how the response is handled. I don't have proof, but there appears to be some randomness to the json provider behavior when used with the jax-rs. Sometimes, the serializer is adding the root element, and sometimes it is not. Maybe there's something wrong with the configuration. Maybe we have competing json providers. I couldn't pin this down. I'm almost certain it is the presence of the root element in the content that causes the API-H code to fail parsing of the BPMN response. This doesn't kill the request, as you might expect, but rather, the API-H passes the BPMN response through to the client (VID, or policy, or whatever). The original problem (SO-586) was "fixed" by "removing the wrapper". This "wrapper" is a needed feature of the interface between BPMN and the API-H. We shouldn't have removed it. The fact that the "fix" appeared to work is due to the behavior I described in the previous paragraph. The API-H chokes on the message, and it passes it through unchanged. Not really what we want. So, I don't know why the jackson/json behavior is flaky and different now, but I can (and did) modify the API-H so it can parse a json message whether or not it has a root element. Note that WorkflowResponse.java (in BPMN) and CamundaResponse.java (in the API-H) are basically the same bean representing the message format. Seems less than ideal to have two different classes. Also note that I changed the name of the "response" attribute of the WorkflowResponse and CamundaResponse classes to "content". Got tired of seeing this nonsense everywhere in the code: response.getResponse() Change-Id: Icaf70f8457de99e493cf882170fe778c620308c9 Issue-ID: SO-586 Issue-ID: SO-618 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-05-04fixed bug in createvnfinfra bpmnBancala, Ben (bb3476)2-0/+14
Change-Id: I3e27ec0d1487eb68e8c54d27508b58233bf49808 Issue-ID: SO-602 Signed-off-by: Bancala, Ben (bb3476) <bb3476@att.com>
2018-05-03ecomp-model-information to onap-model-informationArthur Martella6-42/+42
Change-Id: I05f4648ff898a54e7a00d899d97129746172cdb4 Issue-ID: SO-603 Signed-off-by: Arthur Martella <am153x@att.com>
2018-04-25PnfReadyEventConsumer implementationLukasz Muszkieta1-6/+9
Change-Id: Ic8d5814c555bad436bfcbe1b4e212637a6800947 Issue-ID: SO-466 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-04-24Create VF Module ErrorRob Daugherty1-5/+7
There are multiple issues here. 1) The LCM healthcheck and config-scale-out should be made conditional upon the VNF orchestration status being Active or Activated. I'm not going to do that with this commit, since the logic will probably need to be moved to the DoCreateVfModule flow. What I will do is bypass the LCM operations to unblock testing. Another ticket will need to address the real solution. 2) APP-C gave us an API where the controller type is configured in their client object, which is NOT what we wanted. As a result, we have to keep a client object for each controller type. Our implementation did not do this. 3) Need to support the APP-C client configuration properties for specifying the SDN-C topic names. I'm refactoring the APP-C client urn mapping names to make it clear that they are for configuring the APP-C *client* and not necessarily for APP-C itself. Change-Id: I588f3b98b4ee44ba53b4931f9f1a7938ee70bebf Issue-ID: SO-577 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-04-23Merge "Added canceling subsription to pnf-pnp workflow"Seshu Kumar M2-0/+74
2018-04-19Added canceling subsription to pnf-pnp workflowbiniek2-0/+74
Change-Id: I0997943668b29a89565bbf83a40462a690d4a414 Issue-ID: SO-506 Signed-off-by: biniek <lukasz.biniek@nokia.com>
2018-04-19avoid null exceptionYulian Han1-3/+3
Change-Id: Idaa55084f5ecb0dd3636c232cebc14fa5f064304 Issue-ID: SO-578 Signed-off-by: Yulian Han <elaine.hanyulian@huawei.com>
2018-04-17Synchronization fix for dmaap clientbiniek2-5/+4
Change-Id: Ibcad191dc0994c8c4498ebdbc82e4c1f694517bd Issue-ID: SO-506 Signed-off-by: biniek <lukasz.biniek@nokia.com>
2018-04-16PnfReadyEventConsumer implementationLukasz Muszkieta3-41/+121
Change-Id: I7252400a3f60ca22ddfa71edb28eaf1d16ccd9b4 Issue-ID: SO-466 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-04-10Added informing dmaap client in pnf-ready workflowbiniek4-3/+150
Change-Id: I0d7b610e24da56aad32a9b02b987f98f932456f6 Issue-ID: SO-506 Signed-off-by: biniek <lukasz.biniek@nokia.com>
2018-04-10Merge "PnfReadyEventConsumer implementation"Seshu Kumar M3-0/+94
2018-04-10Merge "Added creating WorkflowException in pnf-pnp"Seshu Kumar M1-4/+7
2018-04-06Merge "Added hc and configscaleout to vfmoduleinfra"Rob Daugherty1-4/+18
2018-04-06PnfReadyEventConsumer implementationLukasz Muszkieta3-0/+94
Change-Id: Ia4d9fedb023ef6893e887ff6b5802623649aeeba Issue-ID: SO-466 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-04-06Added creating WorkflowException in pnf-pnpbiniek1-4/+7
Change-Id: I3cd5932913e58983c85e63c84c5136d04b0489e8 Issue-ID: SO-506 Signed-off-by: biniek <lukasz.biniek@nokia.com>
2018-04-06Added hc and configscaleout to vfmoduleinfraBancala, Ben (bb3476)1-4/+18
Change-Id: I2d5434785708ed34d1f28e22f134857bfcae02b1 Issue-ID: SO-551 Signed-off-by: Bancala, Ben (bb3476) <bb3476@att.com>;
2018-04-06Add junit for WorkflowResourceApplication javaFelix Sangalang1-0/+38
junit coverage for WorkflowResourceApplication Issue-ID: SO-559 Change-Id: I898e9f780e3b3d355881dc3e5dd77b6ecf5a2656 Signed-off-by: Felix Sangalang <fs7692@us.att.com>
2018-04-02Add junit HeaderUtil.javaFelix Sangalang1-1/+1
package org.openecomp.mso.bpmn.infrastructure. workflow.serviceTask.client Issue-ID: SO-556 Change-Id: If24593bb424f6faa3340d0b8fb88e49d37e796c3 Change-Id: If24593bb424f6faa3340d0b8fb88e49d37e796c3 Signed-off-by: Felix Sangalang <fs7692@us.att.com>
2018-04-02Add junit HeaderUtil.javaFelix Sangalang1-1/+0
package org.openecomp.mso.bpmn.infrastructure. workflow.serviceTask.client Issue-ID: SO-556 Change-Id: I34ba4d37eec42164c8e8cfa2c0fb747a625e77d2 Change-Id: I34ba4d37eec42164c8e8cfa2c0fb747a625e77d2 Signed-off-by: Felix Sangalang <fs7692@us.att.com>
2018-04-02Add junit for HeaderUtil javaSangalang, Felix (fs7692)1-1/+1
Add junit for HeaderUtil java Issue-ID: SO-556 Change-Id: Ia6ff8fde5a3689dd8fa46a13fcebc5a01d57d0d7 Change-Id: Ia6ff8fde5a3689dd8fa46a13fcebc5a01d57d0d7 Signed-off-by: Sangalang, Felix (fs7692) <fs7692@att.com>
2018-04-02Add junit for HeaderUtil.javaSangalang, Felix (fs7692)1-0/+35
package: org.openecomp.mso.bpmn.infrastructure. workflow.serviceTask.client Issue-ID: SO-556 Change-Id: I15194cf16262e4e333dfb689930d094495bcf68b Signed-off-by: Sangalang, Felix (fs7692) <fs7692@att.com>
2018-03-30Re-remove appc.service=ueb in infra bpmnArthur Martella1-1/+1
Change-Id: I1b06be26246c8421e7a778330e42b0bb77fd9b34 Issue-ID: SO-546 Signed-off-by: Arthur Martella <amartell@research.att.com>
2018-03-29Restore appc.service=ueb in infra bpmnArthur Martella1-1/+1
Undo change made in https://gerrit.onap.org/r/#/c/39927/ Change-Id: I32a88681fba132ad31cf40707444f3fe1dc87098 Issue-ID: SO-546 Signed-off-by: Arthur Martella <amartell@research.att.com>
2018-03-28Remove appc.service=ueb in infra bpmnArthur Martella1-1/+1
Change-Id: I39809ed7365b96bc225cb290ff0e6cca8cc80594 Issue-ID: SO-546 Signed-off-by: Arthur Martella <amartell@research.att.com>
2018-03-28Merge "ControllerType update for CM flows"Rob Daugherty5-1/+7
2018-03-28Merge "Added subworkflow for Pnf pnp"Rob Daugherty6-0/+447
2018-03-28ControllerType update for CM flowsElena Kuleshov5-1/+7
Change-Id: I42c60ba45baaf29fa5fe54a8bb7ffc0aab5622c7 Signed-off-by: Elena Kuleshov <ek1439@att.com> Issue-ID: SO-526
2018-03-28mannul NS scale unit testguanwenyao3-0/+324
Issue-ID: SO-423 Change-Id: I28d462cba73feb56b90d9d15619149d809fe1780 Signed-off-by: guanwenyao <guanwenyao@chinamobile.com>
2018-03-28Added subworkflow for Pnf pnpbiniek6-0/+447
Change-Id: Ifeba2e74a03ce8c5a13b80f673809c3ef60bfe3f Issue-ID: SO-506 Signed-off-by: biniek <lukasz.biniek@nokia.com>
2018-03-27Refactor homing flows for OOF/HPAMarcus G K Williams6-6/+21
1. Split Homing into OOF and SNIRO versions 2. Added OOF API interactions 3. Added Unit tests for OOF Homing Code Issue-ID: SO-404 Change-Id: Ifeeeec9ea450d8b330110a565208ed89a1e18cde Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2018-03-22Added OpenPojo Validations to beansSmokowski, Steve (ss835w)1-0/+72
Change-Id: I34d8922a55b1ba35610ad0856dcd3363fa016785 Issue-ID: SO-516 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-03-21UT CoverageSindhu A1-0/+114
UT Coverage for SO Change-Id: Ib9517c25b22c37c85b2af84259911b01ddb4bbe5 Issue-ID: SO-369 Signed-off-by: Sindhu A <arcot.sindhuri@huawei.com>
2018-03-20Add UT for AAICreateOwningEntityTestsubhash kumar singh1-0/+35
Add UT for AAICreateOwningEntityTest. Issue-ID: SO-369 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com> Change-Id: I240bd5b7b1677e9fb88a815f67757ea8e9756e32
2018-03-20Add UT for AbstractBuildersubhash kumar singh1-0/+358
Add UT for AbstractBuilder class. Change-Id: Icd337e51c49d24015c1401ecaf36c26e710d4606 Issue-ID: SO-369 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-03-14AT&T 1712 and 1802 release codeRob Daugherty93-1311/+4040
This is code from AT&T's 1712 and 1802 releases. Change-Id: Ie1e85851e94bc66c4d9514a0226c221939531a04 Issue-ID: SO-425 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-03-09Revert Reduce log noise/warningsRob Daugherty42-8337/+8346
This reverts commit 327b17ab250b4c17cf3f91f5e4cd9bffd89f3d1e. It is seriously impeding our ability complete the promised merge of AT&T 1802 code. While I'm all for coding standards, if we are serious about using spaces instead of tabs, then I think we need to (1) agree with the community when this will happen, (2) do consistently in all files, and (3) enforce it. Change-Id: Ib9b996f6b6c7d81ac9ac95d58b0c7d8cc39675ff Issue-ID: SO-368 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-03-08Reduce log noise/warnings format to conventionsMarcus G K Williams42-8346/+8337
Reduce build log warnings by formatting tests to ONAP code conventions (removing tabs etc.) Issue-ID: SO-368 Change-Id: I48c6d359b83617aebeb79db4e30c1d72d31f7eec Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2018-03-07Merge "Swap indexOf with contains"Rob Daugherty2-12/+12
2018-03-07Swap indexOf with containsMunir Ahmad2-12/+12
Change-Id: I609d307acf504ea7ff25ed3327a3d4e0e4686755 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-03-06Store NB Create req. userParam - Customer_LocationMarcus G K Williams4-22/+46
1. Additional user param Customer_Location needs to be passed and stored for use later in communication to OOF for homing/placement. 2. Added request.json fields to unit test Customer_Location and enabled testing of Customer_Location in CreateVcpeResCustServiceTest.groovy 3. Cleanup of CreateVcpeRestCustService.groovy to match code conventions Issue-ID: SO-402 Change-Id: Id23161c1d63e2f0e7871bf9310468c1b64cbd04e Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2018-03-06Replace explicit type with dimond typeMunir Ahmad32-78/+78
Change-Id: I1dedb9ef1ca7b734e3cfc0a3a594d733dbd298d4 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-01-24Same Service names under two different CustomersChittaranjan Sardar1-2/+2
SO is not allowing to create services with same name with in different customers. Change-Id: I2ce83f3d6c8d999f88154a1ac50330a8b6d50118 Issue-ID: SO-382 Signed-off-by: Chittaranjan Sardar <chittaranjan.sardar@amdocs.com>
2017-12-12Fix the super keyword misuseByung-Woo Jun9-276/+274
Remove the super keyword misuse, and create a static method for the correct assignment Change-Id: I7048d45c709520788eca53c8275af508d0c4a9a8 Issue-ID: SO-292 Signed-off-by: byungwoojun<byung-woo.jun@ericsson.com>
2017-11-15Modified create-vcpe to filter out "bad" VNFsJim Hahn1-17/+64
Modified create-vcpe to delete the BRG and TXC items from the service VNF list contained within the service decomposition structure. Change-Id: I7624a93b422fa172a2079f70d66a2604ee2229b0 Issue-Id: SO-344 Signed-off-by: Jim Hahn <jrh3@att.com>
2017-11-13Added global customer id to sdnc delete requestJim Hahn2-2/+10
Modified delete-BRG & delete-TXC to add global customer id and several other fields to the SDNC request. Change-Id: I4b85ba634b56a218037f95e1772fe0fcdde1cd91 Issue-Id: SO-336 Signed-off-by: Jim Hahn <jrh3@att.com>
2017-11-11Query AAI for ARs on deleteJim Hahn3-61/+115
Delete-vcpe code expected allotted-resources to be included within the SI response from AAI. That turns out not to be the case. As a result, the code for delete-vcpe was modified to query each AR found in the SI to get it's full info. Change-Id: I893fb2fcf50a32335bbd68d1aaa84c8d747b14f0 Issue-Id: SO-325 Signed-off-by: Jim Hahn <jrh3@att.com>
2017-11-09Now passing cloudConfig to subflowsJim Hahn1-0/+2
Modified DeleteVcpeResCustService to pass cloudConfiguration to the delete-vnf-and-modules subflow, in addition to passing the cloud id and tenant id. Change-Id: Icf7824ed36eef95b8ab943005c5f4495706b5d70 Issue-Id: SO-324 Signed-off-by: Jim Hahn <jrh3@att.com>
2017-11-09editing test cases for e2e delete groovyseshukm1-1/+4
IssueId: SO-281 Change-Id: I9c5de43451dc7af646ed728839a1bb08ae8f4742 Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
2017-11-08Added input params to service-information sectionShailendra Borale3-6/+19
Added input params to service-information section to facilitate sdnc assign query subscriptionServiceType and globalCustomerId were added to groovy, bpmn parentServiceInstanceId shd not be part of service-information, serviceInstanceId - corrected Updated junit tests with new service-info fields. Change-Id: I9fbfdf8a97b4e42881e187bec198c977241c0c13 Issue-Id: SO-318 Signed-off-by: Jim Hahn <jrh3@att.com>