aboutsummaryrefslogtreecommitdiffstats
path: root/bpmn/MSOCoreBPMN/src
AgeCommit message (Collapse)AuthorFilesLines
2018-03-12Merge changes I5a320c60,I3fbd868eSeshu Kumar M1-1/+1
* changes: Remove unnecessary simicolon from all java classes private is redundant for enum constructors
2018-03-09private is redundant for enum constructorsMunir Ahmad1-1/+1
Change-Id: I3fbd868e83651111a6bce6c268ed4d7cf84c3fd5 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-03-09Replace String concatination with chained appendMunir Ahmad1-1/+1
Change-Id: I7780265c1744b3677718461c1f3013465e83535f Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-03-09Merge "Collapse catch clauses where applicable"Rob Daugherty2-13/+5
2018-03-09Revert Reduce log noise/warningsRob Daugherty5-339/+337
This reverts commit 327b17ab250b4c17cf3f91f5e4cd9bffd89f3d1e. It is seriously impeding our ability complete the promised merge of AT&T 1802 code. While I'm all for coding standards, if we are serious about using spaces instead of tabs, then I think we need to (1) agree with the community when this will happen, (2) do consistently in all files, and (3) enforce it. Change-Id: Ib9b996f6b6c7d81ac9ac95d58b0c7d8cc39675ff Issue-ID: SO-368 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-03-09Collapse catch clauses where applicableMunir Ahmad2-13/+5
Change-Id: Idf9546b9d59bf23547bac4aa4f0fbee4f97a0255 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-03-08Reduce log noise/warnings format to conventionsMarcus G K Williams5-337/+339
Reduce build log warnings by formatting tests to ONAP code conventions (removing tabs etc.) Issue-ID: SO-368 Change-Id: I48c6d359b83617aebeb79db4e30c1d72d31f7eec Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2018-03-07Make use of lambdaMunir Ahmad1-8/+2
Change-Id: I482b874a3e7e686068450c7b5ddf45e2b8ae0d47 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-03-07Merge "Remove redundant catch clause"Rob Daugherty2-12/+0
2018-03-06Remove redundant catch clauseMunir Ahmad2-12/+0
Change-Id: Ib26f47171384125847a1b31bc1a958b50d0bba70 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-03-06Fix javadocMunir Ahmad6-8/+6
Change-Id: Iddc39df32089e1a37c04d089522ead295a037118 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-03-06Merge "Replace StringBuilder with String & inline return"Seshu Kumar M2-22/+11
2018-03-06Replace explicit type with dimond typeMunir Ahmad7-15/+15
Change-Id: I1dedb9ef1ca7b734e3cfc0a3a594d733dbd298d4 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-03-06Replace StringBuilder with String & inline returnMunir Ahmad2-22/+11
Resolved merge conflicts Change-Id: I1a8c8b6fd801c1eb7719ea3d17f029972e2ba84f Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-03-02Make use of Map.getOrDefaultMunir Ahmad1-6/+2
Change-Id: Ifcd5c9b79179ee9ffd6705990bd4b1991034fb48 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-02-28Merge "Remove the unnecessary toString"Seshu Kumar M1-1/+1
2018-02-27Make use of append instead of string concatenationMunir Ahmad2-3/+4
Change-Id: I94ad658026f165ba8b5a74352095188a27ee50e5 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-02-27Remove the unnecessary toStringMunir Ahmad1-1/+1
Change-Id: I32f5d3674583db900f7aa9b45af9fba0f8d9c06c Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-02-26Merge "Swap while loops with foreach where applicable"Seshu Kumar M1-23/+14
2018-02-25Swap while loops with foreach where applicableMunir Ahmad1-23/+14
Change-Id: Id3b54e8192f0e60657aa4c50af56c1ef98fbff5e Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-02-24Remove wrapping of primitive values in objectsMunir Ahmad1-4/+4
Change-Id: I67b1229c7c8d0d82b94857f64a6547d9f57d16b8 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-02-24Swap StringBuffer with StringBuilder everywhereMunir Ahmad3-4/+4
Change-Id: Ia1f8d3ebc4026179bf08cdb0bd71c4480b8481df Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-02-06Merge "Added unittests for RollbackData"Seshu Kumar M2-67/+145
2018-02-06Merge "Refactor of DecomposeJsonUtils class."Seshu Kumar M3-181/+130
2018-01-31Added unittests for RollbackDatabiniek2-67/+145
Change-Id: I3c6f3b204e3cea6acce643f023f73561765226ee Issue-ID: SO-374 Signed-off-by: biniek <lukasz.biniek@nokia.com>
2018-01-31Merge "Sonar:Major"Seshu Kumar M1-0/+1
2018-01-31Merge "Sonar:Major"Seshu Kumar M1-0/+1
2018-01-30Sonar:MajorManamohan Satapathy1-0/+1
Add the @Override annotation above this method signature:L145 Issue-ID: SO-395 Sonar Link: https://sonar.onap.org/component_issues/index?id=org.openecomp.so%3Aso#resolved=false|severities=MAJOR|rules=squid%3AS1161 Location:src/main/java/org/openecomp/mso/bpmn/core/domain/JsonWrapper.java Change-Id: Ifb0d6ee37ec3b935326d7aed7cc50e8b79aa0df5 Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>
2018-01-30Sonar:MajorManamohan Satapathy1-0/+1
Add the @Override annotation above this method signature.java:L92 Issue-ID: SO-394 Sonar Link: https://sonar.onap.org/component_issues/index?id=org.openecomp.so%3Aso#resolved=false|severities=MAJOR|rules=squid%3AS1161 Location:src/main/java/org/openecomp/mso/bpmn/core/RollbackData.java Change-Id: Ib3d56f82b1a21df201fe2f9558f2b33004033c7e Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>
2018-01-30Sonar:MajorAzhar Sardar Sayyed1-0/+1
Add the @Override annotation LoggingAndURNMappingPlugin.java:L326 Sonar Link:https://sonar.onap.org/component_issues/index?id=org.openecomp.so%3Aso#resolved=false|severities=MAJOR|rules=squid%3AS1161 Location:LoggingAndURNMappingPlugin.java:L326 Change-Id: I047385bdf582a8c07998243ce25f9f669ce20765 Issue-ID: SO-396 Signed-off-by: Azhar Sardar Sayyed <AS00465059@TechMahindra.com>
2018-01-29Refactor of DecomposeJsonUtils class.biniek3-181/+130
Change-Id: I72b779eb17ffb901266de605eb2eda49f13bd03e Issue-ID: SO-374 Signed-off-by: biniek <lukasz.biniek@nokia.com>
2018-01-16Unittest refactoring.biniek3-240/+204
Refactored JsonUtilsTest; moved CamundaDBSetup from src to test; added newer version of xmlutils and changed scope to test. Change-Id: I24f51c3b8600be3de08a464bebb3adabc4d7c176 Issue-ID: SO-374 Signed-off-by: biniek <lukasz.biniek@nokia.com>
2018-01-04Moved variable name extraction to separate class.biniek3-500/+575
Change-Id: Ic4105f9f3557c924928321c1b27f7b0e3444bfbc Issue-ID: SO-374 Signed-off-by: biniek <lukasz.biniek@nokia.com>
2017-11-22Fix Json Analyze failed Issuec001491071-1/+1
Fix Json Analyze failed Issue Issue-ID: SO-348 Change-Id: Ibfea7d2cfa5e62e4d8e251a17908d4f7bc8de154 Signed-off-by: c00149107 <chenchuanyu@huawei.com>
2017-11-01removed commented out lines of codeBenjamin, Max (mb388a)1-14/+2
Issue-Id: SO-296 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com> Change-Id: Ie87f3df2abe5cf8954ac94e68a20b08d893cf329
2017-10-20Flows fail to update status in requests DBRob Daugherty1-1/+1
The fallout and completion handlers are not updating the request status in the mso_requests database. The cause is a missing URN mapping that defines the service endpoint for these updates. Issue: SO-230 Change-Id: I5b4ff6e9ca2cde6605b3ed7cb7b086041111d31c Signed-off-by: Rob Daugherty <rd472p@att.com>
2017-10-08Fixes for sonar coverage in bpmnRob Daugherty5-558/+0
1. Coordinated jacoco and surefire JVM arg line options 2. Changed sonar plugin version to 2.19.1 3. Removed dead code (unused classes) Issue: SO-193 Change-Id: I21b7a77510eec71f4d4ca9afde5b7f86f0e3cbd7 Signed-off-by: Rob Daugherty <rd472p@att.com>
2017-10-02Merge "Added @Override annotation to method signature"Seshu Kumar M1-0/+1
2017-09-30Merge "Added @Override annotation to method signature"Seshu Kumar M1-7/+7
2017-09-30Merge "Fixed string literal comparision issue"Seshu Kumar M1-1/+1
2017-09-27Update POM to inherit from oparentRob Daugherty18-0/+360
Issue: SO-71 Change-Id: I91d503b52909cfcb62ca4b5cd93f6cfc70d6eb24 Signed-off-by: Rob Daugherty <rd472p@att.com>
2017-09-26Added @Override annotation to method signatureshashikanth1-0/+1
Fix major sonar issues in so module https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#resolved=false|severities=MAJOR|rules=squid%3AS1161 Add the "@Override" annotation above this method signature Issue-Id: APPC-186 Change-Id: I63b6229cc3b84b2f77f8d391e823933aaab05dd0 Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
2017-09-26Added @Override annotation to method signatureshashikanth1-7/+7
Fix major sonar issues in so module https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#resolved=false|severities=MAJOR|rules=squid%3AS1161 Add the "@Override" annotation above this method signature Issue-Id: APPC-186 Change-Id: I1c13d988683b75b6b59e5626e9a0564161d2dc9a Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
2017-09-26Fixed string literal comparision issueshashikanth1-1/+1
Fix major sonar issues in so module https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#resolved=false|severities=BLOCKER%2CMAJOR|rules=squid%3AS1132%2Csquid%3AS1143 Move the "extracted information" string literal on the left side of this string comparison. Issue-Id: APPC-186 Change-Id: I757599f5c8ebcbe70c86105c335c6195e436486b Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
2017-09-26Use try-with-resourcessurya-huawei1-12/+5
*Replace try with try-with-resources This is done to close resources automatically and not worry about finally block *Replace explicit type info with diamond operator This is done to reduce verbosity of generics code Issue-Id: SO-118 Change-Id: I948ffd26bfe6022496ca4a272de2619aef0dbd88 Signed-off-by: surya-huawei <a.u.surya@huawei.com>
2017-09-26Added the "@Override" annotation above signatureshashikanth1-4/+39
https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#fileUuids=AV3BnsdI5bp_wwmIVCGH|resolved=false|severities=MAJOR Issue-Id:SO-118 Change-Id: If5556adabedb0cb498ecb646df9cb8f2a15a265d Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
2017-09-25Merge "Fixed string literal comparision redundant code"Seshu Kumar M1-6/+4
2017-09-25Merge "Changed try to try with resource"Seshu Kumar M1-243/+232
2017-09-25Merge "Changed try to try with resource"Seshu Kumar M1-22/+4
2017-09-25Fixed string literal comparision redundant codeshashikanth1-6/+4
Move the "content" string literal on the left side of this string comparison. Issue-Id:SO-118 Change-Id: Ice9ef2d94f594669f0399d31e5346e3c0be66c13 Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>