aboutsummaryrefslogtreecommitdiffstats
path: root/bpmn/MSOCommonBPMN
AgeCommit message (Collapse)AuthorFilesLines
2019-08-22General sonar fixesArindam Mondal1-3/+3
+) Use format specifier to log exception ++) remove unused import Issue-ID: SO-2226 Change-Id: I0938d624b918eddf30e96da4f12d7a06cc0ddfe1 Signed-off-by: arindamm <arind.mondal@samsung.com>
2019-08-16Merge "Initial commit of validation framework to APIH"Steve Smokowski9-97/+13
2019-08-16Sonar fix in MSOCommonBPMNParshad Patel2-18/+18
Either log or rethrow this exception Remove this useless assignment to local variable "serviceInstance" Remove the declaration of thrown exception which is a runtime exception Move the string literal on the left side of this string comparison Issue-ID: SO-1841 Change-Id: I24cdd3682eddd2e5ceb7e961477a61457ef91ab2 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2019-08-15Initial commit of validation framework to APIHSmokowski, Steven9-97/+13
Move ListenerRunner to common location Adjust request params name, update junit tests Update validations to work properly Properly escape period for the string split Issue-ID: SO-2232 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Ia468cf7062cccf30e28afeb7a5cddc37ceb2e002
2019-08-13Merge "Removed unused CryptoHandler, ICryptoHandler and CryptoHandlerTest ↵Lukasz Muszkieta3-159/+0
classes"
2019-08-13Merge "Place diamond op in place of type spec"Lukasz Muszkieta3-4/+4
2019-08-13Removed unused CryptoHandler, ICryptoHandler andOleksandr Moliavko3-159/+0
CryptoHandlerTest classes Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: I944ae9b49326257b6ddfe94687c3241e91af4de9
2019-08-13Place diamond op in place of type specsindhu36724-6/+6
Place diamond op in place of type spec MSOCommonBPMN classes Issue-ID: SO-2187 Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com> Change-Id: I133a9328f5c91c61af24a57a610d36c6d6622f66
2019-08-13Merge "Use diamond op in place of type spec"Seshu Kumar M9-18/+18
2019-08-12Merge "added in mapping of aggregate routes in"Steve Smokowski4-10/+34
2019-08-12Use diamond op in place of type specsindhu36729-18/+18
Use diamond op in place of type spec MSOCommonBPMN classes Issue-ID: SO-2187 Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com> Change-Id: I8812392bbc6eac6d703ff7eeabf8e95806aab442
2019-08-11Merge changes Ia52d9db2,Iab16430bSeshu Kumar M1-0/+5
* changes: Remove unused public access modifier Add vfmodule support to e2e service instance
2019-08-11Merge changes I045619a9,Iadffb2af,Ie97c560dSeshu Kumar M5-57/+57
* changes: Remove unwanted semicolon from groovy files Remove unwanted semicolon Removed unrequired semicolon from groovy
2019-08-09Remove unwanted semicolonsubhash kumar singh1-1/+1
Remove unwanted semicolon. Issue-ID: SO-2212 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com> Change-Id: Iadffb2affff8597a8eb8258041b37cb8bf701f20
2019-08-09added in mapping of aggregate routes inKalkere Ramesh, Sharan4-10/+34
added in mapping of aggregate routes in bbinputsetup Issue-ID: SO-2214 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I56048eb78eb06800ec5b9c290493d502ef7435d0
2019-08-09Merge "add rainy day handling with SERVICE_ROLE and type"Steve Smokowski2-9/+69
2019-08-09Removed unrequired semicolon from groovysubhash kumar singh4-56/+56
Removed unrequired semicolon from groovy. Issue-ID: SO-2212 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com> Change-Id: Ie97c560db89dcd15d424c11473a312e9d684cbd8
2019-08-09Add vfmodule support to e2e service instancesubhash.kumar.singh1-0/+5
Parse vfmodule to add to resource instance list. Issue-ID: SO-2213 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com> Change-Id: Iab16430b498e505cd89a0ba4c12cfd2f88b9a982
2019-08-08add rainy day handling with SERVICE_ROLE and typeMnushkin, Dmitry2-9/+69
add rainy day handling with SERVICE_ROLE and type Issue-ID: SO-2205 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Ib85ccd787d4c8b210abb983e1f114da3d36be2b6
2019-08-07Add SO Message instead of Exception when vmIds are emptyBonkur, Venkat (vb8416)2-0/+112
Add the conditions to log messages instead of null pointer exception when vmIds or vserverIds are not present. Issue-ID: SO-2186 Signed-off-by: Bonkur, Venkat (vb8416) <vb8416@att.com> Change-Id: I27dd8a5480cf5e2d8588cc71ca3bfefaf0e138cc
2019-08-06updated delete payloads for bulk deletesBenjamin, Max1-22/+0
updated delete payloads for bulk deletes moved test-request.json to the correct location Issue-ID: SO-2203 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I8d9d4d0bbe45f32d4e07a1ba0128e627d3b27795
2019-08-06Added close() call for InputStream instance toOleksandr Moliavko1-1/+5
remove static analyzer warning about handle leak in getMsoAaiPassword() Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: I2be9cc72f78275a80c6f03d806bea2ad275f23b4
2019-08-02ModelInstanceName is required in SNIROHomingv2 toGamboa, Gilbert2-1/+6
ModelInstanceName is required in SNIROHomingv2 to build placement demand. The source service does not have a modelInstanceName attribute, we need to set it to the service proxy modelInstanceName. Issue-ID: SO-2188 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I85c0940b17349c8dd5dc171954acf9f884ccff9f
2019-08-01Added null checks to prevent crashes atOleksandr Moliavko1-6/+12
method calls Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: Ie3b70aa59cf73ca6203d0f1aab1ed096af906050
2019-07-31Merge "Changed to set source service as model info"Steve Smokowski2-2/+2
2019-07-31Changed to set source service as model infoBoslet, Cory2-2/+2
Changed to set source service as model info for service proxy per sniro. Updated junit test to account for source service change. Issue-ID: SO-2179 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I43161f0109b62a895d5122a7b0aca0eea8694b16
2019-07-31added back missing method in groovy fileBenjamin, Max (mb388a)1-0/+14
Need to bring back AbstractTaskProcessor.logWorkflowException() method because this is being called from a number of groovy files. Issue-ID: SO-2172 Change-Id: Id5dee85fcb48265955dde3d74f7c0f98300410f0 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
2019-07-30Merge "Javadoc and logging improvement"Seshu Kumar M1-0/+19
2019-07-26validate model info for existing service withMnushkin, Dmitry2-0/+64
verify modelVersionId equals during SI AAI validation correct SI name in junit test update SI name in junit test comparison add name/module id verifications for other objects add back junit file after merge from remote format jnit file after verify job failure updated test input values for clarity update name verifications with related ID values adding junit for Configuration name verification updated aai verify call, service dup error msg removed aai depth 2 and refactored private test method implement SI name verification with 3 additional fields fix formatting comment line length limitation Issue-ID: SO-2161 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I43f5cb0601dfa8b41f474615b639fce0572f5613
2019-07-26Javadoc and logging improvementPooja031-0/+19
Added Javadocs for four classes AAIUpdateTasks,OrchestrationStatusValidator,AAICreateTasks ,BBInputSetup Issue-ID: SO-2052 Signed-off-by: Pooja03 <pm00501616@techmahindra.com> Change-Id: I048b42131449e151be91839e45f4d39864b3ec52
2019-07-26Enhanced List Level flow with backward supportsarada prasad sahoo1-1/+11
Modified the e2e service instance flow to support both new list types groups along with backward compatibility to support old types alloted resources, network etc. Change-Id: I1cb128e259c54b80009840914b2c1cee8cf8a4df Issue-ID: SO-1393 Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
2019-07-24set multi-stage flag in listener to log successMnushkin, Dmitry2-0/+98
set multi-stage flag in listener to log success msg added post listener for requests db object Issue-ID: SO-2153 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I4b27cbb69b983bd2f7c0d72c8ebb4d9c43201120
2019-07-23Merge "Enhanced List Level flow with backward support"Seshu Kumar M4-105/+177
2019-07-12Added check for null ptr before dereferencing atOleksandr Moliavko1-1/+1
gBBInput.getCustomer().getServiceSubscription() - to prevent static analyzer warning Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: I5e1cb6248412ae9e3036011bd96d708f36170d70
2019-07-05mso will support new requeststate valuesGamboa, Gilbert2-0/+44
Support new request status - ROLLED_BACK, ROLLED_BACK_TO_ASSIGNED, ROLLED_BACK_TO_CREATED, and ABORTED. Support new request status - ROLLED_BACK, ROLLED_BACK_TO_ASSIGNED, ROLLED_BACK_TO_CREATED, and ABORTED. Added default FAILED request status in case rollback is not needed. Variable rollbackTargetState needs to be returned to WorkflowAction flow Variable rollbackTargetState needs to in to ExecuteBuildingBlock as well. Add new RequestDb migration file to expand infra_active_requests column request_status to 25 bytes to fit new request states. Change-Id: I0da2f8013001a28dcc20f64eb9455e4cfd3dd197 Issue-ID: SO-2093 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-07-05update bpmn to save extsystemerrorsourcePlummer, Brittany7-23/+392
Added ext error source to workflow exception Updated all lines that create this exception with source Added unit tests and updated existing ones Change-Id: Id9b3b1e6e24368224214a6370ea2d450ae667bfb Issue-ID: SO-2092 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-07-02Enhanced List Level flow with backward supportsarada prasad sahoo4-105/+177
Modified the e2e service instance flow to support both new list types groups along with backward compatibility to support old types alloted resources, network etc. Change-Id: Ie8fc8a4550a90b44736b6b9de058e2a2e187570c Issue-ID: SO-1393 Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
2019-06-27enhance workflowaction to handle resume funcMnushkin, Dmitry2-0/+104
init code for RESUME with junit passing overwrite URI on resume op from original request Change-Id: I1eee2bd66aa20804ba4a2834d269b5947565b9dc Issue-ID: SO-2055 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-27Fix macro delete instance bug.Gamboa, Gilbert1-0/+5
Fix macro delete instance bug. vf-modules not being sorted correctly because isbaseboolean field is not being set. Change-Id: Id196e152977d922bee6c9bb797ad240bb70fbf47 Issue-ID: SO-2053 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-25Moved code inside IF checking for null ptr to prevent crashOleksandr Moliavko1-3/+3
Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: Ie759b98828f39fba00ccdb7edcd7fc28e83ea50e
2019-06-18support no payload for alacarte deletesSmokowski, Steven1-0/+20
Swap to using HTTP Enumerations rather than ints Add Unit Tests to Service Instances endpoint Add Vnf Tests remove Abstract class Clean up usage of abstract classes Fix volume and module bean wiring issues Add logic to find create request if cloud not in AAI Updated network to take in version pathparam Additonal refactor of the endpoints Add missing license headers to all files Clean up public variable usage, move to protected Change-Id: Icdbdf78aa6c8af7a30fdff8a5805103f8df9364d Issue-ID: SO-2032 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-15Merge "update multi stage code to accurately skip bbs"Max Benjamin32-79/+374
2019-06-14mso to validate the name uniqueness in A&AIGamboa, Gilbert1-0/+18
Need to change query by name using nodes query to make sure names are globally unique. Added new Exception type for duplicate A&AI object names. Added tests for AAIVfModulResources. Change-Id: I71558d0881d7060819f5f807fe58779be6edfa6f Issue-ID: SO-2020 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-14update multi stage code to accurately skip bbsBenjamin, Max32-79/+374
moved around classes to packages that make more sense updated license headers in java files converted MultiStage logic to FlowManipulator moved tests to new package location and fixed issues allow for custom listeners before flowsToExecute moved validation classes to listener.validation Change-Id: Ic5416812ef9c5611fe19bf9b6aa316373b110ec6 Issue-ID: SO-2021 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-10replaced String.repeat with static final stringsBenjamin, Max27-227/+224
replaced String.repeat with static final strings Change-Id: Ife14fde70e8f648881a03e9343ae8faf9cb87e2e Issue-ID: SO-1999 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-06Accommodate WAN NetworkingGamboa, Gilbert20-23/+469
checked and evaluated naming policy only if infra bonding. Updated workflowAction to include vrf configuration for vpn-binding in resourceIds list. added in linked resource to service proxy cust committing the asdc controller classpath change added some unit tests for vrf validation and updated bbinput setup test update config resource cust foreign key mapping Moved mockbean for AssignVrfConfiguration task class into BaseBpmnTest. added in a check to see if list is empty before access added unit tests for bbinput setup for vrf config Update AssignFlows enum with correct AssignVrfConfiguration flow name Change-Id: Ibf14e36505638b19c1366ecebfce560c02e69e44 Issue-ID: SO-1975 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-06Merge remote-tracking branch 'origin/dublin' into 'origin/master'Steve Smokowski19-1166/+1573
Change-Id: I551ea3f29a76dc99532455ea4d7e84a316f9bf38 Issue-ID: SO-1980 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2019-06-05General Sonar fixes and improvementsr.bogacki6-39/+13
General fixes and improvements according to the Sonar analysis. -Fixed imports. -Removed unnecessary variables. -Protect utility static classes with private constructor. -Removed unnecessary exceptions. Issue-ID: SO-1992 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: Ib0011d730f86e0e1a25d4cf1080a61b2fbb335ae
2019-06-05Fix ConfigAssign/Deploy null return of BlueprintName/Versionsunilb3-1/+24
Fix ConfigAssign/Deploy null return of BlueprintName/Version Issue-ID: SO-1985 Signed-off-by: sunilb <sb00577584@techmahindra.com> Change-Id: I15b6d38a21320eae6ca58a1e3d515813b9c243fd
2019-06-03Cleaned up duplicated literalsrob.bog27-107/+135
Cleaned up Sonar code smells related to the duplicated literals in loggers. Issue-ID: SO-1932 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I58c48cec0012c42b7b892ae76c24c6a087c60c7e