summaryrefslogtreecommitdiffstats
path: root/bpmn/MSOCommonBPMN
AgeCommit message (Collapse)AuthorFilesLines
2019-01-25Merge "Removed deprecated Matcher imports"Steve Smokowski7-11/+11
2019-01-24Removed deprecated Matcher importsBenjamin, Max (mb388a)7-11/+11
replaced org.mockito.Matchers with ArgumentMatchers Change-Id: I2feb4d4fb314cd14aca0719c4cc29b1a0510cbf7 Issue-ID: SO-1413 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-24bugfixes jan 24thBenjamin, Max (mb388a)1-0/+30
Fix null pointer exception when no requestParameters are specified Add configurable timer in ActivateVfModuleBB to delay call to SDNC activate - Use raw slf4j logger - use {} formatting Add configurable timer in ActivateVfModuleBB to delay call to SDNC activate - Use raw slf4j logger Add configurable timer in ActivateVfModuleBB to delay call to SDNC activate - removed unused references in test class Add configurable timer in ActivateVfModuleBB to delay call to SDNC activate Update PortGroup objects separately from the parent VCE object - restore setVariable calls back into vce object - they might be needed later. Update PortGroup objects separately from the parent VCE object - updated test class extra call to get PortGroups Update PortGroup objects separately from the parent VCE object - use PortGroup.getInterfaceRole() getter method instead of accessing field directly. Update PortGroup objects separately from the parent VCE object Added back required headers for tenant isolation. removed workflow exception from outmapping in execute Fix possible null ptr exception, fix to add braces. Default networkTechnology in Update as done in Create Fix failing junits, mapper force upper case nwtech update exception builder to properly throw exception error message supporting assign service instance a la carte as well adding in proper exception handling in network rest v1 add the unassign action to R macro data file Change-Id: Ide420514f81b8083b4c76c762c064de199624cf7 Issue-ID: SO-1424 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-21Merge "Bug fixes from AT&T January 20th"Steve Smokowski6-26/+27
2019-01-21Bug fixes from AT&T January 20thBenjamin, Max (mb388a)6-26/+27
sorted vfmodules by base last for negative action reqs store Response in execution as String on network delete added functionality to skip rollback based on flag # Conflicts: # bpmn/so-bpmn-tasks/src/main/java/org/onap/so/bpmn/infrastructure/workflo w/tasks/WorkflowAction.java require XML in the header for delete network request Update APP-C LCM Client library version to 1.7.0. replaced wiremock style test with mockito test Handle AAIClient Exps in CreateCustomerV1 getServiceInstance() changed default status code to be configurable Replace vnfType by nfRole in the healthcheck request to SDNO. updated error messages in sdnc handler and flow status updated flow status message on completion of flow Send GenericVnf object for AAI VNF update for vnf-api updates Add a JUnit test file for SDNOValidatorImpl.java Set nodeType on the inner SDNO request as per update from SDNO. updated rollbackToAssigned logic to remove unassign flows updated sdnc handler error message for client error added exception handling for httpclienterror in sdnc out map workflow exception so error is reported throws sdnc error message on bad response from sdnc add catalog entries for TRANSPORT service delete flows change script number that was duplicate add find method to NorthBoundRequestRepository include serviceType in hash code use asterisk for all non-TRANSPORT flow db entries alacart true, rm not needed transport srvc model steps correct insert query syntax for orchestration_flow support serviceType (TRANSPORT) process flow fix SDNCAdapterException causing no callback to bpmn use JsonAlias for alternate case when deserializing GRM client will accept both "serviceEndPointList" and "ServiceEndPointList" root node in the JSON response. AAIRestClient now uses getSystemName in headers finishtime should not be returned in requeststatus Change-Id: I81a185252b057020f7f36f125c85c3357756da88 Issue-ID: SO-1403 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-20convert from sync to asyncBenjamin, Max (mb388a)1-1/+1
fixed network adapter object mapper test issues fixed all test issues and compilation issues remove setting of notification url for rollback covert sync calls for create and delete network to async removed async after from invoke sdnc adapter task remove unwanted changes that were committed earlier fix unmarshalling of response back from openstack adap added in code to throw an error when AIC issue Change-Id: Ic9fa39584ed2bcb70804fbd74586f1cc119c7d8b Issue-ID: SO-1404 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-14Add missing license headersBenjamin, Max (mb388a)3-0/+60
add headers to files which were missing them Issue-ID: SO-1390 Change-Id: I6c754f72c5d1ef6485d6343aae4b994120901d08 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-12Merge "Created sniro request pojos for homingV2 flow"Steve Smokowski1-1/+3
2019-01-12Merge changes I49db843f,I6c6d7a50Steve Smokowski18-288/+238
* changes: descriptive messages now returned by validator refactored validator to be more generic
2019-01-12Merge "removed retired A&AI versions from codebase"Steve Smokowski1-1/+1
2019-01-12Merge "Miscellaneous fixes"Steve Smokowski1-5/+5
2019-01-12Merge "explicitly type defs and strings for templates"Steve Smokowski11-34/+34
2019-01-11descriptive messages now returned by validatorBenjamin, Max (mb388a)10-20/+28
descriptive messages now returned by validator Change-Id: I49db843fbdfe20979fba6991744c62aa1f745d5f Issue-ID: SO-1388 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-11explicitly type defs and strings for templatesBenjamin, Max (mb388a)11-34/+34
explicitly type defs and strings for templates Change-Id: If4af5b0cdf086cd0d30277d1e835e2aa7c8e7f9c Issue-ID: SO-1386 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-11Miscellaneous fixesBenjamin, Max (mb388a)1-5/+5
updated common pom to use aai schema version 1.4.1 removed handle sync error from SDNCHandler bpmn flow added mso-request-id to in mapping of delete vnf flows moved temporary test file to temporary folder Removed obsolete genericVnfNode parameter from updateGenericVnfNode sorted vfmodules by base last for negative action reqs Change-Id: I7a5018d67292cfaac8d923ac3bd9b27ed037be57 Issue-ID: SO-1382 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-11removed retired A&AI versions from codebaseBenjamin, Max (mb388a)1-1/+1
removed retired A&AI versions from codebase Change-Id: I3e0a185ad1020c91be2fa3df7a509fde2a83c4cd Issue-ID: SO-1385 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-11refactored validator to be more genericBenjamin, Max (mb388a)18-276/+218
removed overloaded method from class for JUEL changed test back to DelegateExecution added methods to allow validations with DelegateExecution refactored validator to be more generic Change-Id: I6c6d7a50e8b5470ffa5619cc83966f5ad68e66fe Issue-ID: SO-1383 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-11validation for vnfs before WorkflowAction startsBenjamin, Max (mb388a)7-0/+421
Removed accidental merge markup from WorkflowActionBB Addition of prevalidation to WorkflowActionBB. Implement more JUnits for validation methods. Implement verification of deleteInstance workflow for VNR configuration dependencies. Added a validation mechanism on a workflow level to check for valid actions. Change-Id: Icb2859c3b8ece534d4e9831ca5f48a15dfaef58d Issue-ID: SO-1379 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-11Created sniro request pojos for homingV2 flowBenjamin, Max (mb388a)1-1/+3
Updated random ports to replaced in expected file response Created sniro request pojos for homingV2 flow. Change-Id: Ib2fedbc28dc048048a21eaa88601bcb0c21360f7 Issue-ID: SO-1376 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-04Bugfixes for December 2018Benjamin, Max (mb388a)6-69/+127
Changed the way that the cidr is constructed in network utils. added in the if statement to check if selflink already exists removed execution line that was not needed in pull added service instance id to workflowResourceIds for virtualLinkKey network flows wrote test for updating request to complete in db workflow action directly updates db instead of using mso complete process Increase max timeout for SDNO Health Checks dmaap. Added execution variable and corrected type and way data is retrieved to fix defect fixed retry status message in request db for #/5 updated workflowActionBBTasks for flow status message updated flow status to failed on a workflowaction fail Removed slashes and fixed rollbackStatusMessage Updated requestStatus logic for adding status messages Added junit test to validate casue of a defect and cleaned up code and logging added end timestamp to request db on complete request fixed l3Network update of orchestation status in DoUpdateNetworkInstance groovy as well fixed update of l3network orchestration status Add explicit resetting of heatStackId in A&AI to DeleteVfModule and DeleteVolumeGroup BBs. Preserve heatStackId setting in the copiedVfModule when updating the VF Module in A&AI. added functionality to skip rollback based on flag Update snapshot version for logging, add headers fixed optional of error in retrieveErrorMessage method Set heatStackId to null if we want to remove it in A&AI. added in a warn logger statement to keep track of field map network technology from l3network instead of model info for network adapter object mapper Force heatStackId value to empty on an attempt to set it to null on update updated common pom to use aai schema version 1.4.1 removed handle sync error from SDNCHandler bpmn flow Change-Id: I1bd7aa55b06d4e439000b216165c9daafeacc9a4 Issue-ID: SO-1361 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-04HttpClientFactory to create HttpClient instancesMichal Kabaj21-31/+73
-Replace constructor calls with existing factory -Add create methods to factory for each required Media Type Change-Id: Ibd03c10230c87a0413c0ec529e0ea9ac800444f9 Issue-ID: SO-1344 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-12-13Merge "Add junit tests for CatalogDBUtils"Steve Smokowski4-62/+203
2018-12-13Merge "Add the query to AAI for SI with customer info"Rob Daugherty1-1/+6
2018-12-13Add junit tests for CatalogDBUtilsLukasz Muszkieta4-62/+203
Change-Id: I1ea3e92b6dcb3fbca837513e11451be47d8c488b Issue-ID: SO-784 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-12-12Merge "Fixed vlan xml and host routes"Steve Smokowski1-394/+25
2018-12-12Add the query to AAI for SI with customer infoKalkere Ramesh, Sharan (sk720x)1-1/+6
added in the same block of code to getSIHelper method Change-Id: I512898d86b5bfd10d1cbbdfeaaa5f2b8cf71510a Issue-ID: SO-1326 Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
2018-12-12Merge "vfc adapter authentication bug fix"Steve Smokowski1-2/+5
2018-12-12Merge "fixed aai response code in updateAAIVfModule"Steve Smokowski3-1/+12
2018-12-12Merge "removed the AAIPropertiesConfiguration file"Steve Smokowski2-89/+0
2018-12-12Merge "ConfirmVolumeGroupNameTest improvements"Steve Smokowski6-74/+275
2018-12-12Merge "fix lookup of si if customer exists"Steve Smokowski1-2/+7
2018-12-12Merge "Changed sdncRequestId to SDNCA_requestId"Steve Smokowski2-4/+4
2018-12-12ConfirmVolumeGroupNameTest improvementsJoanna Jeremicz6-74/+275
Change-Id: I3e611f2577e66932d8337d1768ba803c25d01b39 Issue-ID: SO-784 Signed-off-by: Joanna Jeremicz <joanna.jeremicz@nokia.com>
2018-12-11Fixed vlan xml and host routesKalkere Ramesh, Sharan (sk720x)1-394/+25
Fixed parse error in build vlan xml and host routes, removed dead code. Change-Id: Id3f4e6400434c77f9a942f7e64e03aed91e24c9f Issue-ID: SO-1322 Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
2018-12-11fix lookup of si if customer existsKalkere Ramesh, Sharan (sk720x)2-3/+7
fix lookup of service instance in aai if customer exists remove the unwanted mock in the bb input setup test Change-Id: I12a666fef771c127a69eef254228753204cadd73 Issue-ID: SO-1321 Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
2018-12-11Changed sdncRequestId to SDNCA_requestIdKalkere Ramesh, Sharan (sk720x)2-4/+4
Updated junit groovy test for sdnc adapter Changed to set sdncRequestId to be set to SDNCA_requestId so correlation happens during callback. Change-Id: I6532a676caa4332a32c89ef0ff2e2739d7e8cb56 Issue-ID: SO-1320 Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
2018-12-11fix issue with instance groups and unassign reqKalkere Ramesh, Sharan (sk720x)2-4/+14
fixed issue where instance groups were added on an Unassign request Change-Id: I0bec76d17730553c4ff5c750dfe1d88edabd7837 Issue-ID: SO-1319 Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
2018-12-10removed the AAIPropertiesConfiguration fileKalkere Ramesh, Sharan (sk720x)2-89/+0
remove the test class that was importing it as well remove the AAIPropertiesConfiguration file Change-Id: I65b756961ec3e42a12ccf10ce0bb6cfb8d47ed30 Issue-ID: SO-1318 Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
2018-12-10fixed aai response code in updateAAIVfModuleKalkere Ramesh, Sharan (sk720x)3-1/+12
Added PUAAIVfMod_updateVfModuleResponseCode to be set to execution Added responseCode verification in unit tests Set UAAIVfMod_updateVfModuleResponseCode Change-Id: I0d429388ff49ae78241ad1b0f33815a80f749061 Issue-ID: SO-1313 Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
2018-12-10Merge "requestid retrieval and validation in bpmn"Rob Daugherty3-73/+128
2018-12-10Merge "fix execute and workflow layers for recreate"Rob Daugherty2-44/+92
2018-12-10requestid retrieval and validation in bpmnKalkere Ramesh, Sharan (sk720x)3-73/+128
Change-Id: I4d30a784eed5dd68f9ee7c2b6833d72cbf0eccfa Issue-ID: SO-1311 Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
2018-12-10fix execute and workflow layers for recreateKalkere Ramesh, Sharan (sk720x)2-44/+92
reverted resource id change and populated service id removed all unnecessary mocks from bb input setup test fixed unit tests that were failing in PR committing to get jenkins verify pipeline job to run fix both workflow action and bb input setup for recreate replace Change-Id: I789738a77ebcc42c2256a434cb4785212cf592a7 Issue-ID: SO-1309 Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
2018-12-10Merge "add in volume group model info lookup"Rob Daugherty2-10/+50
2018-12-10add in volume group model info lookupKalkere Ramesh, Sharan (sk720x)2-10/+51
added in the lookup of volume group for vf on macro as well Change-Id: Ie3582724b78e88a0b2dd90c37dff086b5e2c3bf9 Issue-ID: SO-1298 Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
2018-12-10Merge "remove unused methods"Rob Daugherty5-1229/+2
2018-12-10Merge "fixed headers for traceability"Rob Daugherty4-90/+98
2018-12-10Merge "remove multiline strings with A&AI client"Rob Daugherty1-12/+10
2018-12-10Merge "fix volume group model info retrieval"Rob Daugherty2-9/+21
2018-12-10Merge "Add unit tests for ExternalAPIUtil"Rob Daugherty3-18/+247