Age | Commit message (Collapse) | Author | Files | Lines |
|
Increase junit tests coverage according to Sonar analyses.
Fix imports.
Change-Id: Ia6c3f4a3178f5293ee6750f7581cd7107c8ced84
Issue-ID: SO-1692
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
|
|
|
|
The BPMNLogger class has overlapping use to preferred solution based on
slf4j and logback - thus has been replaced by it.
Change-Id: I9889d4b9ab06f28941f0d827df889e3c081155da
Issue-ID: LOG-631
Signed-off-by: Witold Ficio Kopel <w.kopel@samsung.com>
|
|
|
|
The BPMN layer has the CloudRegion which includes the CloudOwner
attribute, but this is not passed to the VNF adapter layer.
Calls to the Multicloud infrastructure workload need the
CloudOwner as well.
This patch adds CloudOwner to the VNF adapter API. While
the intended usage is primarily for the multicloud adapter,
it touches a log of other files - though those do not
make use of it at this point.
Change-Id: I88028096fbd84fc3fe5d53786c70b3c8806bb711
Issue-ID: SO-1447
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
|
|
|
|
Following methods has been removed from MsoUtils (.groovy) class:
logContext(requestId, serviceInstanceId)
logMetrics(elapsedTime, logtxt)
logAudit(logtxt)
as no longer required.
Remaining uses of them in other groovy clases has been deleted/replaced by
apropriate use of logback.
Change-Id: I473f01b65c67e90667311cff3b2a671e719f7258
Issue-ID: LOG-631
Signed-off-by: Witold Ficio Kopel <w.kopel@samsung.com>
|
|
Bye bye MsoLogger class.
Extracted constants to separated classes.
Fixed imports.
Change-Id: I7c8e0527e7dbd097d3ea93b9dab279354652da47
Issue-ID: LOG-631
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
|
|
Update Tasks API with additional fields and new valid response
Change-Id: I39d85ae599f9274373bbcf66dce4752ee75f16ed
Issue-ID: SO-1594
Signed-off-by: Kuleshov, Elena <evn@att.com>
|
|
fix unit test that was broken because of mapping
correctly connect the configuration to vfModule
added in mapping of configuration to aai object
fix compilation error with mapper layer
Fix unit test compare to contain vfnc name
Update vnfc to have proper generated serialVersionID
Change-Id: I161c73b3ace1e9c5385c028ae65fe5258b4decd5
Issue-ID: SO-1663
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
added vnfc to gbb for execute bb and bb layer
enhance workflow action layer to handle vnfcs
Change-Id: I0d39c3aefe66180ed6f2b75a0c946e07ca603261
Issue-ID: SO-1658
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Cleaned java and groovy code from 'getServiceName'
method in MsoLogger.
Change-Id: I23c3fc8005db5f89e94b87271bb60b7bcce72064
Issue-ID: LOG-631
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
|
|
Cleaned java code dependencies for
'setLogContext' and 'getServiceName'
methods from MsoLogger.
Fixed imports.
Change-Id: I33251c837088ce580ffa1c44e69766c77283004b
Issue-ID: LOG-631
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
|
|
only cast to Element if value is of that type
added XmlAccessorType annotations to classes
map of string, object now correctly maps with jaxb
Null comma delimited lists can convert to null as well
Handle null values all types in input parameters map.
Change-Id: Ic46ed31c05b8f8551d39b2267ae731829abfc1f0
Issue-ID: SO-1617
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
Modifications of groovy scripts in MSOCommonBPMN removing following:
Replaced MsoLogger with plain slf4j.
Refactored loging output.
Fixed imports.
Replaced utils.log() with respective logger calls (except for
AbstractServiceTaskProcessor class).
Modifications to MsoUtils class.
Change-Id: I6bdd8ab6f60dca9b765fcf7d56f5aaa707c028cc
Issue-ID: LOG-631
Signed-off-by: Witold Ficio Kopel <w.kopel@samsung.com>
|
|
add create support
add delete support
added naming service support
Change-Id: Iaf4f2bdae8ea55aca71d6e9b818a76e90db0b012
Issue-ID: SO-1616
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
Change-Id: I22834f989afb748917aa2099b1da78c5f794bbe5
Issue-ID: CCSDK-1055
Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
|
|
Adjust test data to add tenant mapping
Remove unused unit test already renamed
Update logic, to pass hostname not pservername
remove unused file that has been refactored
Add project to ignore, remove class
Address issues in comments on pull request
Remove logging that is not needed, used
UPdate BPMN to use Boolean Value, change timings
Adjust BPMN to not hit deadlock scenario
put error message in execution before checking rollback
- removed extra code for vnf resource processing found in onap
environment.
Fix improper use of inclusive gateway causing deadlock
Fix flakey unit tests from ONAP
Remove qualifier on bean, as it breaks callbacks
Adjust pom version of external camunda client
Fix polling timers to be more reasonable
Updated Junit test for delete vf module in onap.
Changed auditInventoryNeeded variable to a boolean to prevent
bpmn from erroring out in the event this variable is not found
on the execution.
Update logic to support writing of self link
Change-Id: I2f784a0a58a09f303775282c9be6019031668570
Issue-ID: SO-1597
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
|
|
Correct the JUnits to address userParams non-String values
Remove restriction on mapping of String values only for userParams in
BB RequestContext.
Change-Id: I8a0d30e61618c275301d62bf04c064bea56c1b4d
Issue-ID: SO-1593
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
put error message in execution before checking rollback
Change-Id: I41bc89f589a260aece0c837d83218794ec1ec72e
Issue-ID: SO-1591
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
flow validators can now be skipped via an annotation
Change-Id: I7796d5829aacee466419d558dfc95a761125577a
Issue-ID: SO-1589
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
map object representations of json back to json strings
marshal all objects to json strings before sending
all input params converted to Map<String, Object>
Updated userParams map from HashMap<String, String> to Map<String,
Object> as HashMap<String, String> userParams was causing VNF spin up
to fail. Input json in Userparams was not accepted as a valid json
format. Updated other files that were affected by this change.
Change-Id: I0c00fc00c4c11b54ace4df7be8d5bfc80d41d130
Issue-ID: SO-1582
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Removed MsoLogger from adapters ('MSOCommonBPMN')
Replaced MsoLogger with plain slf4j.
Refactored login output.
Fixed imports.
Change-Id: I5e1ed5e438c19be9a9cfd2decae06c706fd1a92a
Issue-ID: LOG-631
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
|
|
Change-Id: I3f77a2c9e8341239b97675f5897cecf28c7dfb6f
Issue-ID: SO-1483
Signed-off-by: Alexis de Talhouët <adetalhouet89@gmail.com>
|
|
fixed unit test after changing how entities are read
remove payload logging from metric/audit side
Change-Id: Ibfe7cf96c76920926e9ae9ce5041389324d09b46
Issue-ID: SO-1564
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
|
|
This git review replaces https://gerrit.onap.org/r/#/c/78430/. As I had
some issues updating the existing git review, I'm creating a new one.
Issue-ID: SO-1391
Change-Id: Ida3f94ad7e2249a30a99d67a071930323ba743b5
Signed-off-by: Prema Bhatt <pb6115@att.com>
|
|
Corrections to JUnit data to account for usePreload usage.
Resurrect usage of usePreload value and pass fromPreload to SDNC.
Change-Id: I6fb52f6abf09ec501e90335a01e37db1c10ae2b3
Issue-ID: SO-1539
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Use Flowvalidator shouldRunFor method to check if flow needs to be
validated.
Create Pre Building Block validator to check if cloud-region
orchestration-disabled is true
Change-Id: I2f1dca16c97505292d9b99f7e206713e4963261f
Issue-ID: SO-1534
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
fixed unit tests that reference forItems()
forItems is now shouldRunFor allowing more flexibility
Change-Id: I497f3a2899ae4df555e781c7c85a238e657fcba8
Issue-ID: SO-1533
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
fixed CandidateType json serialization
Change-Id: Icafa5884db5424167c7fac08ad6aae5781bdafa5
Issue-ID: SO-1503
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
|
|
According to Sonar current implementation could cause
NullPointerException.
Added JUnit test.
Change-Id: I840c018bed346d85e2042c7308bdd27197f50b46
Issue-ID: SO-1498
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
|
|
|
|
fixed an error with the wrong variable being printed
made max retries configurable via mso config
Change-Id: Iec6d209ec2868200ec5956e269b6a048d7619307
Issue-ID: SO-1495
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
made generics a bit safer and updated groovy tests
Change-Id: I6d7a2567cd9bf795e0cfa4914a7674a4ed5f50c4
Issue-ID: SO-1493
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Corrected a JUnit to include updated timeout value.
Increase long poll DMaaP timeout value to 60 seconds
Change-Id: I22a6f17bc694b17b14f25c7dccd6b57d89d0c2b7
Issue-ID: SO-1488
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
add in a junit test to check if all vfModules model info get populated
populate all vf modules for the vnf not just the orchestrated
Change-Id: Icaed88f217f61861157313a0c7e09a28fff74fdb
Issue-ID: SO-1467
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Updated setter methods in avpn bonding classes.
Updated fields on sniro request to be idenitier instead of candidate
Change-Id: I67a98f742b28a93912c4b6fb05618449b629c883
Issue-ID: SO-1463
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Address Review comments on pull request
Update Unit test to have proper variable for testing
update logic inside bpmn to reflect proper variable
Update unit test to check property for audit
Add flag to turn on and off audit behavior
Add license headers, remove un-used files
Update Building Block Tests and Activity Names
Fix additional unit tests in so-bpmn-tasks layer
Fix broken Junit Test, and correct Bug in if statement
Add annotation to ignore class under test profile
Additional bug fixes and unit tests for classes
Add Additional JUNITS, add more sample data
Add Openstack Audit functionality to Adapter
Change-Id: I0492063271e991eefc608b56336a5cdf1d5a7778
Issue-ID: SO-1456
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Add setting of serviceId to productFamilyId and provStatus to PREPROV
on GenericVnf creation
Change-Id: I6b09e8dff522af6c0b32a0bfe30dc6b0623fc900
Issue-ID: SO-1453
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Issue-ID: SO-1435
Change-Id: If065ef5c91e769452fd6701fa6c28a23b4bdf2b2
Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
|
|
|
|
replaced org.mockito.Matchers with ArgumentMatchers
Change-Id: I2feb4d4fb314cd14aca0719c4cc29b1a0510cbf7
Issue-ID: SO-1413
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|