Age | Commit message (Collapse) | Author | Files | Lines |
|
Added in maven plugins to enforce coding style rules
Added in eclipse java formatting xml
Change-Id: I3727bbf4ce8dc66abfd8ad21b6cfd0890c5d3ff0
Issue-ID: SO-1765
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
|
|
Fixed blockers according to Sonar analysis.
Added tests for fixed issues.
Change-Id: I8e259147082d722961048454fae9484cc0d8b0a8
Issue-ID: SO-1734
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
|
|
Add PNF ipv4/v6 address for config Deploy
Add Integration test for CreateVcpeResCustService_simplified.bpmn
Modify the PnfEventReadyDmaapClient to avoid one more running thread
Refactor the so-bpmn-infrastructure-flows test resources
Modify the CreateVcpeResCustService_simplified.bpmn
Add ConfigurePnfResource.bpmn
Add Delegates
Issue-ID: SO-1506
Change-Id: Iffb69d1441ef0b485ee8cd3fb5da5f1a35279a95
Signed-off-by: eeginux <henry.xie@est.tech>
|
|
DoDeleteVfModuleV2: non-existing variable uri (was renamed to resourceUri)
DoUpdateNetworkInstance: queryIdResponse type is expected to be L3Network
UpdateVfModuleVolumeInfraV1: non-existing variable cloudOwner
Include tests for those fixes to build
Change-Id: Icaea91260fbf6603f134df893a64ec1ca5ac40ab
Issue-ID: SO-1649
Signed-off-by: k.kazak <k.kazak@samsung.com>
|
|
Hibernate entities were all wrong and needed
a complete rewrite.
The scope kept growing and ended up touching a
lot more of the code than originally planned.
These changes make the db interactions much easier
and more straightforward from java.
The flyway script order had to change to make this
migration possible.
Change-Id: I6ce363a385661300eddb11923ac6a80538edaddc
Issue-ID: SO-1710
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
trying to get the tests that can be threaded to pass
started to remove fixed port references
Change-Id: I7bfe067a8f36c908039700646571681321e9a6f5
Issue-ID: SO-1676
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
Standardized usage of MsoUtils class in all methods of SDNCAdapterUtils.
Removed AbstractServiceTaskProcessor from constructor parameter.
Change-Id: I45263aefc980163a927d8a6dce886e299691e025
Issue-ID: SO-1700
Signed-off-by: Witold Ficio Kopel <w.kopel@samsung.com>
|
|
Change-Id: I140796717f9e8a365650355d92df60b85bc7a8e2
Issue-ID: SO-1690
Signed-off-by: Andrei Barcovschi <andrei.barcovschi@ericsson.com>
|
|
|
|
Increase junit tests coverage according to Sonar analyses.
Fix imports.
Change-Id: Ia6c3f4a3178f5293ee6750f7581cd7107c8ced84
Issue-ID: SO-1692
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
|
|
|
|
|
|
|
|
|
|
removed extra argument from extractByKey method
Change-Id: I9835672eef5d6ab0c7b0c2b21e5a84be8aa305a7
Issue-ID: SO-1678
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Refactored calls to MsoUtils.log() to use logger object already present
in the CatalogDbUtils class.
In addition the CatalogDbUtils class has been accepting MsoUtils object
as parameter to constructor - which is not necessary and not aligned
with style in rest of the groovy code.
Change-Id: Ib80593294ead5b2779f667d8e58f128e958538f0
Issue-ID: LOG-631
Signed-off-by: Witold Ficio Kopel <w.kopel@samsung.com>
|
|
removed unused test classes and methods
Change-Id: I9ae5f6f49e416f208e8879ed202aa8865bc9ef83
Issue-ID: SO-1687
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Generic Bulding block for assign shall trigger controller for config
assign action
Change-Id: I2da91cccdbff9eacbb225b7f3a7bdbb253be607a
Issue-ID: SO-1481
Change-Id: I2da91cccdbff9eacbb225b7f3a7bdbb253be607a
Signed-off-by: sunilb <sb00577584@techmahindra.com>
|
|
The BPMN layer has the CloudRegion which includes the CloudOwner
attribute, but this is not passed to the VNF adapter layer.
Calls to the Multicloud infrastructure workload need the
CloudOwner as well.
This patch adds CloudOwner to the VNF adapter API. While
the intended usage is primarily for the multicloud adapter,
it touches a log of other files - though those do not
make use of it at this point.
Change-Id: I88028096fbd84fc3fe5d53786c70b3c8806bb711
Issue-ID: SO-1447
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
|
|
added vnfc to gbb for execute bb and bb layer
enhance workflow action layer to handle vnfcs
Change-Id: I0d39c3aefe66180ed6f2b75a0c946e07ca603261
Issue-ID: SO-1658
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
add create support
add delete support
added naming service support
Change-Id: Iaf4f2bdae8ea55aca71d6e9b818a76e90db0b012
Issue-ID: SO-1616
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Adjust test data to add tenant mapping
Remove unused unit test already renamed
Update logic, to pass hostname not pservername
remove unused file that has been refactored
Add project to ignore, remove class
Address issues in comments on pull request
Remove logging that is not needed, used
UPdate BPMN to use Boolean Value, change timings
Adjust BPMN to not hit deadlock scenario
put error message in execution before checking rollback
- removed extra code for vnf resource processing found in onap
environment.
Fix improper use of inclusive gateway causing deadlock
Fix flakey unit tests from ONAP
Remove qualifier on bean, as it breaks callbacks
Adjust pom version of external camunda client
Fix polling timers to be more reasonable
Updated Junit test for delete vf module in onap.
Changed auditInventoryNeeded variable to a boolean to prevent
bpmn from erroring out in the event this variable is not found
on the execution.
Update logic to support writing of self link
Change-Id: I2f784a0a58a09f303775282c9be6019031668570
Issue-ID: SO-1597
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
Correct the JUnits to address userParams non-String values
Remove restriction on mapping of String values only for userParams in
BB RequestContext.
Change-Id: I8a0d30e61618c275301d62bf04c064bea56c1b4d
Issue-ID: SO-1593
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
flow validators can now be skipped via an annotation
Change-Id: I7796d5829aacee466419d558dfc95a761125577a
Issue-ID: SO-1589
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
map object representations of json back to json strings
marshal all objects to json strings before sending
all input params converted to Map<String, Object>
Updated userParams map from HashMap<String, String> to Map<String,
Object> as HashMap<String, String> userParams was causing VNF spin up
to fail. Input json in Userparams was not accepted as a valid json
format. Updated other files that were affected by this change.
Change-Id: I0c00fc00c4c11b54ace4df7be8d5bfc80d41d130
Issue-ID: SO-1582
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Removed MsoLogger from adapters ('MSOCommonBPMN')
Replaced MsoLogger with plain slf4j.
Refactored login output.
Fixed imports.
Change-Id: I5e1ed5e438c19be9a9cfd2decae06c706fd1a92a
Issue-ID: LOG-631
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
|
|
fixed unit test after changing how entities are read
remove payload logging from metric/audit side
Change-Id: Ibfe7cf96c76920926e9ae9ce5041389324d09b46
Issue-ID: SO-1564
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
|
|
This git review replaces https://gerrit.onap.org/r/#/c/78430/. As I had
some issues updating the existing git review, I'm creating a new one.
Issue-ID: SO-1391
Change-Id: Ida3f94ad7e2249a30a99d67a071930323ba743b5
Signed-off-by: Prema Bhatt <pb6115@att.com>
|
|
Corrections to JUnit data to account for usePreload usage.
Resurrect usage of usePreload value and pass fromPreload to SDNC.
Change-Id: I6fb52f6abf09ec501e90335a01e37db1c10ae2b3
Issue-ID: SO-1539
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
fixed unit tests that reference forItems()
forItems is now shouldRunFor allowing more flexibility
Change-Id: I497f3a2899ae4df555e781c7c85a238e657fcba8
Issue-ID: SO-1533
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
|
|
According to Sonar current implementation could cause
NullPointerException.
Added JUnit test.
Change-Id: I840c018bed346d85e2042c7308bdd27197f50b46
Issue-ID: SO-1498
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
|
|
|
|
fixed an error with the wrong variable being printed
made max retries configurable via mso config
Change-Id: Iec6d209ec2868200ec5956e269b6a048d7619307
Issue-ID: SO-1495
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
made generics a bit safer and updated groovy tests
Change-Id: I6d7a2567cd9bf795e0cfa4914a7674a4ed5f50c4
Issue-ID: SO-1493
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Corrected a JUnit to include updated timeout value.
Increase long poll DMaaP timeout value to 60 seconds
Change-Id: I22a6f17bc694b17b14f25c7dccd6b57d89d0c2b7
Issue-ID: SO-1488
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
add in a junit test to check if all vfModules model info get populated
populate all vf modules for the vnf not just the orchestrated
Change-Id: Icaed88f217f61861157313a0c7e09a28fff74fdb
Issue-ID: SO-1467
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Address Review comments on pull request
Update Unit test to have proper variable for testing
update logic inside bpmn to reflect proper variable
Update unit test to check property for audit
Add flag to turn on and off audit behavior
Add license headers, remove un-used files
Update Building Block Tests and Activity Names
Fix additional unit tests in so-bpmn-tasks layer
Fix broken Junit Test, and correct Bug in if statement
Add annotation to ignore class under test profile
Additional bug fixes and unit tests for classes
Add Additional JUNITS, add more sample data
Add Openstack Audit functionality to Adapter
Change-Id: I0492063271e991eefc608b56336a5cdf1d5a7778
Issue-ID: SO-1456
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Add setting of serviceId to productFamilyId and provStatus to PREPROV
on GenericVnf creation
Change-Id: I6b09e8dff522af6c0b32a0bfe30dc6b0623fc900
Issue-ID: SO-1453
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Issue-ID: SO-1435
Change-Id: If065ef5c91e769452fd6701fa6c28a23b4bdf2b2
Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
|
|
replaced org.mockito.Matchers with ArgumentMatchers
Change-Id: I2feb4d4fb314cd14aca0719c4cc29b1a0510cbf7
Issue-ID: SO-1413
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
remove deobfuscate as crypto is already used.
update based on the feedback to use crypto utils to decrypt
Re-Factor DMAAP Credentials to use encrypted auth credential
Change-Id: I2ac5be84594d84f0f24ae554d99cef274dbb6c16
Issue-ID: SO-1425
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
sorted vfmodules by base last for negative action reqs
store Response in execution as String on network delete
added functionality to skip rollback based on flag # Conflicts: #
bpmn/so-bpmn-tasks/src/main/java/org/onap/so/bpmn/infrastructure/workflo
w/tasks/WorkflowAction.java
require XML in the header for delete network request
Update APP-C LCM Client library version to 1.7.0.
replaced wiremock style test with mockito test
Handle AAIClient Exps in CreateCustomerV1 getServiceInstance()
changed default status code to be configurable
Replace vnfType by nfRole in the healthcheck request to SDNO.
updated error messages in sdnc handler and flow status
updated flow status message on completion of flow
Send GenericVnf object for AAI VNF update for vnf-api updates
Add a JUnit test file for SDNOValidatorImpl.java
Set nodeType on the inner SDNO request as per update from SDNO.
updated rollbackToAssigned logic to remove unassign flows
updated sdnc handler error message for client error
added exception handling for httpclienterror in sdnc
out map workflow exception so error is reported
throws sdnc error message on bad response from sdnc
add catalog entries for TRANSPORT service delete flows
change script number that was duplicate
add find method to NorthBoundRequestRepository
include serviceType in hash code
use asterisk for all non-TRANSPORT flow db entries
alacart true, rm not needed transport srvc model steps
correct insert query syntax for orchestration_flow
support serviceType (TRANSPORT) process flow
fix SDNCAdapterException causing no callback to bpmn
use JsonAlias for alternate case when deserializing
GRM client will accept both "serviceEndPointList" and
"ServiceEndPointList" root node in the JSON response.
AAIRestClient now uses getSystemName in headers
finishtime should not be returned in requeststatus
Change-Id: I81a185252b057020f7f36f125c85c3357756da88
Issue-ID: SO-1403
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|