summaryrefslogtreecommitdiffstats
path: root/bpmn/MSOCommonBPMN/src/main
AgeCommit message (Collapse)AuthorFilesLines
2018-05-17Revert placementInfo to placement in SniroHomingMarcus G K Williams1-1/+1
Issue-ID: SO-628 Change-Id: I6e9e44d453a72b4e9ec1a0abe99eb8028aa5ba1a Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2018-05-16Revert placementInfo to placement in SNIROUtilsMarcus G K Williams1-2/+2
Issue-ID: SO-628 Change-Id: I3bd802fc966f466b12556d19e347a130e152a51d Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2018-05-15WorkflowResponse json issuesRob Daugherty4-59/+87
This commit adds some robustness to the interface between the API-H and BPMN, specifically, in how the response is handled. I don't have proof, but there appears to be some randomness to the json provider behavior when used with the jax-rs. Sometimes, the serializer is adding the root element, and sometimes it is not. Maybe there's something wrong with the configuration. Maybe we have competing json providers. I couldn't pin this down. I'm almost certain it is the presence of the root element in the content that causes the API-H code to fail parsing of the BPMN response. This doesn't kill the request, as you might expect, but rather, the API-H passes the BPMN response through to the client (VID, or policy, or whatever). The original problem (SO-586) was "fixed" by "removing the wrapper". This "wrapper" is a needed feature of the interface between BPMN and the API-H. We shouldn't have removed it. The fact that the "fix" appeared to work is due to the behavior I described in the previous paragraph. The API-H chokes on the message, and it passes it through unchanged. Not really what we want. So, I don't know why the jackson/json behavior is flaky and different now, but I can (and did) modify the API-H so it can parse a json message whether or not it has a root element. Note that WorkflowResponse.java (in BPMN) and CamundaResponse.java (in the API-H) are basically the same bean representing the message format. Seems less than ideal to have two different classes. Also note that I changed the name of the "response" attribute of the WorkflowResponse and CamundaResponse classes to "content". Got tired of seeing this nonsense everywhere in the code: response.getResponse() Change-Id: Icaf70f8457de99e493cf882170fe778c620308c9 Issue-ID: SO-586 Issue-ID: SO-618 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-05-08Remove wrapper from WorkflowResponseArthur Martella1-2/+2
When the workflow response succeeds, the requestReferences object is being wrapped by "WorkflowResponse": {"response": {... and all the other fields from the WorkflowResponse object are being included as well. Adding a WorkflowResponseSerializer didn't seem to work since the root node was still included and there was no ObjectMapper in which to set WrapRootValue to false. So this is the next best thing. Patch 2 fixes most of the broken unit tests. Change-Id: Ifa5bd02e70b23f41c9042ac207848c8ade77313a Issue-ID: SO-586 Signed-off-by: Arthur Martella <am153x@att.com>
2018-05-04Use tosca parser without resolving GetInputsubhash kumar singh1-1/+1
Use tosca parser without resolving GetInput. Change-Id: I964464dd76c0bdd096e67ce78ab4cc7c2e76a167 Issue-ID: SO-422 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-05-03ecomp-model-information to onap-model-informationArthur Martella1-17/+28
Change-Id: I05f4648ff898a54e7a00d899d97129746172cdb4 Issue-ID: SO-603 Signed-off-by: Arthur Martella <am153x@att.com>
2018-04-25Set Resource Recipe Time Out Valc001491072-12/+15
Set Resource Recipe Time Out Val Change-Id: I7f304465c71837ee37e5fa99a48ca14d97d8f91f Issue-ID: SO-587 Signed-off-by: c00149107 <chenchuanyu@huawei.com>
2018-04-25Sonar-Critical:Use Dedicated ExceptionAS004650591-157/+157
File Name:ApplicationControllerAction.java Line: L127 L134 L142 L150 L155 L160 L165 Sonar Link: https://sonar.onap.org/project/issues?assignees=as00465059&id=org.onap.so%3Aso&open=AWJuJvroRGy6eclHE9B2&resolved=false&rules=squid%3AS00112&severities=CRITICAL%2CMAJOR Change-Id: I84c79aef3ceda73b9421b0a1881c5d14817c7840 Issue-ID: SO-593 Signed-off-by: AS00465059 <AS00465059@techmahindra.com>
2018-04-24Create VF Module ErrorRob Daugherty1-30/+69
There are multiple issues here. 1) The LCM healthcheck and config-scale-out should be made conditional upon the VNF orchestration status being Active or Activated. I'm not going to do that with this commit, since the logic will probably need to be moved to the DoCreateVfModule flow. What I will do is bypass the LCM operations to unblock testing. Another ticket will need to address the real solution. 2) APP-C gave us an API where the controller type is configured in their client object, which is NOT what we wanted. As a result, we have to keep a client object for each controller type. Our implementation did not do this. 3) Need to support the APP-C client configuration properties for specifying the SDN-C topic names. I'm refactoring the APP-C client urn mapping names to make it clear that they are for configuring the APP-C *client* and not necessarily for APP-C itself. Change-Id: I588f3b98b4ee44ba53b4931f9f1a7938ee70bebf Issue-ID: SO-577 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-04-23Sonar-Critical Bug FixingAS004650593-295/+303
File:RestfulUtil.java Line:L85 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:E2EServiceInstances.java Line:L263 L1059 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:OrchestrationRequests.java Line:L343 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:ASDCConfiguration.java Line:L286 L378 SonarLink: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:ResourceInput.java Line:L287 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:ResourceRecipeRequest.java Line:L136 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:ResourceRequestBuilder.java Line:L108 L214 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:CheckAaiForCorrelationIdDelegate.java Line:L70 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:AbstractSdncOperationTask.java Line:L359 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:DmaapClient.java Line:L62 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL File:HasAnnotationPropertyWithValueMatcher.java Line:L60 Sonar Link: https://sonar.onap.org/issues?assigned=false&projectUuids=AWHCr9eDWid2ybiDeORt&resolved=false&rules=squid%3AS1166&severities=BLOCKER%2CCRITICAL Change-Id: Ic168a118790c31850a9f32f98465be5d52b8c96f Issue-ID: SO-581 Signed-off-by: AS00465059 <AS00465059@techmahindra.com>
2018-04-21Fix request parameter building for sdnc resourcesubhash kumar singh1-6/+1
Fix request parameter building for sdnc resource Change-Id: Ib87c08e31837ec9f2c10bcfe9ce7caccfb3f461e Issue-ID: SO-422 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-04-21Merge "Fix input for SDNC resource creaation"Chuanyu Chen1-2/+7
2018-04-20Fix input for SDNC resource creaationsubhash kumar singh1-2/+7
Fix version id and model name. Fix input param for sdnc resource request. Change-Id: I6ade488aec061c9bf4dc0cd04e124896a71571be Issue-ID: SO-422 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-04-20Update create flow for E2E servicec001491074-9/+74
Update create generic flow for E2E service Change-Id: I7f5c912348ce0d0ee9035aa3a5e34979ee14b247 Issue-ID: SO-583 Signed-off-by: c00149107 <chenchuanyu@huawei.com>
2018-04-18AAIRestClient support for Basic AuthRob Daugherty2-21/+10
Adding support for Basic Auth in the AAI Rest Clients because ONAP uses this (whereas ECOMP uses 2-way SSL). In general, each AAI client will allow the user to configure properties called "aai.auth" and "mso.msoKey". If these are set, then the client will add the Authorization header to every request. Change-Id: I7c81ec05d2ec4a7dca131f2e9e19d341ac89b09f Issue-ID: SO-576 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-04-11Merge "Fix exception case in null return"Seshu Kumar M1-0/+9
2018-04-10Fix exception case in null returnsubhash kumar singh1-0/+9
Fix exception case in null return. Change-Id: I7f6a0ec3c372e34c1f04468be729d1cbc079e991 Issue-ID: SO-422 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-04-10Merge "Bug Fix - OOF api updates processing flavor-label"Seshu Kumar M2-46/+80
2018-04-10Fix URL to get CSAR namesubhash kumar singh1-3/+4
Fix URL to collect CSAR name. Change-Id: I6ba5baf5b41cb24793e510f93d1a9ffe6de4407e Issue-ID: SO-422 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-04-10Add service type for bpmn inputsubhash kumar singh1-0/+1
Add service type for bpmn input. Change-Id: Icc7487724bd4f6df5a78473f39a0e99a4e16cd28 Issue-ID: SO-422 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-04-10Update web.xml file to enable propertiessubhash kumar singh1-0/+1
Update web.xml to enable reacing properties from MSO-API-Prop. Change-Id: I7dc1f48ff798c6f83e8976584edb5dfd9152f950 Issue-ID: SO-422 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-04-10Fix JsonProperty for BpmnParamsubhash kumar singh1-1/+1
Fix JsonProperty for BpmnParam. Change-Id: I98c9e92ccd08c0d5965d9f18dc68ab6d0c7f822b Issue-ID: SO-422 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-04-09Bug Fix - OOF api updates processing flavor-labelMarcus G K Williams2-46/+80
Additional API interactions were added to OOF response post API freeze that enable core HPA functionality. This patch updates the processsing of the API reponse to process additional flavor parameters. Issue-ID: SO-408 Change-Id: I1656a7ba955ab41c57b7a3e07a3d0cc38b16e2fa Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2018-04-06Added hc and configscaleout to vfmoduleinfraBancala, Ben (bb3476)1-1/+3
Change-Id: I2d5434785708ed34d1f28e22f134857bfcae02b1 Issue-ID: SO-551 Signed-off-by: Bancala, Ben (bb3476) <bb3476@att.com>;
2018-04-02SO application deployment issuesRob Daugherty1-0/+32
There are a few problems here. 1) Hibernate definitions for a few tables don't match the column definitions in the MySQL schema scripts. 2) The process engine in MSOInfrastructureBPMN is defined incorrectly. 3) Several bpmn flows have errors that block deployment. Change-Id: I029238b82736a3d4977fdf56416c5feb2705b041 Issue-ID: SO-557 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-03-28ControllerType update for CM flowsElena Kuleshov4-35/+41
Change-Id: I42c60ba45baaf29fa5fe54a8bb7ffc0aab5622c7 Signed-off-by: Elena Kuleshov <ek1439@att.com> Issue-ID: SO-526
2018-03-27Refactor homing flows for OOF/HPAMarcus G K Williams6-534/+1373
1. Split Homing into OOF and SNIRO versions 2. Added OOF API interactions 3. Added Unit tests for OOF Homing Code Issue-ID: SO-404 Change-Id: Ifeeeec9ea450d8b330110a565208ed89a1e18cde Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2018-03-27Dependency version updates for BeijingRob Daugherty1-7/+7
Update so/libs version to 1.2.1 Update aai-common version to 1.2.1 Update sdc-distribution-client version to 1.3.0 Update sdc-tosca version to 1.3.3 Change-Id: I6c8f1c5476efc4dc866bf765c265736ab70c12c7 Issue-ID: SO-536 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-03-22Added OpenPojo Validations to beansSmokowski, Steve (ss835w)1-11/+21
Change-Id: I34d8922a55b1ba35610ad0856dcd3363fa016785 Issue-ID: SO-516 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-03-22CII badging issue resolutionManamohan Satapathy2-3/+8
Pwd detected in this expression is potentially hardcoded credential CryptoHandler.java:L31 Sonar link:https://sonar.onap.org/issues?myIssues=true&open=AWHCr-PVEU5FCDfKtl8E&resolved=false Change-Id: I29aaa489a4b1f2e472eb11ed8ba811d31a4d6809 Issue-ID: SO-478 Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>
2018-03-21Merge "SO License issue fix take 3"Seshu Kumar M2-16/+1
2018-03-21SO License issue fix take 3Seshu-Kumar-M2-16/+1
Issue-ID: SO-505 Change-Id: Ie253b0d9d54b72b2716c0f9fe0ee8c47f340ec84 Signed-off-by: Seshu-Kumar-M <seshu.kumar.m@huawei.com>
2018-03-21Generate sdnc network operation request bodyc001491071-47/+23
Generate sdnc network operation request body Change-Id: I192a50e322f9982b07b3fa3cbb7c180ab6a66bc3 Issue-ID: SO-501 Signed-off-by: c00149107 <chenchuanyu@huawei.com>
2018-03-19Fix String concatenation optimzationByung-Woo Jun1-20/+20
Replaced queryString from String to StringBuffer for memory and GC optimization Change-Id: I0e4656d1fdf8ff773704e788a3b59b3f910ae3ba Issue-ID: SO-500 Signed-off-by: byungwoojun<byung-woo.jun@ericsson.com>
2018-03-15Merge "Fix get resource input json string issue"Seshu Kumar M1-1/+1
2018-03-15Fix get resource input json string issuec001491071-1/+1
Fix get resource input json string issue Change-Id: I1babb7e987948c4f86c231cef67586bf452aab12 Issue-ID: SO-452 Signed-off-by: c00149107 <chenchuanyu@huawei.com>
2018-03-14Merge "Fit parameter name issue"Seshu Kumar M1-3/+3
2018-03-14Merge "Support resource parameters generated"Seshu Kumar M1-30/+109
2018-03-14Fit parameter name issuec001491071-3/+3
Fit parameter name issue Change-Id: I79fcb1e9d2aa97aa55dbe0bfca36e32d931238c8 Issue-ID: SO-452 Signed-off-by: c00149107 <chenchuanyu@huawei.com>
2018-03-14AT&T 1712 and 1802 release codeRob Daugherty155-4746/+7684
This is code from AT&T's 1712 and 1802 releases. Change-Id: Ie1e85851e94bc66c4d9514a0226c221939531a04 Issue-ID: SO-425 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-03-14Support resource parameters generatedc001491071-30/+109
Support resource parameters generated Change-Id: I9fb882024edc8e72d06dbc545e2342f32ad8f750 Issue-ID: SO-452 Signed-off-by: c00149107 <chenchuanyu@huawei.com>
2018-03-13Update license for ResourceRequestsubhash kumar singh1-1/+1
Update license for ResourceRequest. Change-Id: Icb17226758d85368fa8a4de3a6c76332253cdab8 Issue-ID: SO-453 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-03-12Merge "Fix urls for collecting CSAR info"Seshu Kumar M1-3/+3
2018-03-12Fix urls for collecting CSAR infosubhash kumar singh1-3/+3
Fix url for collecting CSAR info from catalogdb. Change-Id: Ib887e7b733610ac3dfb5388a56c11ad5d477c321 Issue-ID: SO-453 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-03-12Merge changes I5a320c60,I3fbd868eSeshu Kumar M1-1/+1
* changes: Remove unnecessary simicolon from all java classes private is redundant for enum constructors
2018-03-12Merge "Swap Optional.isPresent with functional expression"Seshu Kumar M1-8/+3
2018-03-12Merge "Combine the design and runtime parameter"Chuanyu Chen1-0/+131
2018-03-12Combine the design and runtime parametersubhash kumar singh1-0/+131
Combine designand run time paramters. Change-Id: Ide61cb14697f137e73308b29b721cedb1bd3e13e Issue-ID: SO-453 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-03-09private is redundant for enum constructorsMunir Ahmad1-1/+1
Change-Id: I3fbd868e83651111a6bce6c268ed4d7cf84c3fd5 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-03-09Swap Optional.isPresent with functional expressionMunir Ahmad1-8/+3
Change-Id: Id4b724b189f98c89e3e038b154990a95733e0624 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>