aboutsummaryrefslogtreecommitdiffstats
path: root/bpmn/MSOCommonBPMN/src/main
AgeCommit message (Collapse)AuthorFilesLines
2018-02-08Sonar:CriticalManamohan Satapathy2-13/+9
Define and throw a dedicated exception instead of using a generic one:L39 L41 L43 Sonar Link: https://sonar.onap.org/component_issues/index?id=org.openecomp.so%3Aso#resolved=false|severities=CRITICAL|fileUuids=AV5mhvcK32hFUzlqebDQ Location:src/main/java/org/openecomp/mso/client/aai/AAIRestClient.java Change-Id: I606ff51c58ef22975222fc7fda04aab4680ac2de Issue-ID: SO-399 Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>
2018-02-06Merge "Sonar:Critical"Seshu Kumar M1-3/+3
2018-02-06Merge "Refactor of DecomposeJsonUtils class."Seshu Kumar M1-6/+8
2018-02-06Sonar:CriticalSumapriya Sarvepalli1-3/+3
Define and throw a dedicated exception instead of using a generic one ApplicationControllerClient.java:L79 L121 L132 Sonar Link: https://sonar.onap.org/account/issues#resolved=false|rules=squid%3AS00112 Location:src/main/java/org/openecomp/mso/client/appc/ApplicationControllerClient.java Change-Id: Iba0d52ad2310fed17bb1012611e4ca0bf0ae2180 Issue-ID: SO-400 Signed-off-by: Sumapriya Sarvepalli <SS00493505@TechMahindra.com>
2018-01-29Refactor of DecomposeJsonUtils class.biniek1-6/+8
Change-Id: I72b779eb17ffb901266de605eb2eda49f13bd03e Issue-ID: SO-374 Signed-off-by: biniek <lukasz.biniek@nokia.com>
2018-01-24Same Service names under two different CustomersChittaranjan Sardar1-4/+32
SO is not allowing to create services with same name with in different customers. Change-Id: I2ce83f3d6c8d999f88154a1ac50330a8b6d50118 Issue-ID: SO-382 Signed-off-by: Chittaranjan Sardar <chittaranjan.sardar@amdocs.com>
2018-01-08Utility Methods: clean xml of all empty nodesAbhishek Shekhar1-0/+27
Change-Id: I29e26659da6d031237dffe940373515ccaa645c8 Issue-ID: SO-377 Signed-off-by: Abhishek Shekhar <abhishek.shekhar1@amdocs.com>
2017-11-11Changed parsing code in DoDeleteVfModuleFromVnfJim Hahn1-0/+15
Modified code to use MsoUtils to parse the xml rather than walking the nodes generated by documentBuilder. Added check for missing vfModuleOutputs. Added MsoUtils.getMultNodeObjects() to return real Node objects instead of lazy nodes. Change-Id: I0266502f1e0353c778dce982fa55cf7ce944d91e Issue-Id: SO-333 Signed-off-by: Jim Hahn <jrh3@att.com>
2017-11-08Clean up Process Engine selection logicRob Daugherty12-306/+68
Several failed attempts to split the BPMN application into multiple applications with separate camunda process engines have left a mess of confusing classes and process engine definitions. In the Amsterdam release, there should be only one BPMN application war. This is MSOInfrastructureBPMN. MSOCommonBPMN should not be deployed as a separate application. Its classes are compiled into a jar and this is included inside MSOInfrastructureBPMN. The MSOInfrastructureBPMN application should use the "default" process engine. WorkflowAsyncInfrastructureResource and MSOCommonApplication classes are not needed. Issue: SO-322 Change-Id: Ifdb3b33541346b561a16361d1aa791e8342a34fa Signed-off-by: Rob Daugherty <rd472p@att.com>
2017-11-07modified sample SDNO code for SOBenjamin, Max (mb388a)33-351/+1630
Issue-Id: SO-309 Change-Id: I998d5573d60d99987bb99133967ca012ef8dba6f Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com> modified RestClient to accept rest properties Issue-Id: SO-309 Change-Id: I68bd88f9f942573dc470dda2eb60dc747e78276
: Benjamin, Max (mb388a) <mb388a@us.att.com> 2017-11-01added javadoc comments to SDNOValidator interfaceBenjamin, Max (mb388a)1-2/+9 Issue-Id: SO-298 Change-Id: I2207a65884fc75c8b3a09467fa311718878331bd Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com> 2017-10-31Merge "Changed files ecomp-model to onap-model"Seshu Kumar M1-7/+7 2017-10-30Changed files ecomp-model to onap-modelShailendra Borale1-7/+7 SDNC does not recognize ecomp-model-information SDNC recognizes onap-model-information The ecomp-model-information was changed to onap-model-information Change-Id: I60c02ba6cb272703ad3bca17f71d5407d8a507d2 Issue-Id: SO-289 Signed-off-by: Shailendra Borale <sb8915@att.com> 2017-10-30Handle embedded "<" in SDNC responsesJim Hahn1-15/+14 Modified the code to use an actual XML parser when decoding the SDNC response-data element, instead of using the simple-minded replace("&amp;", "&") approach. The latter did not function correctly when XML elements contained other xml-encoded data. Change-Id: Ied6b8b19f307f728b8da1a2b410b9e239ec62ab6 Issue-Id: SO-115 Signed-off-by: Jim Hahn <jrh3@att.com> 2017-10-23Changed copyright informationShailendra Borale2-12/+30 Changed copyright info in the listed files. For csar files, files were unzipped using unzip csarFileName The text files were modified: The license info was added in the beginning of the file, not at the end. And then zipped again: zip csarFileName -r * For Xsd files, the information was added within commment section Change-Id: Ifc7c9594f948f98077c4364f4b9631fcf6cb1c32 Issue-Id: SO-252 Signed-off-by: Shailendra Borale <sb8915@att.com> 2017-10-23Merge "Iterate over "entrySet" instead of "keySet"."Seshu Kumar M2-194/+199 2017-10-23Merge "Update license in a couple of groovy scripts"Seshu Kumar M1-1/+17 2017-10-20Merge "Added additional arguments to method call"Seshu Kumar M1-1/+1 2017-10-20Flows fail to update status in requests DBRob Daugherty2-2/+2 The fallout and completion handlers are not updating the request status in the mso_requests database. The cause is a missing URN mapping that defines the service endpoint for these updates. Issue: SO-230 Change-Id: I5b4ff6e9ca2cde6605b3ed7cb7b086041111d31c Signed-off-by: Rob Daugherty <rd472p@att.com> 2017-10-19Added additional arguments to method callJim Hahn1-1/+1 The code already included "BPMN" and MsoLogger.getServiceName() as additional arguments in the call to warn() and error(). Simply added those same arguments to the call to info(), to match the method signature. Issue-Id: SO-244 Change-Id: Ic6297d67329358a3b9cdb480d930dc032b7029a2 Signed-off-by: Jim Hahn <jrh3@att.com> 2017-10-19Iterate over "entrySet" instead of "keySet".Ramanjaneya-Huawei2-194/+199 Issue-id: SO-224 Change-Id: Ib4e15f7db253d8af8f73d2185afd950f33c1a8ac Signed-off-by: Ramanjaneya-Huawei <ramanjaneya.palleti@huawei.com> 2017-10-18NullPointerException after adapter callbackRob Daugherty3-5/+5 The exception occurs because the default process engine is being used to handle the callback. Until we come up with a better design, we will use the "infrastructure" process engine. Issue: SO-76 Change-Id: Ibe8a40ac28b2ae855f85094f57d878ee622349a0 Signed-off-by: Rob Daugherty <rd472p@att.com> 2017-10-18Update license in a couple of groovy scriptsJim Hahn1-1/+17 Replaced the license in several groovy scripts with reference to the Apache license, as is standard for ONAP. Change-Id: I2be9aef096a95fe70b82579d0a2f6ee88b3caf03 Issue-Id: SO-238 Signed-off-by: Jim Hahn <jrh3@att.com> 2017-10-18Merge "Added the "@Override" annotation"Seshu Kumar M1-114/+115 2017-10-18Added the "@Override" annotationRamanjaneya-Huawei1-114/+115 Issue-id: SO-224 Change-Id: I98e6b2de01514f2e2c705c9f880057bb977ff075 Signed-off-by: Ramanjaneya-Huawei <ramanjaneya.palleti@huawei.com> 2017-10-17Added the "@Override" annotationRamanjaneya-Huawei1-2/+3 Change-Id: I0cbfeb8931a46ccd0b2f759c95adea49c5825af2 Issue-id: SO-224 Signed-off-by: Ramanjaneya-Huawei <ramanjaneya.palleti@huawei.com> 2017-10-09MSOCommonBPMN flows are not being deployedRob Daugherty2-1/+33 Flows in the MSOCommonBPMN jar, which is embedded in the MSOInfrastructureBPMN war, are not being deployed. MSOCommonBPMN needs a processes.xml file. I'm also fixing a problem with CustomE2EGetService.bpmn, which claims it is the GenericGetService flow. This creates a conflict with the real GenericGetService flow. Issue: SO-199 Change-Id: I1ec9d4ad079abf65b5c276b625b46a86805a15e6 Signed-off-by: Rob Daugherty <rd472p@att.com> 2017-10-08Fixes for sonar coverage in bpmnRob Daugherty1-6/+0 1. Coordinated jacoco and surefire JVM arg line options 2. Changed sonar plugin version to 2.19.1 3. Removed dead code (unused classes) Issue: SO-193 Change-Id: I21b7a77510eec71f4d4ca9afde5b7f86f0e3cbd7 Signed-off-by: Rob Daugherty <rd472p@att.com> 2017-10-03Fixed so issuesramanjaneya1-5/+8 Change-Id: I5bc9dc02ac81789dc0b113571c073e74d8cee609 Issue-Id:SO-118 Signed-off-by: ramanjaneya <ramanjaneya.palleti@huawei.com> 2017-10-02Merge "Fix major sonar issues"Seshu Kumar M1-3/+3 2017-10-02Merge "Added @Override annotation to method signature"Seshu Kumar M1-0/+1 2017-09-30Merge "Replace with the diamnod operator"Seshu Kumar M5-11/+12 2017-09-30Merge "Removed unused variables"Seshu Kumar M2-9/+1 2017-09-30Merge "Removed unused variables"Seshu Kumar M1-9/+1 2017-09-29Fix the SO build issuesDeterme, Sebastien (sd378r)3-9/+9 Fix the AAI java package names that was still openecomp, remove the variable for LF repositories due to Oparent, Fix the jacoco to overwrite the oparent settings (fix test coverage) Change-Id: I40b9b326e33ff27992a1bf2cc9d3094d338f8828 Issue-ID: SO-168 Signed-off-by: Determe, Sebastien (sd378r) <sd378r@intl.att.com> 2017-09-28Merge changes Ibc78f5be,Id1a6e6d2Seshu Kumar M3-3/+3 * changes: Fix code complexity Use diamond operator(<>) 2017-09-28Merge "Replaced with the diamnod operator"Seshu Kumar M2-1/+2 2017-09-27Replaced with the diamnod operatorrama-huawei2-1/+2 Issue-Id:SO-118 Change-Id: Iaad28a363586cd8b42e86bd7e854faa9e716c59d Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com> 2017-09-27Update POM to inherit from oparentRob Daugherty35-0/+690 Issue: SO-71 Change-Id: I91d503b52909cfcb62ca4b5cd93f6cfc70d6eb24 Signed-off-by: Rob Daugherty <rd472p@att.com> 2017-09-27Replace with the diamnod operatorrama-huawei5-11/+12 Issue-Id:SO-118 Change-Id: I96a1fb659bafd204221c5ff8f3d0b680a36dba9d Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com> 2017-09-27Removed unused variablesrama-huawei2-9/+1 Issue-Id:SO-118 Change-Id: I5db909a4c2bfb803c3d3647f30cfa4533c729148 Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com> 2017-09-27Removed unused variablesrama-huawei1-9/+1 Issue-Id:SO-118 Change-Id: I3f749777618e506efe4b83314e45574455639f7b Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com> 2017-09-27Use diamond operator(<>)surya-huawei3-3/+3 Major Sonar Issue *Replace type specification with diamond operator This is done to reduce the verbosity of generics code Issue-Id: SO-118 Change-Id: Id1a6e6d2e03f6f92a0e36b9326df61154c0ba910 Signed-off-by: surya-huawei <a.u.surya@huawei.com> 2017-09-26Fix major sonar issuesshashikanth1-3/+3 Fix major sonar issues in so module https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#resolved=false|severities=MAJOR|rules=squid%3AS1161 Add the "@Override" annotation above this method signature Issue-Id: APPC-186 Change-Id: I0a93e48f921c968ab9a43fc0599ba16d2349db40 Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com> 2017-09-26Added @Override annotation to method signatureshashikanth1-0/+1 Fix major sonar issues in so module https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#resolved=false|severities=MAJOR|rules=squid%3AS1161 Add the "@Override" annotation above this method signature Issue-Id: APPC-186 Change-Id: Ia896df35c7f81f3f149e3f7cf06656dafc0a7abf Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com> 2017-09-25Fixed string format specifier.shashikanth1-1/+1 String contains no format specifiers. https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#resolved=false|severities=CRITICAL Issue-Id:SO-118 Change-Id: Ibcb5124a98ea689a01461dddc42a4aa1db147a20 Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com> 2017-09-21Move Homing Building Block into ONAPArthur Martella5-0/+1073 Files regarding the Homing building blocks added for use in vCPE flows. Change-Id: Iae9eb70b81ec7d473e6c4e9c821a9282dc40baa9 Issue-id: SO-138 Signed-off-by: Arthur Martella <amartell@research.att.com> 2017-09-20Added Groovy for E2E svcSeshu-Kumar-M2-0/+2 IssueId: SO-146 Change-Id: Id247132c451e16c49dde8b8547d50924cdfa00c4 Signed-off-by: Seshu-Kumar-M <seshu.kumar.m@huawei.com> 2017-09-20Merge "BPMN applications not deployed properly"Rob Daugherty3-39/+63 2017-09-19BPMN applications not deployed properlyRob Daugherty3-39/+63 Since the 1710 MSO merge the following problems exist: The workflow applications are not deployed properly. I've also fixed a few small issues with the CreateCustomE2EServiceInstance flows that prevented them from being deployed. Change-Id: Ia4f7a6de87abbc99e80c0e9083e2175cdf9b4fe5 Issue-id: SO-148 Signed-off-by: Rob Daugherty <rd472p@att.com>