aboutsummaryrefslogtreecommitdiffstats
path: root/bpmn/MSOCommonBPMN/src/main/groovy
AgeCommit message (Collapse)AuthorFilesLines
2019-09-10Integrate Logging LibraryPlummer, Brittany10-41/+42
Updated SO to use ONAP provided filters and constants to meet logging standards. Removed redundant classes Updated constant references Issue-ID: SO-2301 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Ia4e3c2b1a4dcb3881aa34d39885c8b2782880d64
2019-08-09Remove unwanted semicolonsubhash kumar singh1-1/+1
Remove unwanted semicolon. Issue-ID: SO-2212 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com> Change-Id: Iadffb2affff8597a8eb8258041b37cb8bf701f20
2019-08-09Removed unrequired semicolon from groovysubhash kumar singh4-56/+56
Removed unrequired semicolon from groovy. Issue-ID: SO-2212 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com> Change-Id: Ie97c560db89dcd15d424c11473a312e9d684cbd8
2019-07-31added back missing method in groovy fileBenjamin, Max (mb388a)1-0/+14
Need to bring back AbstractTaskProcessor.logWorkflowException() method because this is being called from a number of groovy files. Issue-ID: SO-2172 Change-Id: Id5dee85fcb48265955dde3d74f7c0f98300410f0 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
2019-07-05update bpmn to save extsystemerrorsourcePlummer, Brittany2-22/+32
Added ext error source to workflow exception Updated all lines that create this exception with source Added unit tests and updated existing ones Change-Id: Id9b3b1e6e24368224214a6370ea2d450ae667bfb Issue-ID: SO-2092 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-10replaced String.repeat with static final stringsBenjamin, Max24-219/+216
replaced String.repeat with static final strings Change-Id: Ife14fde70e8f648881a03e9343ae8faf9cb87e2e Issue-ID: SO-1999 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-06Merge remote-tracking branch 'origin/dublin' into 'origin/master'Steve Smokowski4-1146/+1231
Change-Id: I551ea3f29a76dc99532455ea4d7e84a316f9bf38 Issue-ID: SO-1980 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2019-06-03Cleaned up duplicated literalsrob.bog24-102/+127
Cleaned up Sonar code smells related to the duplicated literals in loggers. Issue-ID: SO-1932 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I58c48cec0012c42b7b892ae76c24c6a087c60c7e
2019-05-30Remove oof_directives from user_directivesEric Multanen1-5/+7
Oof_directives - when populated with a json string, breaks the parsing of the user_directives. Since it is not needed in the user_directives, remove it. Change-Id: I0e2c3deef8266df52ac73b95209843ac31f986ef Issue-ID: SO-1939 Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
2019-05-29Fix UriBuilder import in OofUtilsMarcus G K Williams2-41/+30
Import all changes from Casablanca that were incorrectly removed during merge from Casablanca back into master. Issue-ID: SO-1926 Change-Id: I8355e804586aa80e291f3c72a00bf69ce424316b Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2019-05-28Set response code in UpdateAAIGenericVnfYang Xu1-0/+2
Change-Id: I67fb789d40ea86a82379e76b94c2da1bd552cd31 Issue-ID: SO-1927 Signed-off-by: Yang Xu <yxu@futurewei.com>
2019-05-24Fix Missing Import in OofHoming.groovyMarcus G K Williams1-0/+2
Issue-ID: SO-1926 Change-Id: Idee7eb0ab789fd8ac335b8c97b344b6e4f4b7fba Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2019-05-01build sndc and user directives in groovyEric Multanen1-1105/+1195
Fill out the sdnc_directives and user_directives used by the multicloud vnf plugin adapter when invoked via the groovy path. Change-Id: Ia11680be682b38756f188c71e3e000bc21c15aa9 Issue-ID: SO-1822 Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
2019-04-11Merge "Support for SO to ExtAPI"Seshu Kumar M1-0/+4
2019-04-01replace all fixed wiremock portsBenjamin, Max (mb388a)5-3/+15
trying to get the tests that can be threaded to pass started to remove fixed port references Change-Id: I7bfe067a8f36c908039700646571681321e9a6f5 Issue-ID: SO-1676 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-03-29Refactored SDNCAdapterUtils (groovy)Witold Ficio Kopel2-142/+134
Standardized usage of MsoUtils class in all methods of SDNCAdapterUtils. Removed AbstractServiceTaskProcessor from constructor parameter. Change-Id: I45263aefc980163a927d8a6dce886e299691e025 Issue-ID: SO-1700 Signed-off-by: Witold Ficio Kopel <w.kopel@samsung.com>
2019-03-26Eliminated printStackTrace() callsWitold Ficio Kopel12-119/+110
Eliminated calls to printStackTrace() on Throwable as they go to stdout and are not handled by logger. Occurences has been replaced by calls to logger or modifications to nearby logger calls (Throwable passed as last parameter). Occurences in unit test classes left without modification. Change-Id: I6a771d60a3ea69ceecc29bb21358e565aa5ce101 Issue-ID: LOG-631 Signed-off-by: Witold Ficio Kopel <w.kopel@samsung.com>
2019-03-22Hid MsoUtils.log() methods from public useWitold Ficio Kopel2-133/+38
The MsoUtils class has utility methods for logging made publicly available (by default groovy scope). With changes to logging subsystem, other classes should not use them for logging - so they have been made private. This is last commit in a series to eliminate use of MsoUtils.log() from other classes and should prevent such usage in future. Change-Id: I8311df26e17b70043c5d8de6b13818f803319ab8 Signed-off-by: Witold Ficio Kopel <w.kopel@samsung.com> Issue-ID: LOG-631
2019-03-21Removed MsoUtils.log() calls from CatalogDbUtilsWitold Ficio Kopel2-10/+12
Refactored calls to MsoUtils.log() to use logger object already present in the CatalogDbUtils class. In addition the CatalogDbUtils class has been accepting MsoUtils object as parameter to constructor - which is not necessary and not aligned with style in rest of the groovy code. Change-Id: Ib80593294ead5b2779f667d8e58f128e958538f0 Issue-ID: LOG-631 Signed-off-by: Witold Ficio Kopel <w.kopel@samsung.com>
2019-03-20Removed BPMNLogger classWitold Ficio Kopel1-75/+71
The BPMNLogger class has overlapping use to preferred solution based on slf4j and logback - thus has been replaced by it. Change-Id: I9889d4b9ab06f28941f0d827df889e3c081155da Issue-ID: LOG-631 Signed-off-by: Witold Ficio Kopel <w.kopel@samsung.com>
2019-03-20Merge "Removed logXXX() methods from MsoUtils"Steve Smokowski4-29/+0
2019-03-20Support for SO to ExtAPIVodafone1-0/+4
Change-Id: I5789ceb1fd4bd22d3b5ca706e55efe1bf4a3f51a Issue-ID: SO-1421 Co-authored-by: gopal.sabhadiya@vodafone.com Signed-off-by: Vodafone <onap@vodafone.com>
2019-03-19Merge "Update Tasks API with additional fields"Steve Smokowski1-0/+4
2019-03-19Removed logXXX() methods from MsoUtilsWitold Ficio Kopel4-29/+0
Following methods has been removed from MsoUtils (.groovy) class: logContext(requestId, serviceInstanceId) logMetrics(elapsedTime, logtxt) logAudit(logtxt) as no longer required. Remaining uses of them in other groovy clases has been deleted/replaced by apropriate use of logback. Change-Id: I473f01b65c67e90667311cff3b2a671e719f7258 Issue-ID: LOG-631 Signed-off-by: Witold Ficio Kopel <w.kopel@samsung.com>
2019-03-18Removed MsoLogger classr.bogacki26-132/+134
Bye bye MsoLogger class. Extracted constants to separated classes. Fixed imports. Change-Id: I7c8e0527e7dbd097d3ea93b9dab279354652da47 Issue-ID: LOG-631 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
2019-03-15Update Tasks API with additional fieldsElena Kuleshov1-0/+4
Update Tasks API with additional fields and new valid response Change-Id: I39d85ae599f9274373bbcf66dce4752ee75f16ed Issue-ID: SO-1594 Signed-off-by: Kuleshov, Elena <evn@att.com>
2019-03-14Cleaned up content of MsoLoggerr.bogacki24-198/+199
Cleaned java and groovy code from 'getServiceName' method in MsoLogger. Change-Id: I23c3fc8005db5f89e94b87271bb60b7bcce72064 Issue-ID: LOG-631 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
2019-03-13Remove MsoLogger from MSOCommonBPMN scriptsWitold Ficio Kopel38-1050/+1308
Modifications of groovy scripts in MSOCommonBPMN removing following: Replaced MsoLogger with plain slf4j. Refactored loging output. Fixed imports. Replaced utils.log() with respective logger calls (except for AbstractServiceTaskProcessor class). Modifications to MsoUtils class. Change-Id: I6bdd8ab6f60dca9b765fcf7d56f5aaa707c028cc Issue-ID: LOG-631 Signed-off-by: Witold Ficio Kopel <w.kopel@samsung.com>
2019-01-28Merge 'origin/casablanca' into masterBenjamin, Max (mb388a)3-23/+79
Issue-ID: SO-1435 Change-Id: If065ef5c91e769452fd6701fa6c28a23b4bdf2b2 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2019-01-21Bug fixes from AT&T January 20thBenjamin, Max (mb388a)2-22/+20
sorted vfmodules by base last for negative action reqs store Response in execution as String on network delete added functionality to skip rollback based on flag # Conflicts: # bpmn/so-bpmn-tasks/src/main/java/org/onap/so/bpmn/infrastructure/workflo w/tasks/WorkflowAction.java require XML in the header for delete network request Update APP-C LCM Client library version to 1.7.0. replaced wiremock style test with mockito test Handle AAIClient Exps in CreateCustomerV1 getServiceInstance() changed default status code to be configurable Replace vnfType by nfRole in the healthcheck request to SDNO. updated error messages in sdnc handler and flow status updated flow status message on completion of flow Send GenericVnf object for AAI VNF update for vnf-api updates Add a JUnit test file for SDNOValidatorImpl.java Set nodeType on the inner SDNO request as per update from SDNO. updated rollbackToAssigned logic to remove unassign flows updated sdnc handler error message for client error added exception handling for httpclienterror in sdnc out map workflow exception so error is reported throws sdnc error message on bad response from sdnc add catalog entries for TRANSPORT service delete flows change script number that was duplicate add find method to NorthBoundRequestRepository include serviceType in hash code use asterisk for all non-TRANSPORT flow db entries alacart true, rm not needed transport srvc model steps correct insert query syntax for orchestration_flow support serviceType (TRANSPORT) process flow fix SDNCAdapterException causing no callback to bpmn use JsonAlias for alternate case when deserializing GRM client will accept both "serviceEndPointList" and "ServiceEndPointList" root node in the JSON response. AAIRestClient now uses getSystemName in headers finishtime should not be returned in requeststatus Change-Id: I81a185252b057020f7f36f125c85c3357756da88 Issue-ID: SO-1403 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-12Merge "Miscellaneous fixes"Steve Smokowski1-5/+5
2019-01-11explicitly type defs and strings for templatesBenjamin, Max (mb388a)5-10/+10
explicitly type defs and strings for templates Change-Id: If4af5b0cdf086cd0d30277d1e835e2aa7c8e7f9c Issue-ID: SO-1386 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-11Miscellaneous fixesBenjamin, Max (mb388a)1-5/+5
updated common pom to use aai schema version 1.4.1 removed handle sync error from SDNCHandler bpmn flow added mso-request-id to in mapping of delete vnf flows moved temporary test file to temporary folder Removed obsolete genericVnfNode parameter from updateGenericVnfNode sorted vfmodules by base last for negative action reqs Change-Id: I7a5018d67292cfaac8d923ac3bd9b27ed037be57 Issue-ID: SO-1382 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-04Bugfixes for December 2018Benjamin, Max (mb388a)2-6/+5
Changed the way that the cidr is constructed in network utils. added in the if statement to check if selflink already exists removed execution line that was not needed in pull added service instance id to workflowResourceIds for virtualLinkKey network flows wrote test for updating request to complete in db workflow action directly updates db instead of using mso complete process Increase max timeout for SDNO Health Checks dmaap. Added execution variable and corrected type and way data is retrieved to fix defect fixed retry status message in request db for #/5 updated workflowActionBBTasks for flow status message updated flow status to failed on a workflowaction fail Removed slashes and fixed rollbackStatusMessage Updated requestStatus logic for adding status messages Added junit test to validate casue of a defect and cleaned up code and logging added end timestamp to request db on complete request fixed l3Network update of orchestation status in DoUpdateNetworkInstance groovy as well fixed update of l3network orchestration status Add explicit resetting of heatStackId in A&AI to DeleteVfModule and DeleteVolumeGroup BBs. Preserve heatStackId setting in the copiedVfModule when updating the VF Module in A&AI. added functionality to skip rollback based on flag Update snapshot version for logging, add headers fixed optional of error in retrieveErrorMessage method Set heatStackId to null if we want to remove it in A&AI. added in a warn logger statement to keep track of field map network technology from l3network instead of model info for network adapter object mapper Force heatStackId value to empty on an attempt to set it to null on update updated common pom to use aai schema version 1.4.1 removed handle sync error from SDNCHandler bpmn flow Change-Id: I1bd7aa55b06d4e439000b216165c9daafeacc9a4 Issue-ID: SO-1361 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-04HttpClientFactory to create HttpClient instancesMichal Kabaj9-14/+26
-Replace constructor calls with existing factory -Add create methods to factory for each required Media Type Change-Id: Ibd03c10230c87a0413c0ec529e0ea9ac800444f9 Issue-ID: SO-1344 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-12-13Add junit tests for CatalogDBUtilsLukasz Muszkieta3-62/+58
Change-Id: I1ea3e92b6dcb3fbca837513e11451be47d8c488b Issue-ID: SO-784 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-12-12Merge "Fixed vlan xml and host routes"Steve Smokowski1-394/+25
2018-12-12Merge "fixed aai response code in updateAAIVfModule"Steve Smokowski2-1/+9
2018-12-12Merge "ConfirmVolumeGroupNameTest improvements"Steve Smokowski3-17/+58
2018-12-12ConfirmVolumeGroupNameTest improvementsJoanna Jeremicz3-17/+58
Change-Id: I3e611f2577e66932d8337d1768ba803c25d01b39 Issue-ID: SO-784 Signed-off-by: Joanna Jeremicz <joanna.jeremicz@nokia.com>
2018-12-11Fixed vlan xml and host routesKalkere Ramesh, Sharan (sk720x)1-394/+25
Fixed parse error in build vlan xml and host routes, removed dead code. Change-Id: Id3f4e6400434c77f9a942f7e64e03aed91e24c9f Issue-ID: SO-1322 Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
2018-12-11Changed sdncRequestId to SDNCA_requestIdKalkere Ramesh, Sharan (sk720x)1-3/+3
Updated junit groovy test for sdnc adapter Changed to set sdncRequestId to be set to SDNCA_requestId so correlation happens during callback. Change-Id: I6532a676caa4332a32c89ef0ff2e2739d7e8cb56 Issue-ID: SO-1320 Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
2018-12-10fixed aai response code in updateAAIVfModuleKalkere Ramesh, Sharan (sk720x)2-1/+9
Added PUAAIVfMod_updateVfModuleResponseCode to be set to execution Added responseCode verification in unit tests Set UAAIVfMod_updateVfModuleResponseCode Change-Id: I0d429388ff49ae78241ad1b0f33815a80f749061 Issue-ID: SO-1313 Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
2018-12-10requestid retrieval and validation in bpmnKalkere Ramesh, Sharan (sk720x)1-6/+10
Change-Id: I4d30a784eed5dd68f9ee7c2b6833d72cbf0eccfa Issue-ID: SO-1311 Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
2018-12-10Merge "remove unused methods"Rob Daugherty5-1229/+2
2018-12-10Merge "fixed headers for traceability"Rob Daugherty2-2/+10
2018-12-10Merge "remove multiline strings with A&AI client"Rob Daugherty1-12/+10
2018-12-10Merge "Add unit tests for ExternalAPIUtil"Rob Daugherty2-18/+48
2018-12-10remove unused methodsLukasz Muszkieta5-1229/+2
Change-Id: Ica2d63e4d64f778257deb970b72d3fe858729952 Issue-ID: SO-729 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-12-07remove multiline strings with A&AI clientKalkere Ramesh, Sharan (sk720x)1-12/+10
do not use multiline strings with A&AI client Change-Id: I6c88e198601479dda1c09edc7717289beae5dc60 Issue-ID: SO-1302 Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>