summaryrefslogtreecommitdiffstats
path: root/adapters
AgeCommit message (Collapse)AuthorFilesLines
2019-02-24Prevent race conditions on same distributionId.Benjamin, Max (mb388a)2-4/+7
- Code to include optimistic lock to prevent race conditions on same distributionId. Change-Id: Ibe110b32f2472d991a4a3e03e3d15d5e4deefd65 Issue-ID: SO-1566 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-22Merge "fix potential nullpointer from sonar"Steve Smokowski2-21/+144
2019-02-22fix potential nullpointer from sonark.kazak2-21/+144
MsoMulticloudUtils: multicloudClient may be null throw MsoException if it is null (instead of NullPointer) removed unnecessary StackInfo object creation using format specifiers for a logger instead of String concatenation removed else block to make the code easier to read Added tests for the method Change-Id: I80d2e0ba2ef2d20c488cdfcf103d9cfa5784ab65 Issue-ID: SO-1516 Signed-off-by: k.kazak <k.kazak@samsung.com>
2019-02-21updated base yamls to properly connect to DBKalkere Ramesh, Sharan (sk720x)8-129/+135
Fix startup of catalog, request, bpmn and openstack Change-Id: I83dcd17d03c71301610ab2c8bbeb30142cc14303 Issue-ID: SO-1558 Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
2019-02-20Cleaned up Sonar issues in AuditStackServiceDatar.bogacki1-2/+3
Removed unnecessary imports. Removed unnecessary cast to "String". Change-Id: I8b14b0f53860edb656b38914941c44003a625037 Issue-ID: SO-1537 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
2019-02-18Merge "fix sonar critical bug"Steve Smokowski4-23/+83
2019-02-18Merge "fix critical sonar bugs"Steve Smokowski2-0/+12
2019-02-15fix sonar critical bugk.kazak4-23/+83
MsoHeatUtils: remove unnecessary heatClient check for null 1. sonar assumes that heatClient is nullable and NullPointer may be thrown in line 309 2. heatClient is never null: method creates a new object or throws Exception MsoHeatUtilsTest: added tests for getHeatClient and createStack methods BaseTest: made CloudIdentity and CloudSite getters protected for other tests to use them StubOpenStack: added stubs for getStack and unsuccessful authorization removed unused imports Change-Id: Ie62c89f55d1894df48d9cc4d14760d36e96c4cb2 Issue-ID: SO-1516 Signed-off-by: k.kazak <k.kazak@samsung.com>
2019-02-14fix issue where we attempt audit with no serversBenjamin, Max (mb388a)5-5/+53
fix issue where we attempt audit with no servers Change-Id: I47f76121c616bf65a5f8be73910adcc0d7088bdb Issue-ID: SO-1513 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-14Merge "cloud config migration from openstack to catdb"Steve Smokowski8-196/+39
2019-02-14Merge "Remove un-needed cacheing layer for OS Clients"Steve Smokowski3-147/+2
2019-02-14fix critical sonar bugsk.kazak2-0/+12
Restore interrupted state when InterruptedException is thrown in SDNCRestClient Added test for this case Replaced formatting anchor with text empty object in GraphInventoryResultWrapper Escaped anchor is also considered as bug by sonar Case is already covered in AAIResultWrapperTest Marked comparison of the same object as false positive in EqualsAndHashCodeTester Added clearer comment to this comparison Change-Id: I24496c2323c33599db99a3d3b59fc4f6a008cf1f Issue-ID: SO-1492 Signed-off-by: k.kazak <k.kazak@samsung.com>
2019-02-13Strip off TenantId from self link urlBenjamin, Max (mb388a)2-22/+33
Strip off TenantId from self link url Change-Id: I58ac9fe693059eb8cb93d85fb88604cb9c0a0db2 Issue-ID: SO-1502 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-13Remove un-needed cacheing layer for OS ClientsBenjamin, Max (mb388a)3-147/+2
Remove un-needed cacheing layer for OS Clients Change-Id: I7fbb6e23a3c34f65286202ec4dad1fb051991cf0 Issue-ID: SO-1500 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-11Merge "fix cvnfc bean and repository access"Steve Smokowski2-4/+104
2019-02-08fix cvnfc bean and repository accessBenjamin, Max (mb388a)2-4/+104
update repository id field type for fix cvnfc bean and repository access Change-Id: Ic4785387ffdbb544e649d9e7be40aed5e0ab9502 Issue-ID: SO-1489 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-08Remove resources that are not neutron networksBenjamin, Max (mb388a)2-2/+25
Remove resources that are not neutron networks Change-Id: Ie136895f95273e53f86201fe3b58a12fa27c8fe6 Issue-ID: SO-1486 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-08Merge "provide correct custIds"Steve Smokowski2-0/+150
2019-02-06store raw distribution notification in dbBenjamin, Max (mb388a)1-0/+6
updated the test case to verify ASDC notification sent is the same as one persisted in the DB and verified it updated the test case to verify ASDC notification sent is the same as one persisted in the DB Added unit test case for WatchdogServiceModVerIdLookup changes Updated test resources schema.sql and data.sql to include changes to watchdog_service_mod_ver_id_lookup table Added length to consumer id column with WatchdogServiceModVerIdLookup class ASDC Controller has been enhanced to include the notification message and consumer id as part of existing table watchdog_service_mod_ver_id_lookup. Change-Id: Iee805761ffc16f456d068c44b53804a7febc7933 Issue-ID: SO-1475 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-05provide correct custIdsBenjamin, Max (mb388a)2-0/+150
correct variable name and use bean comparison included object assertion in junit on catalog client update test name to reflect return value fix cvnfc query by 2 customization uuid relationships provide customization ids to module query input Change-Id: I99df11c417230e398f86554d889a40e9d157544c Issue-ID: SO-1466 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-04cloud config migration from openstack to catdbBenjamin, Max (mb388a)8-196/+39
remove the wait and sleep code in migration move cloud config migration from openstack to catdb Change-Id: Id887a37ce12665e5d8a604308ea251744529491c Issue-ID: SO-1461 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-04Clean up Unit tests for auditBenjamin, Max (mb388a)16-344/+342
Fix file names to adjust for case sensitivity Clean up Unit tests for audit Change-Id: I839b8a55d47c545cfd54c4c81eecda098b847fce Issue-ID: SO-1462 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-04Merge "add in a retry function for cloud config migration"Steve Smokowski1-1/+16
2019-02-01compare resources from openstack to aaiBenjamin, Max (mb388a)27-217/+2363
Address Review comments on pull request Update Unit test to have proper variable for testing update logic inside bpmn to reflect proper variable Update unit test to check property for audit Add flag to turn on and off audit behavior Add license headers, remove un-used files Update Building Block Tests and Activity Names Fix additional unit tests in so-bpmn-tasks layer Fix broken Junit Test, and correct Bug in if statement Add annotation to ignore class under test profile Additional bug fixes and unit tests for classes Add Additional JUNITS, add more sample data Add Openstack Audit functionality to Adapter Change-Id: I0492063271e991eefc608b56336a5cdf1d5a7778 Issue-ID: SO-1456 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-01add in a retry function for cloud config migrationBenjamin, Max (mb388a)1-1/+16
add in a retry function into cloud config migration Change-Id: Iee5dd2ece0262cc7087021b567d9661e0ef91d72 Issue-ID: SO-1457 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-28Merge "Merge 'origin/casablanca' into master"Marcus Williams32-85/+439
2019-01-28Merge 'origin/casablanca' into masterBenjamin, Max (mb388a)32-85/+439
Issue-ID: SO-1435 Change-Id: If065ef5c91e769452fd6701fa6c28a23b4bdf2b2 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2019-01-27pool is now serializableBenjamin, Max (mb388a)1-4/+19
add implements Serializable to openstack Pool object Make Openstack Pool object serializable - for netwk Change-Id: I9ba294b68a0896c528558ebc1d66d909a7787b47 Issue-ID: SO-1430 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-25Merge "Removed deprecated Matcher imports"Steve Smokowski1-1/+1
2019-01-24Removed deprecated Matcher importsBenjamin, Max (mb388a)1-1/+1
replaced org.mockito.Matchers with ArgumentMatchers Change-Id: I2feb4d4fb314cd14aca0719c4cc29b1a0510cbf7 Issue-ID: SO-1413 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-24bugfixes jan 24thBenjamin, Max (mb388a)12-44/+239
Fix null pointer exception when no requestParameters are specified Add configurable timer in ActivateVfModuleBB to delay call to SDNC activate - Use raw slf4j logger - use {} formatting Add configurable timer in ActivateVfModuleBB to delay call to SDNC activate - Use raw slf4j logger Add configurable timer in ActivateVfModuleBB to delay call to SDNC activate - removed unused references in test class Add configurable timer in ActivateVfModuleBB to delay call to SDNC activate Update PortGroup objects separately from the parent VCE object - restore setVariable calls back into vce object - they might be needed later. Update PortGroup objects separately from the parent VCE object - updated test class extra call to get PortGroups Update PortGroup objects separately from the parent VCE object - use PortGroup.getInterfaceRole() getter method instead of accessing field directly. Update PortGroup objects separately from the parent VCE object Added back required headers for tenant isolation. removed workflow exception from outmapping in execute Fix possible null ptr exception, fix to add braces. Default networkTechnology in Update as done in Create Fix failing junits, mapper force upper case nwtech update exception builder to properly throw exception error message supporting assign service instance a la carte as well adding in proper exception handling in network rest v1 add the unassign action to R macro data file Change-Id: Ide420514f81b8083b4c76c762c064de199624cf7 Issue-ID: SO-1424 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-24Fix AR receipe retrivalsubhash kumar singh3-6/+59
Fix AR receipe retrival. Change-Id: I5675fef17c1ee6375dd6c68a311d5f0568438879 Issue-ID: SO-1422 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2019-01-23Fix get of operationTypesubhash kumar singh2-6/+38
OperationType should return empty from db request instead of "null". Change-Id: I5df3df5aead6008c4e14961ee385cafe64c37959 Issue-ID: SO-1417 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2019-01-22Fix CSAR distribution on CCVPN servicesubhash kumar singh2-4/+8
Fix db schema to allow CCVPN service witout heat artifacts. Change-Id: I4f79881a6a04f01f8984835eea88907a61c640db Issue-ID: SO-1407 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2019-01-21Bug fixes from AT&T January 20thBenjamin, Max (mb388a)3-4/+23
sorted vfmodules by base last for negative action reqs store Response in execution as String on network delete added functionality to skip rollback based on flag # Conflicts: # bpmn/so-bpmn-tasks/src/main/java/org/onap/so/bpmn/infrastructure/workflo w/tasks/WorkflowAction.java require XML in the header for delete network request Update APP-C LCM Client library version to 1.7.0. replaced wiremock style test with mockito test Handle AAIClient Exps in CreateCustomerV1 getServiceInstance() changed default status code to be configurable Replace vnfType by nfRole in the healthcheck request to SDNO. updated error messages in sdnc handler and flow status updated flow status message on completion of flow Send GenericVnf object for AAI VNF update for vnf-api updates Add a JUnit test file for SDNOValidatorImpl.java Set nodeType on the inner SDNO request as per update from SDNO. updated rollbackToAssigned logic to remove unassign flows updated sdnc handler error message for client error added exception handling for httpclienterror in sdnc out map workflow exception so error is reported throws sdnc error message on bad response from sdnc add catalog entries for TRANSPORT service delete flows change script number that was duplicate add find method to NorthBoundRequestRepository include serviceType in hash code use asterisk for all non-TRANSPORT flow db entries alacart true, rm not needed transport srvc model steps correct insert query syntax for orchestration_flow support serviceType (TRANSPORT) process flow fix SDNCAdapterException causing no callback to bpmn use JsonAlias for alternate case when deserializing GRM client will accept both "serviceEndPointList" and "ServiceEndPointList" root node in the JSON response. AAIRestClient now uses getSystemName in headers finishtime should not be returned in requeststatus Change-Id: I81a185252b057020f7f36f125c85c3357756da88 Issue-ID: SO-1403 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-17Merge "Sonar:Critical"Steve Smokowski1-4/+4
2019-01-17Change size for resource inputsubhash kumar singh2-3/+13
Change size for resource input. Change-Id: Ic6856e6baa2623867d0ae688c98ed24dbb245036 Issue-ID: SO-1400 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2019-01-15Sonar:CriticalManamohan Satapathy1-4/+4
ValetUpdateResponse.java:L37 Change-Id: I93db82c18cda553d3b1c78467d7c558a2787e7d8 Issue-ID: SO-1351 Signed-off-by: Manamohan Satapathy <MS00534989@techmahindra.com>
2019-01-15MsoTenantUtilsFactoryTest unit testsMichal Kabaj1-2/+34
-added new test cases for factory class Change-Id: Iddd221d1ff5fa6748657b635bc07b6c795b8b9d8 Issue-ID: SO-1339 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2019-01-14Add missing license headersBenjamin, Max (mb388a)5-1/+101
add headers to files which were missing them Issue-ID: SO-1390 Change-Id: I6c754f72c5d1ef6485d6343aae4b994120901d08 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-12Merge "Add junit tests for MsoCloudifyUtils"Steve Smokowski1-1/+94
2019-01-12Merge "get subnet sequence number from A&AI"Steve Smokowski1-1/+11
2019-01-12Merge "Re-enable Actuator for Springboot 2.0"Steve Smokowski5-19/+16
2019-01-12Merge "Service Proxy Consolidation"Steve Smokowski2-29/+67
2019-01-11Quality of Life logging improvementsBenjamin, Max (mb388a)1-1/+1
Remove invalid newline character in process name Quality of Life logging improvements Change-Id: I2193c08e365e847f6be144106a0b20aa7828497e Issue-ID: SO-1381 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-11Service Proxy ConsolidationBenjamin, Max (mb388a)2-29/+67
- Updated ServiceProxyResourceCustomization to remove the ID column - Removed setConfigurationResourceCustomization from serviceProxyResource since that relationship doesn't exist anymore - Updated ServiceProxy resource to remove the object dependencies between ServiceProxyCustomization and ConfigurationResourceCustomization - Removed the delete statement since this is causing the test to fail because the service table doesn't exist yet - Updated configuration_customization to drop the serviceProxyCustomization FK - Added migration script to consolidate the ServiceProxy and ServiceProxyCustomization into a single table and migrate the data. - Code changes to support consolidating the ServiceProxy and ServiceProxyCustomization table into a single table Change-Id: I1e49cb22c8b667f157dd1c349b5e36fd06236630 Issue-ID: SO-1380 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-11get subnet sequence number from A&AIBenjamin, Max (mb388a)1-1/+11
Add AAIQuery for subnet block to CreateNetwork bpmn MSO shall get subnet sequence number. Change-Id: I5cf73d1b5344f41ac98a51274948822322e3591b Issue-ID: SO-1378 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-11Re-enable Actuator for Springboot 2.0Benjamin, Max (mb388a)5-19/+16
Re-enable Actuator for Springboot 2.0 Change-Id: Icee67885d9bd26d6b6ff8a4fceb9add56926b0a8 Issue-ID: SO-1377 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-11Add junit tests for MsoCloudifyUtilsLukasz Muszkieta1-1/+94
Change-Id: If12ed6350306cd489aa8b1744a513875b42540c3 Issue-ID: SO-430 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-01-11junits for MsoTenantUtilsFactoryTomasz Gwozdecki1-0/+16
-Added new test for MsoTenantUtilsFactory Change-Id: I9ba756a1f1c569dc7d0c1528272cca1ccfe3aad4 Issue-ID: SO-1339 Signed-off-by: Tomasz Gwozdecki <tomasz.gwozdecki@nokia.com>