summaryrefslogtreecommitdiffstats
path: root/adapters
AgeCommit message (Collapse)AuthorFilesLines
2018-11-05Catchup commits for DublinBenjamin, Max (mb388a)13-51/+41
added property for retry timer multiplier for testing Infra APIH table, fixed test assertNull condition. Infra APIH table, added tests for request-url = null. Infra APIH should write request_url to infra_active_requests. Return SelfLink URL on ServiceInstantiation SyncResponse. Added JUNITS. Added helper method to get AAI ResourceUri to faciliate unit test. Fixed code to correctly extract related generic vnf or vce id. updated unit test coverage for update network Handle REST NotFoundException for serviceInstance nodes query. Process should continue for new order request and throw exception only for SUPP request. Added disconnect functionality to the gw vnf test tool. Added conversion of vnf management option to dhv change speed sync subnet status with network update updated macroData vol assigned delete continue script Correct the name of DeleteVfModuleBB subprocess. fix the custom resolver to not convert int in string to int Write the returned value from Homing to gBBInput Use explicit conversion to JSON to read cloudConfiguration settings. added property for retry timer multiplier for testing avoid storing AAI yang models in execution added handlingCode to rollback test in workflowactionbb passed in alacarte flag to execute layer for rainy day added test cases for RollbackToAssigned rainy day hand added rollback to assign in catalog db rainy day hand Updated vnf adapter delete stubs to be a post for test. Added a javadoc to basic auth override method Added a check to not add blank headers to the headerMap in httpClient. Added check for if entity exist before calling readEntity. Fixed failing junits and updated way the body is obtained Added missing import statement for http client. Fixed mistakes and made updates caught during review. Removed post and httpPost methods from RESTClient and refactored references Refactored multiple http post references to use httpClient instead. Removed close connection method and randomized port in unit test Added http client unit test, coverage is currently at 90 percent Resolve conflict in sdnc adapter reste v1 method Began removing http delete and delete methods from RESTClient and aaiUtil. Removed http put method and executeput method, refactored references. fixed broken tests in the branch in jenkins build Fix Springboot 2.0 start up issues, and other issues added in implementation to generate self link if there isnt one removed dbcp2 from poms that still had them added rollbackstatusmessage to stub in testprocess added rollback_status_message to the schema sql file Added variable for rollbackStatusMessage Added rollbackStatusMessage to get response added rollback status message to archived infra request set rollback status message to successful on boolean added logic to split rollback and regular error message added rollback status message to infra active requests pushing the cloud config changes as well Added media type and fixed cast plural issue. Made various updated and fixes to code that was changed. Removed all no longer used RESTClient imports from classes Removed and refactored references for aaiUtil methods and all remaining RESTClient methods, removed RESTClient project and updated poms. Return canonical stack id on multicloud create Fix OOF Config Ingestion Fix variable to retrieve sdnc endpoint Prepare resources for service uuid req Fix swapped parameters for multicloud DELETE Update msb-java-sdk to resolve license issues cloud owner support for SDNC interface correlationId is now read from userParams Fix up request body of multicloud adapter body removed LinkedHashMap<?,?> from java classes Cut over logging project to release not snapshot Update unit tests, revert test code, fix comments Fix remaining number of Unit Tests, on avpn flow Fix JUNITS add callback url, fix BPMN issues Update SDNC interaction to support a-sync updated bpm assert import and corrected tests updated test case to be mockito 2 compliant additional changes to import statements and tests Change the place where the data for multistage gets set Update treatment of PENDING_ACTIVATION VF_MODULE CREATE entries to SILENT_SUCCESS to support first stage of multistage. Implement second stage of multistage design VF Module Creation removed LinkedHashMap<?,?> from java classes Removed SNAPSHOT from dependency Cut over logging project to release not snapshot Fixed failing BBInputSetup tests Update unit tests, revert test code, fix comments Updated apih tests to use networkInstanceGroup Updated ModelType enum and fixed compilation issues Fix remaining number of Unit Tests, on avpn flow Fix JUNITS add callback url, fix BPMN issues Implementation of the first stage of multistage design for VF Module creation. Update SDNC interaction to support a-sync no longer leave modified files after test runs Remove generated CSAR, that occurs during JUNIT Update Camunda Pods to use Flyway Migration in 1902 Updated hashcode method and removed comment. Added aggregate routes to the sdnw request and updated pom sdnw dependency. Began to set aggreagate route information for vrf configuration. modified remaining files with att-aic references Correct rollbackData setting and protect against potential null objects. correct AAIObjectPlurals enum value name Update POJO to use type URL for selfLink. Optional<URL> - construct SelfLink Url format. Construct SelfLink Url format from full Url. added missing properties to application-test.yaml fixed compliation error after merge of unit test restored files which should not have been deleted Fix SO vulnerabilities with cxf Fixing bpmn infra endpoint in so-monitoring yaml removed att-aic from codebase default cloud owner now configurable Set homingService in WorkflowAction Fix Java Ex in Homing Version should be 1.3.1 to release new dockers Pnf Spring Environment correction test property now has dynamic wiremock port removed test specific wiremock rule that was causing problems re-enabled and corrected integration tests for so-bpmn-tasks Test to get sniro homing v2 test working by splitting test suites for each spring application Reverted changes to old migration scripts.. Fixed spring context issue with test HomingV2. Removed unused import to fix compilation errors Fixed onap changes to homing, migrated homingV2 to homingBB, fixed broken junits again. - Updated isUseHttpsWithDmaapTest to check assertTrue rather than assertFalse. - Upgraded code to make the isUseHttpsWithDmaap configurable. It will default to true if no value is found in the config file. moved workflowaction test class to the test section added status message update for retry and rollback beefed up error message debug logging and req db msg added debug lines to workflowactionbbtasks reqdbcall Issue-ID: SO-1187 Change-Id: Iec1aff4ed30a43c0e0b2cdb06c28d8db8a99a830 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-11-05Springboot 2.0 upgradeBenjamin, Max (mb388a)73-1002/+444
corrected typo in CloudConfiguration class removed files which should not have been merged updated gr api test cases with dynamic cloud owner updated groovy files to allow for dynamic cloud owner values moved VFModularity folder to mso-infrastructure bpmn updated GR API layer to include cloud owner added enum for default cloud owner - fixing junit test cases for using catalogDb client r2 - fixing junit test cases for using catalogDb client - Internal review comments incorporated for merging mocking into BaseTest - Internal review comments incorporated for removing direct repo calls - CLONE - Key Management Hardcoded encryption key | fixing junits - CLONE - Key Management Hardcoded encryption key Updated builder to use String.format Added exception specifically for issues interacting with requestdbadapter Updated exception message and added junit test case removed useless error handling test case from workflow changed method name and added junit coverage to errors added max retry and success status after completed bb Added case to handle when homing is not called during assign vnf. Fixing fortify issues | Implementing review comments - Key Management Hardcoded encryption key - fixing prop files - Key Management Hardcoded encryption key include network ID for completion handler Added exception handling for saving to requestdb - Adding a check on the predicate availability on the repository before firing the query with default conditions. This ensures that the api returns data only when there is an input against which it was able to form some conditions Modify UT to show that the API does not behave - adding negative test case for checkInstanceNameDuplicate added assertion that global count var was reset to 0 updated rollback to reset current sequence count var workflowaction calls rollback is complete before error workflowaction will set failure on successful rollback added check for isrollback to know which complete to call removed file which should not have been added add fabric check before running vf module a la carte Enhance UCPEMigrateService junits and add them to Jenkins build.. Added back removed test case for ManualTasks Added test case for response error Added rainy day test cases for ManualTasks revert the other change and fix the rollback logic instead fixed current sequence and updated rollback code added network cloud heat template parameters to mapper Generate a unique subRequestId for each request to APP-C. reverted conditional logic for determining fabric Fix Bean scanning so it picks up the resttemplate removed unnecessary RestTemplate Bean configurations removed file which should not have been added workflowaction calls rollback is complete before error workflowaction will set failure on successful rollback added check for isrollback to know which complete to call add fabric check before running vf module a la carte added assertion that global count var was reset to 0 updated rollback to reset current sequence count var include network ID for completion handler Revert Application.yaml change accidentally checked in Added exception handling for saving to requestdb Added case to handle when homing is not called during assign vnf. removed useless error handling test case from workflow changed method name and added junit coverage to errors ... add cloud owner variable to camunda in mapping Revert "Pass cloudOwner to subflow DoCreateVfModuleVolumeV2. Added juint test to verify variables are set in the execution. Set default cloudOwner in main module CreateVfModuleVolumeInfraV2" updated cloud configuration pojo to inlcude defaults Revert "Test to verify ServiceInstance object mapping" Test to verify ServiceInstance object mapping Pass cloudOwner to subflow DoCreateVfModuleVolumeV2. Added juint test to verify variables are set in the execution. Set default cloudOwner in main module CreateVfModuleVolumeInfraV2 Pass cloudOwner to subflow DoCreateVfModuleVolumeV2. Set default cloudOwner 'att-aic' if null per old requirements. removed references to att-aic from BBInputSetup Changes done in encryption decryption logic | used DelegateExecutionFake in Tests Changes done in encryption decryption logic | used DelegateExecutionFake in Tests Changes done in encryption decryption logic Changes done in encryption decryption logic | removed Default Auth Constant as per the comments Changes done in encryption decryption logic | Fixed UT Changes done in encryption decryption logic | Added XmlComparator assertion for verifying XML Changes done in encryption decryption logic | Reverted as per the review comment Changes done in encryption decryption logic | Fixed UTs Changes done in encryption decryption logic | Fixed UTs Changes done in encryption decryption logic | modified related encrypted properties in test yaml files Changes done in encryption decryption logic for fortify issue resolution | Fixed UTs Changes done in encryption decryption logic | modified related encrypted properties in yaml files Changes done in encryption decryption logic for fortify issue resolution. Fixed Property fetching issue in required file Added TasksBeansTest using openpojo Removed renamed test file from tasksbeans Updated imports on TasksBeansTest Added openpojo test to replace the individual tests Removed tests that provided no coverage script clean up -Update reference data to support distinct recreate and replace requests with their own sequences Update reference data to support distinct recreate and replace requests with their own sequences- Fix seq number Update reference data to support distinct recreate and replace requests with their own sequences added null check to mdc and interceptors to sdnc cxf validations can now match against multiple BBs reverted changes to BBInputSetup class added support for pre and post validation for BBs initial commit of generic building block validator converted test to no longer be a springboot test Remove cosmetic changes from BPMN files to be consistent. Remove minor changes that are not related to functionality. Rework to implement the functionality as part of Validator Combine the verification methods into one based on the flow's name; change the logging. Add verification of status of other VF Modules in the VNF for the delete/deactivate/unassign. added network-technology validation for CreateNetworkBB Sonar Issue Fix | Changes done in encryption decryption logic | Refactoring Changes done in encryption decryption logic| Used AES/GCM/NoPadding algorithm | fixed sonar issues added network-type and network-technology to mapper Continue the fight to make JUNITS work properly Update ASDC ATT to be springboot 2.0 compliant Continue to fix Unit tests for springboot 2.0 port removed autowired from workflowactionbbtaskstest fixed workflowactiontest and reduced size by 500 lines Update last of UT for mockito upgrade to 2.0 Fix more JUNITS due to mockito 2.0 upgrade Unit Test fixes to use proper mockito not spring Update Base Test to import proper packages for compile Additional Springboot 2.0 changes, for tests Additional springboot 2.0 fixes and upgrades Update Migration to be Flyway 5 Compliant Fix MSOBPMN Infrastructure common tests Fix Groovy Unit Tests in CommonBPMN Project Update MSO common BPMN to Springboot 2.0 Upgrade ASDC controller to SpringBoot 2.0 Port Openstack adapters to springboot 2.0 Fix VFC Adapter to be springboot 2 compatible Port CatalogDB adapter code to springboot 2 Port SDNC Adapter to Springboot 2.0 ... added update scripts to macro data instead of v12 sql added secondarypolicy to rainy day handling table confirm subnet map is not null in adapter response shallow copy subnet before AAI udpate update AAIObjectType to use uriTemplate extract subnet data from adapter response update correct AAIObjectType for subnet query update subnet(s) in AAI on network create completion confirm subnet map is not null in adapter response shallow copy subnet before AAI udpate update AAIObjectType to use uriTemplate extract subnet data from adapter response update correct AAIObjectType for subnet query update subnet(s) in AAI on network create completion fixed test http entity unit test to remove testing appid and transaction id added unit test for querySubsystemHealth method. also added resttemplate mock to implement healthcheck endpoint fixed unit test to use mock instead of actually goes out to health check endpoint added code to extend globalhealthcheck to include pinging other components and consolidate the responses converted test to no longer be a springboot test Remove cosmetic changes from BPMN files to be consistent. Remove minor changes that are not related to functionality. added update scripts to macro data instead of v12 sql Rework to implement the functionality as part of Validator added secondarypolicy to rainy day handling table added network-type and network-technology to mapper Combine the verification methods into one based on the flow's name; change the logging. Add verification of status of other VF Modules in the VNF for the delete/deactivate/unassign. updated how request db is set to failure in workflowA corrected code to match existing unit tests corrected tests after springboot 2 upgrade Added Required UTs in UpdateConfigurationStateTest and also fixed some UTs. added in missing parenthesis on method call added back execution variable for allotted uri addressed comments on pull request refactor AAI Rest calls from groovy files - Changes as per review comments checkin to refactor AAI rest | Fixing AAIResourceClient.update call refactor AAI Rest calls from groovy files - UpdateConfiguration refactor AAI Rest calls from groovy file - DeleteConfiguration refactor AAI Rest calls from groovy file - UpdateConfiguration refactor AAI Rest calls from groovy file - CreateConfiguration & ConfigurationUtils refactor AAI Rest calls from groovy files - Fix getARByID issue checkin to refactor AAI rest | Adding Junits checkin to refactor AAI rest | Adding few more classes checkin to refactor AAI rest of DoCreateVfModuleVolumeV2 checkin to refactor AAI rest | Update junit checkin to refactor AAI rest of DoCreateVfModuleVolumeV2 | Adding junits checkin to refactor AAI rest of DoCreateVfModuleVolumeV2 | Adding junits checkin to refactor AAI rest of DoCreateVfModuleVolumeV2.groovy ... updated in and out mapping to be generalBuildingBlock change source out mapping to generalBuildingBlock Change-Id: I122f1ebe3e15b77da0a55af201d89d47e326bf83 Issue-ID: SO-1098 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-10-3110/31: merge casablanca to masterRob Daugherty1-7/+18
Commit: 649c4e85cc991ffe9c13fd3fab4cc3a303faa656 Subject: Fix Error, Check that vimID is present Issue: SO-1156 https://gerrit.onap.org/r/#/c/71247/ Commit: 959493d3274d2f2749586248cf31ee12b730e2af Subject: Bug fixes October 26th Issue: SO-1169 https://gerrit.onap.org/r/#/c/71343/ Commit: 373c057bfa82583f615ea46814ad3cdf9ea8d669 Subject: Resolve vf_module_id setting bug Issue: SO-1165 https://gerrit.onap.org/r/#/c/71270/ Commit: 6c2c8a66fade016f74b51bdfea3ba04494530b97 Issue: SO-1102 Subject: Pnf Spring Environment correction https://gerrit.onap.org/r/#/c/71137/ Change-Id: I22b4566050f627e1f1428aacdb52ec4d4fe75733 Issue-ID: SO-1173 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-10-25Resolve vf_module_id setting bugMarcus G K Williams1-7/+18
Do not remove vf_module_id and vnf_id from parameters in HeatUtils. Issue-ID: SO-1165 Change-Id: I6f00350a6f7dc419a8be9b90b28188228949cb43 Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2018-10-19Update version to 1.4.0-SNAPSHOT for DublinRob Daugherty8-11/+11
Henceforth, the master branch will be for Dublin work. Change-Id: I269fd8f227e37afdab9c633f45488c643e5e765e Issue-ID: SO-1151 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-10-17Merge "Prepare resources for service uuid req"maopeng zhang1-2/+9
2018-10-17Return canonical stack id on multicloud createEric Multanen1-1/+1
When creating vfmodule via multicloud adapter, return the canonical name of the stack <stackname>/<stack id> Code was returning <stack id>/<stack id> Change-Id: Iaa2a105ab779acc9638fe515c7bc4e5c23d7233e Issue-ID: SO-1142 Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
2018-10-16Prepare resources for service uuid reqsubhash kumar singh1-2/+9
Retrieve all the resource for queried service uuid. Change-Id: If2beaa27570821c9897387d3b7098a939d99c895 Issue-ID: SO-689 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-10-16Fix swapped parameters for multicloud DELETEEric Multanen1-1/+1
cloudSiteId and tenantId were swapped in call to deleteStack(). Change-Id: I56bc326cb680dabb9d397cb7f0f918e406cb8bba Issue-ID: SO-1139 Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
2018-10-12Fix up request body of multicloud adapter bodyEric Multanen2-31/+19
Make some of the attributes json instead of json in a string. Fixed up payload of request. Change-Id: I7737fd19d44c8075bd7fef19068a72f8c0ec7e6d Issue-ID: SO-1124 Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
2018-10-12Dynamic Cloud Owner SupportBenjamin, Max (mb388a)2-5/+60
added in cloud configuration object to request params Fix Bean scanning so it picks up the resttemplate removed unnecessary RestTemplate Bean configurations corrected typo in CloudConfiguration class updated gr api test cases with dynamic cloud owner updated groovy files to allow for dynamic cloud owner values updated GR API layer to include cloud owner added enum for default cloud owner add cloud owner variable to camunda in mapping removed references to att-aic from BBInputSetup updated aai schema dependency to 1.3.1 from 1.3.0 Fixed incorrect type AAIUri and updated logging in the method. use existing service instance id instead of generating Pass cloudOwner to process to propagate to subprocesses. NOTE: our aai-schema dependency is 1.3.1-SNAPSHOT to be compatible with the cloud owner changes here. The releaesed 1.3.0 version is NOT compatible. Change-Id: I43b46774b77981d1c8bfe7c7a79b9434889e62ae Issue-ID: SO-1128 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com> Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-10-02Take generic VNF ID and vfModule ID from requestEric Multanen12-257/+290
In createVfModule (for multicloud adapter), take the generic VNF ID and vfModuleId from the Web service request. Change-Id: I092e081fef2ccc70c9b71dd6d75bb038c5663fef Issue-ID: SO-1082 Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
2018-10-01Merge "Fix up handling of multicloud return status"Marcus Williams4-36/+265
2018-10-01Merge "Updated Reference data for AutoScaleOut"Rob Daugherty1-0/+7
2018-10-01Fix up handling of multicloud return statusEric Multanen4-36/+265
Add calls to query vfmodule status to return when doing create and delete. Return status based on the query result and not the rest response. Put in the completion polling support on create. Change-Id: Ife50509e54e001b92f4a65ec6be2905aef99f9b5 Issue-ID: SO-1082 Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
2018-09-28Merge " Duplicate service entry removed"Seshu Kumar M1-4/+0
2018-09-27Fix calls to multicloud adapterEric Multanen16-320/+902
Fix up the json body of the POST call to multicloud. Improve checkout of responses from multicloud calls. Change-Id: I1fb47460b54e9e5b478815d3b531d5bdbe1fe3dc Issue-ID: SO-1082 Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
2018-09-27 Duplicate service entry removedprashank1-4/+0
Change-Id: Icddb4a0ce3454f638cc425e4cf14609a36fa68ea Issue-ID: SO-754 Signed-off-by: prashank <prashant.kumar1@amdocs.com>
2018-09-24Add cloudSite Post to catalogDbClientMarcus G K Williams3-5/+52
Issue-ID: SO-1081 Change-Id: I5808292c4b11413dfef07216d2b933b3358e4fae Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2018-09-22Merge "Fix improper Licesnse scans"Byung-Woo Jun1-1/+1
2018-09-22Fix improper Licesnse scansseshukm1-1/+1
Change-Id: I701f1b9475e0a1f74e007c90757b70bc4502b6da Issue-ID: SO-915 Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
2018-09-22Merge "DeploymentInfo tests and construction improvement"Seshu Kumar M6-279/+423
2018-09-21Updated Reference data for AutoScaleOutPrema Bhatt1-0/+7
Change-Id: I7a4739a748dda3e34369b2f0fa5ca398ffe8be9b Issue-ID: SO-1083 Signed-off-by: Prema Bhatt <pb6115@att.com>
2018-09-21Merge "various bugfixes for casablanca"Rob Daugherty3-2/+65
2018-09-20Add multicloud to VnfPluginAdapterEric Multanen9-263/+1057
Adds new mode 'multicloud' to VnfPluginAdapter along with MsoMulticloudUtils and supporting code. Change-Id: I1cfdc9ba09c58315fb0bfc025854cf0122a32759 Issue-ID: SO-752 Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
2018-09-20various bugfixes for casablancaBenjamin, Max (mb388a)3-2/+65
fixed unit tests after addition of A&AI edge label added option for edgelabel between vnf inst group added belongs to in connecting a vnf to instance group - Adding test for getRainyDayHandlerStatusByFlowNameAndServiceTypeAndVnfTypeAndErrorCodeAn dWorkStep method in the catalogdb client correct default RainyDay table search input updated custom resolver to include float and added comment to explain timestamp configuration added a custom resolver and updated snake yaml version Replacing bowman client with restTemplate.exchange | Add Accept and Content-Type to headers Removing the unused imports as well Implementing some review comments for hte tests being ignored Replacing bowman client with restTemplate.exchange |Fixing Junits Replacing bowman client with restTemplate.exchange | Making Data inserts to go specifically in requestDB Replacing bowman client with restTemplate.exchange | Adding Junits Replacing bowman client with restTemplate.exchange | Adding Junits Replacing bowman client with restTemplate.exchange | Adding Junits Replacing bowman client with restTemplate.exchange - Updated tosca parser version to 1.4.3 and upgraded vnfc test case with new csar to pass with latest parser code. added test case for when workflow has not called all flows fixed issue with rollback and retry in workflowaction Reverted homing changes and changes assign vnf to use the homing produced GeneralBuildingBlock. fixed unit test to build the correct format hashmap reverted extraction back to LinkedHashMap marshal sdnc output to an object removed unused variables and imports extract response code/message from embedded map add junits to parse SDNC assign response removed missed org.openecomp.mso imports from bpmn Change-Id: Ib2b6591a744ecb5b08c522494cdf1ad7dae18a08 Issue-ID: SO-1069 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-09-20Update LoggingSmokowski, Steve (ss835w)5-20/+32
Update logging to meet Casablanca Spec Change-Id: I029d6c63765992d6f091d96e2b4c34c60d30c484 Issue-ID: SO-947 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-09-19Removed unused import in CXFConfigurationezhil1-1/+1
Removed logger import Issue-ID: SO-1030 Change-Id: Ifd890e7319f963a3958b5d42c0e4505eacd2eb43 Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2018-09-18Upgrade to openstack libs version 1.3.0Rob Daugherty5-24/+23
Version 1.3.0 uses fasterxml.jackson. Note: several unit tests were wrong and had to be fixed. They were using a fasterxml ObjectMapper to deserialize openstack library class objects compiled with codehaus JsonProperty annotations. Consequently, the ObjectMapper could not "see" the annotations. The tests "worked" because the json was constructed wrongly to match. I have now fixed the json so that they have the true property names defined by the annotations. Change-Id: I088137ee5dd5af9cffd426610a50ae6408c5b190 Issue-ID: SO-1025 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-09-18Merge "fixed sonar issue in MsoNetworkAdapterAsyncImpl"Seshu Kumar M1-16/+16
2018-09-18Merge "NetworkAdapterRest.java: Fixed sonar issues"Seshu Kumar M1-10/+10
2018-09-17Merge "more stability fixes"Marcus Williams5-2/+125
2018-09-17more stability fixesBenjamin, Max (mb388a)5-2/+125
Remove conditional to not check VNF topology add empty string verification for serviceName field Add junits for CNRCR and NtwkAdptr changes. Add search in new CollNtwkResCust tbl to get NtwkResource. - Updated test data files to include 'pre-load' flag in both VfModuleOperation and NetworkOperation json test data files. - MSO to not to send <preload>boolean</from-preload> to SDNC in network-topology-opertion and vf-module-topology-operation. Updated GeneralTopologyObjectMapper to set 'from-preload' to null so that elements with Nulls are not sent to SDNC. Updated buildNetworkInformation() and buildVfModuleInformation() methods. update flow stats to not cause bpmn flow to crash Fix headers so SDNC does not return XML Add implementation of deleteVolumeGroupResponse parsing; fix JUnits that worked by accident. Change-Id: Ia96d552d731e112505fcf739029a6fd4d0134546 Issue-ID: SO-1061 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-09-17add single transaction api to aaiclientBenjamin, Max (mb388a)1-1/+0
fixed marshalling when issuing a patch request added support for single transaction api in A&AI Change-Id: Icf755f547523cc7dbf931e198177847a5a1c6ea1 Issue-ID: SO-1060 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-09-17NetworkAdapterRest.java: Fixed sonar issuesArundathi Patil1-10/+10
Sonar Link: https://sonar.onap.org/code?id=org.onap.so%3Aso&selected=org.onap.so%3Amso-openstack-adapters%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fso%2Fadapters%2Fnetwork%2FNetworkAdapterRest.java Issue-ID: SO-1049 Change-Id: I4256f09b0d89714eb2214215e7a2a2f1f1644a8b Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2018-09-17Accept VNF Recreate RequestsBenjamin, Max (mb388a)2-1/+5
Updated nfRole in sample catdb json response Added gr-api-default recipe for recreate Updated description in catdb response json Updated catdb response file to have the correct action Added action to common package Removed requestor ids and source from test requests Began adding recreate endpoint and tests Began adding validation for recreate and junit tests Change-Id: I60c588be104b82b2d0dfb8587069e04f7b4710be Issue-ID: SO-1057 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-09-17DeploymentInfo tests and construction improvementMichal Kabaj6-279/+423
- Improved construction by adding DeploymentInfoBuilder - DeploymentInfo immutable - added detailed unit tests Change-Id: I3dabb91d5190ef932e77f0c76e18fde8ca73c64d Issue-ID: SO-1055 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-09-17fixed sonar issue in MsoNetworkAdapterAsyncImplSandeep J1-16/+16
fixed sonar issue as detailed in SO-1050 Issue-ID: SO-1050 Change-Id: Ia93775d855c04bb5b955d17c002c55f619198298 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-09-16Merge "fix sonar isue in openstack adapters ObjectFactory"Byung-Woo Jun1-10/+13
2018-09-16Merge "fix sonar issue in ValetClient.java"Byung-Woo Jun1-1/+1
2018-09-16Merge "fixed sonar issue in MSORequestDBApplication.java"Byung-Woo Jun1-2/+2
2018-09-16Merge "fixed sonar issue in ObjectFactory.java"Byung-Woo Jun1-21/+23
2018-09-16fix sonar isue in openstack adapters ObjectFactorySandeep J1-10/+13
fixed sonar issue as detailed in SO-1046 Issue-ID: SO-1046 Change-Id: I4064b7d7729f15afbfa07752cf5cc54e9847e861 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-09-16fix sonar issue in ValetClient.javaSandeep J1-1/+1
fixed sonar issue as detailed in SO-1045 Issue-ID: SO-145 Change-Id: I754a6699ea1be798cf68c08c6e5900007bf6350b Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-09-16fixed sonar issue in MSORequestDBApplication.javaSandeep J1-2/+2
fixed sonar issue as detailed in SO-1044 Issue-ID: SO-144 Change-Id: I08bfe045eda953e23c9fa54ea159cd6c915705bd Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-09-16fixed sonar issue in ObjectFactory.javaSandeep J1-21/+23
fixed sonar issue as detailed in SO-1043 Issue-ID: SO-1043 Change-Id: I529c1e8951b286c6f18d60aa810942d8db94df21 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-09-16fixed sonar issue in NetworkAdapterNotify_ServiceSandeep J1-3/+4
fixed sonae issue as detailed in SO-1042 Issue-ID: SO-1042 Change-Id: Iadb765acc0acd94c65281e212eed54d28e98ea91 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-09-14ObjectFactory.java: Fixed sonar issuesArundathi Patil1-20/+20
Sonar Link : https://sonar.onap.org/code?id=org.onap.so%3Aso&selected=org.onap.so%3Amso-openstack-adapters%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fso%2Fadapters%2Fnetwork%2Fasync%2Fclient%2FObjectFactory.java Issue-ID: SO-1038 Change-Id: I88c7c76d266afabcbbe1ea26772b601a0238cde1 Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2018-09-14Merge "Remove unused import"Chuanyu Chen1-1/+0
2018-09-13Stability fixesBenjamin, Max (mb388a)2-2/+45
sdnc now logs the full response message as a json removed erroneous encoding of variables with full XML Return created network from getVirtualLinkL3Network added exception logger to workflowaction aai check Check for null value for vnfcPorts before referencing it Added test case for invalid camunda response Changed to use updateStatus method Added saving for currentActiveReq and test for 401 resp Change JUnit to use expectedException and clean up unused items. Add vfModuleId to the exception message for missing model info. Report an error if VF Module model info is expected but is null. - Just renamed the Cvnfc and Vnfc set names - Updated code to check for duplicate VNFC's across multiple modules in the same VNF. - Removed commented out if statement line for ALLOTTED_RESOURCE - Reinitialize the Cvnfc and Vnfc Sets each time we iterate the VFModule loop. This will avoid the concurrent modification exception. Eliminated Ben from the sample request Changed to use else if for null check Added null check before catdb call and test case Fix implementation of a call to VNF Adapter for DeleteVolumeGroupBB. Update the method to no call save and do a put Revert usage of PUT method, use save instead Change-Id: I9f69fb68d0639c23b8e1de6931938119bd3ac54b Issue-ID: SO-1032 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>