summaryrefslogtreecommitdiffstats
path: root/adapters/mso-sdnc-adapter
AgeCommit message (Collapse)AuthorFilesLines
2022-07-12sonar issue, Change the assertion arguments to not compare a primitive valueGanesh1-1/+2
Signed-off-by: Ganesh <ganesh.c@samsung.com> Change-Id: I1710ada880155d30582c0b9bcceb5f8152a32527 Issue-ID: SO-3966
2022-06-27sonar bug, Change the assertion arguments to not compare a primitive value ↵Ganesh1-1/+0
with null Signed-off-by: Ganesh <ganesh.c@samsung.com> Change-Id: I72e255d016d3c08ceb6c075cfc6b9e710e5acfa0 Issue-ID: SO-3966
2021-06-30Reducing org.reflections package loggingwaqas.ikram1-18/+19
Change-Id: I05c95912a2f7ed5fef7d76728b8a4c0a6cecca10 Issue-ID: SO-3702 Signed-off-by: waqas.ikram <waqas.ikram@est.tech>
2021-06-24Updating pom version to 1.9.0-SNAPSHOTwaqas.ikram1-1/+1
Change-Id: Idb3e497148225d4158390b944f74e82ff9f771c8 Issue-ID: SO-3688 Signed-off-by: waqas.ikram <waqas.ikram@est.tech>
2021-03-15update swagger to v3 open api versionBOSLET, CORY2-15/+15
Upgraded all projects and services to use the new v3 swagger, discontinued use of old swagger. Updated unit test to account for swagger change and removed apis Issue-ID: SO-3587 Signed-off-by: AT&T Open Source <g22940@att.com> Change-Id: Iddcfe92f8ab240691f92ce2bf23e1ab2ad159780
2021-03-12Merge "add new sdnc interaction"1.8.1Max Benjamin5-0/+278
2021-03-10add new sdnc interactionBOSLET, CORY5-0/+278
Added Cors auth support option for sdnc interaction Issue-ID: SO-3580 Signed-off-by: AT&T Open Source <g22940@att.com> Change-Id: I54d17ea5e02a20114f5857940cc4dabc72854dea
2021-03-09version upgrades plus cleanupBOSLET, CORY1-2/+0
Removed over 125 dependencies and added to dependency management Added in a few dependencies and removed some Change the swagger version to so pom Removed version property reference in the pom Added in missing dependency for bpmn blocks Added in missing dependecy for common bpmn Updated the camunda-bpm-assert to use a version that is compatible with assertj-core 3.11. The camunda-bpm-assert namespace group also changed. This fixes the no method found error. Updated unit test to account for class name change Updated the unit test to account for lib change Fixed unit test for software upgrade stuff Exclude older versions of javassist to fix null pointer caused by incompatible javassist version with hibernate and bowman Added in missing dependency for task test Added missing dependency and fixed formatting Remove files that got added back in by merge conflict Use the new namespace for the swagger annotations Need to exclude swagger annoatations from the old namespace Updated to fix compilation error due to use of legacy swagger and cxf swagger Use the swagger v3 plugin for gen resources Use the openapi v3 swagger in all bpmn packages Fix null pointer to create the OpenApiFeature in cxf Issue-ID: SO-3578 Signed-off-by: AT&T Open Source <g22940@att.com> Change-Id: I7093376b2d8271e9c5b911b901133e01b957da84
2021-02-17Merge "update camunda and spring to latest versions"Steve Smokowski2-32/+16
2021-02-16update camunda and spring to latest versionsBenjamin, Max (mb388a)2-32/+16
Updated camunda to 7.14 and updated spring boot camunda to 3.4 Started to clean up duplicate maven dependencies Issue-ID: SO-3521 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Ic65b04772b91dd989e41d6b6b93872978bc4e4e2
2021-02-15update the version for the H releaseseshukm1-1/+1
Issue-ID: SO-2765 Signed-off-by: seshukm <seshu.kumar.m@huawei.com> Change-Id: I563295123f7f8de7164495a7db3bc58872863098
2020-10-08Exclude problematic dependency from cxfBenjamin, Max (mb388a)1-3/+0
jboss rmi dependency excluded from all cxf dependencies Done at the root pom to prevent from happening again Issue-ID: SO-3292 Change-Id: I022b8ecf58d76d090b16079324df2047fecc1a61 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
2020-08-06bump the master to 1.7.1seshukm1-1/+1
Issue-ID: SO-2940 Signed-off-by: seshukm <seshu.kumar.m@huawei.com> Change-Id: I888677f7d32ff35619be0f5bb2b677f56215f2e0
2020-06-30merged ONAP refactor and fluent builder methodBenjamin, Max1-1/+1
WorkflowAction refactoring merged ONAP refactor and fluent builder method types Issue-ID: SO-3005 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I5c2a7dbcdf645efe408f81c1abbc7bfe8770fe9e
2020-06-18Prepare for java 11Benjamin, Max3-64/+21
final changes for java11 groovy compatibility removed unnecessary dependencies and cleaned up poms added missing jaxws-api dependency to pom.xml java8 profile is now active by default in parent pom update beans to have RemoteResource annotation always use the compiler plugin from parent pom Update external task timeout to longer value to hold lock update remote resource annotation to match catalog db client add remote resource annotation to bean for bowman completely remove bowman from requests db client Issue-ID: SO-2059 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: If6f0df36e8077ccd703abce9f64290daed63955b
2020-06-10Fix for MDONS usecase SO-2967Srinivasan Ramanathan1-3/+6
Change-Id: Ic1bf13f6a2cb3974e090f4a13f5750242027e1c7 Issue-ID: SO-2967 Signed-off-by: Srinivasan Ramanathan <srinivasan.ramanathan2@us.fujitsu.com>
2020-06-02make sure maven plugins only run when we wantBenjamin, Max1-3/+4
make sure maven plugins only run when we want Issue-ID: SO-2972 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I5fe1b4836f597cf6bda5fee02ca6c234c7917f33
2020-05-20Began adding pluging to lifecycle mappingBoslet, Cory1-0/+28
Began adding pluging to lifecycle mapping metadata to get rid of eclipse workspace pom errors/markers Issue-ID: SO-2948 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I78946c59e6aaf440e014ed06e9ff476bac5c2613
2020-05-13switch to docker-maven-plugin because that's allBenjamin, Max1-1/+1
switch to docker-maven-plugin because that's all we need Issue-ID: SO-2933 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I65783d3a7c172f4ce7fc39d64a3987eeae58feed
2020-03-23Fix sonar issuesParshad Patel3-97/+107
The Cyclomatic Complexity of this method is greater than 10 authorized Remove unused fields Issue-ID: SO-1841 Change-Id: I792e02a3843623b1a93d5a272946ad79a07373f8 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2020-03-12Changes for MDONS usecaseSrinivasan Ramanathan3-0/+85
Template handling and SDNC request sending for Optical services. Change-Id: I52838076ea119237758dfdc804f2ee1f55f3c33c Issue-ID: SO-2460 Signed-off-by: Srinivasan Ramanathan <srinivasan.ramanathan2@us.fujitsu.com>
2020-03-05create custom spring aop annotation for loggingPlummer, Brittany12-12/+12
Added annotation for setting up scheduled tasks logs Added new annotation to scheduledTasks Moved annotation setup to logging-library Issue-ID: SO-2713 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I7080c4bb289e454f14167631e2601c954389c0ef
2020-02-26bump the versions for all the SO to 1.6.0seshukm1-1/+1
Issue-ID: SO-2519 Signed-off-by: seshukm <seshu.kumar.m@huawei.com> Change-Id: Id0993b244b0978375ff8476e4bf8ef79e1bb9e68
2020-02-03Support LCM API for sdnc adapterEnbo Wang4-24/+133
Enhance sdnc adapter to support LCM API for PNF SW Upgrade. Issue-ID: SO-2588 Signed-off-by: Enbo Wang <wangenbo@huawei.com> Change-Id: I193a5f61a5a63da6608692b34c221df8aeddc323
2020-01-07consolidated security configurationBenjamin, Max3-238/+0
consolidated security configuration into common package Issue-ID: SO-2584 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I1e78259ffbf88e792f1f7a5a10cd1fdad8eaea36
2019-12-20Merge "Added AAF Integration related changes"Seshu Kumar M5-10/+198
2019-12-16update so to use 1.6.3 snapshot from the loggingPlummer, Brittany4-75/+215
Updated snapshot to 1.6.3 and began fixing failing tests Update SOAPLoggingInInterceptor to use new InvocationID value Changed client and server keys to InvocationID BPRestCallback to use ServerInvocationId Removed logging MDC checking from unit tests Began switching bprestcallback to use resttemplate Removed changes to logback replacing invocationIds Updated logic where requestEntity is created on null message Added unit tests for BPRestCallback Set InvocationID in MDC in SOAPLoggingInInterceptor Send in URI to prevent encoding of URI causing % to change to %25 Updated restTemplate to fix issue with interceptors Issue-ID: SO-2571 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I7e0d80eae9036c993414ae96ebd571c89cb9dfa9
2019-11-22improve error log scoresPlummer, Brittany4-9/+9
Updated error code name to fix spelling Defaulted errorcode and errordesc to unknown when not provided Remove unused imports from nc orchestrator application Added defaulting of serviceName to error log Issue-ID: SO-2538 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I5ae960f728739e2528173b66484562742429416c
2019-11-21Added AAF Integration related changesRamesh Parthasarathy5-10/+198
Created two profiles for the application to run. Basic profile will allow the application to run in the current spring security authentication. AAF profile will authenticate and authorize requests with AAF. if no profile is given, it will fallback to basic. Change-Id: I2576f02e7afca3c10e02aaffef66a60fa1c4dd1a Issue-ID: SO-2451 Signed-off-by: Ramesh Parthasarathy(rp6768)<ramesh.parthasarathy@att.com>
2019-11-08removed global configuration of jar pluginBenjamin, Max1-0/+3
removed global configuration of jar plugin to prevent extra artifacts Issue-ID: SO-2518 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I5b25150089f39792452cf67cac1c916ef2069bed
2019-09-10Integrate Logging LibraryPlummer, Brittany2-4/+4
Updated SO to use ONAP provided filters and constants to meet logging standards. Removed redundant classes Updated constant references Issue-ID: SO-2301 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Ia4e3c2b1a4dcb3881aa34d39885c8b2782880d64
2019-07-26Upgrade springboot.version from 2.0.5 to 2.1.5.Sangalang, Felix1-0/+4
Upgrade springboot.version from 2.0.5 to 2.1.5. Fixed APIHandler junit test cases with expected DB error messages. Issue-ID: SO-2157 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I77ce873018b88268b9221226b95c9c106f93a8d0
2019-07-23Major Sonar fixesr.bogacki1-3/+1
Major Sonar fixes in different classes: -Removed unnecessary code. -Removed unused variables. -Removed unnecessary imports. -Simplified diamond operators. -Improved String comparisons in equals. Issue-ID: SO-2102 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I279c63f8e7161d6e33d5d6a28b938c0c64e90f1f
2019-07-18Removing application-local.yaml filesRoy, Amresh1-133/+0
Removing the application-local.yaml files because they're no longer maintained or working. Issue-ID: SO-2121 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I191c8775de931671a4657be8940e6aec64023359
2019-07-10Sonar Fix: SDNCAdapterApplication.javaArundathi Patil1-2/+2
Removed unused imports from the file Issue-ID: SO-2103 Change-Id: Id126f5203789d866b340d86b55bbc616991afc99 Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2019-06-24Sonar fixes and improvementsr.bogacki2-3/+4
General fixes and improvements according to the Sonar analysis. -Fixed imports. -Removed unnecessary code. Issue-ID: SO-1992 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I4299f3efc4444625f70fc36e65b57c500b113596
2019-06-10replaced String.repeat with static final stringsBenjamin, Max12-77/+71
replaced String.repeat with static final strings Change-Id: Ife14fde70e8f648881a03e9343ae8faf9cb87e2e Issue-ID: SO-1999 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-03Cleaned up duplicated literalsrob.bog12-63/+81
Cleaned up Sonar code smells related to the duplicated literals in loggers. Issue-ID: SO-1932 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I58c48cec0012c42b7b892ae76c24c6a087c60c7e
2019-04-25SDNCRestClient - sonar fixesDriptaroop Das1-11/+2
SDNCRestClient - sonar fixes Issue-ID: SO-1811 Change-Id: I7348e35a325c523648696a2321d873f481a0b36d Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
2019-04-11corrected inlucde filter for formatterBenjamin, Max (mb388a)1-168/+168
all pom.xml files now have two spaces validation is on for pom.xml files Change-Id: I424ea2e4d6a549f468792e5f90a43f3a97e6c954 Issue-ID: SO-1781 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-04-08Replaced all tabs with spaces in java and pom.xmlBenjamin, Max (mb388a)50-2857/+2686
Added in maven plugins to enforce coding style rules Added in eclipse java formatting xml Change-Id: I3727bbf4ce8dc66abfd8ad21b6cfd0890c5d3ff0 Issue-ID: SO-1765 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-04-01replace all fixed wiremock portsBenjamin, Max (mb388a)6-16/+72
trying to get the tests that can be threaded to pass started to remove fixed port references Change-Id: I7bfe067a8f36c908039700646571681321e9a6f5 Issue-ID: SO-1676 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-03-26Eliminated printStackTrace() callsWitold Ficio Kopel1-9/+9
Eliminated calls to printStackTrace() on Throwable as they go to stdout and are not handled by logger. Occurences has been replaced by calls to logger or modifications to nearby logger calls (Throwable passed as last parameter). Occurences in unit test classes left without modification. Change-Id: I6a771d60a3ea69ceecc29bb21358e565aa5ce101 Issue-ID: LOG-631 Signed-off-by: Witold Ficio Kopel <w.kopel@samsung.com>
2019-03-18Removed MsoLogger classr.bogacki13-54/+53
Bye bye MsoLogger class. Extracted constants to separated classes. Fixed imports. Change-Id: I7c8e0527e7dbd097d3ea93b9dab279354652da47 Issue-ID: LOG-631 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
2019-03-11Cleaned up MsoLogger classr.bogacki1-1/+0
Removed setServiceName method from MsoLogger. Cleaned up unused methods from MsoLogger. Change-Id: I1fe033ed25dda32c07693a5087bf65de3ecc229c Issue-ID: LOG-631 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
2019-02-26Removed MsoLogger from 'mso-sdnc-adapter'r.bogacki16-178/+218
Removed MsoLogger from adapters ('mso-sdnc-adapter') Replaced MsoLogger with plain slf4j. Refactored login output. Fixed imports. Change-Id: I1656776a04b322b9b8da30a3cc6aad31cd621a3e Issue-ID: LOG-631 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
2019-02-14fix critical sonar bugsk.kazak2-0/+12
Restore interrupted state when InterruptedException is thrown in SDNCRestClient Added test for this case Replaced formatting anchor with text empty object in GraphInventoryResultWrapper Escaped anchor is also considered as bug by sonar Case is already covered in AAIResultWrapperTest Marked comparison of the same object as false positive in EqualsAndHashCodeTester Added clearer comment to this comparison Change-Id: I24496c2323c33599db99a3d3b59fc4f6a008cf1f Issue-ID: SO-1492 Signed-off-by: k.kazak <k.kazak@samsung.com>
2019-01-28Merge 'origin/casablanca' into masterBenjamin, Max (mb388a)1-0/+8
Issue-ID: SO-1435 Change-Id: If065ef5c91e769452fd6701fa6c28a23b4bdf2b2 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2019-01-21Bug fixes from AT&T January 20thBenjamin, Max (mb388a)1-2/+8
sorted vfmodules by base last for negative action reqs store Response in execution as String on network delete added functionality to skip rollback based on flag # Conflicts: # bpmn/so-bpmn-tasks/src/main/java/org/onap/so/bpmn/infrastructure/workflo w/tasks/WorkflowAction.java require XML in the header for delete network request Update APP-C LCM Client library version to 1.7.0. replaced wiremock style test with mockito test Handle AAIClient Exps in CreateCustomerV1 getServiceInstance() changed default status code to be configurable Replace vnfType by nfRole in the healthcheck request to SDNO. updated error messages in sdnc handler and flow status updated flow status message on completion of flow Send GenericVnf object for AAI VNF update for vnf-api updates Add a JUnit test file for SDNOValidatorImpl.java Set nodeType on the inner SDNO request as per update from SDNO. updated rollbackToAssigned logic to remove unassign flows updated sdnc handler error message for client error added exception handling for httpclienterror in sdnc out map workflow exception so error is reported throws sdnc error message on bad response from sdnc add catalog entries for TRANSPORT service delete flows change script number that was duplicate add find method to NorthBoundRequestRepository include serviceType in hash code use asterisk for all non-TRANSPORT flow db entries alacart true, rm not needed transport srvc model steps correct insert query syntax for orchestration_flow support serviceType (TRANSPORT) process flow fix SDNCAdapterException causing no callback to bpmn use JsonAlias for alternate case when deserializing GRM client will accept both "serviceEndPointList" and "ServiceEndPointList" root node in the JSON response. AAIRestClient now uses getSystemName in headers finishtime should not be returned in requeststatus Change-Id: I81a185252b057020f7f36f125c85c3357756da88 Issue-ID: SO-1403 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-11Re-enable Actuator for Springboot 2.0Benjamin, Max (mb388a)1-4/+3
Re-enable Actuator for Springboot 2.0 Change-Id: Icee67885d9bd26d6b6ff8a4fceb9add56926b0a8 Issue-ID: SO-1377 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>