summaryrefslogtreecommitdiffstats
path: root/adapters/mso-sdnc-adapter/src
AgeCommit message (Collapse)AuthorFilesLines
2018-11-05Springboot 2.0 upgradeBenjamin, Max (mb388a)10-30/+85
corrected typo in CloudConfiguration class removed files which should not have been merged updated gr api test cases with dynamic cloud owner updated groovy files to allow for dynamic cloud owner values moved VFModularity folder to mso-infrastructure bpmn updated GR API layer to include cloud owner added enum for default cloud owner - fixing junit test cases for using catalogDb client r2 - fixing junit test cases for using catalogDb client - Internal review comments incorporated for merging mocking into BaseTest - Internal review comments incorporated for removing direct repo calls - CLONE - Key Management Hardcoded encryption key | fixing junits - CLONE - Key Management Hardcoded encryption key Updated builder to use String.format Added exception specifically for issues interacting with requestdbadapter Updated exception message and added junit test case removed useless error handling test case from workflow changed method name and added junit coverage to errors added max retry and success status after completed bb Added case to handle when homing is not called during assign vnf. Fixing fortify issues | Implementing review comments - Key Management Hardcoded encryption key - fixing prop files - Key Management Hardcoded encryption key include network ID for completion handler Added exception handling for saving to requestdb - Adding a check on the predicate availability on the repository before firing the query with default conditions. This ensures that the api returns data only when there is an input against which it was able to form some conditions Modify UT to show that the API does not behave - adding negative test case for checkInstanceNameDuplicate added assertion that global count var was reset to 0 updated rollback to reset current sequence count var workflowaction calls rollback is complete before error workflowaction will set failure on successful rollback added check for isrollback to know which complete to call removed file which should not have been added add fabric check before running vf module a la carte Enhance UCPEMigrateService junits and add them to Jenkins build.. Added back removed test case for ManualTasks Added test case for response error Added rainy day test cases for ManualTasks revert the other change and fix the rollback logic instead fixed current sequence and updated rollback code added network cloud heat template parameters to mapper Generate a unique subRequestId for each request to APP-C. reverted conditional logic for determining fabric Fix Bean scanning so it picks up the resttemplate removed unnecessary RestTemplate Bean configurations removed file which should not have been added workflowaction calls rollback is complete before error workflowaction will set failure on successful rollback added check for isrollback to know which complete to call add fabric check before running vf module a la carte added assertion that global count var was reset to 0 updated rollback to reset current sequence count var include network ID for completion handler Revert Application.yaml change accidentally checked in Added exception handling for saving to requestdb Added case to handle when homing is not called during assign vnf. removed useless error handling test case from workflow changed method name and added junit coverage to errors ... add cloud owner variable to camunda in mapping Revert "Pass cloudOwner to subflow DoCreateVfModuleVolumeV2. Added juint test to verify variables are set in the execution. Set default cloudOwner in main module CreateVfModuleVolumeInfraV2" updated cloud configuration pojo to inlcude defaults Revert "Test to verify ServiceInstance object mapping" Test to verify ServiceInstance object mapping Pass cloudOwner to subflow DoCreateVfModuleVolumeV2. Added juint test to verify variables are set in the execution. Set default cloudOwner in main module CreateVfModuleVolumeInfraV2 Pass cloudOwner to subflow DoCreateVfModuleVolumeV2. Set default cloudOwner 'att-aic' if null per old requirements. removed references to att-aic from BBInputSetup Changes done in encryption decryption logic | used DelegateExecutionFake in Tests Changes done in encryption decryption logic | used DelegateExecutionFake in Tests Changes done in encryption decryption logic Changes done in encryption decryption logic | removed Default Auth Constant as per the comments Changes done in encryption decryption logic | Fixed UT Changes done in encryption decryption logic | Added XmlComparator assertion for verifying XML Changes done in encryption decryption logic | Reverted as per the review comment Changes done in encryption decryption logic | Fixed UTs Changes done in encryption decryption logic | Fixed UTs Changes done in encryption decryption logic | modified related encrypted properties in test yaml files Changes done in encryption decryption logic for fortify issue resolution | Fixed UTs Changes done in encryption decryption logic | modified related encrypted properties in yaml files Changes done in encryption decryption logic for fortify issue resolution. Fixed Property fetching issue in required file Added TasksBeansTest using openpojo Removed renamed test file from tasksbeans Updated imports on TasksBeansTest Added openpojo test to replace the individual tests Removed tests that provided no coverage script clean up -Update reference data to support distinct recreate and replace requests with their own sequences Update reference data to support distinct recreate and replace requests with their own sequences- Fix seq number Update reference data to support distinct recreate and replace requests with their own sequences added null check to mdc and interceptors to sdnc cxf validations can now match against multiple BBs reverted changes to BBInputSetup class added support for pre and post validation for BBs initial commit of generic building block validator converted test to no longer be a springboot test Remove cosmetic changes from BPMN files to be consistent. Remove minor changes that are not related to functionality. Rework to implement the functionality as part of Validator Combine the verification methods into one based on the flow's name; change the logging. Add verification of status of other VF Modules in the VNF for the delete/deactivate/unassign. added network-technology validation for CreateNetworkBB Sonar Issue Fix | Changes done in encryption decryption logic | Refactoring Changes done in encryption decryption logic| Used AES/GCM/NoPadding algorithm | fixed sonar issues added network-type and network-technology to mapper Continue the fight to make JUNITS work properly Update ASDC ATT to be springboot 2.0 compliant Continue to fix Unit tests for springboot 2.0 port removed autowired from workflowactionbbtaskstest fixed workflowactiontest and reduced size by 500 lines Update last of UT for mockito upgrade to 2.0 Fix more JUNITS due to mockito 2.0 upgrade Unit Test fixes to use proper mockito not spring Update Base Test to import proper packages for compile Additional Springboot 2.0 changes, for tests Additional springboot 2.0 fixes and upgrades Update Migration to be Flyway 5 Compliant Fix MSOBPMN Infrastructure common tests Fix Groovy Unit Tests in CommonBPMN Project Update MSO common BPMN to Springboot 2.0 Upgrade ASDC controller to SpringBoot 2.0 Port Openstack adapters to springboot 2.0 Fix VFC Adapter to be springboot 2 compatible Port CatalogDB adapter code to springboot 2 Port SDNC Adapter to Springboot 2.0 ... added update scripts to macro data instead of v12 sql added secondarypolicy to rainy day handling table confirm subnet map is not null in adapter response shallow copy subnet before AAI udpate update AAIObjectType to use uriTemplate extract subnet data from adapter response update correct AAIObjectType for subnet query update subnet(s) in AAI on network create completion confirm subnet map is not null in adapter response shallow copy subnet before AAI udpate update AAIObjectType to use uriTemplate extract subnet data from adapter response update correct AAIObjectType for subnet query update subnet(s) in AAI on network create completion fixed test http entity unit test to remove testing appid and transaction id added unit test for querySubsystemHealth method. also added resttemplate mock to implement healthcheck endpoint fixed unit test to use mock instead of actually goes out to health check endpoint added code to extend globalhealthcheck to include pinging other components and consolidate the responses converted test to no longer be a springboot test Remove cosmetic changes from BPMN files to be consistent. Remove minor changes that are not related to functionality. added update scripts to macro data instead of v12 sql Rework to implement the functionality as part of Validator added secondarypolicy to rainy day handling table added network-type and network-technology to mapper Combine the verification methods into one based on the flow's name; change the logging. Add verification of status of other VF Modules in the VNF for the delete/deactivate/unassign. updated how request db is set to failure in workflowA corrected code to match existing unit tests corrected tests after springboot 2 upgrade Added Required UTs in UpdateConfigurationStateTest and also fixed some UTs. added in missing parenthesis on method call added back execution variable for allotted uri addressed comments on pull request refactor AAI Rest calls from groovy files - Changes as per review comments checkin to refactor AAI rest | Fixing AAIResourceClient.update call refactor AAI Rest calls from groovy files - UpdateConfiguration refactor AAI Rest calls from groovy file - DeleteConfiguration refactor AAI Rest calls from groovy file - UpdateConfiguration refactor AAI Rest calls from groovy file - CreateConfiguration & ConfigurationUtils refactor AAI Rest calls from groovy files - Fix getARByID issue checkin to refactor AAI rest | Adding Junits checkin to refactor AAI rest | Adding few more classes checkin to refactor AAI rest of DoCreateVfModuleVolumeV2 checkin to refactor AAI rest | Update junit checkin to refactor AAI rest of DoCreateVfModuleVolumeV2 | Adding junits checkin to refactor AAI rest of DoCreateVfModuleVolumeV2 | Adding junits checkin to refactor AAI rest of DoCreateVfModuleVolumeV2.groovy ... updated in and out mapping to be generalBuildingBlock change source out mapping to generalBuildingBlock Change-Id: I122f1ebe3e15b77da0a55af201d89d47e326bf83 Issue-ID: SO-1098 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-09-20Update LoggingSmokowski, Steve (ss835w)1-1/+4
Update logging to meet Casablanca Spec Change-Id: I029d6c63765992d6f091d96e2b4c34c60d30c484 Issue-ID: SO-947 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-09-10Merge "RequestTunables.java: Fixed sonar issues"Byung-Woo Jun1-3/+0
2018-09-10RequestTunables.java: Fixed sonar issuesArundathi Patil1-3/+0
Sonar-Link : https://sonar.onap.org/code?id=org.onap.so%3Aso&selected=org.onap.so%3Amso-sdnc-adapter%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fso%2Fadapters%2Fsdnc%2Fimpl%2FRequestTunables.java Issue-ID: SO-1008 Change-Id: I7660ac5f7be56e1a1d409305e6ffaf5a841ae446 Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2018-09-10SDNCAdapterTypeImpl.java: Fixed sonar issueArundathi Patil1-3/+1
Sonar Link : https://sonar.onap.org/code?id=org.onap.so%3Aso&selected=org.onap.so%3Amso-sdnc-adapter%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fso%2Fadapters%2Fsdnc%2Fimpl%2FSDNCAdapterPortTypeImpl.java Issue-ID: SO-1007 Change-Id: Id11dcccaeb7a728f9fa238570759783fb9053ed9 Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2018-09-10CFXConfiguration.java: Fixed sonar issuesArundathi Patil1-2/+0
Sonar Link : https://sonar.onap.org/code?id=org.onap.so%3Aso&selected=org.onap.so%3Amso-sdnc-adapter%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fso%2Fadapters%2Fsdnc%2FCXFConfiguration.java Issue-ID: SO-1002 Change-Id: Ieea4c3a2fe9798dc44d2f3bd8bc6c1d02726f32f Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2018-09-05Client LoggingSmokowski, Steve (ss835w)1-9/+4
Update Client Logging to use interceptor Move CXF to own project due to dependency hell Issue-ID: SO-947 Change-Id: I2597ff6d32231b8625b04ef63ab5e8f589e2545c Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-09-05Merge "fixed sonar issue in RequestTunables.java"Rob Daugherty1-2/+3
2018-09-05fixed sonar issue in SNIROResponse.javaSandeep J1-1/+3
fixed sonar issue as detailed in SO-976 Issue-ID: SO-976 Change-Id: If9710595248969bf72a55cfda759067439e6d2d4 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-09-05fixed sonar issue in RequestTunables.javaSandeep J1-2/+3
fixed sonar issue as detailed in SO-975 Issue-ID: SO-975 Change-Id: Ic98db5f80f939bee8ad2c1ad33efebaa1b2d6a21 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-09-04Merge "fixed sonar issue in MapRequestTunables.java"Byung-Woo Jun1-1/+3
2018-09-04fixed sonar issue in SDNCServiceRequestConnectorSandeep J1-2/+4
fixed sonar issue as detailed in SO-970 Issue-ID: SO-970 Change-Id: I57c14693fa6918401d37d0d56bdccfe91bb2f372 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-09-04fixed sonar issue in MapRequestTunables.javaSandeep J1-1/+3
fixed sonar issue as detailed in SO-964 Issue-ID: SO-964 Change-Id: I7f51faba54571186242021048c0b3e755bdde731 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-08-31Merge "Update Logging"Rob Daugherty2-6/+15
2018-08-31Update LoggingSmokowski, Steve (ss835w)2-6/+15
Add CXF interceptor for SOAP based logging Clean up extra logging statements Add UT to ensure MDC properly populated Change package name on Jax-RS Filter to be more accurate Issue-ID: SO-947 Change-Id: I3a2afc58de3bf370675658ce3d19cf899b90def7 Change-Id: I3a2afc58de3bf370675658ce3d19cf899b90def7 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-08-30resolved sonar isue in MapTypedRequestTunablesDataSandeep J1-10/+16
resolved sonar issue as detailed in SO-937 Issue-ID: SO-937 Change-Id: I554a43af29fe8965c72f05a84217a0aae43750df Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-08-30Merge "fixed sonar issue in BPRestCallback.java"Byung-Woo Jun1-9/+12
2018-08-30Merge "fixed sonar issue in SDNCConnector.java"Byung-Woo Jun1-7/+10
2018-08-30Merge "fixed sonar issue in SDNCRestClient.java"Byung-Woo Jun1-12/+16
2018-08-30Merge "fixed sonar issue in SDNCCallBackAdapterService"Byung-Woo Jun1-5/+5
2018-08-29fixed sonar issue in SDNCConnector.javaSandeep J1-7/+10
fixed sonar issue as detailed in SO-935 Issue-ID: SO-935 Change-Id: Ifdde63670b78acfa8ba84a0130dcd4f4f4649e72 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-08-29fixed sonar issue in BPRestCallback.javaSandeep J1-9/+12
fixed sonar issue as detailed in SO-934 Issue-ID: SO-934 Change-Id: I6f87ea6c61e81e0241702b20bcc2688a4a9d5d6a Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-08-30fixed sonar issue in SDNCRestClient.javaSandeep J1-12/+16
fixed sonar issue detailed in SO-933 Issue-ID: SO-933 Change-Id: I8d522f51689568c19da491f0c7272fc9551df9d1 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-08-30fixed sonar issue in SDNCCallBackAdapterServiceSandeep J1-5/+5
fixed sonar issue mentioned in jira ticket no SO-932 Issue-ID: SO-932 Change-Id: I9493b09d12446daed1cf43801308d13052232452 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-08-30fixed sonar issue in SDNCAdapterService.javaSandeep J1-1/+1
fixed sonar issue mentioned in jira SO-914 Issue-ID: SO-914 Change-Id: I4893bce5dbdd5e0bc524dc0ead0dc41f246afca4 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-08-29fixed sonar issue in SDNCAdapterService.javaSandeep J1-4/+7
resolved sonar issue desribed in Jira id: SO-914 Issue-ID: SO-914 Change-Id: Icc79a36d665ca950ddcd289dd239b8aa3360db37 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-07-31Containerization feature of SOBenjamin, Max (mb388a)95-2253/+2911
Change-Id: I95381232eeefcd247a66a5cec370a8ce1c288e18 Issue-ID: SO-670 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-07-27Reorder modifiersAnisha Kumar1-3/+3
Reordered the modifiers to be "public static final" instead of "public final static" in order to comply with Java Language Specification. Issue-ID: SO-666 Change-Id: I70a9cfcf454ce79dcb3940ccc24750416462c225 Signed-off-by: Anisha Kumar <anishax.kumar@intel.com>
2018-07-25Merge "Sonar major issues"Seshu Kumar M1-10/+0
2018-07-25Merge "Sonar major issues"Seshu Kumar M1-1/+1
2018-07-25Sonar major issuesSurendra Reddy Katam1-10/+0
This block of commented-out lines of code should be removed Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.so%3Aso&open=AWHCr-Z9EU5FCDfKtmIA&resolved=false&severities=MAJOR Location: adapters/mso-sdnc-adapter/src/main/java/org/openecomp/mso/adapters/sdnc/notify/SDNCNotifyResource.java Line No-177 Change-Id: I3fd12f01315a2ead0f7f676caeb88d9d9b207a43 Issue-ID: SO-753 Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
2018-07-24Sonar major issuesSumapriya Sarvepalli1-1/+1
This block of commented-out lines of code should be removed Sonar Link: https://sonar.onap.org/project/issues?id=org.onap.so%3Aso&open=AWHCr-Y0EU5FCDfKtmG_&resolved=false&severities=MAJOR Location: src/main/java/org/openecomp/mso/adapters/sdnc/SDNCAdapterService.java Line No: L58 Change-Id: I5665a41ea85a5464d1c5fb208f20be725fe044d7 Issue-ID: SO-738 Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
2018-07-24Sonar Major issuesSurendra Reddy Katam1-1/+0
This block of commented-out lines of code should be removed Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.so%3Aso&open=AWHCr-Y0EU5FCDfKtmG-&resolved=false&severities=MAJOR Location: adapters/mso-sdnc-adapter/src/main/java/org/openecomp/mso/adapters/sdnc/SDNCAdapterService.java Line No-32 Change-Id: I6d80143d6268a05c34128fba3999b73abf8c376e Issue-ID: SO-737 Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
2018-04-18UT modification for adaptes - db,sdncroot2-33/+56
UT changes for mso-sdnc-adapter and mso-requests-db Issue-ID: SO-369 Change-Id: Id201617addb3a83d7ed9773f7991907917c46129 Signed-off-by: root <arcot.sindhuri@huawei.com>
2018-04-13updated to use latest vdu plugin codedfilppi1-2/+3
Change-Id: I46cd41d32e0902a141a87d0c1e01aea278ec17ea Issue-ID: SO-561 Signed-off-by: DeWayne Filppi <dewayne@cloudify.co>
2018-04-13Removing the test cases with issuesSeshu-Kumar-M1-3/+3
Issue-ID: SO-561 Change-Id: Idb7017c58390d017df1806e70d2410a20d0fbca0 Signed-off-by: Seshu-Kumar-M <seshu.kumar.m@huawei.com>
2018-03-28UT for sdnc adapter TypedRequestTunableSindhu A1-0/+48
UT for sdnc adapter TypedRequestTunable Issue-ID: SO-369 Change-Id: I973ab1f1329518da06e9b4a78acf6c40f84cfbf1 Signed-off-by: Sindhu A <arcot.sindhuri@huawei.com>
2018-03-28UT for sdnc adapter rest implSindhu A1-0/+61
UT for sdnc-adapter SDNCAdapterRestImpl Issue-ID: SO-369 Change-Id: I1378458de4a47e561c6b3b99222133e3551924ae Signed-off-by: Sindhu A <arcot.sindhuri@huawei.com>
2018-03-28UT for sdnc adapter BPRestCallbackSindhu A1-0/+38
UT for sdnc adapter BPRestCallback Issue-ID: SO-369 Change-Id: Icf719140c74998f60930caf538537fbe0300dbbe Signed-off-by: Sindhu A <arcot.sindhuri@huawei.com>
2018-03-28UT for SDNCNotifyResourceSindhu A1-0/+46
UT for SDNCNotifyResource Issue-ID: SO-369 Change-Id: I880440bce37666e40d5ca0878f3c7833af59d8bc Signed-off-by: Sindhu A <arcot.sindhuri@huawei.com>
2018-03-28improved coverage of module Benjamin, Max (mb388a)7-32/+71
Change-Id: I2adc89fc30fbd8ae9eaf93ae9b9d63f3fbe6f5e8 Issue-ID: SO-538 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-03-14AT&T 1712 and 1802 release codeRob Daugherty7-66/+385
This is code from AT&T's 1712 and 1802 releases. Change-Id: Ie1e85851e94bc66c4d9514a0226c221939531a04 Issue-ID: SO-425 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-03-13Merge "Remove redundant type cast"Seshu Kumar M1-1/+1
2018-03-12Adding JunitAS004650591-0/+49
Junit for SDNCResponse.java Sonar-Link: https://sonar.onap.org/code?id=org.onap.so%3Aso&selected=org.onap.so.adapters%3Amso-sdnc-adapter%3Asrc%2Fmain%2Fjava%2Forg%2Fopenecomp%2Fmso%2Fadapters%2Fsdnc%2Fimpl%2FSDNCResponse.java Change-Id: I9b4fc5b0f414ddf8a7229299d482ea0cc51aa21f Issue-ID: SO-473 Signed-off-by: AS00465059 <AS00465059@techmahindra.com>
2018-03-10Remove redundant type castMunir Ahmad1-1/+1
Change-Id: Ie00d5ec5a4677c99a9a689bf18a85055902f6384 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-03-09Revert Reduce log noise/warningsRob Daugherty6-527/+529
This reverts commit 327b17ab250b4c17cf3f91f5e4cd9bffd89f3d1e. It is seriously impeding our ability complete the promised merge of AT&T 1802 code. While I'm all for coding standards, if we are serious about using spaces instead of tabs, then I think we need to (1) agree with the community when this will happen, (2) do consistently in all files, and (3) enforce it. Change-Id: Ib9b996f6b6c7d81ac9ac95d58b0c7d8cc39675ff Issue-ID: SO-368 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-03-08Reduce log noise/warnings format to conventionsMarcus G K Williams6-529/+527
Reduce build log warnings by formatting tests to ONAP code conventions (removing tabs etc.) Issue-ID: SO-368 Change-Id: I48c6d359b83617aebeb79db4e30c1d72d31f7eec Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2018-03-06Remove redundant catch clauseMunir Ahmad1-6/+1
Change-Id: Ib26f47171384125847a1b31bc1a958b50d0bba70 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-02-28Merge "Adding Junit"Seshu Kumar M1-0/+53
2018-02-26Adding JunitSumapriya1-0/+53
Adding Junit for SDNCAdapterCallbackRequest.java Sonar Link: https://sonar.onap.org/code?id=org.openecomp.so%3Aso&selected=org.openecomp.so.adapters%3Amso-sdnc-adapter%3Asrc%2Fmain%2Fjava%2Forg%2Fopenecomp%2Fmso%2Fadapters%2Fsdnc%2Fclient%2FSDNCAdapterCallbackRequest.java Change-Id: I8c84a7aadeeccb4288c89b026d5d815f97f7f9dd Issue-ID: SO-447 Signed-off-by: Sumapriya <SS00493505@techmahindra.com>