aboutsummaryrefslogtreecommitdiffstats
path: root/adapters/mso-sdnc-adapter/src/test
AgeCommit message (Collapse)AuthorFilesLines
2020-06-18Prepare for java 11Benjamin, Max1-64/+0
final changes for java11 groovy compatibility removed unnecessary dependencies and cleaned up poms added missing jaxws-api dependency to pom.xml java8 profile is now active by default in parent pom update beans to have RemoteResource annotation always use the compiler plugin from parent pom Update external task timeout to longer value to hold lock update remote resource annotation to match catalog db client add remote resource annotation to bean for bowman completely remove bowman from requests db client Issue-ID: SO-2059 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: If6f0df36e8077ccd703abce9f64290daed63955b
2020-03-23Fix sonar issuesParshad Patel1-3/+4
The Cyclomatic Complexity of this method is greater than 10 authorized Remove unused fields Issue-ID: SO-1841 Change-Id: I792e02a3843623b1a93d5a272946ad79a07373f8 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2019-12-16update so to use 1.6.3 snapshot from the loggingPlummer, Brittany2-0/+143
Updated snapshot to 1.6.3 and began fixing failing tests Update SOAPLoggingInInterceptor to use new InvocationID value Changed client and server keys to InvocationID BPRestCallback to use ServerInvocationId Removed logging MDC checking from unit tests Began switching bprestcallback to use resttemplate Removed changes to logback replacing invocationIds Updated logic where requestEntity is created on null message Added unit tests for BPRestCallback Set InvocationID in MDC in SOAPLoggingInInterceptor Send in URI to prevent encoding of URI causing % to change to %25 Updated restTemplate to fix issue with interceptors Issue-ID: SO-2571 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I7e0d80eae9036c993414ae96ebd571c89cb9dfa9
2019-04-08Replaced all tabs with spaces in java and pom.xmlBenjamin, Max (mb388a)17-766/+702
Added in maven plugins to enforce coding style rules Added in eclipse java formatting xml Change-Id: I3727bbf4ce8dc66abfd8ad21b6cfd0890c5d3ff0 Issue-ID: SO-1765 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-04-01replace all fixed wiremock portsBenjamin, Max (mb388a)5-16/+54
trying to get the tests that can be threaded to pass started to remove fixed port references Change-Id: I7bfe067a8f36c908039700646571681321e9a6f5 Issue-ID: SO-1676 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-26Removed MsoLogger from 'mso-sdnc-adapter'r.bogacki1-3/+6
Removed MsoLogger from adapters ('mso-sdnc-adapter') Replaced MsoLogger with plain slf4j. Refactored login output. Fixed imports. Change-Id: I1656776a04b322b9b8da30a3cc6aad31cd621a3e Issue-ID: LOG-631 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
2019-02-14fix critical sonar bugsk.kazak1-0/+10
Restore interrupted state when InterruptedException is thrown in SDNCRestClient Added test for this case Replaced formatting anchor with text empty object in GraphInventoryResultWrapper Escaped anchor is also considered as bug by sonar Case is already covered in AAIResultWrapperTest Marked comparison of the same object as false positive in EqualsAndHashCodeTester Added clearer comment to this comparison Change-Id: I24496c2323c33599db99a3d3b59fc4f6a008cf1f Issue-ID: SO-1492 Signed-off-by: k.kazak <k.kazak@samsung.com>
2018-11-05Springboot 2.0 upgradeBenjamin, Max (mb388a)2-2/+56
corrected typo in CloudConfiguration class removed files which should not have been merged updated gr api test cases with dynamic cloud owner updated groovy files to allow for dynamic cloud owner values moved VFModularity folder to mso-infrastructure bpmn updated GR API layer to include cloud owner added enum for default cloud owner - fixing junit test cases for using catalogDb client r2 - fixing junit test cases for using catalogDb client - Internal review comments incorporated for merging mocking into BaseTest - Internal review comments incorporated for removing direct repo calls - CLONE - Key Management Hardcoded encryption key | fixing junits - CLONE - Key Management Hardcoded encryption key Updated builder to use String.format Added exception specifically for issues interacting with requestdbadapter Updated exception message and added junit test case removed useless error handling test case from workflow changed method name and added junit coverage to errors added max retry and success status after completed bb Added case to handle when homing is not called during assign vnf. Fixing fortify issues | Implementing review comments - Key Management Hardcoded encryption key - fixing prop files - Key Management Hardcoded encryption key include network ID for completion handler Added exception handling for saving to requestdb - Adding a check on the predicate availability on the repository before firing the query with default conditions. This ensures that the api returns data only when there is an input against which it was able to form some conditions Modify UT to show that the API does not behave - adding negative test case for checkInstanceNameDuplicate added assertion that global count var was reset to 0 updated rollback to reset current sequence count var workflowaction calls rollback is complete before error workflowaction will set failure on successful rollback added check for isrollback to know which complete to call removed file which should not have been added add fabric check before running vf module a la carte Enhance UCPEMigrateService junits and add them to Jenkins build.. Added back removed test case for ManualTasks Added test case for response error Added rainy day test cases for ManualTasks revert the other change and fix the rollback logic instead fixed current sequence and updated rollback code added network cloud heat template parameters to mapper Generate a unique subRequestId for each request to APP-C. reverted conditional logic for determining fabric Fix Bean scanning so it picks up the resttemplate removed unnecessary RestTemplate Bean configurations removed file which should not have been added workflowaction calls rollback is complete before error workflowaction will set failure on successful rollback added check for isrollback to know which complete to call add fabric check before running vf module a la carte added assertion that global count var was reset to 0 updated rollback to reset current sequence count var include network ID for completion handler Revert Application.yaml change accidentally checked in Added exception handling for saving to requestdb Added case to handle when homing is not called during assign vnf. removed useless error handling test case from workflow changed method name and added junit coverage to errors ... add cloud owner variable to camunda in mapping Revert "Pass cloudOwner to subflow DoCreateVfModuleVolumeV2. Added juint test to verify variables are set in the execution. Set default cloudOwner in main module CreateVfModuleVolumeInfraV2" updated cloud configuration pojo to inlcude defaults Revert "Test to verify ServiceInstance object mapping" Test to verify ServiceInstance object mapping Pass cloudOwner to subflow DoCreateVfModuleVolumeV2. Added juint test to verify variables are set in the execution. Set default cloudOwner in main module CreateVfModuleVolumeInfraV2 Pass cloudOwner to subflow DoCreateVfModuleVolumeV2. Set default cloudOwner 'att-aic' if null per old requirements. removed references to att-aic from BBInputSetup Changes done in encryption decryption logic | used DelegateExecutionFake in Tests Changes done in encryption decryption logic | used DelegateExecutionFake in Tests Changes done in encryption decryption logic Changes done in encryption decryption logic | removed Default Auth Constant as per the comments Changes done in encryption decryption logic | Fixed UT Changes done in encryption decryption logic | Added XmlComparator assertion for verifying XML Changes done in encryption decryption logic | Reverted as per the review comment Changes done in encryption decryption logic | Fixed UTs Changes done in encryption decryption logic | Fixed UTs Changes done in encryption decryption logic | modified related encrypted properties in test yaml files Changes done in encryption decryption logic for fortify issue resolution | Fixed UTs Changes done in encryption decryption logic | modified related encrypted properties in yaml files Changes done in encryption decryption logic for fortify issue resolution. Fixed Property fetching issue in required file Added TasksBeansTest using openpojo Removed renamed test file from tasksbeans Updated imports on TasksBeansTest Added openpojo test to replace the individual tests Removed tests that provided no coverage script clean up -Update reference data to support distinct recreate and replace requests with their own sequences Update reference data to support distinct recreate and replace requests with their own sequences- Fix seq number Update reference data to support distinct recreate and replace requests with their own sequences added null check to mdc and interceptors to sdnc cxf validations can now match against multiple BBs reverted changes to BBInputSetup class added support for pre and post validation for BBs initial commit of generic building block validator converted test to no longer be a springboot test Remove cosmetic changes from BPMN files to be consistent. Remove minor changes that are not related to functionality. Rework to implement the functionality as part of Validator Combine the verification methods into one based on the flow's name; change the logging. Add verification of status of other VF Modules in the VNF for the delete/deactivate/unassign. added network-technology validation for CreateNetworkBB Sonar Issue Fix | Changes done in encryption decryption logic | Refactoring Changes done in encryption decryption logic| Used AES/GCM/NoPadding algorithm | fixed sonar issues added network-type and network-technology to mapper Continue the fight to make JUNITS work properly Update ASDC ATT to be springboot 2.0 compliant Continue to fix Unit tests for springboot 2.0 port removed autowired from workflowactionbbtaskstest fixed workflowactiontest and reduced size by 500 lines Update last of UT for mockito upgrade to 2.0 Fix more JUNITS due to mockito 2.0 upgrade Unit Test fixes to use proper mockito not spring Update Base Test to import proper packages for compile Additional Springboot 2.0 changes, for tests Additional springboot 2.0 fixes and upgrades Update Migration to be Flyway 5 Compliant Fix MSOBPMN Infrastructure common tests Fix Groovy Unit Tests in CommonBPMN Project Update MSO common BPMN to Springboot 2.0 Upgrade ASDC controller to SpringBoot 2.0 Port Openstack adapters to springboot 2.0 Fix VFC Adapter to be springboot 2 compatible Port CatalogDB adapter code to springboot 2 Port SDNC Adapter to Springboot 2.0 ... added update scripts to macro data instead of v12 sql added secondarypolicy to rainy day handling table confirm subnet map is not null in adapter response shallow copy subnet before AAI udpate update AAIObjectType to use uriTemplate extract subnet data from adapter response update correct AAIObjectType for subnet query update subnet(s) in AAI on network create completion confirm subnet map is not null in adapter response shallow copy subnet before AAI udpate update AAIObjectType to use uriTemplate extract subnet data from adapter response update correct AAIObjectType for subnet query update subnet(s) in AAI on network create completion fixed test http entity unit test to remove testing appid and transaction id added unit test for querySubsystemHealth method. also added resttemplate mock to implement healthcheck endpoint fixed unit test to use mock instead of actually goes out to health check endpoint added code to extend globalhealthcheck to include pinging other components and consolidate the responses converted test to no longer be a springboot test Remove cosmetic changes from BPMN files to be consistent. Remove minor changes that are not related to functionality. added update scripts to macro data instead of v12 sql Rework to implement the functionality as part of Validator added secondarypolicy to rainy day handling table added network-type and network-technology to mapper Combine the verification methods into one based on the flow's name; change the logging. Add verification of status of other VF Modules in the VNF for the delete/deactivate/unassign. updated how request db is set to failure in workflowA corrected code to match existing unit tests corrected tests after springboot 2 upgrade Added Required UTs in UpdateConfigurationStateTest and also fixed some UTs. added in missing parenthesis on method call added back execution variable for allotted uri addressed comments on pull request refactor AAI Rest calls from groovy files - Changes as per review comments checkin to refactor AAI rest | Fixing AAIResourceClient.update call refactor AAI Rest calls from groovy files - UpdateConfiguration refactor AAI Rest calls from groovy file - DeleteConfiguration refactor AAI Rest calls from groovy file - UpdateConfiguration refactor AAI Rest calls from groovy file - CreateConfiguration & ConfigurationUtils refactor AAI Rest calls from groovy files - Fix getARByID issue checkin to refactor AAI rest | Adding Junits checkin to refactor AAI rest | Adding few more classes checkin to refactor AAI rest of DoCreateVfModuleVolumeV2 checkin to refactor AAI rest | Update junit checkin to refactor AAI rest of DoCreateVfModuleVolumeV2 | Adding junits checkin to refactor AAI rest of DoCreateVfModuleVolumeV2 | Adding junits checkin to refactor AAI rest of DoCreateVfModuleVolumeV2.groovy ... updated in and out mapping to be generalBuildingBlock change source out mapping to generalBuildingBlock Change-Id: I122f1ebe3e15b77da0a55af201d89d47e326bf83 Issue-ID: SO-1098 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-08-31Update LoggingSmokowski, Steve (ss835w)1-2/+1
Add CXF interceptor for SOAP based logging Clean up extra logging statements Add UT to ensure MDC properly populated Change package name on Jax-RS Filter to be more accurate Issue-ID: SO-947 Change-Id: I3a2afc58de3bf370675658ce3d19cf899b90def7 Change-Id: I3a2afc58de3bf370675658ce3d19cf899b90def7 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-07-31Containerization feature of SOBenjamin, Max (mb388a)28-697/+828
Change-Id: I95381232eeefcd247a66a5cec370a8ce1c288e18 Issue-ID: SO-670 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-04-18UT modification for adaptes - db,sdncroot2-33/+56
UT changes for mso-sdnc-adapter and mso-requests-db Issue-ID: SO-369 Change-Id: Id201617addb3a83d7ed9773f7991907917c46129 Signed-off-by: root <arcot.sindhuri@huawei.com>
2018-04-13updated to use latest vdu plugin codedfilppi1-2/+3
Change-Id: I46cd41d32e0902a141a87d0c1e01aea278ec17ea Issue-ID: SO-561 Signed-off-by: DeWayne Filppi <dewayne@cloudify.co>
2018-04-13Removing the test cases with issuesSeshu-Kumar-M1-3/+3
Issue-ID: SO-561 Change-Id: Idb7017c58390d017df1806e70d2410a20d0fbca0 Signed-off-by: Seshu-Kumar-M <seshu.kumar.m@huawei.com>
2018-03-28UT for sdnc adapter TypedRequestTunableSindhu A1-0/+48
UT for sdnc adapter TypedRequestTunable Issue-ID: SO-369 Change-Id: I973ab1f1329518da06e9b4a78acf6c40f84cfbf1 Signed-off-by: Sindhu A <arcot.sindhuri@huawei.com>
2018-03-28UT for sdnc adapter rest implSindhu A1-0/+61
UT for sdnc-adapter SDNCAdapterRestImpl Issue-ID: SO-369 Change-Id: I1378458de4a47e561c6b3b99222133e3551924ae Signed-off-by: Sindhu A <arcot.sindhuri@huawei.com>
2018-03-28UT for sdnc adapter BPRestCallbackSindhu A1-0/+38
UT for sdnc adapter BPRestCallback Issue-ID: SO-369 Change-Id: Icf719140c74998f60930caf538537fbe0300dbbe Signed-off-by: Sindhu A <arcot.sindhuri@huawei.com>
2018-03-28UT for SDNCNotifyResourceSindhu A1-0/+46
UT for SDNCNotifyResource Issue-ID: SO-369 Change-Id: I880440bce37666e40d5ca0878f3c7833af59d8bc Signed-off-by: Sindhu A <arcot.sindhuri@huawei.com>
2018-03-28improved coverage of module Benjamin, Max (mb388a)7-32/+71
Change-Id: I2adc89fc30fbd8ae9eaf93ae9b9d63f3fbe6f5e8 Issue-ID: SO-538 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-03-14AT&T 1712 and 1802 release codeRob Daugherty5-61/+373
This is code from AT&T's 1712 and 1802 releases. Change-Id: Ie1e85851e94bc66c4d9514a0226c221939531a04 Issue-ID: SO-425 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-03-12Adding JunitAS004650591-0/+49
Junit for SDNCResponse.java Sonar-Link: https://sonar.onap.org/code?id=org.onap.so%3Aso&selected=org.onap.so.adapters%3Amso-sdnc-adapter%3Asrc%2Fmain%2Fjava%2Forg%2Fopenecomp%2Fmso%2Fadapters%2Fsdnc%2Fimpl%2FSDNCResponse.java Change-Id: I9b4fc5b0f414ddf8a7229299d482ea0cc51aa21f Issue-ID: SO-473 Signed-off-by: AS00465059 <AS00465059@techmahindra.com>
2018-03-09Revert Reduce log noise/warningsRob Daugherty6-527/+529
This reverts commit 327b17ab250b4c17cf3f91f5e4cd9bffd89f3d1e. It is seriously impeding our ability complete the promised merge of AT&T 1802 code. While I'm all for coding standards, if we are serious about using spaces instead of tabs, then I think we need to (1) agree with the community when this will happen, (2) do consistently in all files, and (3) enforce it. Change-Id: Ib9b996f6b6c7d81ac9ac95d58b0c7d8cc39675ff Issue-ID: SO-368 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-03-08Reduce log noise/warnings format to conventionsMarcus G K Williams6-529/+527
Reduce build log warnings by formatting tests to ONAP code conventions (removing tabs etc.) Issue-ID: SO-368 Change-Id: I48c6d359b83617aebeb79db4e30c1d72d31f7eec Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2018-02-28Merge "Adding Junit"Seshu Kumar M1-0/+53
2018-02-26Adding JunitSumapriya1-0/+53
Adding Junit for SDNCAdapterCallbackRequest.java Sonar Link: https://sonar.onap.org/code?id=org.openecomp.so%3Aso&selected=org.openecomp.so.adapters%3Amso-sdnc-adapter%3Asrc%2Fmain%2Fjava%2Forg%2Fopenecomp%2Fmso%2Fadapters%2Fsdnc%2Fclient%2FSDNCAdapterCallbackRequest.java Change-Id: I8c84a7aadeeccb4288c89b026d5d815f97f7f9dd Issue-ID: SO-447 Signed-off-by: Sumapriya <SS00493505@techmahindra.com>
2018-02-26Adding JunitAS004650591-0/+47
Junit for CallbackHeader.java Sonar link: https://sonar.onap.org/code?id=org.openecomp.so%3Aso&selected=org.openecomp.so.adapters%3Amso-sdnc-adapter%3Asrc%2Fmain%2Fjava%2Forg%2Fopenecomp%2Fmso%2Fadapters%2Fsdnc%2Fclient%2FCallbackHeader.java Change-Id: Ic539c486d703f8376257b8bbc2166a3054c8007e Issue-ID: SO-446 Signed-off-by: AS00465059 <AS00465059@techmahindra.com>
2018-02-20Adding Junit AS004650591-0/+54
Junit for SDNCAdapterRequest.java Change-Id: I570ce3381b967e184601535558413826a5c0baf2 Issue-ID: SO-431 Signed-off-by: AS00465059 <AS00465059@techmahindra.com>
2017-09-11Change the header to SOSeshu-Kumar-M4-4/+4
IssueId: SO-120 Change-Id: I59982b12d5b538b3f9765410ac26cbdde1844957 Signed-off-by: Seshu-Kumar-M <seshu.kumar.m@huawei.com>
2017-04-11[MSO-8] Update the maven dependencyxg353y2-10/+477
Update the maven depenency for sdc-distribution-client to cooperate with the sdc changes. Change-Id: I2da936e5c40cb68c7181bb78307192dd5655b5dc Signed-off-by: xg353y <xg353y@intl.att.com>
2017-01-31Initial OpenECOMP MSO commitChrisC5-0/+316
Change-Id: Ia6a7574859480717402cc2f22534d9973a78fa6d Signed-off-by: ChrisC <cc697w@intl.att.com>