summaryrefslogtreecommitdiffstats
path: root/adapters/mso-sdnc-adapter/src/main
AgeCommit message (Collapse)AuthorFilesLines
2019-03-26Eliminated printStackTrace() callsWitold Ficio Kopel1-9/+9
Eliminated calls to printStackTrace() on Throwable as they go to stdout and are not handled by logger. Occurences has been replaced by calls to logger or modifications to nearby logger calls (Throwable passed as last parameter). Occurences in unit test classes left without modification. Change-Id: I6a771d60a3ea69ceecc29bb21358e565aa5ce101 Issue-ID: LOG-631 Signed-off-by: Witold Ficio Kopel <w.kopel@samsung.com>
2019-03-18Removed MsoLogger classr.bogacki13-54/+53
Bye bye MsoLogger class. Extracted constants to separated classes. Fixed imports. Change-Id: I7c8e0527e7dbd097d3ea93b9dab279354652da47 Issue-ID: LOG-631 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
2019-03-11Cleaned up MsoLogger classr.bogacki1-1/+0
Removed setServiceName method from MsoLogger. Cleaned up unused methods from MsoLogger. Change-Id: I1fe033ed25dda32c07693a5087bf65de3ecc229c Issue-ID: LOG-631 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
2019-02-26Removed MsoLogger from 'mso-sdnc-adapter'r.bogacki15-175/+212
Removed MsoLogger from adapters ('mso-sdnc-adapter') Replaced MsoLogger with plain slf4j. Refactored login output. Fixed imports. Change-Id: I1656776a04b322b9b8da30a3cc6aad31cd621a3e Issue-ID: LOG-631 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
2019-02-14fix critical sonar bugsk.kazak1-0/+2
Restore interrupted state when InterruptedException is thrown in SDNCRestClient Added test for this case Replaced formatting anchor with text empty object in GraphInventoryResultWrapper Escaped anchor is also considered as bug by sonar Case is already covered in AAIResultWrapperTest Marked comparison of the same object as false positive in EqualsAndHashCodeTester Added clearer comment to this comparison Change-Id: I24496c2323c33599db99a3d3b59fc4f6a008cf1f Issue-ID: SO-1492 Signed-off-by: k.kazak <k.kazak@samsung.com>
2019-01-28Merge 'origin/casablanca' into masterBenjamin, Max (mb388a)1-0/+8
Issue-ID: SO-1435 Change-Id: If065ef5c91e769452fd6701fa6c28a23b4bdf2b2 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2019-01-21Bug fixes from AT&T January 20thBenjamin, Max (mb388a)1-2/+8
sorted vfmodules by base last for negative action reqs store Response in execution as String on network delete added functionality to skip rollback based on flag # Conflicts: # bpmn/so-bpmn-tasks/src/main/java/org/onap/so/bpmn/infrastructure/workflo w/tasks/WorkflowAction.java require XML in the header for delete network request Update APP-C LCM Client library version to 1.7.0. replaced wiremock style test with mockito test Handle AAIClient Exps in CreateCustomerV1 getServiceInstance() changed default status code to be configurable Replace vnfType by nfRole in the healthcheck request to SDNO. updated error messages in sdnc handler and flow status updated flow status message on completion of flow Send GenericVnf object for AAI VNF update for vnf-api updates Add a JUnit test file for SDNOValidatorImpl.java Set nodeType on the inner SDNO request as per update from SDNO. updated rollbackToAssigned logic to remove unassign flows updated sdnc handler error message for client error added exception handling for httpclienterror in sdnc out map workflow exception so error is reported throws sdnc error message on bad response from sdnc add catalog entries for TRANSPORT service delete flows change script number that was duplicate add find method to NorthBoundRequestRepository include serviceType in hash code use asterisk for all non-TRANSPORT flow db entries alacart true, rm not needed transport srvc model steps correct insert query syntax for orchestration_flow support serviceType (TRANSPORT) process flow fix SDNCAdapterException causing no callback to bpmn use JsonAlias for alternate case when deserializing GRM client will accept both "serviceEndPointList" and "ServiceEndPointList" root node in the JSON response. AAIRestClient now uses getSystemName in headers finishtime should not be returned in requeststatus Change-Id: I81a185252b057020f7f36f125c85c3357756da88 Issue-ID: SO-1403 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-11Re-enable Actuator for Springboot 2.0Benjamin, Max (mb388a)1-4/+3
Re-enable Actuator for Springboot 2.0 Change-Id: Icee67885d9bd26d6b6ff8a4fceb9add56926b0a8 Issue-ID: SO-1377 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-06Merge "Remove Swagger UI"Seshu Kumar M21-791/+0
2019-01-04Bugfixes for December 2018Benjamin, Max (mb388a)1-0/+5
Changed the way that the cidr is constructed in network utils. added in the if statement to check if selflink already exists removed execution line that was not needed in pull added service instance id to workflowResourceIds for virtualLinkKey network flows wrote test for updating request to complete in db workflow action directly updates db instead of using mso complete process Increase max timeout for SDNO Health Checks dmaap. Added execution variable and corrected type and way data is retrieved to fix defect fixed retry status message in request db for #/5 updated workflowActionBBTasks for flow status message updated flow status to failed on a workflowaction fail Removed slashes and fixed rollbackStatusMessage Updated requestStatus logic for adding status messages Added junit test to validate casue of a defect and cleaned up code and logging added end timestamp to request db on complete request fixed l3Network update of orchestation status in DoUpdateNetworkInstance groovy as well fixed update of l3network orchestration status Add explicit resetting of heatStackId in A&AI to DeleteVfModule and DeleteVolumeGroup BBs. Preserve heatStackId setting in the copiedVfModule when updating the VF Module in A&AI. added functionality to skip rollback based on flag Update snapshot version for logging, add headers fixed optional of error in retrieveErrorMessage method Set heatStackId to null if we want to remove it in A&AI. added in a warn logger statement to keep track of field map network technology from l3network instead of model info for network adapter object mapper Force heatStackId value to empty on an attempt to set it to null on update updated common pom to use aai schema version 1.4.1 removed handle sync error from SDNCHandler bpmn flow Change-Id: I1bd7aa55b06d4e439000b216165c9daafeacc9a4 Issue-ID: SO-1361 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-11-29Remove Swagger UIBenjamin, Max (mb388a)21-791/+0
Remove Swagger UI due to security scan concerns Change-Id: I8c8a0f57f0e91af13280bbb260a67877017b6513 Issue-ID: SO-1227 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-11-27Remove all usage of AlarmLoggerBenjamin, Max (mb388a)6-32/+28
Fix broken UT from removing alarm logger fixed compilation and merge issues Remove all usage of AlarmLogger Change-Id: Ic87abd51423274570bfca0ed976d9642a91a843d Issue-ID: SO-1229 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-11-25Fix intgration issue for E2E servicesubhash kumar singh1-1/+1
Fix intgration issue for E2E service. Change-Id: I1b701f137ebc79addfb6914c7c68ac8c73f673d4 Issue-ID: SO-1252 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-11-17Fix request resource buildingsubhash kumar singh1-0/+8
Fix request resource building. Change-Id: I64161359ae1b3d36ef3647382fab615d6afd6647 Issue-ID: SO-689 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-11-05Springboot 2.0 upgradeBenjamin, Max (mb388a)8-28/+29
corrected typo in CloudConfiguration class removed files which should not have been merged updated gr api test cases with dynamic cloud owner updated groovy files to allow for dynamic cloud owner values moved VFModularity folder to mso-infrastructure bpmn updated GR API layer to include cloud owner added enum for default cloud owner - fixing junit test cases for using catalogDb client r2 - fixing junit test cases for using catalogDb client - Internal review comments incorporated for merging mocking into BaseTest - Internal review comments incorporated for removing direct repo calls - CLONE - Key Management Hardcoded encryption key | fixing junits - CLONE - Key Management Hardcoded encryption key Updated builder to use String.format Added exception specifically for issues interacting with requestdbadapter Updated exception message and added junit test case removed useless error handling test case from workflow changed method name and added junit coverage to errors added max retry and success status after completed bb Added case to handle when homing is not called during assign vnf. Fixing fortify issues | Implementing review comments - Key Management Hardcoded encryption key - fixing prop files - Key Management Hardcoded encryption key include network ID for completion handler Added exception handling for saving to requestdb - Adding a check on the predicate availability on the repository before firing the query with default conditions. This ensures that the api returns data only when there is an input against which it was able to form some conditions Modify UT to show that the API does not behave - adding negative test case for checkInstanceNameDuplicate added assertion that global count var was reset to 0 updated rollback to reset current sequence count var workflowaction calls rollback is complete before error workflowaction will set failure on successful rollback added check for isrollback to know which complete to call removed file which should not have been added add fabric check before running vf module a la carte Enhance UCPEMigrateService junits and add them to Jenkins build.. Added back removed test case for ManualTasks Added test case for response error Added rainy day test cases for ManualTasks revert the other change and fix the rollback logic instead fixed current sequence and updated rollback code added network cloud heat template parameters to mapper Generate a unique subRequestId for each request to APP-C. reverted conditional logic for determining fabric Fix Bean scanning so it picks up the resttemplate removed unnecessary RestTemplate Bean configurations removed file which should not have been added workflowaction calls rollback is complete before error workflowaction will set failure on successful rollback added check for isrollback to know which complete to call add fabric check before running vf module a la carte added assertion that global count var was reset to 0 updated rollback to reset current sequence count var include network ID for completion handler Revert Application.yaml change accidentally checked in Added exception handling for saving to requestdb Added case to handle when homing is not called during assign vnf. removed useless error handling test case from workflow changed method name and added junit coverage to errors ... add cloud owner variable to camunda in mapping Revert "Pass cloudOwner to subflow DoCreateVfModuleVolumeV2. Added juint test to verify variables are set in the execution. Set default cloudOwner in main module CreateVfModuleVolumeInfraV2" updated cloud configuration pojo to inlcude defaults Revert "Test to verify ServiceInstance object mapping" Test to verify ServiceInstance object mapping Pass cloudOwner to subflow DoCreateVfModuleVolumeV2. Added juint test to verify variables are set in the execution. Set default cloudOwner in main module CreateVfModuleVolumeInfraV2 Pass cloudOwner to subflow DoCreateVfModuleVolumeV2. Set default cloudOwner 'att-aic' if null per old requirements. removed references to att-aic from BBInputSetup Changes done in encryption decryption logic | used DelegateExecutionFake in Tests Changes done in encryption decryption logic | used DelegateExecutionFake in Tests Changes done in encryption decryption logic Changes done in encryption decryption logic | removed Default Auth Constant as per the comments Changes done in encryption decryption logic | Fixed UT Changes done in encryption decryption logic | Added XmlComparator assertion for verifying XML Changes done in encryption decryption logic | Reverted as per the review comment Changes done in encryption decryption logic | Fixed UTs Changes done in encryption decryption logic | Fixed UTs Changes done in encryption decryption logic | modified related encrypted properties in test yaml files Changes done in encryption decryption logic for fortify issue resolution | Fixed UTs Changes done in encryption decryption logic | modified related encrypted properties in yaml files Changes done in encryption decryption logic for fortify issue resolution. Fixed Property fetching issue in required file Added TasksBeansTest using openpojo Removed renamed test file from tasksbeans Updated imports on TasksBeansTest Added openpojo test to replace the individual tests Removed tests that provided no coverage script clean up -Update reference data to support distinct recreate and replace requests with their own sequences Update reference data to support distinct recreate and replace requests with their own sequences- Fix seq number Update reference data to support distinct recreate and replace requests with their own sequences added null check to mdc and interceptors to sdnc cxf validations can now match against multiple BBs reverted changes to BBInputSetup class added support for pre and post validation for BBs initial commit of generic building block validator converted test to no longer be a springboot test Remove cosmetic changes from BPMN files to be consistent. Remove minor changes that are not related to functionality. Rework to implement the functionality as part of Validator Combine the verification methods into one based on the flow's name; change the logging. Add verification of status of other VF Modules in the VNF for the delete/deactivate/unassign. added network-technology validation for CreateNetworkBB Sonar Issue Fix | Changes done in encryption decryption logic | Refactoring Changes done in encryption decryption logic| Used AES/GCM/NoPadding algorithm | fixed sonar issues added network-type and network-technology to mapper Continue the fight to make JUNITS work properly Update ASDC ATT to be springboot 2.0 compliant Continue to fix Unit tests for springboot 2.0 port removed autowired from workflowactionbbtaskstest fixed workflowactiontest and reduced size by 500 lines Update last of UT for mockito upgrade to 2.0 Fix more JUNITS due to mockito 2.0 upgrade Unit Test fixes to use proper mockito not spring Update Base Test to import proper packages for compile Additional Springboot 2.0 changes, for tests Additional springboot 2.0 fixes and upgrades Update Migration to be Flyway 5 Compliant Fix MSOBPMN Infrastructure common tests Fix Groovy Unit Tests in CommonBPMN Project Update MSO common BPMN to Springboot 2.0 Upgrade ASDC controller to SpringBoot 2.0 Port Openstack adapters to springboot 2.0 Fix VFC Adapter to be springboot 2 compatible Port CatalogDB adapter code to springboot 2 Port SDNC Adapter to Springboot 2.0 ... added update scripts to macro data instead of v12 sql added secondarypolicy to rainy day handling table confirm subnet map is not null in adapter response shallow copy subnet before AAI udpate update AAIObjectType to use uriTemplate extract subnet data from adapter response update correct AAIObjectType for subnet query update subnet(s) in AAI on network create completion confirm subnet map is not null in adapter response shallow copy subnet before AAI udpate update AAIObjectType to use uriTemplate extract subnet data from adapter response update correct AAIObjectType for subnet query update subnet(s) in AAI on network create completion fixed test http entity unit test to remove testing appid and transaction id added unit test for querySubsystemHealth method. also added resttemplate mock to implement healthcheck endpoint fixed unit test to use mock instead of actually goes out to health check endpoint added code to extend globalhealthcheck to include pinging other components and consolidate the responses converted test to no longer be a springboot test Remove cosmetic changes from BPMN files to be consistent. Remove minor changes that are not related to functionality. added update scripts to macro data instead of v12 sql Rework to implement the functionality as part of Validator added secondarypolicy to rainy day handling table added network-type and network-technology to mapper Combine the verification methods into one based on the flow's name; change the logging. Add verification of status of other VF Modules in the VNF for the delete/deactivate/unassign. updated how request db is set to failure in workflowA corrected code to match existing unit tests corrected tests after springboot 2 upgrade Added Required UTs in UpdateConfigurationStateTest and also fixed some UTs. added in missing parenthesis on method call added back execution variable for allotted uri addressed comments on pull request refactor AAI Rest calls from groovy files - Changes as per review comments checkin to refactor AAI rest | Fixing AAIResourceClient.update call refactor AAI Rest calls from groovy files - UpdateConfiguration refactor AAI Rest calls from groovy file - DeleteConfiguration refactor AAI Rest calls from groovy file - UpdateConfiguration refactor AAI Rest calls from groovy file - CreateConfiguration & ConfigurationUtils refactor AAI Rest calls from groovy files - Fix getARByID issue checkin to refactor AAI rest | Adding Junits checkin to refactor AAI rest | Adding few more classes checkin to refactor AAI rest of DoCreateVfModuleVolumeV2 checkin to refactor AAI rest | Update junit checkin to refactor AAI rest of DoCreateVfModuleVolumeV2 | Adding junits checkin to refactor AAI rest of DoCreateVfModuleVolumeV2 | Adding junits checkin to refactor AAI rest of DoCreateVfModuleVolumeV2.groovy ... updated in and out mapping to be generalBuildingBlock change source out mapping to generalBuildingBlock Change-Id: I122f1ebe3e15b77da0a55af201d89d47e326bf83 Issue-ID: SO-1098 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-09-20Update LoggingSmokowski, Steve (ss835w)1-1/+4
Update logging to meet Casablanca Spec Change-Id: I029d6c63765992d6f091d96e2b4c34c60d30c484 Issue-ID: SO-947 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-09-10Merge "RequestTunables.java: Fixed sonar issues"Byung-Woo Jun1-3/+0
2018-09-10RequestTunables.java: Fixed sonar issuesArundathi Patil1-3/+0
Sonar-Link : https://sonar.onap.org/code?id=org.onap.so%3Aso&selected=org.onap.so%3Amso-sdnc-adapter%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fso%2Fadapters%2Fsdnc%2Fimpl%2FRequestTunables.java Issue-ID: SO-1008 Change-Id: I7660ac5f7be56e1a1d409305e6ffaf5a841ae446 Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2018-09-10SDNCAdapterTypeImpl.java: Fixed sonar issueArundathi Patil1-3/+1
Sonar Link : https://sonar.onap.org/code?id=org.onap.so%3Aso&selected=org.onap.so%3Amso-sdnc-adapter%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fso%2Fadapters%2Fsdnc%2Fimpl%2FSDNCAdapterPortTypeImpl.java Issue-ID: SO-1007 Change-Id: Id11dcccaeb7a728f9fa238570759783fb9053ed9 Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2018-09-10CFXConfiguration.java: Fixed sonar issuesArundathi Patil1-2/+0
Sonar Link : https://sonar.onap.org/code?id=org.onap.so%3Aso&selected=org.onap.so%3Amso-sdnc-adapter%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fso%2Fadapters%2Fsdnc%2FCXFConfiguration.java Issue-ID: SO-1002 Change-Id: Ieea4c3a2fe9798dc44d2f3bd8bc6c1d02726f32f Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2018-09-05Client LoggingSmokowski, Steve (ss835w)1-9/+4
Update Client Logging to use interceptor Move CXF to own project due to dependency hell Issue-ID: SO-947 Change-Id: I2597ff6d32231b8625b04ef63ab5e8f589e2545c Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-09-05Merge "fixed sonar issue in RequestTunables.java"Rob Daugherty1-2/+3
2018-09-05fixed sonar issue in SNIROResponse.javaSandeep J1-1/+3
fixed sonar issue as detailed in SO-976 Issue-ID: SO-976 Change-Id: If9710595248969bf72a55cfda759067439e6d2d4 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-09-05fixed sonar issue in RequestTunables.javaSandeep J1-2/+3
fixed sonar issue as detailed in SO-975 Issue-ID: SO-975 Change-Id: Ic98db5f80f939bee8ad2c1ad33efebaa1b2d6a21 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-09-04Merge "fixed sonar issue in MapRequestTunables.java"Byung-Woo Jun1-1/+3
2018-09-04fixed sonar issue in SDNCServiceRequestConnectorSandeep J1-2/+4
fixed sonar issue as detailed in SO-970 Issue-ID: SO-970 Change-Id: I57c14693fa6918401d37d0d56bdccfe91bb2f372 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-09-04fixed sonar issue in MapRequestTunables.javaSandeep J1-1/+3
fixed sonar issue as detailed in SO-964 Issue-ID: SO-964 Change-Id: I7f51faba54571186242021048c0b3e755bdde731 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-08-31Merge "Update Logging"Rob Daugherty1-4/+14
2018-08-31Update LoggingSmokowski, Steve (ss835w)1-4/+14
Add CXF interceptor for SOAP based logging Clean up extra logging statements Add UT to ensure MDC properly populated Change package name on Jax-RS Filter to be more accurate Issue-ID: SO-947 Change-Id: I3a2afc58de3bf370675658ce3d19cf899b90def7 Change-Id: I3a2afc58de3bf370675658ce3d19cf899b90def7 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-08-30resolved sonar isue in MapTypedRequestTunablesDataSandeep J1-10/+16
resolved sonar issue as detailed in SO-937 Issue-ID: SO-937 Change-Id: I554a43af29fe8965c72f05a84217a0aae43750df Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-08-30Merge "fixed sonar issue in BPRestCallback.java"Byung-Woo Jun1-9/+12
2018-08-30Merge "fixed sonar issue in SDNCConnector.java"Byung-Woo Jun1-7/+10
2018-08-30Merge "fixed sonar issue in SDNCRestClient.java"Byung-Woo Jun1-12/+16
2018-08-30Merge "fixed sonar issue in SDNCCallBackAdapterService"Byung-Woo Jun1-5/+5
2018-08-29fixed sonar issue in SDNCConnector.javaSandeep J1-7/+10
fixed sonar issue as detailed in SO-935 Issue-ID: SO-935 Change-Id: Ifdde63670b78acfa8ba84a0130dcd4f4f4649e72 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-08-29fixed sonar issue in BPRestCallback.javaSandeep J1-9/+12
fixed sonar issue as detailed in SO-934 Issue-ID: SO-934 Change-Id: I6f87ea6c61e81e0241702b20bcc2688a4a9d5d6a Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-08-30fixed sonar issue in SDNCRestClient.javaSandeep J1-12/+16
fixed sonar issue detailed in SO-933 Issue-ID: SO-933 Change-Id: I8d522f51689568c19da491f0c7272fc9551df9d1 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-08-30fixed sonar issue in SDNCCallBackAdapterServiceSandeep J1-5/+5
fixed sonar issue mentioned in jira ticket no SO-932 Issue-ID: SO-932 Change-Id: I9493b09d12446daed1cf43801308d13052232452 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-08-30fixed sonar issue in SDNCAdapterService.javaSandeep J1-1/+1
fixed sonar issue mentioned in jira SO-914 Issue-ID: SO-914 Change-Id: I4893bce5dbdd5e0bc524dc0ead0dc41f246afca4 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-08-29fixed sonar issue in SDNCAdapterService.javaSandeep J1-4/+7
resolved sonar issue desribed in Jira id: SO-914 Issue-ID: SO-914 Change-Id: Icc79a36d665ca950ddcd289dd239b8aa3360db37 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-07-31Containerization feature of SOBenjamin, Max (mb388a)68-1578/+2105
Change-Id: I95381232eeefcd247a66a5cec370a8ce1c288e18 Issue-ID: SO-670 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-07-27Reorder modifiersAnisha Kumar1-3/+3
Reordered the modifiers to be "public static final" instead of "public final static" in order to comply with Java Language Specification. Issue-ID: SO-666 Change-Id: I70a9cfcf454ce79dcb3940ccc24750416462c225 Signed-off-by: Anisha Kumar <anishax.kumar@intel.com>
2018-07-25Merge "Sonar major issues"Seshu Kumar M1-10/+0
2018-07-25Merge "Sonar major issues"Seshu Kumar M1-1/+1
2018-07-25Sonar major issuesSurendra Reddy Katam1-10/+0
This block of commented-out lines of code should be removed Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.so%3Aso&open=AWHCr-Z9EU5FCDfKtmIA&resolved=false&severities=MAJOR Location: adapters/mso-sdnc-adapter/src/main/java/org/openecomp/mso/adapters/sdnc/notify/SDNCNotifyResource.java Line No-177 Change-Id: I3fd12f01315a2ead0f7f676caeb88d9d9b207a43 Issue-ID: SO-753 Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
2018-07-24Sonar major issuesSumapriya Sarvepalli1-1/+1
This block of commented-out lines of code should be removed Sonar Link: https://sonar.onap.org/project/issues?id=org.onap.so%3Aso&open=AWHCr-Y0EU5FCDfKtmG_&resolved=false&severities=MAJOR Location: src/main/java/org/openecomp/mso/adapters/sdnc/SDNCAdapterService.java Line No: L58 Change-Id: I5665a41ea85a5464d1c5fb208f20be725fe044d7 Issue-ID: SO-738 Signed-off-by: Sumapriya Sarvepalli <ss00493505@techmahindra.com>
2018-07-24Sonar Major issuesSurendra Reddy Katam1-1/+0
This block of commented-out lines of code should be removed Sonar Link: https://sonar.onap.org/project/issues?assignees=surendraReddy&id=org.onap.so%3Aso&open=AWHCr-Y0EU5FCDfKtmG-&resolved=false&severities=MAJOR Location: adapters/mso-sdnc-adapter/src/main/java/org/openecomp/mso/adapters/sdnc/SDNCAdapterService.java Line No-32 Change-Id: I6d80143d6268a05c34128fba3999b73abf8c376e Issue-ID: SO-737 Signed-off-by: Surendra Reddy Katam <SK00524980@techmahindra.com>
2018-03-14AT&T 1712 and 1802 release codeRob Daugherty2-5/+12
This is code from AT&T's 1712 and 1802 releases. Change-Id: Ie1e85851e94bc66c4d9514a0226c221939531a04 Issue-ID: SO-425 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-03-10Remove redundant type castMunir Ahmad1-1/+1
Change-Id: Ie00d5ec5a4677c99a9a689bf18a85055902f6384 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-03-06Remove redundant catch clauseMunir Ahmad1-6/+1
Change-Id: Ib26f47171384125847a1b31bc1a958b50d0bba70 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>