summaryrefslogtreecommitdiffstats
path: root/adapters/mso-openstack-adapters
AgeCommit message (Collapse)AuthorFilesLines
2019-07-23Major Sonar fixesr.bogacki1-31/+16
Major Sonar fixes in different classes: -Removed unnecessary code. -Removed unused variables. -Removed unnecessary imports. -Simplified diamond operators. -Improved String comparisons in equals. Issue-ID: SO-2102 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I279c63f8e7161d6e33d5d6a28b938c0c64e90f1f
2019-07-22Merge "Added servicename to MDC so that it gets logged"Steve Smokowski5-4/+20
2019-07-19Added servicename to MDC so that it gets loggedBoslet, Cory5-4/+20
Added servicename to MDC so that it gets logged and added enter and exit markers. Issue-ID: SO-2122 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I63ff5e5de21d851c989ffa5db2051755751d9ead
2019-07-18Merge changes I5e72e1c6,I5e1cb624Steve Smokowski1-8/+16
* changes: Added null check for function param pFqdns to prevent crash at for loop. Added check for null ptr before dereferencing at gBBInput.getCustomer().getServiceSubscription() - to prevent static analyzer warning
2019-07-18Removing application-local.yaml filesRoy, Amresh1-105/+0
Removing the application-local.yaml files because they're no longer maintained or working. Issue-ID: SO-2121 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I191c8775de931671a4657be8940e6aec64023359
2019-07-17add query stack data and populate table stepBoslet, Cory11-19/+504
Need to check if audit is enabled first in the delete record task Updates to audit delete redeisgn and data to table Various updates to logging, audit object, added tag to query, updated tag value. Updated write method to make sure an entry for this heat stack doesnt already exist to avoid duplicate entrys Updated unit test to account for get query Added so that id is not hidden from query results Updated the was delete is done plus minor updates. Updated delete method to use resttemplate instead of bowman client Combined the write and get stack data task into the external tasks. Removed the task to delete the stack data from db Updates to junit request id so its not a random id for test Updated service tasks in att BB to call external task Update to be a real uuid format due to failing unit test Updated fields to protected and updated unit test Issue-ID: SO-2111 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com> Change-Id: I8f479a046cf837403f60c330ed6ad8bc08a9c82f
2019-07-12Added null check for function param pFqdns toOleksandr Moliavko1-8/+16
prevent crash at for loop. Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: I5e72e1c6d74c5f197479062348090ab2b87fafae
2019-07-09Sonar fix in CreateInventoryTask.javaArundathi Patil1-4/+8
Fixed multiple sonar issues in this file Issue-ID: SO-2098 Change-Id: I7da9ffae8ee11d8475445b5263bc7cfb78834a9c Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2019-07-02Added null check to prevent call of getVnfResources() methodOleksandr Moliavko1-2/+4
for null vf object Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: I0c2ea5de5ed9ab55ad78f58f3a68241e7cb2d064
2019-07-02Added null check for heatStack to prevent crash atOleksandr Moliavko1-1/+1
getCanonicalName() call Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: Icf49b7db336002ad56769b221ec61101fac04fd5
2019-06-26Merge "Security updates for maven dependencies"Steve Smokowski1-1/+1
2019-06-24Sonar fixes in MsoVnfAdapterAsyncImplr.bogacki1-5/+3
General fixes and improvements according to the Sonar analysis. -Removed unnecessary code. Issue-ID: SO-1220 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I0f9ab1fe490975e4eefa31afd5bf09616f4de3f2
2019-06-21Security updates for maven dependenciesSangalang, Felix1-1/+1
Update commons-collections version to 3.2.2. Updated distribution client version to 1.4.0. Update commons-fileupload to version 1.4. Update commons-codec to version 1.12. Change-Id: I4ab794e3aef7300c30088e5197092fd30231c4af Issue-ID: SO-2043 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-18Merge "Changes related to eviction of connections"Steve Smokowski2-5/+84
2019-06-18Fixed critical Sonar bugsr.bogacki1-4/+7
Fixed critical bugs according to the Sonar analysis. -Fixed possible NPE. -Fixed wrong comparison. -Removed unused variables. Issue-ID: SO-2025 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I5e2e5413c8421eb7ed1db21de6d888a50e1db689
2019-06-17Changes related to eviction of connectionsBenjamin, Max (mb388a)2-5/+84
These are changes related to ASDC controller for evicting database connection pool when ip address changes Included other appllications such as requestDB, CatalogDB, API Handler, BPMN, OpenstackAdapter etc Change-Id: I9a96ea12fb0c10643a204a58d55360bebba326fe Issue-ID: SO-2018 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-17Merge "Fix sonar issues in mso-openstack-adapters"Steve Smokowski1-79/+62
2019-06-17Improvements in MsoVnfAdapterImplr.bogacki1-67/+62
Improvements in MsoVnfAdapterImpl according to the Sonar analyses. -Removed unnecessary code. -Fixed imports. -Extracted constants. Issue-ID: SO-2011 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I9dc8406fe0cdea74b08ebb013a68f970da647b6c
2019-06-14update multi stage code to accurately skip bbsBenjamin, Max20-0/+400
moved around classes to packages that make more sense updated license headers in java files converted MultiStage logic to FlowManipulator moved tests to new package location and fixed issues allow for custom listeners before flowsToExecute moved validation classes to listener.validation Change-Id: Ic5416812ef9c5611fe19bf9b6aa316373b110ec6 Issue-ID: SO-2021 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-10replaced String.repeat with static final stringsBenjamin, Max9-165/+155
replaced String.repeat with static final strings Change-Id: Ife14fde70e8f648881a03e9343ae8faf9cb87e2e Issue-ID: SO-1999 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-06Accommodate WAN NetworkingGamboa, Gilbert1-1/+3
checked and evaluated naming policy only if infra bonding. Updated workflowAction to include vrf configuration for vpn-binding in resourceIds list. added in linked resource to service proxy cust committing the asdc controller classpath change added some unit tests for vrf validation and updated bbinput setup test update config resource cust foreign key mapping Moved mockbean for AssignVrfConfiguration task class into BaseBpmnTest. added in a check to see if list is empty before access added unit tests for bbinput setup for vrf config Update AssignFlows enum with correct AssignVrfConfiguration flow name Change-Id: Ibf14e36505638b19c1366ecebfce560c02e69e44 Issue-ID: SO-1975 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-06Merge remote-tracking branch 'origin/dublin' into 'origin/master'Steve Smokowski2-2/+60
Change-Id: I551ea3f29a76dc99532455ea4d7e84a316f9bf38 Issue-ID: SO-1980 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2019-06-03Cleaned up duplicated literalsrob.bog7-128/+143
Cleaned up Sonar code smells related to the duplicated literals in loggers. Issue-ID: SO-1932 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I58c48cec0012c42b7b892ae76c24c6a087c60c7e
2019-05-31enhanced vnf adapter errog log.Sangalang, Felix3-6/+15
enhanced vnf adapter error log for heatEnvironment when null. removed the junit tests because of no assertions coverage. enhanced vnf adapter errog log. Change-Id: I80d3070ce203c4c8339f0a0e7df6f3731d0a16c2 Issue-ID: SO-1967 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-31Merge "converted lock time from hard coded value"Steve Smokowski4-5/+13
2019-05-31Corrected enum formatting by pluginBenjamin, Max (mb388a)1-3/+9
enums are now single item per line Change-Id: I6330ea4a9093071457dd47b95b6ed3bb7f8312e7 Issue-ID: SO-1970 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-31converted lock time from hard coded valueKalkere Ramesh, Sharan4-5/+13
update lock time property to have a default of 60000 converted lock time from hard coded to property driven Change-Id: I4a42b85c4241c8865f8dc133be96d7bc92b8574d Issue-ID: SO-1962 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-31fix keypair conflict issue in openstack adapterSmokowski, Steven9-125/+74
Fix wiremock stubs to return proper data and url Fix copyright header issue on unit test file Fix keypair issue, clean up unit tests and logging Fix issues found in unit testing, update data Fix broken Unit tests that used invalid data Continue Refactor to support keypair failure scenario Update logic for when to auto delete a stuck keypair Change-Id: Ice5256cf0381a3b46d1c442907c0f321a1c0d006 Issue-ID: SO-1897 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-29Fix sonar issues in mso-openstack-adaptersParshad Patel1-79/+62
Fix Either log or rethrow this exception Fix Replace the type specification in this constructor call with the diamond operator ("<>") Fix Remove this unused local variable Fix Iterate over the "entrySet" instead of the "keySet" Issue-ID: SO-1841 Change-Id: I5e9195d75d29a66a4a360e031ab02ab7c9872388 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2019-05-17Audit service enhancementsBoslet, Cory3-18/+99
Update number of threads used for openstack audit Refactored post construct audit service and added junits Change-Id: Ic5bd42cda98835305d2e2d5d09a5c039376316a5 Issue-ID: SO-1898 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-15store openstack request status in requestdbSmokowski, Steven13-90/+179
Openstack request status now stored in request db Change-Id: Ida8f4f613d406c2b834ab190e01d5aaf2f16dd3d Issue-ID: SO-1867 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-10Merge "Remove triple logging of VNF adapter response"Steve Smokowski2-2/+1
2019-05-10Remove triple logging of VNF adapter responseMcblain, Thomas2-2/+1
Remove triple logging of VNF adapter response to bpel Change-Id: Ia8f3d3b9b76616e9dcc9f638ba5ca58dcac3ab8b Issue-ID: SO-1863 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-10Added to write variablles on audit failureBoslet, Cory1-1/+1
Added to write variablles on audit failure so bpmn knows whether success or not. Change-Id: I1eb0827a10ee75f4ee89bfb36d13035a2612e032 Issue-ID: SO-1862 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-03Merge "Merge remote-tracking branch 'origin/dublin'"Marcus Williams2-1/+29
2019-05-03Merge remote-tracking branch 'origin/dublin'Benjamin, Max (mb388a)2-1/+29
merged dublin into master branch Change-Id: Ifb78d405611b65764fd4f01558b0e703551ed663 Issue-ID: SO-1830 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com> Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2019-05-02test suite file movingLukasz Muszkieta1-1/+1
not all test are taken into suite, the test suite file should be moved up Change-Id: I4ee4911bee9ee583a6fe3ec4f5edd8c669f75b4d Issue-ID: SO-1843 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2019-05-01Fixup handling of multicloud post responseEric Multanen2-2/+60
Make the handling of the multicloud post response more flexible. Add additional parameters that may come back. Change-Id: I0a5c7016f11dbfe832c81e2fcafc398a998b622b Issue-ID: SO-1833 Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
2019-04-30Add Model Version QuerySmokowski, Steven1-1/+1
Fix the sql migration version numbering to be proper Fix marking test as private, mark public Clean up public declarations to private Fix schema.sql to have new column for unit test Revert POM Change, add License, clean up comments Fix bad spelling of method name issue Update catalog db to support new rest endpoint Update local query service and mappers Localstaging of potential catalog db changes Update logic to write overall distro status Change-Id: I84d53b972ede3176c5af32d13444583a36606efa Issue-ID: SO-1820 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-04-28Store Cloud Request in DatabaseSmokowski, Steven3-4/+4
Store Cloud Request in Database, add to request service Add query Param to Plural to include cloud data Change-Id: If906d28d0dc9c0c804e550e2074af3d75ba46d32 Issue-ID: SO-1807 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-04-26Do not need to retry on inventory exceptionBoslet, Cory2-2/+30
Do not need to retry on inventory exception due to vservers/linterfaces missing. Change-Id: I8e1e1d89ebd35e2b84a65e5e6db3e1db3f976982 Issue-ID: SO-1812 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-04-26Enhancement for querysubhash kumar singh1-0/+1
Enhancemenv for query to include group and vnfccustomization. { "serviceResources": { "modelInfo": { "modelName": "NSService", "modelUuid": "0bad8c92-7d22-49f0-b092-b64e6ca564a7", "modelInvariantUuid": "69161960-515b-4bf3-91f1-313b813f5e1d", "modelVersion": "1.0" }, "serviceType": "", "serviceRole": "", "environmentContext": "General_Revenue-Bearing", "resourceOrder": "NF", "workloadContext": "Production", "serviceVnfs": [ { "modelInfo": { "modelName": "", "modelUuid": "123", "modelInvariantUuid": "", "modelVersion": "", "modelCustomizationUuid": "1234", "modelInstanceName": "test" }, "toscaNodeType": "", "nfFunction": "", "nfType": "", "nfRole": "", "nfNamingCode": "", "multiStageDesign": "", "resourceInput": "", "vfModules": [], "groups": [ { "modelInfo": { "modelName": "test", "modelUuid": "11", "modelInvariantUuid": "11", "modelVersion": "2" }, "vnfcs": [ { "modelInfo": { "modelName": "xfs", "modelUuid": "22", "modelInvariantUuid": "2222", "modelVersion": "22222", "modelCustomizationUuid": "2222" } } ] } ] } ], "serviceNetworks": [], "serviceAllottedResources": [] } } Issue-ID: SO-1393 Change-Id: Iee7f79337f73276f857d6d42b5b2416e4e8f4536 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2019-04-25Merge "Add SO update config file -application.yaml file"Steve Smokowski2-9/+47
2019-04-25Merge "add resourceInput in vnfc Issue-ID: SO-1393"Yan Yang1-0/+1
2019-04-25MsoVnfAdapterImpl - sonar fixDriptaroop Das1-30/+11
MsoVnfAdapterImpl - sonar fix Issue-ID: SO-1811 Change-Id: Ic3bebd30e4f65b9ba5732c43cfd8baf0050e3b7b Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
2019-04-24add resourceInput in vnfczm3301-0/+1
Issue-ID: SO-1393 Change-Id: I643f49df545bef92f0f0e931f7b7ce1a5dbc21c0 Signed-off-by: zm330 <zhangminyj@chinamobile.com>
2019-04-23add vnfcInstanceGroup sequencezm3301-0/+1
Issue-ID: SO-1393 Change-Id: Ife3b71dcfa543a693564779da44800f1dd8486e9 Signed-off-by: zm330 <zhangminyj@chinamobile.com>
2019-04-22Merge "Status message for create vf module event audit"Steve Smokowski17-94/+200
2019-04-21Fix issue where null variable causes task to notBenjamin, Max (mb388a)2-10/+47
fixed formatting of newly added files Fix issue where null variable causes task to not complete Change-Id: If2361a0834220c2e2738917a2e5bf9b012570929 Issue-ID: SO-1806 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-04-21Status message for create vf module event auditBenjamin, Max (mb388a)17-94/+200
Added appc to application-test due to new dependency in openstack Updated exception class to inject mock into class for junits. Added error handling support for when create audit fails. Added error handling for when create audit fails and added test Updated test schema file to create table and added field. Updated pom file to relfect typo in change made. Updated locaton of pojos for audit code Updated test schema file to create table and added field. Updated pom file to relfect typo in change made. Comitting files that i forgot to stage from previous commit Updated locaton of pojos for audit code Additional fixes including vnfcname and null check Fixed bug in delete audit failure check and reverted gateway change. Change-Id: I993ce377dd6407960a65b4940d83d8162b24633c Issue-ID: SO-1792 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>