Age | Commit message (Collapse) | Author | Files | Lines |
|
General fixes and improvements according to the Sonar analysis.
-Removed unnecessary code.
Issue-ID: SO-1220
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I0f9ab1fe490975e4eefa31afd5bf09616f4de3f2
|
|
|
|
Fixed critical bugs according to the Sonar analysis.
-Fixed possible NPE.
-Fixed wrong comparison.
-Removed unused variables.
Issue-ID: SO-2025
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I5e2e5413c8421eb7ed1db21de6d888a50e1db689
|
|
These are changes related to ASDC controller for evicting database
connection pool when ip address changes
Included other appllications such as requestDB, CatalogDB, API Handler,
BPMN, OpenstackAdapter etc
Change-Id: I9a96ea12fb0c10643a204a58d55360bebba326fe
Issue-ID: SO-2018
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
Improvements in MsoVnfAdapterImpl according to the Sonar analyses.
-Removed unnecessary code.
-Fixed imports.
-Extracted constants.
Issue-ID: SO-2011
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I9dc8406fe0cdea74b08ebb013a68f970da647b6c
|
|
moved around classes to packages that make more sense
updated license headers in java files
converted MultiStage logic to FlowManipulator
moved tests to new package location and fixed issues
allow for custom listeners before flowsToExecute
moved validation classes to listener.validation
Change-Id: Ic5416812ef9c5611fe19bf9b6aa316373b110ec6
Issue-ID: SO-2021
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
replaced String.repeat with static final strings
Change-Id: Ife14fde70e8f648881a03e9343ae8faf9cb87e2e
Issue-ID: SO-1999
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
checked and evaluated naming policy only if infra bonding.
Updated workflowAction to include vrf configuration for vpn-binding in
resourceIds list.
added in linked resource to service proxy cust
committing the asdc controller classpath change
added some unit tests for vrf validation and updated bbinput setup test
update config resource cust foreign key mapping
Moved mockbean for AssignVrfConfiguration task class into BaseBpmnTest.
added in a check to see if list is empty before access
added unit tests for bbinput setup for vrf config
Update AssignFlows enum with correct AssignVrfConfiguration flow name
Change-Id: Ibf14e36505638b19c1366ecebfce560c02e69e44
Issue-ID: SO-1975
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Change-Id: I551ea3f29a76dc99532455ea4d7e84a316f9bf38
Issue-ID: SO-1980
Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
|
|
Cleaned up Sonar code smells related to the duplicated
literals in loggers.
Issue-ID: SO-1932
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I58c48cec0012c42b7b892ae76c24c6a087c60c7e
|
|
enhanced vnf adapter error log for heatEnvironment when null.
removed the junit tests because of no assertions coverage.
enhanced vnf adapter errog log.
Change-Id: I80d3070ce203c4c8339f0a0e7df6f3731d0a16c2
Issue-ID: SO-1967
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
enums are now single item per line
Change-Id: I6330ea4a9093071457dd47b95b6ed3bb7f8312e7
Issue-ID: SO-1970
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
update lock time property to have a default of 60000
converted lock time from hard coded to property driven
Change-Id: I4a42b85c4241c8865f8dc133be96d7bc92b8574d
Issue-ID: SO-1962
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Fix wiremock stubs to return proper data and url
Fix copyright header issue on unit test file
Fix keypair issue, clean up unit tests and logging
Fix issues found in unit testing, update data
Fix broken Unit tests that used invalid data
Continue Refactor to support keypair failure scenario
Update logic for when to auto delete a stuck keypair
Change-Id: Ice5256cf0381a3b46d1c442907c0f321a1c0d006
Issue-ID: SO-1897
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Fix Either log or rethrow this exception
Fix Replace the type specification in this constructor call with the diamond operator ("<>")
Fix Remove this unused local variable
Fix Iterate over the "entrySet" instead of the "keySet"
Issue-ID: SO-1841
Change-Id: I5e9195d75d29a66a4a360e031ab02ab7c9872388
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
|
|
Update number of threads used for openstack audit
Refactored post construct audit service and added junits
Change-Id: Ic5bd42cda98835305d2e2d5d09a5c039376316a5
Issue-ID: SO-1898
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Openstack request status now stored in request db
Change-Id: Ida8f4f613d406c2b834ab190e01d5aaf2f16dd3d
Issue-ID: SO-1867
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
Remove triple logging of VNF adapter response to bpel
Change-Id: Ia8f3d3b9b76616e9dcc9f638ba5ca58dcac3ab8b
Issue-ID: SO-1863
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Added to write variablles on audit failure so bpmn knows whether
success or not.
Change-Id: I1eb0827a10ee75f4ee89bfb36d13035a2612e032
Issue-ID: SO-1862
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
merged dublin into master branch
Change-Id: Ifb78d405611b65764fd4f01558b0e703551ed663
Issue-ID: SO-1830
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
|
|
not all test are taken into suite, the test suite file should be moved up
Change-Id: I4ee4911bee9ee583a6fe3ec4f5edd8c669f75b4d
Issue-ID: SO-1843
Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
|
|
Make the handling of the multicloud post response
more flexible. Add additional parameters that may
come back.
Change-Id: I0a5c7016f11dbfe832c81e2fcafc398a998b622b
Issue-ID: SO-1833
Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
|
|
Fix the sql migration version numbering to be proper
Fix marking test as private, mark public
Clean up public declarations to private
Fix schema.sql to have new column for unit test
Revert POM Change, add License, clean up comments
Fix bad spelling of method name issue
Update catalog db to support new rest endpoint
Update local query service and mappers
Localstaging of potential catalog db changes
Update logic to write overall distro status
Change-Id: I84d53b972ede3176c5af32d13444583a36606efa
Issue-ID: SO-1820
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Store Cloud Request in Database, add to request service
Add query Param to Plural to include cloud data
Change-Id: If906d28d0dc9c0c804e550e2074af3d75ba46d32
Issue-ID: SO-1807
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Do not need to retry on inventory exception due to vservers/linterfaces
missing.
Change-Id: I8e1e1d89ebd35e2b84a65e5e6db3e1db3f976982
Issue-ID: SO-1812
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Enhancemenv for query to include group and vnfccustomization.
{
"serviceResources": {
"modelInfo": {
"modelName": "NSService",
"modelUuid": "0bad8c92-7d22-49f0-b092-b64e6ca564a7",
"modelInvariantUuid": "69161960-515b-4bf3-91f1-313b813f5e1d",
"modelVersion": "1.0"
},
"serviceType": "",
"serviceRole": "",
"environmentContext": "General_Revenue-Bearing",
"resourceOrder": "NF",
"workloadContext": "Production",
"serviceVnfs": [
{
"modelInfo": {
"modelName": "",
"modelUuid": "123",
"modelInvariantUuid": "",
"modelVersion": "",
"modelCustomizationUuid": "1234",
"modelInstanceName": "test"
},
"toscaNodeType": "",
"nfFunction": "",
"nfType": "",
"nfRole": "",
"nfNamingCode": "",
"multiStageDesign": "",
"resourceInput": "",
"vfModules": [],
"groups": [
{
"modelInfo": {
"modelName": "test",
"modelUuid": "11",
"modelInvariantUuid": "11",
"modelVersion": "2"
},
"vnfcs": [
{
"modelInfo": {
"modelName": "xfs",
"modelUuid": "22",
"modelInvariantUuid": "2222",
"modelVersion": "22222",
"modelCustomizationUuid": "2222"
}
}
]
}
]
}
],
"serviceNetworks": [],
"serviceAllottedResources": []
}
}
Issue-ID: SO-1393
Change-Id: Iee7f79337f73276f857d6d42b5b2416e4e8f4536
Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
|
|
|
|
|
|
MsoVnfAdapterImpl - sonar fix
Issue-ID: SO-1811
Change-Id: Ic3bebd30e4f65b9ba5732c43cfd8baf0050e3b7b
Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
|
|
Issue-ID: SO-1393
Change-Id: I643f49df545bef92f0f0e931f7b7ce1a5dbc21c0
Signed-off-by: zm330 <zhangminyj@chinamobile.com>
|
|
Issue-ID: SO-1393
Change-Id: Ife3b71dcfa543a693564779da44800f1dd8486e9
Signed-off-by: zm330 <zhangminyj@chinamobile.com>
|
|
|
|
fixed formatting of newly added files
Fix issue where null variable causes task to not complete
Change-Id: If2361a0834220c2e2738917a2e5bf9b012570929
Issue-ID: SO-1806
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Added appc to application-test due to new dependency in openstack
Updated exception class to inject mock into class for junits.
Added error handling support for when create audit fails.
Added error handling for when create audit fails and added test
Updated test schema file to create table and added field.
Updated pom file to relfect typo in change made.
Updated locaton of pojos for audit code
Updated test schema file to create table and added field.
Updated pom file to relfect typo in change made.
Comitting files that i forgot to stage from previous commit
Updated locaton of pojos for audit code
Additional fixes including vnfcname and null check
Fixed bug in delete audit failure check and reverted gateway change.
Change-Id: I993ce377dd6407960a65b4940d83d8162b24633c
Issue-ID: SO-1792
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
|
|
Replace String literal with a constant VnfAdapterNotify_Service class
Issue-ID: SO-1490
Change-Id: Iebcfb6254fce98cc09e772389629bba2af169194
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
|
|
Remove unused import,variable,shift constructor call MsoVnfPluginAdapterImpl class
Issue-ID: SO-1490
Change-Id: I1d722d7157ccbb9366dfe0ae60529c40615bb8e3
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
|
|
Replace String literal with a constant MsoVnfCloudifyAdapterImpl class
Issue-ID: SO-1490
Change-Id: I89599391fba99a6e979bd19d6e86684c8691ec8b
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
|
|
|
|
|
|
|
|
Substitute String Literals with Constant MsoVnfCloudifyAdapterImpl class
Issue-ID: SO-1490
Change-Id: I5b8340049a85a5405f158cac2518c571b74bc440
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
|
|
|
|
|
|
Replace String Literals with Constant MsoVnfAdapterAsyncImpl class
Issue-ID: SO-1490
Change-Id: Iaf8519e6ec216bf8e79e56e76856019b50371616
Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
|