Age | Commit message (Collapse) | Author | Files | Lines |
|
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I0efbb38cb34b0b36d2659ebf36f6cd2d109e5deb
|
|
StringBuffer appends to remove static analyzer
warning about inefficient string operations
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I89e0e5b599a8263882b0f91fb0f9191734a04ec1
|
|
prevent static analyzer warning"
|
|
String.format() call to prevent static analyzer
warning
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I1e3ea352aac9a88172b683d267b2f3c804bb362b
|
|
fix sonar issues
Issue-ID: SO-1811
Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com>
Change-Id: Iba1f585de7465da5649b60e6990a737936656ac7
|
|
|
|
Avoid null pointer exception mso-openstack-adapters classes
Issue-ID: SO-2187
Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: Ie7099318a79162aed26ec3a8e4a013cece367736
|
|
Replace duplicated String literals mso-openstack-adapters files
Issue-ID: SO-2187
Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com>
Change-Id: I3089f407ffd01afbccaada81c2aef290299dfe32
|
|
+) Add logger to log exception
++) Format logger
Issue-ID: SO-2187
Change-Id: Id77271340070a61e7ce82822321d7e5b8b03f759
Signed-off-by: arind.mondal <arind.mondal@samsung.com>
|
|
call; removed redundant null check to simplify the code"
|
|
to prevent crash at get() call; removed redundant
null check to simplify the code
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: If9d8dcba3008cd7ebe60c17c08c71a07a6df9df4
|
|
analyzer warning about inefficient use of constructor"
|
|
Change-Id: I57e0e1378e743074b3fad3533756179776bfaf0b
Signed-off-by: DeWayne Filppi <dewayne@cloudify.co>
Issue-ID: SO-1836
|
|
|
|
remove static analyzer warning about inefficient
use of constructor
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I5b6285aa8708b57bb54a90d38130a21b07c2b2c5
|
|
|
|
Upgrade springboot.version from 2.0.5 to 2.1.5.
Fixed APIHandler junit test cases with expected DB error messages.
Issue-ID: SO-2157
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I77ce873018b88268b9221226b95c9c106f93a8d0
|
|
Add SpringClientFilter in ValetClient to autolog msgs
Modify to use our RestTemplateConfig for RestTemplate
Use Provider for thread-safe RestTemplate autowire
Issue-ID: SO-2160
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I02d1995ebd6d2c93477008feb13193d3c0b3cd05
|
|
Major Sonar fixes in different classes:
-Removed unnecessary code.
-Removed unused variables.
-Removed unnecessary imports.
-Simplified diamond operators.
-Improved String comparisons in equals.
Issue-ID: SO-2102
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I279c63f8e7161d6e33d5d6a28b938c0c64e90f1f
|
|
|
|
Added servicename to MDC so that it gets logged and added enter and
exit markers.
Issue-ID: SO-2122
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I63ff5e5de21d851c989ffa5db2051755751d9ead
|
|
Fixed sonar issues across this file
Issue-ID: SO-2137
Change-Id: I7650e1746bc3da5149310e6eb4b53f2ee98e3d9f
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
* changes:
Added null check for function param pFqdns to prevent crash at for loop.
Added check for null ptr before dereferencing at gBBInput.getCustomer().getServiceSubscription() - to prevent static analyzer warning
|
|
Removing the application-local.yaml files because they're no longer
maintained or working.
Issue-ID: SO-2121
Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com>
Change-Id: I191c8775de931671a4657be8940e6aec64023359
|
|
Need to check if audit is enabled first in the delete record task
Updates to audit delete redeisgn and data to table
Various updates to logging, audit object, added tag to query, updated
tag value.
Updated write method to make sure an entry for this heat stack doesnt
already exist to avoid duplicate entrys
Updated unit test to account for get query
Added so that id is not hidden from query results
Updated the was delete is done plus minor updates.
Updated delete method to use resttemplate instead of bowman client
Combined the write and get stack data task into the external tasks.
Removed the task to delete the stack data from db
Updates to junit request id so its not a random id for test
Updated service tasks in att BB to call external task
Update to be a real uuid format due to failing unit test
Updated fields to protected and updated unit test
Issue-ID: SO-2111
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
Change-Id: I8f479a046cf837403f60c330ed6ad8bc08a9c82f
|
|
prevent crash at for loop.
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I5e72e1c6d74c5f197479062348090ab2b87fafae
|
|
Fixed multiple sonar issues in this file
Issue-ID: SO-2098
Change-Id: I7da9ffae8ee11d8475445b5263bc7cfb78834a9c
Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
|
|
for null vf object
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: I0c2ea5de5ed9ab55ad78f58f3a68241e7cb2d064
|
|
getCanonicalName() call
Issue-ID: SO-1841
Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com>
Change-Id: Icf49b7db336002ad56769b221ec61101fac04fd5
|
|
General fixes and improvements according to the Sonar analysis.
-Removed unnecessary code.
Issue-ID: SO-1220
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I0f9ab1fe490975e4eefa31afd5bf09616f4de3f2
|
|
|
|
Fixed critical bugs according to the Sonar analysis.
-Fixed possible NPE.
-Fixed wrong comparison.
-Removed unused variables.
Issue-ID: SO-2025
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I5e2e5413c8421eb7ed1db21de6d888a50e1db689
|
|
These are changes related to ASDC controller for evicting database
connection pool when ip address changes
Included other appllications such as requestDB, CatalogDB, API Handler,
BPMN, OpenstackAdapter etc
Change-Id: I9a96ea12fb0c10643a204a58d55360bebba326fe
Issue-ID: SO-2018
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
Improvements in MsoVnfAdapterImpl according to the Sonar analyses.
-Removed unnecessary code.
-Fixed imports.
-Extracted constants.
Issue-ID: SO-2011
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I9dc8406fe0cdea74b08ebb013a68f970da647b6c
|
|
moved around classes to packages that make more sense
updated license headers in java files
converted MultiStage logic to FlowManipulator
moved tests to new package location and fixed issues
allow for custom listeners before flowsToExecute
moved validation classes to listener.validation
Change-Id: Ic5416812ef9c5611fe19bf9b6aa316373b110ec6
Issue-ID: SO-2021
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
replaced String.repeat with static final strings
Change-Id: Ife14fde70e8f648881a03e9343ae8faf9cb87e2e
Issue-ID: SO-1999
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
checked and evaluated naming policy only if infra bonding.
Updated workflowAction to include vrf configuration for vpn-binding in
resourceIds list.
added in linked resource to service proxy cust
committing the asdc controller classpath change
added some unit tests for vrf validation and updated bbinput setup test
update config resource cust foreign key mapping
Moved mockbean for AssignVrfConfiguration task class into BaseBpmnTest.
added in a check to see if list is empty before access
added unit tests for bbinput setup for vrf config
Update AssignFlows enum with correct AssignVrfConfiguration flow name
Change-Id: Ibf14e36505638b19c1366ecebfce560c02e69e44
Issue-ID: SO-1975
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Change-Id: I551ea3f29a76dc99532455ea4d7e84a316f9bf38
Issue-ID: SO-1980
Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
|
|
Cleaned up Sonar code smells related to the duplicated
literals in loggers.
Issue-ID: SO-1932
Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
Change-Id: I58c48cec0012c42b7b892ae76c24c6a087c60c7e
|
|
enhanced vnf adapter error log for heatEnvironment when null.
removed the junit tests because of no assertions coverage.
enhanced vnf adapter errog log.
Change-Id: I80d3070ce203c4c8339f0a0e7df6f3731d0a16c2
Issue-ID: SO-1967
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
enums are now single item per line
Change-Id: I6330ea4a9093071457dd47b95b6ed3bb7f8312e7
Issue-ID: SO-1970
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
update lock time property to have a default of 60000
converted lock time from hard coded to property driven
Change-Id: I4a42b85c4241c8865f8dc133be96d7bc92b8574d
Issue-ID: SO-1962
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Fix wiremock stubs to return proper data and url
Fix copyright header issue on unit test file
Fix keypair issue, clean up unit tests and logging
Fix issues found in unit testing, update data
Fix broken Unit tests that used invalid data
Continue Refactor to support keypair failure scenario
Update logic for when to auto delete a stuck keypair
Change-Id: Ice5256cf0381a3b46d1c442907c0f321a1c0d006
Issue-ID: SO-1897
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Fix Either log or rethrow this exception
Fix Replace the type specification in this constructor call with the diamond operator ("<>")
Fix Remove this unused local variable
Fix Iterate over the "entrySet" instead of the "keySet"
Issue-ID: SO-1841
Change-Id: I5e9195d75d29a66a4a360e031ab02ab7c9872388
Signed-off-by: Parshad Patel <pars.patel@samsung.com>
|
|
Update number of threads used for openstack audit
Refactored post construct audit service and added junits
Change-Id: Ic5bd42cda98835305d2e2d5d09a5c039376316a5
Issue-ID: SO-1898
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
Openstack request status now stored in request db
Change-Id: Ida8f4f613d406c2b834ab190e01d5aaf2f16dd3d
Issue-ID: SO-1867
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|
|
|
|
Remove triple logging of VNF adapter response to bpel
Change-Id: Ia8f3d3b9b76616e9dcc9f638ba5ca58dcac3ab8b
Issue-ID: SO-1863
Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
|