aboutsummaryrefslogtreecommitdiffstats
path: root/adapters/mso-openstack-adapters/src/main
AgeCommit message (Collapse)AuthorFilesLines
2019-06-18Fixed critical Sonar bugsr.bogacki1-4/+7
Fixed critical bugs according to the Sonar analysis. -Fixed possible NPE. -Fixed wrong comparison. -Removed unused variables. Issue-ID: SO-2025 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I5e2e5413c8421eb7ed1db21de6d888a50e1db689
2019-06-17Merge "Fix sonar issues in mso-openstack-adapters"Steve Smokowski1-79/+62
2019-06-17Improvements in MsoVnfAdapterImplr.bogacki1-67/+62
Improvements in MsoVnfAdapterImpl according to the Sonar analyses. -Removed unnecessary code. -Fixed imports. -Extracted constants. Issue-ID: SO-2011 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I9dc8406fe0cdea74b08ebb013a68f970da647b6c
2019-06-14update multi stage code to accurately skip bbsBenjamin, Max17-0/+340
moved around classes to packages that make more sense updated license headers in java files converted MultiStage logic to FlowManipulator moved tests to new package location and fixed issues allow for custom listeners before flowsToExecute moved validation classes to listener.validation Change-Id: Ic5416812ef9c5611fe19bf9b6aa316373b110ec6 Issue-ID: SO-2021 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-10replaced String.repeat with static final stringsBenjamin, Max9-165/+155
replaced String.repeat with static final strings Change-Id: Ife14fde70e8f648881a03e9343ae8faf9cb87e2e Issue-ID: SO-1999 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-03Cleaned up duplicated literalsrob.bog7-128/+143
Cleaned up Sonar code smells related to the duplicated literals in loggers. Issue-ID: SO-1932 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I58c48cec0012c42b7b892ae76c24c6a087c60c7e
2019-05-31enhanced vnf adapter errog log.Sangalang, Felix3-6/+15
enhanced vnf adapter error log for heatEnvironment when null. removed the junit tests because of no assertions coverage. enhanced vnf adapter errog log. Change-Id: I80d3070ce203c4c8339f0a0e7df6f3731d0a16c2 Issue-ID: SO-1967 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-31Merge "converted lock time from hard coded value"Steve Smokowski3-5/+11
2019-05-31Corrected enum formatting by pluginBenjamin, Max (mb388a)1-3/+9
enums are now single item per line Change-Id: I6330ea4a9093071457dd47b95b6ed3bb7f8312e7 Issue-ID: SO-1970 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-31converted lock time from hard coded valueKalkere Ramesh, Sharan3-5/+11
update lock time property to have a default of 60000 converted lock time from hard coded to property driven Change-Id: I4a42b85c4241c8865f8dc133be96d7bc92b8574d Issue-ID: SO-1962 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-31fix keypair conflict issue in openstack adapterSmokowski, Steven2-63/+25
Fix wiremock stubs to return proper data and url Fix copyright header issue on unit test file Fix keypair issue, clean up unit tests and logging Fix issues found in unit testing, update data Fix broken Unit tests that used invalid data Continue Refactor to support keypair failure scenario Update logic for when to auto delete a stuck keypair Change-Id: Ice5256cf0381a3b46d1c442907c0f321a1c0d006 Issue-ID: SO-1897 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-29Fix sonar issues in mso-openstack-adaptersParshad Patel1-79/+62
Fix Either log or rethrow this exception Fix Replace the type specification in this constructor call with the diamond operator ("<>") Fix Remove this unused local variable Fix Iterate over the "entrySet" instead of the "keySet" Issue-ID: SO-1841 Change-Id: I5e9195d75d29a66a4a360e031ab02ab7c9872388 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2019-05-17Audit service enhancementsBoslet, Cory2-18/+28
Update number of threads used for openstack audit Refactored post construct audit service and added junits Change-Id: Ic5bd42cda98835305d2e2d5d09a5c039376316a5 Issue-ID: SO-1898 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-15store openstack request status in requestdbSmokowski, Steven6-45/+150
Openstack request status now stored in request db Change-Id: Ida8f4f613d406c2b834ab190e01d5aaf2f16dd3d Issue-ID: SO-1867 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-10Merge "Remove triple logging of VNF adapter response"Steve Smokowski2-2/+1
2019-05-10Remove triple logging of VNF adapter responseMcblain, Thomas2-2/+1
Remove triple logging of VNF adapter response to bpel Change-Id: Ia8f3d3b9b76616e9dcc9f638ba5ca58dcac3ab8b Issue-ID: SO-1863 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-10Added to write variablles on audit failureBoslet, Cory1-1/+1
Added to write variablles on audit failure so bpmn knows whether success or not. Change-Id: I1eb0827a10ee75f4ee89bfb36d13035a2612e032 Issue-ID: SO-1862 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-03Merge remote-tracking branch 'origin/dublin'Benjamin, Max (mb388a)1-1/+9
merged dublin into master branch Change-Id: Ifb78d405611b65764fd4f01558b0e703551ed663 Issue-ID: SO-1830 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com> Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2019-04-28Store Cloud Request in DatabaseSmokowski, Steven1-2/+2
Store Cloud Request in Database, add to request service Add query Param to Plural to include cloud data Change-Id: If906d28d0dc9c0c804e550e2074af3d75ba46d32 Issue-ID: SO-1807 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-04-26Do not need to retry on inventory exceptionBoslet, Cory1-2/+10
Do not need to retry on inventory exception due to vservers/linterfaces missing. Change-Id: I8e1e1d89ebd35e2b84a65e5e6db3e1db3f976982 Issue-ID: SO-1812 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-04-25Merge "Add SO update config file -application.yaml file"Steve Smokowski1-9/+11
2019-04-25MsoVnfAdapterImpl - sonar fixDriptaroop Das1-30/+11
MsoVnfAdapterImpl - sonar fix Issue-ID: SO-1811 Change-Id: Ic3bebd30e4f65b9ba5732c43cfd8baf0050e3b7b Signed-off-by: Driptaroop Das <driptaroop.das@in.ibm.com>
2019-04-22Merge "Status message for create vf module event audit"Steve Smokowski9-89/+20
2019-04-21Fix issue where null variable causes task to notBenjamin, Max (mb388a)1-10/+11
fixed formatting of newly added files Fix issue where null variable causes task to not complete Change-Id: If2361a0834220c2e2738917a2e5bf9b012570929 Issue-ID: SO-1806 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-04-21Status message for create vf module event auditBenjamin, Max (mb388a)9-89/+20
Added appc to application-test due to new dependency in openstack Updated exception class to inject mock into class for junits. Added error handling support for when create audit fails. Added error handling for when create audit fails and added test Updated test schema file to create table and added field. Updated pom file to relfect typo in change made. Updated locaton of pojos for audit code Updated test schema file to create table and added field. Updated pom file to relfect typo in change made. Comitting files that i forgot to stage from previous commit Updated locaton of pojos for audit code Additional fixes including vnfcname and null check Fixed bug in delete audit failure check and reverted gateway change. Change-Id: I993ce377dd6407960a65b4940d83d8162b24633c Issue-ID: SO-1792 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-04-21Merge "Remove import,variable,shift constructor call"Seshu Kumar M1-11/+9
2019-04-21Merge "Replace String literal with constant"Seshu Kumar M1-10/+9
2019-04-20Replace String literal with constantSindhuri.A1-10/+9
Replace String literal with a constant VnfAdapterNotify_Service class Issue-ID: SO-1490 Change-Id: Iebcfb6254fce98cc09e772389629bba2af169194 Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
2019-04-20Remove import,variable,shift constructor callSindhuri.A1-11/+9
Remove unused import,variable,shift constructor call MsoVnfPluginAdapterImpl class Issue-ID: SO-1490 Change-Id: I1d722d7157ccbb9366dfe0ae60529c40615bb8e3 Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
2019-04-20Replace String literal with a constantSindhuri.A1-4/+5
Replace String literal with a constant MsoVnfCloudifyAdapterImpl class Issue-ID: SO-1490 Change-Id: I89599391fba99a6e979bd19d6e86684c8691ec8b Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
2019-04-20Merge "Substitute String Literal with Constant"Seshu Kumar M1-32/+30
2019-04-20Merge "Replace String Literal with a Constant"Seshu Kumar M1-3/+4
2019-04-20Merge "Replace String Literals with Constant"Seshu Kumar M1-9/+10
2019-04-19Substitute String Literal with ConstantSindhuri.A1-32/+30
Substitute String Literals with Constant MsoVnfCloudifyAdapterImpl class Issue-ID: SO-1490 Change-Id: I5b8340049a85a5405f158cac2518c571b74bc440 Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
2019-04-19Merge "move constructor calling after variable declare"Seshu Kumar M1-4/+4
2019-04-19Merge "Add String constant for duplicate literals"Seshu Kumar M1-40/+38
2019-04-19Replace String Literal with a ConstantSindhuri.A1-3/+4
Replace String Literals with Constant MsoVnfAdapterAsyncImpl class Issue-ID: SO-1490 Change-Id: Iaf8519e6ec216bf8e79e56e76856019b50371616 Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
2019-04-19Merge "Replace String Literal with Constant"Seshu Kumar M1-5/+6
2019-04-19Merge "change modifiers order and method name"Seshu Kumar M1-6/+6
2019-04-19Replace String Literals with ConstantSindhuri.A1-9/+10
Replace String Literals with Constant NetworkAdapterRest class Issue-ID: SO-1490 Change-Id: I2b8aa59b971da7af1b1abda0fd137f55d3a32284 Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
2019-04-19move constructor calling after variable declareSindhuri.A1-4/+4
move constructor call after variable declaration HeatBridgeUtils Issue-ID: SO-1490 Change-Id: Ieea4b037f1fbd001eae49f55aa073d1d4eab7379 Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
2019-04-19Replace String Literal with ConstantSindhuri.A1-5/+6
Replace String Literal with Constant MsoNetworkAdapterAsyncImpl class Issue-ID: SO-1490 Change-Id: I906efda71f380c495bc4b6988a0d8f6c57d2983e Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
2019-04-19move constructor call after variable declarationSindhuri.A1-4/+5
move constructor call after variable declaration HeatBridgeConstants Issue-ID: SO-1490 Change-Id: I568c4c724b2d80a3d14bbb9765a7dba0f37b780d Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
2019-04-19Add String constant for duplicate literalsSindhuri.A1-40/+38
Added String constant for duplicate literals MsoVnfAdapterImpl class Issue-ID: SO-1490 Change-Id: I1dba65ee9f7c5a01f34f0ca51191325eb6805ef5 Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
2019-04-19change modifiers order and method nameSindhuri.A1-6/+6
change modifiers order and method name VnfAdapterNotify_Service class Issue-ID: SO-1490 Change-Id: I6b3e44ae5959ebdd1161c0375423a9e4a1b7990a Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>
2019-04-19Merge "Reorder modifiers, replace type specification"Seshu Kumar M1-37/+32
2019-04-19Merge "replace type specification for vnf async client"Seshu Kumar M2-2/+2
2019-04-19Merge "Replace str literal for const, replace type spec"Seshu Kumar M1-15/+16
2019-04-19Merge "Remove unused constants, change constructor place"Seshu Kumar M1-14/+9
2019-04-19Reorder modifiers, replace type specificationSindhuri.A1-37/+32
Reorder modifiers, replace type specification vnf async client ObjectFactory Issue-ID: SO-1490 Change-Id: I64e86b87045c800616c4662262fd960c8672b437 Signed-off-by: Sindhuri.A <arcot.sindhuri@huawei.com>