summaryrefslogtreecommitdiffstats
path: root/adapters/mso-adapters-rest-interface
AgeCommit message (Collapse)AuthorFilesLines
2019-06-24Sonar fixes and improvementsr.bogacki1-2/+2
General fixes and improvements according to the Sonar analysis. -Fixed imports. -Removed unnecessary code. Issue-ID: SO-1992 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com> Change-Id: I4299f3efc4444625f70fc36e65b57c500b113596
2019-06-06Merge remote-tracking branch 'origin/dublin' into 'origin/master'Steve Smokowski1-1/+2
Change-Id: I551ea3f29a76dc99532455ea4d7e84a316f9bf38 Issue-ID: SO-1980 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2019-05-31Corrected enum formatting by pluginBenjamin, Max (mb388a)1-3/+9
enums are now single item per line Change-Id: I6330ea4a9093071457dd47b95b6ed3bb7f8312e7 Issue-ID: SO-1970 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-31fix keypair conflict issue in openstack adapterSmokowski, Steven1-3/+3
Fix wiremock stubs to return proper data and url Fix copyright header issue on unit test file Fix keypair issue, clean up unit tests and logging Fix issues found in unit testing, update data Fix broken Unit tests that used invalid data Continue Refactor to support keypair failure scenario Update logic for when to auto delete a stuck keypair Change-Id: Ice5256cf0381a3b46d1c442907c0f321a1c0d006 Issue-ID: SO-1897 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-27Fix sonar for MapEntryk.kazak5-11/+53
MapEntry bug: make entry private and provide accessors MapEntry codesmell: move comment 'Required by JAXB' into empty constructor MapElements codesmell: move explanatory comment inside empty constructor MapElements codesmell: log error stacktrace MapAdapter codesmell: use entry set instead of key set for iteration JAXBMarshallingTest: add test cases to cover 100% of MapElements & other cases Change-Id: If51f1f86b5ad44b3462424e4fd73cb0eff352124 Issue-ID: SO-1811 Signed-off-by: k.kazak <k.kazak@samsung.com>
2019-05-17make HostRoute serializable classMnushkin, Dmitry1-3/+3
make HostRoute serializable class Change-Id: Id9eb0e42568ab96ce533288c15000ef8fd8fe066 Issue-ID: SO-1894 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-05-15store openstack request status in requestdbSmokowski, Steven1-0/+15
Openstack request status now stored in request db Change-Id: Ida8f4f613d406c2b834ab190e01d5aaf2f16dd3d Issue-ID: SO-1867 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-04-26Fix multicloud query of non-existant stackEric Multanen1-0/+1
Fix handling of Not Found status for multicloud plugin query of a workload. Change-Id: Ie33b8728bf71fbcf0eaaa6496520351404928a36 Issue-ID: SO-1821 Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
2019-04-20always convert values toString for xml marshallingBenjamin, Max (mb388a)5-5/+63
always convert values toString for xml marshalling added in null check and object mapper call Change-Id: Ie91c313dce110d53586e6773e2223d63be799a54 Issue-ID: SO-1786 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-04-11corrected inlucde filter for formatterBenjamin, Max (mb388a)1-60/+60
all pom.xml files now have two spaces validation is on for pom.xml files Change-Id: I424ea2e4d6a549f468792e5f90a43f3a97e6c954 Issue-ID: SO-1781 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-04-08Replaced all tabs with spaces in java and pom.xmlBenjamin, Max (mb388a)134-5602/+5510
Added in maven plugins to enforce coding style rules Added in eclipse java formatting xml Change-Id: I3727bbf4ce8dc66abfd8ad21b6cfd0890c5d3ff0 Issue-ID: SO-1765 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-03-22Multicloud VNF adapter use updated multicloud APIEric Multanen1-5/+19
Update the Multicloud plugin adapter to use the the enhanced multicloud infra_workload API. Mainly involves adding the user_directives and the vf-module model IDs to the call. Change-Id: I7ab78a8a304dbd61a5743ec67bb839037861ef9d Issue-ID: SO-1446 Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
2019-03-19Add cloudOwner to VNF adapter callEric Multanen11-34/+128
The BPMN layer has the CloudRegion which includes the CloudOwner attribute, but this is not passed to the VNF adapter layer. Calls to the Multicloud infrastructure workload need the CloudOwner as well. This patch adds CloudOwner to the VNF adapter API. While the intended usage is primarily for the multicloud adapter, it touches a log of other files - though those do not make use of it at this point. Change-Id: I88028096fbd84fc3fe5d53786c70b3c8806bb711 Issue-ID: SO-1447 Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
2019-03-13Openstack adapter can't resolve HEAT parameterBenjamin, Max (mb388a)9-2/+418
only cast to Element if value is of that type added XmlAccessorType annotations to classes map of string, object now correctly maps with jaxb Null comma delimited lists can convert to null as well Handle null values all types in input parameters map. Change-Id: Ic46ed31c05b8f8551d39b2267ae731829abfc1f0 Issue-ID: SO-1617 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-03-01vnf spin up gr api vnf s base module failsBenjamin, Max (mb388a)4-12/+12
map object representations of json back to json strings marshal all objects to json strings before sending all input params converted to Map<String, Object> Updated userParams map from HashMap<String, String> to Map<String, Object> as HashMap<String, String> userParams was causing VNF spin up to fail. Input json in Userparams was not accepted as a valid json format. Updated other files that were affected by this change. Change-Id: I0c00fc00c4c11b54ace4df7be8d5bfc80d41d130 Issue-ID: SO-1582 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-02-25Removed MsoLogger in 'mso-adapters-rest-interface'r.bogacki9-41/+57
Removed MsoLogger from adapters ('mso-adapters-rest-interface') Replaced MsoLogger with plain slf4j. Refactored login output. Fixed imports. Change-Id: I2623c14dda55ae471bc11d40345c5f91c62bd94f Issue-ID: LOG-631 Signed-off-by: Robert Bogacki <r.bogacki@samsung.com>
2019-01-28Merge "Merge 'origin/casablanca' into master"Marcus Williams1-2/+2
2019-01-28Merge 'origin/casablanca' into masterBenjamin, Max (mb388a)1-2/+2
Issue-ID: SO-1435 Change-Id: If065ef5c91e769452fd6701fa6c28a23b4bdf2b2 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2019-01-27pool is now serializableBenjamin, Max (mb388a)1-4/+19
add implements Serializable to openstack Pool object Make Openstack Pool object serializable - for netwk Change-Id: I9ba294b68a0896c528558ebc1d66d909a7787b47 Issue-ID: SO-1430 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-24bugfixes jan 24thBenjamin, Max (mb388a)3-29/+7
Fix null pointer exception when no requestParameters are specified Add configurable timer in ActivateVfModuleBB to delay call to SDNC activate - Use raw slf4j logger - use {} formatting Add configurable timer in ActivateVfModuleBB to delay call to SDNC activate - Use raw slf4j logger Add configurable timer in ActivateVfModuleBB to delay call to SDNC activate - removed unused references in test class Add configurable timer in ActivateVfModuleBB to delay call to SDNC activate Update PortGroup objects separately from the parent VCE object - restore setVariable calls back into vce object - they might be needed later. Update PortGroup objects separately from the parent VCE object - updated test class extra call to get PortGroups Update PortGroup objects separately from the parent VCE object - use PortGroup.getInterfaceRole() getter method instead of accessing field directly. Update PortGroup objects separately from the parent VCE object Added back required headers for tenant isolation. removed workflow exception from outmapping in execute Fix possible null ptr exception, fix to add braces. Default networkTechnology in Update as done in Create Fix failing junits, mapper force upper case nwtech update exception builder to properly throw exception error message supporting assign service instance a la carte as well adding in proper exception handling in network rest v1 add the unassign action to R macro data file Change-Id: Ide420514f81b8083b4c76c762c064de199624cf7 Issue-ID: SO-1424 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-01-11get subnet sequence number from A&AIBenjamin, Max (mb388a)1-1/+11
Add AAIQuery for subnet block to CreateNetwork bpmn MSO shall get subnet sequence number. Change-Id: I5cf73d1b5344f41ac98a51274948822322e3591b Issue-ID: SO-1378 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-11-17Bug Fixes November 16thBenjamin, Max (mb388a)1-2/+2
fix failing junit when heatID not available provide name if ID is not present on delete op removed logic to skip unassign sdnc in rollback flows Move default settings to CrVfModRequest pojo. Check for null backout and failIfExists params - 1810. Updated exception message and test Added tests for networkCustomization not found Added tests for delete and update network Separated networkResourceCustomization and networkResource lookups Removed version check as not necessary for setting boolean Change-Id: Ia4b409244dc5ebdbb163d4a178713115719366ca Issue-ID: SO-1231 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-10-19Update version to 1.4.0-SNAPSHOT for DublinRob Daugherty1-1/+1
Henceforth, the master branch will be for Dublin work. Change-Id: I269fd8f227e37afdab9c633f45488c643e5e765e Issue-ID: SO-1151 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-09-18Upgrade to openstack libs version 1.3.0Rob Daugherty1-7/+6
Version 1.3.0 uses fasterxml.jackson. Note: several unit tests were wrong and had to be fixed. They were using a fasterxml ObjectMapper to deserialize openstack library class objects compiled with codehaus JsonProperty annotations. Consequently, the ObjectMapper could not "see" the annotations. The tests "worked" because the json was constructed wrongly to match. I have now fixed the json so that they have the true property names defined by the annotations. Change-Id: I088137ee5dd5af9cffd426610a50ae6408c5b190 Issue-ID: SO-1025 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-09-11UpdateNetworkRequest.java: Fixed sonar issueArundathi Patil1-1/+0
Sonar Link : https://sonar.onap.org/code?id=org.onap.so%3Aso&selected=org.onap.so.adapters%3Amso-adapters-rest-interface%3Asrc%2Fmain%2Fjava%2Forg%2Fonap%2Fso%2Fadapters%2Fnwrest%2FUpdateNetworkRequest.java Issue-ID: SO-1012 Change-Id: I1324f1ef4bf35523f9ae1bf55915bf1671900720 Signed-off-by: Arundathi Patil <arundpil@in.ibm.com>
2018-09-06Merge "Removed unused import"Seshu Kumar M1-1/+0
2018-09-06Removed unused importezhil1-1/+0
Removed unused import in the code Issue-ID: SO-982 Change-Id: Ifbbd1a789aa2e95a0f4a4533cca0b77439117a51 Signed-off-by: ezhil <ezhrajam@in.ibm.com>
2018-09-05Merge "fixed sonar issue in CreateTenantRequest.java"Byung-Woo Jun1-1/+5
2018-09-05fixed sonar issue in DeleteTenantRequest.javaSandeep J1-1/+5
fixed sonar issue as detailed in SO-979 Issue-ID: SO-979 Change-Id: I4c0aa6380e734088ba6fb68414d4391f9b6d6344 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-09-05fixed sonar issue in CreateTenantRequest.javaSandeep J1-1/+5
fixed sonar issue as detailed in SO-978 Issue-ID: SO-978 Change-Id: Id53fdea75b13b8ce234fe69d121f7bd996f21a82 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-09-04Merge "resolved sonar issue in VduArtifact.java"Byung-Woo Jun1-2/+2
2018-09-04Merge "fixed sonar issue in DeleteNetworkRequest.java"Byung-Woo Jun1-1/+5
2018-09-04Merge "fixed sonar issue in QueryNetworkResponse.java"Byung-Woo Jun1-2/+3
2018-09-03fixed sonar issue in UpdateNetworkRequest.javaSandeep J1-1/+3
fixed sonar issue as detailed in SO-960 Issue-ID: SO-960 Change-Id: Iebf2fc563fea2aef70c8f7db75d104efeeb54ff5 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-09-03fixed sonar issue in QueryNetworkResponse.javaSandeep J1-2/+3
fixed sonar issue as detailed in SO-959 Issue-ID: SO-959 Change-Id: I878061aa88247e39b703bca065f3c92a1eea3eb6 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-09-03fixed sonar issue in DeleteNetworkRequest.javaSandeep J1-1/+5
fixed sonar issue detailed in SO-958 Issue-ID: SO-958 Change-Id: I4c25995c702165cd7c737d22b1c26bc4442cd490 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-09-02resolved sonar issue in VduArtifact.javaSandeep J1-2/+2
resolved sonar issue detailed in SO-948 Issue-ID: SO-948 Change-Id: Ic7238eb53ba6a26534cb80cffe5364e6288b9b00 Signed-off-by: Sandeep J <sandeejh@in.ibm.com>
2018-08-23Created Ref Data tbl for controllerSelectionPrema Bhatt1-0/+1
RD: I rebased this and fixed the unit tests. Issue-ID: SO-763 Change-Id: Ie5f6a708cffbc70a9481afd35db3047fe44cb088 Signed-off-by: Prema Bhatt <pb6115@att.com> Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-08-02Resolve Sonar Blocking issuesSmokowski, Steve (ss835w)1-13/+18
Issue-ID: SO-788 Change-Id: I4496ef16c56c980a81031ad01fcbb1524d135ea8 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-08-01Remove unused import statementsEthan Hampton1-3/+0
Issue-ID: SO-666 Change-Id: I3775d25c0328807b083725c61da015364e59f2be Signed-off-by: Ethan Hampton <ethanx.hampton@intel.com>
2018-07-31Containerization feature of SOBenjamin, Max (mb388a)150-2365/+2685
Change-Id: I95381232eeefcd247a66a5cec370a8ce1c288e18 Issue-ID: SO-670 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-03-27UT Coverage for mso-adapter-rest-interfaceAnjali Walsatwar11-0/+283
UT Coverage for mso-adapter-rest-interface. Change-Id: Ib03912c9dbcec309be2cb04cfcea7cdb9c525bbd Issue-ID: SO-369 Signed-off-by: Anjali Walsatwar <anjali.walsatwar@huawei.com>
2018-03-27Dependency version updates for BeijingRob Daugherty1-12/+0
Update so/libs version to 1.2.1 Update aai-common version to 1.2.1 Update sdc-distribution-client version to 1.3.0 Update sdc-tosca version to 1.3.3 Change-Id: I6c8f1c5476efc4dc866bf765c265736ab70c12c7 Issue-ID: SO-536 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-03-21Improve code coveragesubhash kumar singh1-0/+179
Improve code coverage. Change-Id: I8745d26ec9e19aa72f19157c310504d87b139543 Issue-ID: SO-369 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-03-21Improve code coveragesubhash kumar singh1-0/+141
Improve code coverage. Change-Id: Ibbe4428fb86c720f77d040b9293dac1f81bbfb02 Issue-ID: SO-369 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-03-21Improve code coveragesubhash kumar singh1-0/+90
Improve code coverage. Change-Id: I5cf78487c9039c5ea2e87189ba212d3ed7bb7c43 Issue-ID: SO-369 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-03-21Improve code coveragesubhash kumar singh1-0/+48
Improve code coverage. Change-Id: If3fcc5bba139516857529350af5fe9285a39ca1b Issue-ID: SO-369 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-03-21Improve code coveragesubhash kumar singh1-0/+48
Improve code coverage. Change-Id: I0d4e78c218dd0196bdfe570012ce8e4923fc8a1d Issue-ID: SO-369 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-03-21mprove code coveragesubhash kumar singh1-0/+151
Improve code coverage. Change-Id: I4995561822abeb2c34f9fa23e34853496f63d9d4 Issue-ID: SO-369 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-03-21Improve code coveragesubhash kumar singh1-0/+86
Improve code coverage. Change-Id: I01d31b469b7df56328ec3cc76023e15b617842da Issue-ID: SO-369 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>