aboutsummaryrefslogtreecommitdiffstats
path: root/adapters/mso-adapter-utils
AgeCommit message (Collapse)AuthorFilesLines
2020-04-16Merge "reduced code smells"Steve Smokowski1-1/+0
2020-04-15Allow client exception to propogateSmokowski, Steven1-14/+10
Client exception already contains all the information we need Allow it to bubble up Issue-ID: SO-2811 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I2e346366dab3187bb397b386619bf681e53e2cab
2020-04-12reduced code smellsRupinder1-1/+0
Removed some unused imports Issue-ID: SO-2804 Change-Id: Ib0a7716585448ade0c9571479ed06effaf25738b Signed-off-by: Rupinder<rupinsi1@in.ibm.com>
2020-03-26convert openstack to external tasksBoslet, Cory3-28/+37
Use external tasks to communicate with openstack adapter Will be more resilient to failures Refactored all flows to use external tasks not REST calls Rollback is now an external task Ensured backwards compatibility Issue-ID: SO-2767 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I8afdb89c688d756aed0f25f7d9a7fb898142554d
2020-03-19mso to add support for creating the cloud regionSmokowski, Steven1-3/+1
mso to add support for creating the cloud region Updated tag name to msoRequest on deletes. Issue-ID: SO-2753 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I80e318ce34f5938a42896398eb1a38b5c5f6e831
2020-03-16Merge "Fix Critical & Major issues in adapters"Steve Smokowski1-45/+63
2020-03-14catch and log exceptionBoslet, Cory1-1/+6
catch and log exception in MSOHeatUtils Issue-ID: SO-2733 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Ibcb7c58c280f0deb2e5144a0082f4be64aa241af
2020-03-13Fix Critical & Major issues in adaptersParshad Patel1-45/+63
The Cyclomatic Complexity of this method "createStackParam" is 16 which is greater than 10 authorized Either log or rethrow this exception Issue-ID: SO-1841 Change-Id: Ie5539a853a112ed751bbf891699f181479537e47 Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2020-03-10Merge "false positive on network creates"Steve Smokowski1-9/+21
2020-03-10Merge "create custom spring aop annotation for logging"Steve Smokowski7-7/+7
2020-03-08false positive on network createsBoslet, Cory1-9/+21
Added a new resourceStatusMessage field to the GET orch request API added new column to infra active request table updated openstack adapter to record the resource status added support of v8 on GET orch request API. Issue-ID: SO-2718 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I73b35f1562de4df477bf7e5cef01de13440ba98a
2020-03-05create custom spring aop annotation for loggingPlummer, Brittany7-7/+7
Added annotation for setting up scheduled tasks logs Added new annotation to scheduledTasks Moved annotation setup to logging-library Issue-ID: SO-2713 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I7080c4bb289e454f14167631e2601c954389c0ef
2020-03-01Add ability to build https endpoint to multicloudEric Multanen2-1/+8
Add parameter to allow https endpoint to be used for endpoint to multicloud (via msb). Change-Id: Ia3a296cab8e8676e7b39c0f56c03e18e18a0a777 Issue-ID: SO-1450 Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
2020-02-27Merge "enhance openstack library"Steve Smokowski1-0/+63
2020-02-26bump the versions for all the SO to 1.6.0seshukm1-1/+1
Issue-ID: SO-2519 Signed-off-by: seshukm <seshu.kumar.m@huawei.com> Change-Id: Id0993b244b0978375ff8476e4bf8ef79e1bb9e68
2020-02-25enhance openstack librarySmokowski, Steven1-0/+63
Add new methods to NovaClient Issue-ID: SO-2680 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I13fdfcb7052f12ece409a19fbd33abc3f101e2d9
2020-01-30Remove Valet from openstack adapterSmokowski, Steven1-20/+0
Remove Valet from openstack adapter Clean up CI, so it passes on dev branch Fixed bad merge regarding correct method name. Added try catch around createIfNotExists methods to avoid failing sim. Fix broken Fabric Tests from merge Update logging jar dependency for CI Issue-ID: SO-2623 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I572276f751b132ec78d7ab5763f1c76bfc8256c5
2020-01-30- Include stack Status Reason when rollback isMerkel, Jeff2-4/+7
- Include stack Status Reason when rollback is suppressed. - Updated to format code to pass the build. Issue-ID: SO-2620 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Id9789930eaf7c47666a9401f8e3c57156c931b74
2020-01-23Add Neutron Port and Nova Server to ProxySmokowski, Steven2-0/+39
Add Neutron Port and Nova Server to Proxy Issue-ID: SO-2614 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I09e0302bbdb66dadae3dbac7bbf07a64dfc39d10
2020-01-15Use the timeout from the heat template instead ofBoslet, Cory1-5/+1
Use the timeout from the heat template instead of hardcode WIP Added custom uuid to vf adapter delete rest request Added and fixed compilations errors due to interface change added logic to check that the timeout is less than 120 Set the cust model uuid in bpmn so its avaiable to adapter. Added to use timeout from heat template for network. Updated unit test to account for new param change to method. Fixed and added missing param to deletevf in vnfadapterrestv2 Fixed failing junits due to adding model cust id to request Issue-ID: SO-2601 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I6ac276f37d4b6423501fb07fe081828ea3bed235
2019-11-22improve error log scoresPlummer, Brittany2-22/+22
Updated error code name to fix spelling Defaulted errorcode and errordesc to unknown when not provided Remove unused imports from nc orchestrator application Added defaulting of serviceName to error log Issue-ID: SO-2538 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I5ae960f728739e2528173b66484562742429416c
2019-10-15Cleanup - removed unused variables and methods,Oleksandr Moliavko1-1/+1
redundant initializers in several places Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: I15ae50cf327d3d125f9d86c34281093bef677c71
2019-10-04Merge "Added null checks for bp to prevent exceptions at bp.getId() calls; ↵Lukasz Muszkieta1-8/+13
fixed omissions in methods control logic; removed unneeded catch blocks"
2019-10-04Added null checks for bp to prevent exceptions atOleksandr Moliavko1-8/+13
bp.getId() calls; fixed omissions in methods control logic; removed unneeded catch blocks Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: I8347b953381ebb4a112a22fc8c58a9a32f2dbfb7
2019-10-03Merge "Added null check for executions variable to prevent a static analyzer ↵Lukasz Muszkieta1-1/+1
warning"
2019-10-03Added null check for executions variable toOleksandr Moliavko1-1/+1
prevent a static analyzer warning Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: I6c10240048452c242ab3f513a6e13e81baedbc5f
2019-10-01Improve fall out case handlingSmokowski, Steven7-234/+170
Update Openstack adapter to handle fall out cases with greater stability Issue-ID: SO-2376 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I20116cbd3b63bb29c9bf4ed99e92bd5f2b691da5
2019-09-30Added null check for execute() result to removeOleksandr Moliavko1-1/+5
static analyzer warning Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: Ifc8481b659c5b53378611f9e80db087db590ae05
2019-09-10Integrate Logging LibraryPlummer, Brittany1-2/+2
Updated SO to use ONAP provided filters and constants to meet logging standards. Removed redundant classes Updated constant references Issue-ID: SO-2301 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: Ia4e3c2b1a4dcb3881aa34d39885c8b2782880d64
2019-08-21Added null check for latestStack to prevent crashOleksandr Moliavko1-10/+14
at method calls; moved latestStack declaration according to comment by maintainer Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: Ic4bfeca94103f6c902808de39df752569580c066
2019-08-21Rewritten checks for status according to commentsOleksandr Moliavko1-5/+9
Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: I6023a043e2cf532de330060973d23a402a742e36
2019-08-13Merge "Removed unused method setHPAParameters()"Lukasz Muszkieta1-18/+0
2019-08-13Removed unused method setHPAParameters()Oleksandr Moliavko1-18/+0
Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: Ic9de579495c1400bca233b679699ae857180520b
2019-08-12Merge "Sonar fix in mso-adapter-utils"Lukasz Muszkieta2-34/+29
2019-08-12Merge "Change collections size with isEmpty"Seshu Kumar M1-2/+2
2019-08-12Sonar fix in mso-adapter-utilsParshad Patel2-34/+29
Either log or rethrow this exception Remove this unused import Make "workloadStatusReason" transient or serializable Issue-ID: SO-1841 Change-Id: I01fe8ce059b5fde95d300d2d0e5b4a1a114c479a Signed-off-by: Parshad Patel <pars.patel@samsung.com>
2019-08-12Change collections size with isEmptysindhu36721-2/+2
Change collections size with isEmpty mso-adapter-utils class Issue-ID: SO-2187 Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com> Change-Id: I784a5839d003c42a9880287d304060cd9639f1b6
2019-08-09Replace collections size with isEmptysindhu36721-3/+3
Replace collections size with isEmpty mso-adapter-utils class Issue-ID: SO-2187 Signed-off-by: sindhu3672 <arcot.sindhuri@huawei.com> Change-Id: Icf6fc86d9d6f02571938804d214b5b5bfca72698
2019-08-09fix sonar issuesarada prasad sahoo1-12/+9
fix sonar issues Issue-ID: SO-1811 Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com> Change-Id: I8e443077864d758149bb5f62bc5dc5f718c29204
2019-08-09fix sonar issuesarada prasad sahoo2-43/+37
fix sonar issues Issue-ID: SO-1811 Signed-off-by: sarada prasad sahoo <sarada.prasad.sahoo@huawei.com> Change-Id: I51a9106ad99e7bb101c3d6c9a33603ac202d7cb6
2019-07-30Replaced constructor call with Boolean.valueOf() callOleksandr Moliavko1-1/+1
to prevent static analyzer warning about inefficient use of constructor Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: Id5a883628726bdd0313a46ea4808a36eccf03c9a
2019-07-25store heat env file sent to heatGamboa, Gilbert3-2/+56
Initial commit, include heat environment info in cloud-api_requests. Updated MSOHeatUtilsTest.saveStackTest unit test to assert cloudApiRequests requestBody Issue-ID: SO-2158 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I333cae7746459917ba5e64feb07db4f710b8d99b
2019-07-18Merge "Added null check for yaml to prevent crash at getParameterListFromEnvt()"Steve Smokowski1-3/+6
2019-07-18Removing application-local.yaml filesRoy, Amresh1-64/+0
Removing the application-local.yaml files because they're no longer maintained or working. Issue-ID: SO-2121 Signed-off-by: Benjamin, Max (mb388a) <mb388a@att.com> Change-Id: I191c8775de931671a4657be8940e6aec64023359
2019-07-17add query stack data and populate table stepBoslet, Cory1-3/+33
Need to check if audit is enabled first in the delete record task Updates to audit delete redeisgn and data to table Various updates to logging, audit object, added tag to query, updated tag value. Updated write method to make sure an entry for this heat stack doesnt already exist to avoid duplicate entrys Updated unit test to account for get query Added so that id is not hidden from query results Updated the was delete is done plus minor updates. Updated delete method to use resttemplate instead of bowman client Combined the write and get stack data task into the external tasks. Removed the task to delete the stack data from db Updates to junit request id so its not a random id for test Updated service tasks in att BB to call external task Update to be a real uuid format due to failing unit test Updated fields to protected and updated unit test Issue-ID: SO-2111 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com> Change-Id: I8f479a046cf837403f60c330ed6ad8bc08a9c82f
2019-07-15Added null check for yaml to prevent crash atOleksandr Moliavko1-3/+6
getParameterListFromEnvt() Issue-ID: SO-1841 Signed-off-by: Oleksandr Moliavko <o.moliavko@samsung.com> Change-Id: I8fabba8d99e311f01a5fd5dad166e0bb643044e3
2019-06-27Update failsafe dependency to 2.0.1Benjamin, Max1-7/+4
Updated calls to failsafe 2.0.1 API Change-Id: I2c86ca02d56a07262e330ee5f8f088d1a1f5b4a7 Issue-ID: SO-2057 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-18Use Regex to find the name on failure scenarioSmokowski, Steven2-27/+10
Use Regex to find the keypair name on failure scenario Change-Id: Ibf2167283d90407def7750fab4538f5443e57092 Issue-ID: SO-2037 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2019-06-15Merge "update multi stage code to accurately skip bbs"Max Benjamin5-0/+100
2019-06-14Merge "adapter client will not retry on openstack failure"Max Benjamin8-26/+32