aboutsummaryrefslogtreecommitdiffstats
path: root/adapters/mso-adapter-utils/src
AgeCommit message (Collapse)AuthorFilesLines
2018-11-05Springboot 2.0 upgradeBenjamin, Max (mb388a)7-377/+10
corrected typo in CloudConfiguration class removed files which should not have been merged updated gr api test cases with dynamic cloud owner updated groovy files to allow for dynamic cloud owner values moved VFModularity folder to mso-infrastructure bpmn updated GR API layer to include cloud owner added enum for default cloud owner - fixing junit test cases for using catalogDb client r2 - fixing junit test cases for using catalogDb client - Internal review comments incorporated for merging mocking into BaseTest - Internal review comments incorporated for removing direct repo calls - CLONE - Key Management Hardcoded encryption key | fixing junits - CLONE - Key Management Hardcoded encryption key Updated builder to use String.format Added exception specifically for issues interacting with requestdbadapter Updated exception message and added junit test case removed useless error handling test case from workflow changed method name and added junit coverage to errors added max retry and success status after completed bb Added case to handle when homing is not called during assign vnf. Fixing fortify issues | Implementing review comments - Key Management Hardcoded encryption key - fixing prop files - Key Management Hardcoded encryption key include network ID for completion handler Added exception handling for saving to requestdb - Adding a check on the predicate availability on the repository before firing the query with default conditions. This ensures that the api returns data only when there is an input against which it was able to form some conditions Modify UT to show that the API does not behave - adding negative test case for checkInstanceNameDuplicate added assertion that global count var was reset to 0 updated rollback to reset current sequence count var workflowaction calls rollback is complete before error workflowaction will set failure on successful rollback added check for isrollback to know which complete to call removed file which should not have been added add fabric check before running vf module a la carte Enhance UCPEMigrateService junits and add them to Jenkins build.. Added back removed test case for ManualTasks Added test case for response error Added rainy day test cases for ManualTasks revert the other change and fix the rollback logic instead fixed current sequence and updated rollback code added network cloud heat template parameters to mapper Generate a unique subRequestId for each request to APP-C. reverted conditional logic for determining fabric Fix Bean scanning so it picks up the resttemplate removed unnecessary RestTemplate Bean configurations removed file which should not have been added workflowaction calls rollback is complete before error workflowaction will set failure on successful rollback added check for isrollback to know which complete to call add fabric check before running vf module a la carte added assertion that global count var was reset to 0 updated rollback to reset current sequence count var include network ID for completion handler Revert Application.yaml change accidentally checked in Added exception handling for saving to requestdb Added case to handle when homing is not called during assign vnf. removed useless error handling test case from workflow changed method name and added junit coverage to errors ... add cloud owner variable to camunda in mapping Revert "Pass cloudOwner to subflow DoCreateVfModuleVolumeV2. Added juint test to verify variables are set in the execution. Set default cloudOwner in main module CreateVfModuleVolumeInfraV2" updated cloud configuration pojo to inlcude defaults Revert "Test to verify ServiceInstance object mapping" Test to verify ServiceInstance object mapping Pass cloudOwner to subflow DoCreateVfModuleVolumeV2. Added juint test to verify variables are set in the execution. Set default cloudOwner in main module CreateVfModuleVolumeInfraV2 Pass cloudOwner to subflow DoCreateVfModuleVolumeV2. Set default cloudOwner 'att-aic' if null per old requirements. removed references to att-aic from BBInputSetup Changes done in encryption decryption logic | used DelegateExecutionFake in Tests Changes done in encryption decryption logic | used DelegateExecutionFake in Tests Changes done in encryption decryption logic Changes done in encryption decryption logic | removed Default Auth Constant as per the comments Changes done in encryption decryption logic | Fixed UT Changes done in encryption decryption logic | Added XmlComparator assertion for verifying XML Changes done in encryption decryption logic | Reverted as per the review comment Changes done in encryption decryption logic | Fixed UTs Changes done in encryption decryption logic | Fixed UTs Changes done in encryption decryption logic | modified related encrypted properties in test yaml files Changes done in encryption decryption logic for fortify issue resolution | Fixed UTs Changes done in encryption decryption logic | modified related encrypted properties in yaml files Changes done in encryption decryption logic for fortify issue resolution. Fixed Property fetching issue in required file Added TasksBeansTest using openpojo Removed renamed test file from tasksbeans Updated imports on TasksBeansTest Added openpojo test to replace the individual tests Removed tests that provided no coverage script clean up -Update reference data to support distinct recreate and replace requests with their own sequences Update reference data to support distinct recreate and replace requests with their own sequences- Fix seq number Update reference data to support distinct recreate and replace requests with their own sequences added null check to mdc and interceptors to sdnc cxf validations can now match against multiple BBs reverted changes to BBInputSetup class added support for pre and post validation for BBs initial commit of generic building block validator converted test to no longer be a springboot test Remove cosmetic changes from BPMN files to be consistent. Remove minor changes that are not related to functionality. Rework to implement the functionality as part of Validator Combine the verification methods into one based on the flow's name; change the logging. Add verification of status of other VF Modules in the VNF for the delete/deactivate/unassign. added network-technology validation for CreateNetworkBB Sonar Issue Fix | Changes done in encryption decryption logic | Refactoring Changes done in encryption decryption logic| Used AES/GCM/NoPadding algorithm | fixed sonar issues added network-type and network-technology to mapper Continue the fight to make JUNITS work properly Update ASDC ATT to be springboot 2.0 compliant Continue to fix Unit tests for springboot 2.0 port removed autowired from workflowactionbbtaskstest fixed workflowactiontest and reduced size by 500 lines Update last of UT for mockito upgrade to 2.0 Fix more JUNITS due to mockito 2.0 upgrade Unit Test fixes to use proper mockito not spring Update Base Test to import proper packages for compile Additional Springboot 2.0 changes, for tests Additional springboot 2.0 fixes and upgrades Update Migration to be Flyway 5 Compliant Fix MSOBPMN Infrastructure common tests Fix Groovy Unit Tests in CommonBPMN Project Update MSO common BPMN to Springboot 2.0 Upgrade ASDC controller to SpringBoot 2.0 Port Openstack adapters to springboot 2.0 Fix VFC Adapter to be springboot 2 compatible Port CatalogDB adapter code to springboot 2 Port SDNC Adapter to Springboot 2.0 ... added update scripts to macro data instead of v12 sql added secondarypolicy to rainy day handling table confirm subnet map is not null in adapter response shallow copy subnet before AAI udpate update AAIObjectType to use uriTemplate extract subnet data from adapter response update correct AAIObjectType for subnet query update subnet(s) in AAI on network create completion confirm subnet map is not null in adapter response shallow copy subnet before AAI udpate update AAIObjectType to use uriTemplate extract subnet data from adapter response update correct AAIObjectType for subnet query update subnet(s) in AAI on network create completion fixed test http entity unit test to remove testing appid and transaction id added unit test for querySubsystemHealth method. also added resttemplate mock to implement healthcheck endpoint fixed unit test to use mock instead of actually goes out to health check endpoint added code to extend globalhealthcheck to include pinging other components and consolidate the responses converted test to no longer be a springboot test Remove cosmetic changes from BPMN files to be consistent. Remove minor changes that are not related to functionality. added update scripts to macro data instead of v12 sql Rework to implement the functionality as part of Validator added secondarypolicy to rainy day handling table added network-type and network-technology to mapper Combine the verification methods into one based on the flow's name; change the logging. Add verification of status of other VF Modules in the VNF for the delete/deactivate/unassign. updated how request db is set to failure in workflowA corrected code to match existing unit tests corrected tests after springboot 2 upgrade Added Required UTs in UpdateConfigurationStateTest and also fixed some UTs. added in missing parenthesis on method call added back execution variable for allotted uri addressed comments on pull request refactor AAI Rest calls from groovy files - Changes as per review comments checkin to refactor AAI rest | Fixing AAIResourceClient.update call refactor AAI Rest calls from groovy files - UpdateConfiguration refactor AAI Rest calls from groovy file - DeleteConfiguration refactor AAI Rest calls from groovy file - UpdateConfiguration refactor AAI Rest calls from groovy file - CreateConfiguration & ConfigurationUtils refactor AAI Rest calls from groovy files - Fix getARByID issue checkin to refactor AAI rest | Adding Junits checkin to refactor AAI rest | Adding few more classes checkin to refactor AAI rest of DoCreateVfModuleVolumeV2 checkin to refactor AAI rest | Update junit checkin to refactor AAI rest of DoCreateVfModuleVolumeV2 | Adding junits checkin to refactor AAI rest of DoCreateVfModuleVolumeV2 | Adding junits checkin to refactor AAI rest of DoCreateVfModuleVolumeV2.groovy ... updated in and out mapping to be generalBuildingBlock change source out mapping to generalBuildingBlock Change-Id: I122f1ebe3e15b77da0a55af201d89d47e326bf83 Issue-ID: SO-1098 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-10-25Resolve vf_module_id setting bugMarcus G K Williams1-7/+18
Do not remove vf_module_id and vnf_id from parameters in HeatUtils. Issue-ID: SO-1165 Change-Id: I6f00350a6f7dc419a8be9b90b28188228949cb43 Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2018-10-17Return canonical stack id on multicloud createEric Multanen1-1/+1
When creating vfmodule via multicloud adapter, return the canonical name of the stack <stackname>/<stack id> Code was returning <stack id>/<stack id> Change-Id: Iaa2a105ab779acc9638fe515c7bc4e5c23d7233e Issue-ID: SO-1142 Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
2018-10-16Fix swapped parameters for multicloud DELETEEric Multanen1-1/+1
cloudSiteId and tenantId were swapped in call to deleteStack(). Change-Id: I56bc326cb680dabb9d397cb7f0f918e406cb8bba Issue-ID: SO-1139 Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
2018-10-12Fix up request body of multicloud adapter bodyEric Multanen2-31/+19
Make some of the attributes json instead of json in a string. Fixed up payload of request. Change-Id: I7737fd19d44c8075bd7fef19068a72f8c0ec7e6d Issue-ID: SO-1124 Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
2018-10-01Fix up handling of multicloud return statusEric Multanen2-34/+258
Add calls to query vfmodule status to return when doing create and delete. Return status based on the query result and not the rest response. Put in the completion polling support on create. Change-Id: Ife50509e54e001b92f4a65ec6be2905aef99f9b5 Issue-ID: SO-1082 Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
2018-09-27Fix calls to multicloud adapterEric Multanen9-186/+706
Fix up the json body of the POST call to multicloud. Improve checkout of responses from multicloud calls. Change-Id: I1fb47460b54e9e5b478815d3b531d5bdbe1fe3dc Issue-ID: SO-1082 Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
2018-09-22Merge "DeploymentInfo tests and construction improvement"Seshu Kumar M6-279/+423
2018-09-20Add multicloud to VnfPluginAdapterEric Multanen4-171/+795
Adds new mode 'multicloud' to VnfPluginAdapter along with MsoMulticloudUtils and supporting code. Change-Id: I1cfdc9ba09c58315fb0bfc025854cf0122a32759 Issue-ID: SO-752 Signed-off-by: Eric Multanen <eric.w.multanen@intel.com>
2018-09-18Upgrade to openstack libs version 1.3.0Rob Daugherty4-17/+17
Version 1.3.0 uses fasterxml.jackson. Note: several unit tests were wrong and had to be fixed. They were using a fasterxml ObjectMapper to deserialize openstack library class objects compiled with codehaus JsonProperty annotations. Consequently, the ObjectMapper could not "see" the annotations. The tests "worked" because the json was constructed wrongly to match. I have now fixed the json so that they have the true property names defined by the annotations. Change-Id: I088137ee5dd5af9cffd426610a50ae6408c5b190 Issue-ID: SO-1025 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-09-17DeploymentInfo tests and construction improvementMichal Kabaj6-279/+423
- Improved construction by adding DeploymentInfoBuilder - DeploymentInfo immutable - added detailed unit tests Change-Id: I3dabb91d5190ef932e77f0c76e18fde8ca73c64d Issue-ID: SO-1055 Signed-off-by: Michal Kabaj <michal.kabaj@nokia.com>
2018-09-08added generic fabric support to SOBenjamin, Max (mb388a)1-1/+21
Fix Autoincrement of ID field in table Fix accidental removal of method Update usage of requestdb client removed unused imports in common tasks and test Fix broken branch, have unit tests pass references the Epic branch Fix broken branch from compiling committing classpath for vfc adapter cause its not going away added in the fail case for when there are no profiles removed second set of adapters in application test yml removed double adapters in request db application test added jpa repo dependency to the so bpmn folder pom add creation timestamp column to the table added in null checks for Config returned from policy switched to string in requestprocess with jenerate switched to string in requestprocess with jenerate updated aai version in common pom to 605 from 591 renamed the db scripts for flyway sync to register added endpoint to application test yml for failing test ... Change-Id: I800f837ea75d7cdff740dc3a387e4d7654cfd085 Issue-ID: SO-972 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-08-31Update LoggingSmokowski, Steve (ss835w)8-52/+6
Add CXF interceptor for SOAP based logging Clean up extra logging statements Add UT to ensure MDC properly populated Change package name on Jax-RS Filter to be more accurate Issue-ID: SO-947 Change-Id: I3a2afc58de3bf370675658ce3d19cf899b90def7 Change-Id: I3a2afc58de3bf370675658ce3d19cf899b90def7 Signed-off-by: Smokowski, Steve (ss835w) <ss835w@us.att.com>
2018-08-23Changed RequestFactory for Catalog DB clientBenjamin, Max (mb388a)9-47/+15
- Missed some files, the repository isn't required now that we dont fetch the identity service directly - Fixing review comments and removing the unused import - Fixing the build :) Now that cloudSite has a 1-1 relationship with cloudidentity, there shouldn't be a need to query the identity on its own unless the site is missing Refactored some code to use site to fetch identity as a composition - Changing the catalogDb client to use HttpComponentsClientHttpRequestFactory instead of SimpleClientHttpRequestFactory, the later would lead to a IOException (FileNotFoundException specifically) whenever a 40X type of a response code is returned from the spring rest endpoint. Adding some tests for the catalogDbClient which earlier got missed in handover. Also fixing another issue with cloudSite repository which was not fetching data correctly. Fixed a repository which was added initially but later the same went missing (Not sure how) Change-Id: I72506865c4c5f7fd07a6031c146a4aba1a96c2c8 Issue-ID: SO-892 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-08-13Cloud config database table supportBenjamin, Max (mb388a)35-1028/+369
added cloud config database entities added cloud config repository converted existing cloud config class converted all code interacting with previous cloud config object created migration to automatically load cloud config properties from application.yaml Issue-ID: SO-854 Change-Id: Icf408e5d0fcabd1b7e97298963c555fae6964930 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-07-31Containerization feature of SOBenjamin, Max (mb388a)143-7743/+5168
Change-Id: I95381232eeefcd247a66a5cec370a8ce1c288e18 Issue-ID: SO-670 Signed-off-by: Benjamin, Max (mb388a) <mb388a@us.att.com>
2018-07-25Replace with the diamond operatorSS004935051-1/+1
AriaVduPlugin.java Sonar Link: https://sonar.onap.org/project/issues?assignees=sumapriya&id=org.onap.so%3Aso&open=AWK-9MGVwGn37JfbmLXt&resolved=false&severities=MAJOR Location:src/main/java/org/openecomp/mso/aria/AriaVduPlugin.java Line No: L126 Change-Id: I186e7dfef1ddf406036f902d1f04b4677652b91f Issue-ID: SO-739 Signed-off-by: SS00493505 <ss00493505@techmahindra.com>
2018-07-13add junit for VfModuleCustomizationToVduMapperLukasz Muszkieta1-2/+18
Change-Id: Ia63f7ababdb7f51a89da4713ae29c1297e7bd746 Issue-ID: SO-718 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-05-16Add guard time to keystone expiryBrian Freeman1-1/+2
Issue-ID: SO-622 Change-Id: If8260ee70d3c632325939affcbd80258b2602c99 Signed-off-by: Brian Freeman <bf1936@att.com>
2018-05-04Fix CloudConfig junitsRob Daugherty13-70/+104
...for some definition of the word "fix". There is still a lot that's less than ideal about how CloudConfig is handled, and with how the unit tests are written. Change-Id: Ic8c66c64d336f22c141687cf41a4828810bf1aec Issue-ID: SO-584 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-05-01SDNC Adapter not loading propertiesRob Daugherty1-5/+3
Somebody changed some variables from static to non-static, and this broke the CloudConfig loading logic. I changed them back. Change-Id: Id7dca76a4f0af0209ebd6cef8f3e0209c3f7a022 Issue-ID: SO-584 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-04-26SDNC Adapter not loading propertiesRob Daugherty2-0/+127
We are missing 2 source files in SO which were part of MSO 1802: CloudConfigInitializer.java CloudConfigIdentityMapper.java The missing initializer means that cloud-config.json is never loaded. Change-Id: Id1186edda01d345de072b5288382dbdc56679294 Issue-ID: SO-584 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-04-13updated to use latest vdu plugin codedfilppi3-2/+534
Change-Id: I46cd41d32e0902a141a87d0c1e01aea278ec17ea Issue-ID: SO-561 Signed-off-by: DeWayne Filppi <dewayne@cloudify.co>
2018-03-29UT Coverage for MsoHeatUtilsAbhishek Shekhar1-17/+224
Change-Id: I3335ae33681e896589d36269c9c639a30a53276d Issue-ID: SO-369 Signed-off-by: Abhishek Shekhar <abhishek.shekhar1@amdocs.com>
2018-03-28Remove PowerMockRunnerArthur Martella4-12/+22
Did you know that using @RunWith(PowerMockRunner.class) makes tests count 0 lines of coverage in Sonar? I didn't. Change-Id: I5c8fae2d0a329866e9c35a7c85344d368af4ad76 Issue-ID: SO-489 Signed-off-by: Arthur Martella <amartell@research.att.com>
2018-03-27Initial commit of VDU plugin implementationKalkere Ramesh, Sharan (sk720x)15-14/+1634
This was documented in the API we committed to at M3. Change-Id: Id0c886d956dc46dba71157cfa35d88844028e7fd Issue-ID: SO-511 Signed-off-by: Kalkere Ramesh, Sharan (sk720x) <sk720x@att.com>
2018-03-27Merge "Update Heat enviroment HPA parameters"Seshu Kumar M1-194/+218
2018-03-27Update Heat enviroment HPA parametersShashank Kumar Shankar1-194/+218
[WORK IN PROGRESS] This patch adds support for updating HPA parameters in Heat templates. Change-Id: Id37e2d1ec752085bdd6808f03be5e85ac040d0c3 Issue-ID: SO-408 Signed-off-by: Shashank Kumar Shankar <shashank.kumar.shankar@intel.com>
2018-03-27UT Coverage for MsoCloudifyUtilsSindhu A1-0/+143
mso-adapter-utils cloudify utils ut coverage Issue-ID: SO-369 Change-Id: Idd69ec6f9c40c608aba5217c2ff4b68369b45755 Signed-off-by: Sindhu A <arcot.sindhuri@huawei.com>
2018-03-27UT Coverage for mso-adapter-utilsSindhu A1-0/+221
UT Coverage for MsoHeatUtils Issue-ID: SO-369 Change-Id: Ib50f65170582789a4f3f31df4cb80326a74477f1 Signed-off-by: Sindhu A <arcot.sindhuri@huawei.com>
2018-03-23Junit for mso.cloudify.exceptionsSumapriya4-71/+81
Junit for: 1.MsoCloudifyException.java 2.MsoCloudify.java 3.MsoCloudifyTimeout.java 4.MsoCloudifyWorkflowException.java Sonar-Link: https://sonar.onap.org/code?id=org.onap.so%3Aso&selected=org.onap.so.adapters%3Amso-adapter-utils%3Asrc%2Fmain%2Fjava%2Forg%2Fopenecomp%2Fmso%2Fcloudify%2Fexceptions Change-Id: I77ad1f5da55d79104c952999e2ad0ec390a5f6d2 Issue-ID: SO-528 Signed-off-by: Sumapriya <SS00493505@techmahindra.com>
2018-03-23Junit for mso.cloudify.exceptionsSumapriya2-0/+71
Junit for: 1.MsoCloudifyException.java 2.MsoCloudify.java 3.MsoCloudifyTimeout.java 4.MsoCloudifyWorkflowException.java Sonar-Link: https://sonar.onap.org/code?id=org.onap.so%3Aso&selected=org.onap.so.adapters%3Amso-adapter-utils%3Asrc%2Fmain%2Fjava%2Forg%2Fopenecomp%2Fmso%2Fcloudify%2Fexceptions Change-Id: Ic464a5205c64a5f582051a3c6b2045db4379fb4d Issue-ID: SO-528 Signed-off-by: Sumapriya <SS00493505@techmahindra.com>
2018-03-23Junit for mso.cloudify.beansSumapriya1-86/+76
Junit for: DeploymentInfo.java Sonar-Link: https://sonar.onap.org/code?id=org.onap.so%3Aso&selected=org.onap.so.adapters%3Amso-adapter-utils%3Asrc%2Fmain%2Fjava%2Forg%2Fopenecomp%2Fmso%2Fcloudify%2Fbeans Change-Id: Iee916f2ef9847a36b8a8b63db0fa84d70a81b26b Issue-ID: SO-528 Signed-off-by: Sumapriya <SS00493505@techmahindra.com>
2018-03-23Junit for mso.openstock.utilsSumapriya7-0/+502
Adding Junit for: 1.MsoHeatEnvironmentParameter.java 2.MsoHeatEnvironmentResource.java 3.MsoKeystoneUtils.java 4.MsoNeutronUtils.java 5.MsoTenantUtilsFactory.java 6.MsoTenantUtils.java 7.MsoYamlEditorWithEnvt.java Sonar Link: https://sonar.onap.org/code?id=org.onap.so%3Aso&selected=org.onap.so.adapters%3Amso-adapter-utils%3Asrc%2Fmain%2Fjava%2Forg%2Fopenecomp%2Fmso%2Fopenstack%2Futils Change-Id: Icafbc3d2239c00b0e4a74cd5750971a772791865 Issue-ID: SO-528 Signed-off-by: Sumapriya <SS00493505@techmahindra.com>
2018-03-21Improve code coveragesubhash kumar singh1-0/+34
Improve code coverage. Change-Id: I4df9fa2c5a72d526c36b7bd07a4c7296c3ce8253 Issue-ID: SO-369 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-03-21Improve code coveragesubhash kumar singh1-0/+33
Improve code coverage. Change-Id: Ic367bd5d38b31227117807bf1375e4bb81112526 Issue-ID: SO-369 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-03-21Improve code coveragesubhash kumar singh1-0/+86
Improve code coverage. Change-Id: I2b0863593925a23f59879d734db74cf9827bb393 Issue-ID: SO-369 Signed-off-by: subhash kumar singh <subhash.kumar.singh@huawei.com>
2018-03-14AT&T 1712 and 1802 release codeRob Daugherty44-1367/+2230
This is code from AT&T's 1712 and 1802 releases. Change-Id: Ie1e85851e94bc66c4d9514a0226c221939531a04 Issue-ID: SO-425 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-03-13Merge "junit adding and refactor for CloudConfig"Seshu Kumar M6-185/+361
2018-03-12junit adding and refactor for CloudConfigLukasz Muszkieta6-185/+361
Change-Id: I3b98e6f8633347970be70e7b93680ec8ed4daacc Issue-ID: SO-430 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-03-12Adding JunitAS004650591-0/+67
Junit for CloudSite.java Sonar Link: https://sonar.onap.org/code?id=org.onap.so%3Aadapters&selected=org.onap.so.adapters%3Amso-adapter-utils%3Asrc%2Fmain%2Fjava%2Forg%2Fopenecomp%2Fmso%2Fcloud%2FCloudSite.java Change-Id: Ic5229c7e0d1226f2edd85715312ef78b5ecb364e Issue-ID: SO-468 Signed-off-by: AS00465059 <AS00465059@techmahindra.com>
2018-03-12Adding JunitAS004650592-0/+111
Junit for: 1.MsoTenant.java 2.NetworkRollback.java Sonar Link: https://sonar.onap.org/code?id=org.onap.so%3Aso&selected=org.onap.so.adapters%3Amso-adapter-utils%3Asrc%2Fmain%2Fjava%2Forg%2Fopenecomp%2Fmso%2Fopenstack%2Fbeans Change-Id: Idd9202ff8de43c31d624854877ea29d556d5a31b Issue-ID: SO-469 Signed-off-by: AS00465059 <AS00465059@techmahindra.com>
2018-03-09Revert Reduce log noise/warningsRob Daugherty11-393/+387
This reverts commit 327b17ab250b4c17cf3f91f5e4cd9bffd89f3d1e. It is seriously impeding our ability complete the promised merge of AT&T 1802 code. While I'm all for coding standards, if we are serious about using spaces instead of tabs, then I think we need to (1) agree with the community when this will happen, (2) do consistently in all files, and (3) enforce it. Change-Id: Ib9b996f6b6c7d81ac9ac95d58b0c7d8cc39675ff Issue-ID: SO-368 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-03-09Merge "Reduce log noise/warnings format to conventions"Seshu Kumar M11-387/+393
2018-03-09Merge "Sonar:Critical"Seshu Kumar M1-1/+1
2018-03-08Reduce log noise/warnings format to conventionsMarcus G K Williams11-387/+393
Reduce build log warnings by formatting tests to ONAP code conventions (removing tabs etc.) Issue-ID: SO-368 Change-Id: I48c6d359b83617aebeb79db4e30c1d72d31f7eec Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2018-03-08Remove redundant declaration of extending objectMunir Ahmad1-5/+5
Change-Id: Iee7e4fc93dd82cab27986335560a41000851c33d Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-03-06Remove redundant catch clauseMunir Ahmad2-4/+0
Change-Id: Ib26f47171384125847a1b31bc1a958b50d0bba70 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-03-06Merge "Replace StringBuilder with String & inline return"Seshu Kumar M5-51/+31
2018-03-06Replace explicit type with dimond typeMunir Ahmad5-17/+17
Change-Id: I1dedb9ef1ca7b734e3cfc0a3a594d733dbd298d4 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>