aboutsummaryrefslogtreecommitdiffstats
path: root/adapters/mso-adapter-utils/src
AgeCommit message (Collapse)AuthorFilesLines
2018-03-09Revert Reduce log noise/warningsRob Daugherty11-393/+387
This reverts commit 327b17ab250b4c17cf3f91f5e4cd9bffd89f3d1e. It is seriously impeding our ability complete the promised merge of AT&T 1802 code. While I'm all for coding standards, if we are serious about using spaces instead of tabs, then I think we need to (1) agree with the community when this will happen, (2) do consistently in all files, and (3) enforce it. Change-Id: Ib9b996f6b6c7d81ac9ac95d58b0c7d8cc39675ff Issue-ID: SO-368 Signed-off-by: Rob Daugherty <rd472p@att.com>
2018-03-09Merge "Reduce log noise/warnings format to conventions"Seshu Kumar M11-387/+393
2018-03-09Merge "Sonar:Critical"Seshu Kumar M1-1/+1
2018-03-08Reduce log noise/warnings format to conventionsMarcus G K Williams11-387/+393
Reduce build log warnings by formatting tests to ONAP code conventions (removing tabs etc.) Issue-ID: SO-368 Change-Id: I48c6d359b83617aebeb79db4e30c1d72d31f7eec Signed-off-by: Marcus G K Williams <marcus.williams@intel.com>
2018-03-08Remove redundant declaration of extending objectMunir Ahmad1-5/+5
Change-Id: Iee7e4fc93dd82cab27986335560a41000851c33d Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-03-06Remove redundant catch clauseMunir Ahmad2-4/+0
Change-Id: Ib26f47171384125847a1b31bc1a958b50d0bba70 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-03-06Merge "Replace StringBuilder with String & inline return"Seshu Kumar M5-51/+31
2018-03-06Replace explicit type with dimond typeMunir Ahmad5-17/+17
Change-Id: I1dedb9ef1ca7b734e3cfc0a3a594d733dbd298d4 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-03-06Replace StringBuilder with String & inline returnMunir Ahmad5-51/+31
Resolved merge conflicts Change-Id: I1a8c8b6fd801c1eb7719ea3d17f029972e2ba84f Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-03-06Merge "Simplify if statements where it makes sense"Seshu Kumar M3-13/+3
2018-02-27Merge "Make use of getOrDefault"DeWayne Filppi1-3/+1
2018-02-26Make use of getOrDefaultMunir Ahmad1-3/+1
Change-Id: Ic73b58835a7964cb2fd88415f55b03ff79ad33ff Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-02-27Make use of append instead of string concatenationMunir Ahmad3-14/+14
Change-Id: I94ad658026f165ba8b5a74352095188a27ee50e5 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-02-26Simplify if statements where it makes senseMunir Ahmad3-13/+3
Change-Id: Id04ede6b8aa8fa3ca8c02b8c32ad5f4745ef47f4 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-02-25Swap while loops with foreach where applicableMunir Ahmad1-55/+53
Change-Id: Id3b54e8192f0e60657aa4c50af56c1ef98fbff5e Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-02-23add junit for cloud wrappersLukasz Muszkieta5-20/+154
Change-Id: I699b10ee2cb6e8b57ca56e8a9baae8aa41000540 Issue-ID: SO-430 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-02-21Boolean constructor callMunir Ahmad1-1/+1
Change-Id: Ic5a16598b1f1ac4f53ab651064b872316abafde0 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-02-21Swap String concatenation with StringBuilderMunir Ahmad1-3/+3
Change-Id: I5c43d3267e5f75623bcc837e27c57a6ad6aa8877 Issue-ID: SO-437 Signed-off-by: Munir Ahmad <munir.ahmad@bell.ca>
2018-02-21Merge "add junit for AuthenticationMethodFactory"Seshu Kumar M4-79/+121
2018-02-21Sonar:CriticalAS004650591-0/+2
Fixing MsoCommonUtils.java MsoCommonUtils.java: L130 L145 Sonar Link: https://sonar.onap.org/issues/search#resolved=false|severities=MAJOR|rules=squid%3AS2293|assignees=__me__ Location:src/main/java/org/openecomp/mso/openstack/utils/MsoCommonUtils.java Change-Id: I120d35a9c06f56dd82b50f248062fc38e60c0819 Issue-ID: SO-401 Signed-off-by: AS00465059 <AS00465059@techmahindra.com>
2018-02-16Sonar:CriticalSumapriya Sarvepalli1-1/+1
Make the enclosing method static or remove this set CloudConfigFactory.java:L152 L158 Sonar Link: https://sonar.onap.org/project/issues?fileUuids=AV3Bnscm5bp_wwmIVB8j&id=org.openecomp.so%3Aso&resolved=false&severities=CRITICAL Location: src/main/java/org/openecomp/mso/cloud/CloudConfigFactory.java Change-Id: Ie4bbda9ab312f920971b77f58ec3ced6ea9f9db2 Issue-ID: SO-427 Signed-off-by: Sumapriya Sarvepalli <SS00493505@TechMahindra.com>
2018-02-09Merge "add junit for MsoHeatEnvironmentEntry"Seshu Kumar M2-177/+127
2018-02-08add junit for AuthenticationMethodFactoryLukasz Muszkieta4-79/+121
Change-Id: I115792b73c62c50362a39fe45936fe294fe575dc Issue-ID: SO-414 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-02-08Merge "refactoring - add Optional"Seshu Kumar M9-203/+77
2018-02-07add junit for MsoHeatEnvironmentEntryLukasz Muszkieta2-177/+127
Change-Id: Ibc2b9562de8fbfdb60ee09add404bd3923431501 Issue-ID: SO-360 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-01-31add junit for StackInfoLukasz Muszkieta4-110/+138
Change-Id: I80e60b590d761c30fd2c71e259c2b4f5cf53b508 Issue-ID: SO-360 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-01-29refactoring - add OptionalLukasz Muszkieta9-203/+77
change possible null return value to Optional Change-Id: I70bf78a51b901a74932b00d1d8735bef5eeacef7 Issue-ID: SO-360 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-01-19add JUnit for NetworkInfoLukasz Muszkieta4-83/+185
Change-Id: I08210bc29f4f6c2f90723b57e30d48c60a81e3bb Issue-ID: SO-360 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-01-04refactoring - code clean upLukasz Muszkieta8-291/+240
Change-Id: Ic2486da2bd415c132959ad9415d7a3e1b178dffa Issue-ID: SO-360 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2018-01-03refactoring - remove unused codeLukasz Muszkieta15-235/+50
Issue-ID: SO-360 Change-Id: Iac9653fa6d5f10de7986fa3d511535d74f0c24c8 Signed-off-by: Lukasz Muszkieta <lukasz.muszkieta@nokia.com>
2017-10-27Merge "Removed unused "LOGGER" private field"Seshu Kumar M1-4/+5
2017-10-23Removed unused "LOGGER" private fieldRamanjaneya-Huawei1-4/+5
Change-Id: I9c46b5f4df2a0e12d7dd0dc931e8f0ca7da0091c Issue-id: SO-224 Signed-off-by: Ramanjaneya-Huawei <ramanjaneya.palleti@huawei.com>
2017-10-23Merge "Fixed multiple so issues"Seshu Kumar M1-7/+2
2017-10-23Merge "Added the "@Override" annotation"Seshu Kumar M1-3/+12
2017-10-23Merge "Use StringBuilder"Seshu Kumar M2-3/+9
2017-10-23Merge "Remove the declaration of thrown exception"Seshu Kumar M1-3/+1
2017-10-19Rename "LOGGER" field to match regular expressionRamanjaneya-Huawei1-19/+18
Change-Id: Ia8c8e2ed9ad3360556d95cfc78e561e05aa5dddf Issue-id: SO-224 Signed-off-by: Ramanjaneya-Huawei <ramanjaneya.palleti@huawei.com>
2017-10-19Fixed multiple so issuesRamanjaneya-Huawei1-7/+2
Change-Id: I4b73cdeeb2a636d42df7b1b156e27e958c828048 Issue-id: SO-224 Signed-off-by: Ramanjaneya-Huawei <ramanjaneya.palleti@huawei.com>
2017-10-19Added the "@Override" annotationRamanjaneya-Huawei1-3/+12
Change-Id: I9a3a8df844813763948578dc34659da535352ad4 Issue-id: SO-224 Signed-off-by: Ramanjaneya-Huawei <ramanjaneya.palleti@huawei.com>
2017-10-19Use StringBuilderRamanjaneya-Huawei2-3/+9
Change-Id: I13d2856530776cdf57c41f12c0bf522988bea29a Issue-id: SO-224 Signed-off-by: Ramanjaneya-Huawei <ramanjaneya.palleti@huawei.com>
2017-10-19Remove the declaration of thrown exceptionRamanjaneya-Huawei1-3/+1
'org.codehaus.jackson.JsonProcessingException' which is a subclass of 'java.io.IOException' Change-Id: I29ddf71ad7166824dd3fdc8e3aa40fb5d482b4c0 Issue-id: SO-224 Signed-off-by: Ramanjaneya-Huawei <ramanjaneya.palleti@huawei.com>
2017-10-06Adding UT for SOseshukm1-0/+213
IssueId: SO-191 Change-Id: Ic9fb77341842fd48efc81341c3a42c26d101b60d Signed-off-by: seshukm <seshu.kumar.m@huawei.com>
2017-10-03Adding UT for MsoHeatUtilsSeshu-Kumar-M1-11/+74
IssueId: SO-173 Change-Id: If230456ab5ea9a9f0c7a1515c4662ec9b41126ff Signed-off-by: Seshu-Kumar-M <seshu.kumar.m@huawei.com>
2017-10-02Merge "Fixed major sonar issues"Seshu Kumar M1-6/+6
2017-09-28Merge "Replaced with the diamnod operator"Seshu Kumar M3-3/+4
2017-09-27Merge "Fixed string literal comparision issue"Seshu Kumar M1-1/+1
2017-09-27Replaced with the diamnod operatorrama-huawei3-4/+5
Issue-Id:SO-118 Change-Id: Iaad28a363586cd8b42e86bd7e854faa9e716c59d Signed-off-by: rama-huawei <rama.subba.reddy.s@huawei.com>
2017-09-27Update POM to inherit from oparentRob Daugherty2-3/+37
Issue: SO-71 Change-Id: I91d503b52909cfcb62ca4b5cd93f6cfc70d6eb24 Signed-off-by: Rob Daugherty <rd472p@att.com>
2017-09-26Fixed major sonar issuesshashikanth1-6/+6
Fix major sonar issues in so module https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#resolved=false|severities=MAJOR|rules=squid%3AS1132 Move the "vlan" string literal on the left side of this string comparison. Issue-Id: APPC-186 Change-Id: If8f330c4a4f053bbee1064b325dc1cbe6bcd70ae Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>
2017-09-26Fixed string literal comparision issueshashikanth1-1/+1
Fix major sonar issues in so module https://sonar.onap.org/component_issues?id=org.openecomp.so%3Aso#resolved=false|severities=BLOCKER%2CMAJOR|rules=squid%3AS1132%2Csquid%3AS1143 Move the "default" string literal on the left side of this string comparison. Issue-Id: APPC-186 Change-Id: I5d503e08331a867b2871dee7acfe74112228bf16 Signed-off-by: shashikanth.vh <shashikanth.vh@huawei.com>